clk: scmi: Add duty cycle ops only when duty cycle is supported
Subsystems (3)
PATCH 1/1 clk: scmi: Add duty cycle ops only when duty cycle is supported
For some of the SCMI based platforms, the oem extended config may be supported, but not for duty cycle purpose. Skip the duty cycle ops if err return when trying to get duty cycle info.
--- drivers/clk/clk-scmi.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/clk/clk-scmi.c +9 -2
@@ -349,6 +349,8 @@ scmi_clk_ops_select(struct scmi_clk *sclk, bool atomic_capable,unsigned int atomic_threshold_us, const struct clk_ops **clk_ops_db, size_t db_size) { + int ret; +u32 val;const struct scmi_clock_info *ci = sclk->info;unsigned int feats_key =0 ;const struct clk_ops *ops;
@@ -370,8 +372,13 @@ scmi_clk_ops_select(struct scmi_clk *sclk, bool atomic_capable,if (!ci->parent_ctrl_forbidden) feats_key |=BIT (SCMI_CLK_PARENT_CTRL_SUPPORTED ); -if (ci->extended_config) - feats_key |=BIT (SCMI_CLK_DUTY_CYCLE_SUPPORTED ); +if (ci->extended_config) { + ret = scmi_proto_clk_ops->config_oem_get (sclk->ph, sclk->id, +SCMI_CLOCK_CFG_DUTY_CYCLE , + &val,NULL , false); +if (!ret) + feats_key |=BIT (SCMI_CLK_DUTY_CYCLE_SUPPORTED ); + }if (WARN_ON (feats_key >= db_size))return NULL ;
Signature · 1 line
2.34.1
Quoted 4 lines · Jacky Bai
For some of the SCMI based platforms, the oem extended config may be supported, but not for duty cycle purpose. Skip the duty cycle ops if err return when trying to get duty cycle info.
Fair enough.
LGTM,
I assume clk tree maintainers can pick this up.
Signature · 2 lines
Regards, Sudeep
Quoting Jacky Bai (2025-07-28 00:04:46)
Quoted 6 lines
For some of the SCMI based platforms, the oem extended config may be supported, but not for duty cycle purpose. Skip the duty cycle ops if err return when trying to get duty cycle info.
Signed-off-by Jacky Bai <[email protected]>---
Applied to clk-next