Skip to contentSkip to conversation

[PATCH v3 0/2]

PATCH In review Rex Chen 2 participants 6 messages Jul 28, 2025 – Aug 19, 2025

Subsystems (2)
lore
Share & tools
lore

Rex Chen

author
#0 lore raw

v3 cover [PATCH v3 0/2]

[patch 1/2]
No change for patch 1
[patch 2/2]
Add more details in commit message

Rex Chen (2):
mmc: core: SPI mode remove cmd7
mmc: mmc_spi: multiple block read remove read crc ack

 drivers/mmc/core/sdio.c    | 6 +++++-
 drivers/mmc/host/mmc_spi.c | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH v3 1/2 mmc: core: SPI mode remove cmd7

SPI mode doesn't support cmd7, so remove it in mmc_sdio_alive() and confirm if sdio is active by checking CCCR register value is available or not.

---
 drivers/mmc/core/sdio.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/mmc/core/sdio.c +5 -1
index 0f753367aec1..83085e76486a 100644
@@ -945,7 +945,11 @@ static void mmc_sdio_remove(struct mmc_host *host)
  */
 static int mmc_sdio_alive(struct mmc_host *host)
 {
-	return mmc_select_card(host->card);
+	if (!mmc_host_is_spi(host))
+		return mmc_select_card(host->card);
+	else
+		return mmc_io_rw_direct(host->card, 0, 0, SDIO_CCCR_CCCR, 0,
+					NULL);
 }
 
 /*
Signature · 1 line
2.25.1
author
#2 lore raw

PATCH v3 2/2 mmc: mmc_spi: multiple block read remove read crc ack

In reply to Rex Chen

For multiple block read, the current implementation, transfer packet includes cmd53 + cmd53 response + block nums*(1byte token + block length bytes payload + 2bytes CRC + 1byte transfer), the last 1byte transfer of every block is not needed, so remove it.

Why doesn't multiple block read need CRC ack?
For read operation, host side get the payload and CRC value, then will only check the CRC value to confirm if the data is correct or not, but not send CRC ack to card. If the data is correct, save it, or discard it and retransmit if data is error, so the last 1byte transfer of every block make no sense.

What's the side effect of this 1byte transfer?
As the SPI is full duplex, if add this redundant 1byte transfer, SDIO card side take it as the token of next block, then all the next sub blocks sequence distort.

---
 drivers/mmc/host/mmc_spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/mmc_spi.c +1 -1
index 47443fb5eb33..f42d5f9c48c1 100644
@@ -563,7 +563,7 @@ mmc_spi_setup_data_message(struct mmc_spi_host *host, bool multiple, bool write)
 	 * the next token (next data block, or STOP_TRAN).  We can try to
 	 * minimize I/O ops by using a single read to collect end-of-busy.
 	 */
-	if (multiple || write) {
+	if (write) {
 		t = &host->early_status;
 		memset(t, 0, sizeof(*t));
 		t->len = write ? sizeof(scratch->status) : 1;
Signature · 1 line
2.25.1
#3 lore raw
In reply to Rex Chen
Quoted 10 lines · Rex Chen

[patch 1/2]
No change for patch 1
[patch 2/2]
Add more details in commit message

Rex Chen (2):
mmc: core: SPI mode remove cmd7
mmc: mmc_spi: multiple block read remove read crc ack

Quoted 7 lines
 drivers/mmc/core/sdio.c    | 6 +++++-
 drivers/mmc/host/mmc_spi.c | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

--
2.25.1

The series applied for next, thanks!

Do you think we should tag these for stable kernels too?

Kind regards
Uffe

author
#4 lore raw
Quoted 10 lines · Rex Chen

[patch 1/2]
No change for patch 1
[patch 2/2]
Add more details in commit message

Rex Chen (2):
mmc: core: SPI mode remove cmd7
mmc: mmc_spi: multiple block read remove read crc ack

Quoted 7 lines
 drivers/mmc/core/sdio.c    | 6 +++++-
 drivers/mmc/host/mmc_spi.c | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

--
2.25.1

The series applied for next, thanks!

Do you think we should tag these for stable kernels too?
------------------------
RE from Rex:
Thanks, Pls apply the patch to stable kernels.
------------------------

Kind regards
Uffe

#5 lore raw
Quoted 20 lines · Rex Chen
Quoted 10 lines · Rex Chen

[patch 1/2]
No change for patch 1
[patch 2/2]
Add more details in commit message

Rex Chen (2):
mmc: core: SPI mode remove cmd7
mmc: mmc_spi: multiple block read remove read crc ack

Quoted 7 lines
 drivers/mmc/core/sdio.c    | 6 +++++-
 drivers/mmc/host/mmc_spi.c | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

--
2.25.1

Quoted 8 lines

The series applied for next, thanks!

Do you think we should tag these for stable kernels too?
------------------------
RE from Rex:
Thanks, Pls apply the patch to stable kernels.
------------------------

Okay, I have tagged the patches for stable too.

Kind regards
Uffe