xen/rangeset: fix typo in comment
PATCH 1/1 xen/rangeset: fix typo in comment
--- xen/common/rangeset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
xen/common/rangeset.c +1 -1
@@ -38,7 +38,7 @@ struct rangeset { };/***************************** -* Private range functions hide the underlying linked-list implemnetation. +* Private range functions hide the underlying linked-list implementation. */ /* Find highest range lower than or containing s. NULL if no such range. */
Signature · 1 line
2.43.0
Quoted 2 lines · Frediano Ziglio
Fixes fc41b5c1fdbe ("Extend the range abstraction"...)Signed-off-by Frediano Ziglio <[email protected]>
Thanks, Roger.
Quoted 5 lines · Roger Pau Monné
Quoted 2 lines · Frediano Ziglio
Fixes fc41b5c1fdbe ("Extend the range abstraction"...)Signed-off-by Frediano Ziglio <[email protected]>Acked-by Roger Pau Monné <[email protected]>
Just to mention: I committed this as is with Roger's ack, but I don't think a Fixes: tag is really appropriate here (I'm certainly not intending to pick this up for backporting). Even further I question a patch changing the spelling of a single word in a comment: It not only took you time to make and send the patch, it also took people time to look at it, Roger to send an ack, me to commit it, and now CI will put extra effort into testing it in isolation via the build-each-commit job. That's way too much resource use imo to justify the extremely minor effect. Such spelling mistakes are imo best corrected when touching adjacent code anyway.
Jan
Quoted 18 lines · Jan Beulich
Quoted 5 lines · Roger Pau Monné
Quoted 2 lines · Frediano Ziglio
Fixes fc41b5c1fdbe ("Extend the range abstraction"...)Signed-off-by Frediano Ziglio <[email protected]>Acked-by Roger Pau Monné <[email protected]>Just to mention: I committed this as is with Roger's ack, but I don't think a Fixes: tag is really appropriate here (I'm certainly not intending to pick this up for backporting). Even further I question a patch changing the spelling of a single word in a comment: It not only took you time to make and send the patch, it also took people time to look at it, Roger to send an ack, me to commit it, and now CI will put extra effort into testing it in isolation via the build-each-commit job. That's way too much resource use imo to justify the extremely minor effect. Such spelling mistakes are imo best corrected when touching adjacent code anyway.
Quoted 1 line
Jan
Hi,
I didn't know there was an automatism with the "Fixes:" tag.
I found the comment about the effort a bit harsh. In many different open source projects this would be against the code of conduct. Usually an open source project should promote contributions. This seems not the case in Xen. A different phrasing would have been better.
Other projects have separate handling for trivial patches. For instance Qemu has some "TRIVIAL" marking, this will help batching small changes like this; also the trivial changes have different reviewers.
If the issue is CI resources we can talk about. For instance multiple runners can be added, I have a runner too that helps when I compile my branches. Suggesting other users to do that could relieve main runners. Another option would be having the possibility to avoid having to compile commits like this. Disabling the need to have every commit compiled could be an option.
About the commits separation I prefer (and I'm not the only one) to separate hunks and changes by purpose. Fixing typos is a different purpose than other changes.
Regards,
Frediano