ufs: core: Fix interrupt handling
Subsystems (2)
Bart Van Assche
reviewerPATCH 1/1 ufs: core: Fix interrupt handling
Fix the following issues:
* An "irq ...: nobody cared" complaint during boot.
* Not handling a SCSI command in time, resulting in the following complaint:
[ 41.700204][ T13] google-ufshcd 3c2d0000.ufs: ufshcd_abort: Device abort task at tag 23 [ 41.700945][ T13] sd 0:0:0:0: [sda] tag#23 CDB: opcode=0x2a 2a 00 00 02 61 e5 00 00 01 00
Cc Neil Armstrong <[email protected]>
Cc André Draszik <[email protected]>
Fixes 3c7ac40d7322 ("scsi: ufs: core: Delegate the interrupt service routine to a threaded IRQ handler")
Signed-off-by Bart Van Assche <[email protected]>
--- drivers/ufs/core/ufshcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/ufs/core/ufshcd.c +1 -2
@@ -7137,8 +7137,7 @@ static irqreturn_t ufshcd_intr(int irq, void *__hba)return IRQ_WAKE_THREAD ;/* Directly handle interrupts since MCQ ESI handlers does the hard job */ -return ufshcd_sl_intr (hba,ufshcd_readl (hba,REG_INTERRUPT_STATUS ) & -ufshcd_readl (hba,REG_INTERRUPT_ENABLE )); +return ufshcd_threaded_intr (irq, hba); }static int ufshcd_clear_tm_cmd (struct ufs_hba *hba,int tag)
Quoted 8 lines · Bart Van Assche
Fix the following issues:
* An "irq ...: nobody cared" complaint during boot.
* Not handling a SCSI command in time, resulting in the following complaint:[ 41.700204][ T13] google-ufshcd 3c2d0000.ufs: ufshcd_abort: Device abort task at tag 23 [ 41.700945][ T13] sd 0:0:0:0: [sda] tag#23 CDB: opcode=0x2a 2a 00 00 02 61 e5 00 00 01 00
This patch only mentions the issue it is solving, not describing the change.
- Mani
Quoted 22 lines
Cc Neil Armstrong <[email protected]>Cc André Draszik <[email protected]>Fixes 3c7ac40d7322 ("scsi: ufs: core: Delegate the interrupt service routine to a threaded IRQ handler")Signed-off-by Bart Van Assche <[email protected]>--- drivers/ufs/core/ufshcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/ufs/core/ufshcd.c +1
-2@@ -7137,8 +7137,7 @@ static irqreturn_t ufshcd_intr(int irq, void *__hba)return IRQ_WAKE_THREAD ;/* Directly handle interrupts since MCQ ESI handlers does the hard job */ -return ufshcd_sl_intr (hba,ufshcd_readl (hba,REG_INTERRUPT_STATUS ) & -ufshcd_readl (hba,REG_INTERRUPT_ENABLE )); +return ufshcd_threaded_intr (irq, hba); }static int ufshcd_clear_tm_cmd (struct ufs_hba *hba,int tag)
Signature · 1 line
மணிவண்ணன் சதாசிவம்