Skip to contentSkip to conversation

clk: clkdev: fix format security.

PATCH Applied [email protected] 3 participants 3 messages Jul 29, 2025 – Aug 5, 2025 Arm/clkdev support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: clkdev: fix format security.

From: Chali Anis <[email protected]>

not a string literal and no format
arguments [-Werror=format-security]

Fixes dfcdce8eec30 ("arm: add common clkdev")
---
 drivers/clk/clkdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clkdev.c +1 -1
index dbe998b6af35..1ce2eb95b8f9 100644
@@ -273,7 +273,7 @@ int clk_add_alias(const char *alias, const char *alias_dev_name, char *id,
 	if (IS_ERR(r))
 		return PTR_ERR(r);
 
-	l = clkdev_alloc(r, alias, alias_dev_name);
+	l = clkdev_alloc(r, alias, "%s", alias_dev_name);
 	clk_put(r);
 	if (!l)
 		return -ENODEV;
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 7 lines · On 7/29/25 06:56, [email protected] wrote:

From: Chali Anis <[email protected]>

not a string literal and no format
arguments [-Werror=format-security]

Fixes dfcdce8eec30 ("arm: add common clkdev")

Thanks,
Ahmad

Quoted 17 lines
---
 drivers/clk/clkdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clkdev.c +1 -1
index dbe998b6af35..1ce2eb95b8f9 100644
@@ -273,7 +273,7 @@ int clk_add_alias(const char *alias, const char *alias_dev_name, char *id,
 	if (IS_ERR(r))
 		return PTR_ERR(r);
 
-	l = clkdev_alloc(r, alias, alias_dev_name);
+	l = clkdev_alloc(r, alias, "%s", alias_dev_name);
 	clk_put(r);
 	if (!l)
 		return -ENODEV;
Signature · 4 lines
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |