arm64: dts: rockchip: Pinephone Pro: Update WiFi
Subsystems (2)
PATCH 1/1 arm64: dts: rockchip: Pinephone Pro: Update WiFi
Update the WiFi configuration to include the wake-up pin and add an ethernet alias to allow assignment of a mac-address from the firmware.
Signed-off-by Peter Robinson <[email protected]>
--- .../dts/rockchip/rk3399-pinephone-pro.dts | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +19 -0
@@ -21,6 +21,7 @@ / { chassis-type = "handset"; aliases { + ethernet0 = &brcmf; mmc0 = &sdio0; mmc1 = &sdmmc; mmc2 = &sdhci;
@@ -689,6 +690,12 @@ vcc1v8_codec_en: vcc1v8-codec-en { }; }; + wifi { + wifi_host_wake_l: wifi-host-wake-l { + rockchip,pins = <4 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>; + }; + }; + wireless-bluetooth { bt_wake_pin: bt-wake-pin { rockchip,pins = <2 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>;
@@ -715,7 +722,19 @@ &sdio0 { pinctrl-names = "default"; pinctrl-0 = <&sdio0_bus4 &sdio0_cmd &sdio0_clk>; sd-uhs-sdr104; + #address-cells = <1>; + #size-cells = <0>; status = "okay"; + + brcmf: wifi@1 { + reg = <1>; + compatible = "brcm,bcm4329-fmac"; + interrupt-parent = <&gpio4>; + interrupts = <RK_PD0 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "host-wake"; + pinctrl-names = "default"; + pinctrl-0 = <&wifi_host_wake_l>; + }; }; &pwm0 {
Signature · 1 line
2.50.1
Hello Peter,
Quoted 15 lines · Peter Robinson
Update the WiFi configuration to include the wake-up pin and add an ethernet alias to allow assignment of a mac-address from the firmware.
Signed-off-by Peter Robinson <[email protected]>--- .../dts/rockchip/rk3399-pinephone-pro.dts | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +0
-0
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts / { · line 24
Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +1
-0@@ -21,6 +21,7 @@ / { chassis-type = "handset"; aliases { + ethernet0 = &brcmf;
The same comments I made on your Pinebook Pro DT patch [1] apply here as well. To sum it up, I'm sorry, but an alias like this one isn't acceptable.
[1] https://lore.kernel.org/linux-rockchip/[email protected]/T/#u
Quoted 36 lines
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +18
-0mmc0 = &sdio0; mmc1 = &sdmmc; mmc2 = &sdhci;@@ -689,6 +690,12 @@ vcc1v8_codec_en: vcc1v8-codec-en { }; }; + wifi { + wifi_host_wake_l: wifi-host-wake-l { + rockchip,pins = <4 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>; + }; + }; + wireless-bluetooth { bt_wake_pin: bt-wake-pin { rockchip,pins = <2 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>;@@ -715,7 +722,19 @@ &sdio0 { pinctrl-names = "default"; pinctrl-0 = <&sdio0_bus4 &sdio0_cmd &sdio0_clk>; sd-uhs-sdr104; + #address-cells = <1>; + #size-cells = <0>; status = "okay"; + + brcmf: wifi@1 { + reg = <1>; + compatible = "brcm,bcm4329-fmac"; + interrupt-parent = <&gpio4>; + interrupts = <RK_PD0 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "host-wake"; + pinctrl-names = "default"; + pinctrl-0 = <&wifi_host_wake_l>; + }; }; &pwm0 {