Fixedup status+error translation to sense key/code
Damien Le Moal
maintainercover Fixedup status+error translation to sense key/code
A couple of patches to fix issues with the translation of a failed qc status and error into a sense key and sense code. The first patch fixes a long standing problem leading to nonsensical sense reports for failed commands.
Damien Le Moal (2):
ata: libata-scsi: Fix ata_to_sense_error() status handling
ata: libata-scsi: Return aborted command when missing sense and result TF
drivers/ata/libata-scsi.c | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-)
Signature · 1 line
2.50.1
Damien Le Moal
maintainerPATCH 1/2 ata: libata-scsi: Fix ata_to_sense_error() status handling
Commit 8ae720449fca ("libata: whitespace fixes in ata_to_sense_error()") inadvertantly added the entry 0x40 (ATA_DRDY) to the stat_table array in the function ata_to_sense_error(). This entry ties a failed qc which has a status filed equal to ATA_DRDY to the sense key ILLEGAL REQUEST with the additional sense code UNALIGNED WRITE COMMAND. This entry will be used to generate a failed qc sense key and sense code when the qc is missing sense data and there is no match for the qc error field in the sense_table array of ata_to_sense_error().
As a result, for a failed qc for which we failed to get sense data (e.g. read log 10h failed if qc is an NCQ command, or REQUEST SENSE EXT command failed for the non-ncq case, the user very often end up seeing the completely misleading "unaligned write command" error, even if qc was not a write command. E.g.:
sd 0:0:0:0: [sda] tag#12 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s sd 0:0:0:0: [sda] tag#12 Sense Key : Illegal Request [current]
sd 0:0:0:0: [sda] tag#12 Add. Sense: Unaligned write command
sd 0:0:0:0: [sda] tag#12 CDB: Read(10) 28 00 00 00 10 00 00 00 08 00
I/O error, dev sda, sector 4096 op 0x0:(READ) flags 0x80700 phys_seg 1 prio class 0
Fix this by removing the ATA_DRDY entry from the stat_table array so that we default to always returning ABORTED COMMAND without any additional sense code, since we do not know any better. The entry 0x08 (ATA_DRQ) is also removed since signaling ABORTED COMMAND with a parity error is also misleading (as a parity error would likely be signaled through a bus error). So for this case, also default to returning ABORTED COMMAND without any additional sense code. With this, the previous example error case becomes:
sd 0:0:0:0: [sda] tag#17 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s sd 0:0:0:0: [sda] tag#17 Sense Key : Aborted Command [current]
sd 0:0:0:0: [sda] tag#17 Add. Sense: No additional sense information
sd 0:0:0:0: [sda] tag#17 CDB: Read(10) 28 00 00 00 10 00 00 00 08 00
I/O error, dev sda, sector 4096 op 0x0:(READ) flags 0x80700 phys_seg 1 prio class 0
Together with these fixes, refactor stat_table to make it more readable by putting the entries comments in front of the entries and using the defined status bits macros instead of hardcoded values.
--- drivers/ata/libata-scsi.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-)
drivers/ata/libata-scsi.c +8 -12
@@ -859,18 +859,14 @@ static void ata_to_sense_error(u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc, {0xFF, 0xFF, 0xFF, 0xFF}, // END mark };static const unsigned char stat_table[][4 ] = { -/* Must be first because BUSY means no other bits valid */ - {0x80 ,ABORTED_COMMAND ,0x47 ,0x00 }, -// Busy, fake parity for now - {0x40 ,ILLEGAL_REQUEST ,0x21 ,0x04 }, -// Device ready, unaligned write command - {0x20 ,HARDWARE_ERROR ,0x44 ,0x00 }, -// Device fault, internal target failure - {0x08 ,ABORTED_COMMAND ,0x47 ,0x00 }, -// Timed out in xfer, fake parity for now - {0x04 ,RECOVERED_ERROR ,0x11 ,0x00 }, -// Recovered ECC error Medium error, recovered - {0xFF ,0xFF ,0xFF ,0xFF },// END mark +/* Busy: must be first because BUSY means no other bits valid */ + {ATA_BUSY ,ABORTED_COMMAND ,0x00 ,0x00 }, +/* Device fault: INTERNAL TARGET FAILURE */ + {ATA_DF ,HARDWARE_ERROR ,0x44 ,0x00 }, +/* Corrected data error */ + {ATA_CORR ,RECOVERED_ERROR ,0x00 ,0x00 }, + + {0xFF ,0xFF ,0xFF ,0xFF },/* END mark */ };/*
Signature · 1 line
2.50.1
Re: [PATCH 1/2] ata: libata-scsi: Fix ata_to_sense_error() status handling
Quoted 70 lines · Damien Le Moal
Commit
8ae720449fca("libata: whitespace fixes inata_to_sense_error()") inadvertantly added the entry0x40(ATA_DRDY) to thestat_tablearray in the functionata_to_sense_error(). This entry ties a failed qc which has a status filed equal toATA_DRDYto the sense key ILLEGAL REQUEST with the additional sense code UNALIGNED WRITE COMMAND. This entry will be used to generate a failed qc sense key and sense code when the qc is missing sense data and there is no match for the qc error field in thesense_tablearray ofata_to_sense_error().As a result, for a failed qc for which we failed to get sense data (e.g. read log 10h failed if qc is an NCQ command, or REQUEST SENSE EXT command failed for the non-ncq case, the user very often end up seeing the completely misleading "unaligned write command" error, even if qc was not a write command. E.g.:
sd 0:0:0:0: [sda] tag#12 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s sd 0:0:0:0: [sda] tag#12 Sense Key : Illegal Request [current]
sd 0:0:0:0: [sda] tag#12 Add. Sense: Unaligned write command
sd 0:0:0:0: [sda] tag#12 CDB: Read(10) 28 00 00 00 10 00 00 00 08 00
I/O error, dev sda, sector 4096 op 0x0:(READ) flags0x80700phys_seg1 prio class 0Fix this by removing the
ATA_DRDYentry from thestat_tablearray so that we default to always returning ABORTED COMMAND without any additional sense code, since we do not know any better. The entry0x08(ATA_DRQ) is also removed since signaling ABORTED COMMAND with a parity error is also misleading (as a parity error would likely be signaled through a bus error). So for this case, also default to returning ABORTED COMMAND without any additional sense code. With this, the previous example error case becomes:sd 0:0:0:0: [sda] tag#17 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s sd 0:0:0:0: [sda] tag#17 Sense Key : Aborted Command [current]
sd 0:0:0:0: [sda] tag#17 Add. Sense: No additional sense information
sd 0:0:0:0: [sda] tag#17 CDB: Read(10) 28 00 00 00 10 00 00 00 08 00
I/O error, dev sda, sector 4096 op 0x0:(READ) flags0x80700phys_seg1 prio class 0Together with these fixes, refactor
stat_tableto make it more readable by putting the entries comments in front of the entries and using the defined status bits macros instead of hardcoded values.Reported-by Lorenz Brun <[email protected]>Reported-by Brandon Schwartz <[email protected]>Fixes 8ae720449fca ("libata: whitespace fixes in ata_to_sense_error()")Signed-off-by Damien Le Moal <[email protected]>--- drivers/ata/libata-scsi.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-)drivers/ata/libata-scsi.c +1
-12@@ -859,18 +859,14 @@ static void ata_to_sense_error(u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc, {0xFF, 0xFF, 0xFF, 0xFF}, // END mark };static const unsigned char stat_table[][4 ] = { -/* Must be first because BUSY means no other bits valid */ - {0x80 ,ABORTED_COMMAND ,0x47 ,0x00 }, -// Busy, fake parity for now - {0x40 ,ILLEGAL_REQUEST ,0x21 ,0x04 }, -// Device ready, unaligned write command - {0x20 ,HARDWARE_ERROR ,0x44 ,0x00 }, -// Device fault, internal target failure - {0x08 ,ABORTED_COMMAND ,0x47 ,0x00 }, -// Timed out in xfer, fake parity for now - {0x04 ,RECOVERED_ERROR ,0x11 ,0x00 }, -// Recovered ECC error Medium error, recovered - {0xFF, 0xFF, 0xFF, 0xFF}, // END mark + /* Busy: must be first because BUSY means no other bits valid */
drivers/ata/libata-scsi.c static void ata_to_sense_error(u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc, · line 872
Quoted 10 lines
drivers/ata/libata-scsi.c +7
-0+ { ATA_BUSY, ABORTED_COMMAND, 0x00, 0x00 }, +/* Device fault: INTERNAL TARGET FAILURE */ + { ATA_DF, HARDWARE_ERROR, 0x44, 0x00 }, +/* Corrected data error */ + { ATA_CORR, RECOVERED_ERROR, 0x00, 0x00 }, + + { 0xFF, 0xFF, 0xFF, 0xFF }, /* END mark */ };/*
Yeah, I think the translation to 'unaligned write command' was from the very early days of SMR development.
Cheers,
Hannes
Signature · 4 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
Re: [PATCH 1/2] ata: libata-scsi: Fix ata_to_sense_error() status handling
In reply to Damien Le MoalQuoted 61 lines · Damien Le Moal
Commit
8ae720449fca("libata: whitespace fixes inata_to_sense_error()") inadvertantly added the entry0x40(ATA_DRDY) to thestat_tablearray in the functionata_to_sense_error(). This entry ties a failed qc which has a status filed equal toATA_DRDYto the sense key ILLEGAL REQUEST with the additional sense code UNALIGNED WRITE COMMAND. This entry will be used to generate a failed qc sense key and sense code when the qc is missing sense data and there is no match for the qc error field in thesense_tablearray ofata_to_sense_error().As a result, for a failed qc for which we failed to get sense data (e.g. read log 10h failed if qc is an NCQ command, or REQUEST SENSE EXT command failed for the non-ncq case, the user very often end up seeing the completely misleading "unaligned write command" error, even if qc was not a write command. E.g.:
sd 0:0:0:0: [sda] tag#12 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s sd 0:0:0:0: [sda] tag#12 Sense Key : Illegal Request [current]
sd 0:0:0:0: [sda] tag#12 Add. Sense: Unaligned write command
sd 0:0:0:0: [sda] tag#12 CDB: Read(10) 28 00 00 00 10 00 00 00 08 00
I/O error, dev sda, sector 4096 op 0x0:(READ) flags0x80700phys_seg1 prio class 0Fix this by removing the
ATA_DRDYentry from thestat_tablearray so that we default to always returning ABORTED COMMAND without any additional sense code, since we do not know any better. The entry0x08(ATA_DRQ) is also removed since signaling ABORTED COMMAND with a parity error is also misleading (as a parity error would likely be signaled through a bus error). So for this case, also default to returning ABORTED COMMAND without any additional sense code. With this, the previous example error case becomes:sd 0:0:0:0: [sda] tag#17 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s sd 0:0:0:0: [sda] tag#17 Sense Key : Aborted Command [current]
sd 0:0:0:0: [sda] tag#17 Add. Sense: No additional sense information
sd 0:0:0:0: [sda] tag#17 CDB: Read(10) 28 00 00 00 10 00 00 00 08 00
I/O error, dev sda, sector 4096 op 0x0:(READ) flags0x80700phys_seg1 prio class 0Together with these fixes, refactor
stat_tableto make it more readable by putting the entries comments in front of the entries and using the defined status bits macros instead of hardcoded values.Reported-by Lorenz Brun <[email protected]>Reported-by Brandon Schwartz <[email protected]>Fixes 8ae720449fca ("libata: whitespace fixes in ata_to_sense_error()")Signed-off-by Damien Le Moal <[email protected]>--- drivers/ata/libata-scsi.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-)drivers/ata/libata-scsi.c +0
-4@@ -859,18 +859,14 @@ static void ata_to_sense_error(u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc, {0xFF, 0xFF, 0xFF, 0xFF}, // END mark }; static const unsigned char stat_table[][4] = { -/* Must be first because BUSY means no other bits valid */ - {0x80 ,ABORTED_COMMAND ,0x47 ,0x00 }, -// Busy, fake parity for now - {0x40, ILLEGAL_REQUEST, 0x21, 0x04},
drivers/ata/libata-scsi.c static void ata_to_sense_error(u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc, · line 863
Quoted 10 lines
drivers/ata/libata-scsi.c +2
-8-// Device ready, unaligned write command - {0x20, HARDWARE_ERROR, 0x44, 0x00}, -// Device fault, internal target failure - {0x08, ABORTED_COMMAND, 0x47, 0x00}, -// Timed out in xfer, fake parity for now - {0x04, RECOVERED_ERROR, 0x11, 0x00}, -// Recovered ECC error Medium error, recovered - {0xFF, 0xFF, 0xFF, 0xFF}, // END mark +/* Busy: must be first because BUSY means no other bits valid */ + { ATA_BUSY, ABORTED_COMMAND, 0x00, 0x00 },
Hi Damien,
ata_to_sense_error() already has a check for ATA_BUSY. Perhaps we could add a goto statement and fill ABORTED_COMMAND without looking up the same data in the stat_table?
drivers/ata/libata-scsi.c static void ata_to_sense_error(u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc, · line 867
Quoted 4 lines
drivers/ata/libata-scsi.c +4
-0+/* Device fault: INTERNAL TARGET FAILURE */ + { ATA_DF, HARDWARE_ERROR, 0x44, 0x00 }, +/* Corrected data error */ + { ATA_CORR, RECOVERED_ERROR, 0x00, 0x00 },
I'm trying to understand what this "Corrected data error" is. ACS-6 does not seem to have any references to such corrected errors. BIT(2) of STATUS field is defined as "N/A or ALIGNMENT ERROR bit – See 6.2.2". Does it make sense to translate this bit to "unaligned write command" instead?
Thanks,
Igor
Quoted 9 lines
drivers/ata/libata-scsi.c +2
-0+ + { 0xFF, 0xFF, 0xFF, 0xFF }, /* END mark */ };/* Signature · 1 line
2.50.1
Damien Le Moal
maintainerRe: [PATCH 1/2] ata: libata-scsi: Fix ata_to_sense_error() status handling
Quoted 75 lines · Igor Pylypiv
Quoted 61 lines · Damien Le Moal
Commit
8ae720449fca("libata: whitespace fixes inata_to_sense_error()") inadvertantly added the entry0x40(ATA_DRDY) to thestat_tablearray in the functionata_to_sense_error(). This entry ties a failed qc which has a status filed equal toATA_DRDYto the sense key ILLEGAL REQUEST with the additional sense code UNALIGNED WRITE COMMAND. This entry will be used to generate a failed qc sense key and sense code when the qc is missing sense data and there is no match for the qc error field in thesense_tablearray ofata_to_sense_error().As a result, for a failed qc for which we failed to get sense data (e.g. read log 10h failed if qc is an NCQ command, or REQUEST SENSE EXT command failed for the non-ncq case, the user very often end up seeing the completely misleading "unaligned write command" error, even if qc was not a write command. E.g.:
sd 0:0:0:0: [sda] tag#12 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s sd 0:0:0:0: [sda] tag#12 Sense Key : Illegal Request [current]
sd 0:0:0:0: [sda] tag#12 Add. Sense: Unaligned write command
sd 0:0:0:0: [sda] tag#12 CDB: Read(10) 28 00 00 00 10 00 00 00 08 00
I/O error, dev sda, sector 4096 op 0x0:(READ) flags0x80700phys_seg1 prio class 0Fix this by removing the
ATA_DRDYentry from thestat_tablearray so that we default to always returning ABORTED COMMAND without any additional sense code, since we do not know any better. The entry0x08(ATA_DRQ) is also removed since signaling ABORTED COMMAND with a parity error is also misleading (as a parity error would likely be signaled through a bus error). So for this case, also default to returning ABORTED COMMAND without any additional sense code. With this, the previous example error case becomes:sd 0:0:0:0: [sda] tag#17 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s sd 0:0:0:0: [sda] tag#17 Sense Key : Aborted Command [current]
sd 0:0:0:0: [sda] tag#17 Add. Sense: No additional sense information
sd 0:0:0:0: [sda] tag#17 CDB: Read(10) 28 00 00 00 10 00 00 00 08 00
I/O error, dev sda, sector 4096 op 0x0:(READ) flags0x80700phys_seg1 prio class 0Together with these fixes, refactor
stat_tableto make it more readable by putting the entries comments in front of the entries and using the defined status bits macros instead of hardcoded values.Reported-by Lorenz Brun <[email protected]>Reported-by Brandon Schwartz <[email protected]>Fixes 8ae720449fca ("libata: whitespace fixes in ata_to_sense_error()")Signed-off-by Damien Le Moal <[email protected]>--- drivers/ata/libata-scsi.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-)drivers/ata/libata-scsi.c +0
-4@@ -859,18 +859,14 @@ static void ata_to_sense_error(u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc, {0xFF, 0xFF, 0xFF, 0xFF}, // END mark }; static const unsigned char stat_table[][4] = { -/* Must be first because BUSY means no other bits valid */ - {0x80 ,ABORTED_COMMAND ,0x47 ,0x00 }, -// Busy, fake parity for now - {0x40, ILLEGAL_REQUEST, 0x21, 0x04},drivers/ata/libata-scsi.c static void ata_to_sense_error(u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc, · line 863
Quoted 10 lines
drivers/ata/libata-scsi.c +2
-8-// Device ready, unaligned write command - {0x20, HARDWARE_ERROR, 0x44, 0x00}, -// Device fault, internal target failure - {0x08, ABORTED_COMMAND, 0x47, 0x00}, -// Timed out in xfer, fake parity for now - {0x04, RECOVERED_ERROR, 0x11, 0x00}, -// Recovered ECC error Medium error, recovered - {0xFF, 0xFF, 0xFF, 0xFF}, // END mark +/* Busy: must be first because BUSY means no other bits valid */ + { ATA_BUSY, ABORTED_COMMAND, 0x00, 0x00 },Hi Damien,
Quoted 3 lines
ata_to_sense_error()already has a check forATA_BUSY. Perhaps we could add a goto statement and fillABORTED_COMMANDwithout looking up the same data in thestat_table?
Yes, we could do that. I minimized the changes here since this is a bug fix.
Quoted 9 lines
drivers/ata/libata-scsi.c static void ata_to_sense_error(u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc, · line 867
Quoted 4 lines
drivers/ata/libata-scsi.c +4
-0+/* Device fault: INTERNAL TARGET FAILURE */ + { ATA_DF, HARDWARE_ERROR, 0x44, 0x00 }, +/* Corrected data error */ + { ATA_CORR, RECOVERED_ERROR, 0x00, 0x00 },I'm trying to understand what this "Corrected data error" is. ACS-6 does not seem to have any references to such corrected errors. BIT(2) of STATUS field is defined as "N/A or ALIGNMENT ERROR bit – See 6.2.2". Does it make sense to translate this bit to "unaligned write command" instead?
This is an odd one. Indeed, ACS defines it as N/A or alignment error, but up to SAT-3, its translation to sense data says "This condition is not considered an error". The libata-scsi code has this defined as a recovered error since forever, so I did not change it. SAT4 onward do not even define a translation for this at all.
For modern drives, this is all almost completely irrelevant anyway as we get sense data, unless there is a big issue with the drive preventing that, which is the case this patch is for so that we do not get the non-sensical "unaligned error".
If you have a look at SAT specifications, you'll see that most of the error bits translation in this function are "completely made up", or rather, as the SAT specs allows, based on the 3ware driver translation (as noted in the comment for the error table).
I do not want to hit regressions with excessive cleaning of this code, so I just let it be.
Signature · 2 lines
Damien Le Moal Western Digital Research
Igor Pylypiv
Reviewed-byRe: [PATCH 1/2] ata: libata-scsi: Fix ata_to_sense_error() status handling
Quoted 102 lines · Damien Le Moal
Quoted 75 lines · Igor Pylypiv
Quoted 61 lines · Damien Le Moal
Commit
8ae720449fca("libata: whitespace fixes inata_to_sense_error()") inadvertantly added the entry0x40(ATA_DRDY) to thestat_tablearray in the functionata_to_sense_error(). This entry ties a failed qc which has a status filed equal toATA_DRDYto the sense key ILLEGAL REQUEST with the additional sense code UNALIGNED WRITE COMMAND. This entry will be used to generate a failed qc sense key and sense code when the qc is missing sense data and there is no match for the qc error field in thesense_tablearray ofata_to_sense_error().As a result, for a failed qc for which we failed to get sense data (e.g. read log 10h failed if qc is an NCQ command, or REQUEST SENSE EXT command failed for the non-ncq case, the user very often end up seeing the completely misleading "unaligned write command" error, even if qc was not a write command. E.g.:
sd 0:0:0:0: [sda] tag#12 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s sd 0:0:0:0: [sda] tag#12 Sense Key : Illegal Request [current]
sd 0:0:0:0: [sda] tag#12 Add. Sense: Unaligned write command
sd 0:0:0:0: [sda] tag#12 CDB: Read(10) 28 00 00 00 10 00 00 00 08 00
I/O error, dev sda, sector 4096 op 0x0:(READ) flags0x80700phys_seg1 prio class 0Fix this by removing the
ATA_DRDYentry from thestat_tablearray so that we default to always returning ABORTED COMMAND without any additional sense code, since we do not know any better. The entry0x08(ATA_DRQ) is also removed since signaling ABORTED COMMAND with a parity error is also misleading (as a parity error would likely be signaled through a bus error). So for this case, also default to returning ABORTED COMMAND without any additional sense code. With this, the previous example error case becomes:sd 0:0:0:0: [sda] tag#17 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s sd 0:0:0:0: [sda] tag#17 Sense Key : Aborted Command [current]
sd 0:0:0:0: [sda] tag#17 Add. Sense: No additional sense information
sd 0:0:0:0: [sda] tag#17 CDB: Read(10) 28 00 00 00 10 00 00 00 08 00
I/O error, dev sda, sector 4096 op 0x0:(READ) flags0x80700phys_seg1 prio class 0Together with these fixes, refactor
stat_tableto make it more readable by putting the entries comments in front of the entries and using the defined status bits macros instead of hardcoded values.Reported-by Lorenz Brun <[email protected]>Reported-by Brandon Schwartz <[email protected]>Fixes 8ae720449fca ("libata: whitespace fixes in ata_to_sense_error()")Signed-off-by Damien Le Moal <[email protected]>--- drivers/ata/libata-scsi.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-)drivers/ata/libata-scsi.c +0
-4@@ -859,18 +859,14 @@ static void ata_to_sense_error(u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc, {0xFF, 0xFF, 0xFF, 0xFF}, // END mark }; static const unsigned char stat_table[][4] = { -/* Must be first because BUSY means no other bits valid */ - {0x80 ,ABORTED_COMMAND ,0x47 ,0x00 }, -// Busy, fake parity for now - {0x40, ILLEGAL_REQUEST, 0x21, 0x04},drivers/ata/libata-scsi.c static void ata_to_sense_error(u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc, · line 863
Quoted 10 lines
drivers/ata/libata-scsi.c +2
-8-// Device ready, unaligned write command - {0x20, HARDWARE_ERROR, 0x44, 0x00}, -// Device fault, internal target failure - {0x08, ABORTED_COMMAND, 0x47, 0x00}, -// Timed out in xfer, fake parity for now - {0x04, RECOVERED_ERROR, 0x11, 0x00}, -// Recovered ECC error Medium error, recovered - {0xFF, 0xFF, 0xFF, 0xFF}, // END mark +/* Busy: must be first because BUSY means no other bits valid */ + { ATA_BUSY, ABORTED_COMMAND, 0x00, 0x00 },Hi Damien,
Quoted 3 lines
ata_to_sense_error()already has a check forATA_BUSY. Perhaps we could add a goto statement and fillABORTED_COMMANDwithout looking up the same data in thestat_table?Yes, we could do that. I minimized the changes here since this is a bug fix.
Quoted 9 lines
drivers/ata/libata-scsi.c static void ata_to_sense_error(u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc, · line 867
Quoted 4 lines
drivers/ata/libata-scsi.c +4
-0+/* Device fault: INTERNAL TARGET FAILURE */ + { ATA_DF, HARDWARE_ERROR, 0x44, 0x00 }, +/* Corrected data error */ + { ATA_CORR, RECOVERED_ERROR, 0x00, 0x00 },I'm trying to understand what this "Corrected data error" is. ACS-6 does not seem to have any references to such corrected errors. BIT(2) of STATUS field is defined as "N/A or ALIGNMENT ERROR bit – See 6.2.2". Does it make sense to translate this bit to "unaligned write command" instead?
This is an odd one. Indeed, ACS defines it as N/A or alignment error, but up to SAT-3, its translation to sense data says "This condition is not considered an error". The libata-scsi code has this defined as a recovered error since forever, so I did not change it. SAT4 onward do not even define a translation for this at all.
For modern drives, this is all almost completely irrelevant anyway as we get sense data, unless there is a big issue with the drive preventing that, which is the case this patch is for so that we do not get the non-sensical "unaligned error".
Quoted 7 lines
If you have a look at SAT specifications, you'll see that most of the error bits translation in this function are "completely made up", or rather, as the SAT specs allows, based on the 3ware driver translation (as noted in the comment for the error table).
I do not want to hit regressions with excessive cleaning of this code, so I just let it be.
Thank you for the details, Damien!
Quoted 4 lines
Signature · 3 lines
-- Damien Le Moal Western Digital Research
Damien Le Moal
maintainerPATCH 2/2 ata: libata-scsi: Return aborted command when missing sense and result TF
In reply to Damien Le Moalata_gen_ata_sense() is always called for a failed qc missing sense data so that a sense key, code and code qualifier can be generated using ata_to_sense_error() from the qc status and error fields of its result task file. However, if the qc does not have its result task file filled, ata_gen_ata_sense() returns early without setting a sense key.
Improve this by defaulting to returning ABORTED COMMAND without any additional sense code, since we do not know the reason for the failure. The same fix is also applied in ata_gen_passthru_sense() with the additional check that the qc failed (qc->err_mask is set).
--- drivers/ata/libata-scsi.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)
drivers/ata/libata-scsi.c +11 -7
@@ -938,6 +938,8 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc)if (!(qc->flags &ATA_QCFLAG_RTF_FILLED )) {ata_dev_dbg (dev,"missing result TF: can't generate ATA PT sense data\n" ); +if (qc->err_mask) +ata_scsi_set_sense (dev, cmd,ABORTED_COMMAND ,0 ,0 );return ; }
@@ -992,8 +994,8 @@ static void ata_gen_ata_sense(struct ata_queued_cmd *qc)if (!(qc->flags &ATA_QCFLAG_RTF_FILLED )) {ata_dev_dbg (dev, -"missing result TF: can't generate sense data\n" ); -return ; +"Missing result TF: reporting aborted command\n" ); + goto aborted; }/* Use ata_to_sense_error() to map status register bits
@@ -1004,13 +1006,15 @@ static void ata_gen_ata_sense(struct ata_queued_cmd *qc)ata_to_sense_error (tf->status, tf->error, &sense_key, &asc, &ascq);ata_scsi_set_sense (dev, cmd, sense_key, asc, ascq); - }else { -/* Could not decode error */ -ata_dev_warn (dev,"could not decode error status 0x%x err_mask 0x%x\n" , - tf->status, qc->err_mask); -ata_scsi_set_sense (dev, cmd,ABORTED_COMMAND ,0 ,0 );return ; } + +/* Could not decode error */ +ata_dev_warn (dev, +"Could not decode error 0x%x, status 0x%x (err_mask=0x%x)\n" , + tf->error, tf->status, qc->err_mask); +aborted: +ata_scsi_set_sense (dev, cmd,ABORTED_COMMAND ,0 ,0 ); }void ata_scsi_sdev_config (struct scsi_device *sdev)
Signature · 1 line
2.50.1
Re: [PATCH 2/2] ata: libata-scsi: Return aborted command when missing sense and result TF
Quoted 11 lines · Damien Le Moal
ata_gen_ata_sense()is always called for a failed qc missing sense data so that a sense key, code and code qualifier can be generated usingata_to_sense_error()from the qc status and error fields of its result task file. However, if the qc does not have its result task file filled,ata_gen_ata_sense()returns early without setting a sense key.Improve this by defaulting to returning ABORTED COMMAND without any additional sense code, since we do not know the reason for the failure. The same fix is also applied in
ata_gen_passthru_sense()with the additional check that the qc failed (qc->err_maskis set).
Quoted 7 lines
Fixes 816be86c7993 ("ata: libata-scsi: Check ATA_QCFLAG_RTF_FILLED before using result_tf")Signed-off-by Damien Le Moal <[email protected]>--- drivers/ata/libata-scsi.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)
Cheers,
Hannes
Signature · 4 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
Re: [PATCH 2/2] ata: libata-scsi: Return aborted command when missing sense and result TF
In reply to Damien Le Moaldrivers/ata/libata-scsi.c static void ata_gen_ata_sense(struct ata_queued_cmd *qc)
Quoted 43 lines · Damien Le Moal
ata_gen_ata_sense()is always called for a failed qc missing sense data so that a sense key, code and code qualifier can be generated usingata_to_sense_error()from the qc status and error fields of its result task file. However, if the qc does not have its result task file filled,ata_gen_ata_sense()returns early without setting a sense key.Improve this by defaulting to returning ABORTED COMMAND without any additional sense code, since we do not know the reason for the failure. The same fix is also applied in
ata_gen_passthru_sense()with the additional check that the qc failed (qc->err_maskis set).Fixes 816be86c7993 ("ata: libata-scsi: Check ATA_QCFLAG_RTF_FILLED before using result_tf")Signed-off-by Damien Le Moal <[email protected]>--- drivers/ata/libata-scsi.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)drivers/ata/libata-scsi.c +4
-2@@ -938,6 +938,8 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc)if (!(qc->flags &ATA_QCFLAG_RTF_FILLED )) {ata_dev_dbg (dev,"missing result TF: can't generate ATA PT sense data\n" ); +if (qc->err_mask) +ata_scsi_set_sense (dev, cmd,ABORTED_COMMAND ,0 ,0 );return ; }@@ -992,8 +994,8 @@ static void ata_gen_ata_sense(struct ata_queued_cmd *qc)if (!(qc->flags &ATA_QCFLAG_RTF_FILLED )) {ata_dev_dbg (dev, -"missing result TF: can't generate sense data\n" ); -return ; +"Missing result TF: reporting aborted command\n" ); + goto aborted; }/* Use ata_to_sense_error() to map status register bits @@ -1004,13 +1006,15 @@ static void ata_gen_ata_sense(struct ata_queued_cmd *qc)
There is a redundant check in ata_gen_ata_sense(). qc->err_mask (is_error) is already checked in ata_scsi_qc_complete() before it calls ata_gen_ata_sense().
if (qc->err_mask ||
tf->status & (ATA_BUSY | ATA_DF | ATA_ERR | ATA_DRQ)) {The function will be much cleaner once we remove this check.
Quoted 24 lines
drivers/ata/libata-scsi.c +7
-5ata_to_sense_error (tf->status, tf->error, &sense_key, &asc, &ascq);ata_scsi_set_sense (dev, cmd, sense_key, asc, ascq); - }else { -/* Could not decode error */ -ata_dev_warn (dev,"could not decode error status 0x%x err_mask 0x%x\n" , - tf->status, qc->err_mask); -ata_scsi_set_sense (dev, cmd,ABORTED_COMMAND ,0 ,0 );return ; } + +/* Could not decode error */ +ata_dev_warn (dev, +"Could not decode error 0x%x, status 0x%x (err_mask=0x%x)\n" , + tf->error, tf->status, qc->err_mask); +aborted: +ata_scsi_set_sense (dev, cmd,ABORTED_COMMAND ,0 ,0 ); }void ata_scsi_sdev_config (struct scsi_device *sdev)Signature · 1 line
2.50.1
Damien Le Moal
maintainerRe: [PATCH 2/2] ata: libata-scsi: Return aborted command when missing sense and result TF
Quoted 48 lines · Igor Pylypiv
drivers/ata/libata-scsi.c static void ata_gen_ata_sense(struct ata_queued_cmd *qc)
Quoted 43 lines · Damien Le Moal
ata_gen_ata_sense()is always called for a failed qc missing sense data so that a sense key, code and code qualifier can be generated usingata_to_sense_error()from the qc status and error fields of its result task file. However, if the qc does not have its result task file filled,ata_gen_ata_sense()returns early without setting a sense key.Improve this by defaulting to returning ABORTED COMMAND without any additional sense code, since we do not know the reason for the failure. The same fix is also applied in
ata_gen_passthru_sense()with the additional check that the qc failed (qc->err_maskis set).Fixes 816be86c7993 ("ata: libata-scsi: Check ATA_QCFLAG_RTF_FILLED before using result_tf")Signed-off-by Damien Le Moal <[email protected]>--- drivers/ata/libata-scsi.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)drivers/ata/libata-scsi.c +4
-2@@ -938,6 +938,8 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc)if (!(qc->flags &ATA_QCFLAG_RTF_FILLED )) {ata_dev_dbg (dev,"missing result TF: can't generate ATA PT sense data\n" ); +if (qc->err_mask) +ata_scsi_set_sense (dev, cmd,ABORTED_COMMAND ,0 ,0 );return ; }@@ -992,8 +994,8 @@ static void ata_gen_ata_sense(struct ata_queued_cmd *qc)if (!(qc->flags &ATA_QCFLAG_RTF_FILLED )) {ata_dev_dbg (dev, -"missing result TF: can't generate sense data\n" ); -return ; +"Missing result TF: reporting aborted command\n" ); + goto aborted; }/* Use ata_to_sense_error() to map status register bits @@ -1004,13 +1006,15 @@ static void ata_gen_ata_sense(struct ata_queued_cmd *qc)There is a redundant check in
ata_gen_ata_sense().qc->err_mask(is_error) is already checked inata_scsi_qc_complete()before it callsata_gen_ata_sense().
Quoted 4 lines
if (qc->err_mask || tf->status & (ATA_BUSY | ATA_DF | ATA_ERR | ATA_DRQ)) {The function will be much cleaner once we remove this check.
Yep, we can remove the err_mask check.
Signature · 2 lines
Damien Le Moal Western Digital Research
Re: [PATCH 2/2] ata: libata-scsi: Return aborted command when missing sense and result TF
Quoted 49 lines · Damien Le Moal
Quoted 48 lines · Igor Pylypiv
drivers/ata/libata-scsi.c static void ata_gen_ata_sense(struct ata_queued_cmd *qc)
Quoted 43 lines · Damien Le Moal
ata_gen_ata_sense()is always called for a failed qc missing sense data so that a sense key, code and code qualifier can be generated usingata_to_sense_error()from the qc status and error fields of its result task file. However, if the qc does not have its result task file filled,ata_gen_ata_sense()returns early without setting a sense key.Improve this by defaulting to returning ABORTED COMMAND without any additional sense code, since we do not know the reason for the failure. The same fix is also applied in
ata_gen_passthru_sense()with the additional check that the qc failed (qc->err_maskis set).Fixes 816be86c7993 ("ata: libata-scsi: Check ATA_QCFLAG_RTF_FILLED before using result_tf")Signed-off-by Damien Le Moal <[email protected]>--- drivers/ata/libata-scsi.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)drivers/ata/libata-scsi.c +4
-2@@ -938,6 +938,8 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc)if (!(qc->flags &ATA_QCFLAG_RTF_FILLED )) {ata_dev_dbg (dev,"missing result TF: can't generate ATA PT sense data\n" ); +if (qc->err_mask) +ata_scsi_set_sense (dev, cmd,ABORTED_COMMAND ,0 ,0 );return ; }@@ -992,8 +994,8 @@ static void ata_gen_ata_sense(struct ata_queued_cmd *qc)if (!(qc->flags &ATA_QCFLAG_RTF_FILLED )) {ata_dev_dbg (dev, -"missing result TF: can't generate sense data\n" ); -return ; +"Missing result TF: reporting aborted command\n" ); + goto aborted; }/* Use ata_to_sense_error() to map status register bits @@ -1004,13 +1006,15 @@ static void ata_gen_ata_sense(struct ata_queued_cmd *qc)There is a redundant check in
ata_gen_ata_sense().qc->err_mask(is_error) is already checked inata_scsi_qc_complete()before it callsata_gen_ata_sense().
Quoted 7 lines
Quoted 4 lines
if (qc->err_mask || tf->status & (ATA_BUSY | ATA_DF | ATA_ERR | ATA_DRQ)) {The function will be much cleaner once we remove this check.
Yep, we can remove the
err_maskcheck.
To clarify, I mean that both conditions can be removed, not just the err_mask check. In the current code the err_mask check always evaluates to true so the right part of the OR expression is skipped due to lazy evaluation.
Thanks,
Igor
Quoted 4 lines
Signature · 3 lines
-- Damien Le Moal Western Digital Research
Damien Le Moal
maintainerRe: [PATCH 2/2] ata: libata-scsi: Return aborted command when missing sense and result TF
Quoted 6 lines · Igor Pylypiv
Quoted 6 lines
Quoted 6 lines
There is a redundant check in
ata_gen_ata_sense().qc->err_mask(is_error) is already checked inata_scsi_qc_complete()before it callsata_gen_ata_sense().if (qc->err_mask || tf->status & (ATA_BUSY | ATA_DF | ATA_ERR | ATA_DRQ)) {
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
The function will be much cleaner once we remove this check.
Yep, we can remove the
err_maskcheck.To clarify, I mean that both conditions can be removed, not just the
err_maskcheck. In the current code theerr_maskcheck always evaluates to true so the right part of the OR expression is skipped due to lazy evaluation.
Yes, we can simplify this.
Signature · 2 lines
Damien Le Moal Western Digital Research
Damien,
Quoted 4 lines
A couple of patches to fix issues with the translation of a failed qc status and error into a sense key and sense code. The first patch fixes a long standing problem leading to nonsensical sense reports for failed commands.
Looks fine.
Signature · 1 line
Martin K. Petersen