Skip to contentSkip to conversation

ARM: s3c/gpio: complete the conversion to new GPIO value setters

PATCH In review Bartosz Golaszewski 2 participants 3 messages Jul 30, 2025 – Aug 11, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: s3c/gpio: complete the conversion to new GPIO value setters

From: Bartosz Golaszewski <[email protected]>

Commit fb52f3226cab ("ARM: s3c/gpio: use new line value setter callbacks") correctly changed the assignment of the callback but missed the check one liner higher. Change it now too to using the recommended callback as the legacy one is going away soon.

Fixes fb52f3226cab ("ARM: s3c/gpio: use new line value setter callbacks")

---
Autobuilders pointed out only now that I missed the other line that needs changing in my previous patch. I'd like to still queue this for v6.17. Either through the SoC tree if it's not too late or through the GPIO tree together with my second PR for this merge window. Please kindly ack it.

 arch/arm/mach-s3c/gpio-samsung.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-s3c/gpio-samsung.c +1 -1
index 206a492fbaf5..3ee4ad969cc2 100644
@@ -516,7 +516,7 @@ static void __init samsung_gpiolib_add(struct samsung_gpio_chip *chip)
 		gc->direction_input = samsung_gpiolib_2bit_input;
 	if (!gc->direction_output)
 		gc->direction_output = samsung_gpiolib_2bit_output;
-	if (!gc->set)
+	if (!gc->set_rv)
 		gc->set_rv = samsung_gpiolib_set;
 	if (!gc->get)
 		gc->get = samsung_gpiolib_get;
Signature · 1 line
2.48.1
#1 lore raw
Quoted 7 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Commit fb52f3226cab ("ARM: s3c/gpio: use new line value setter callbacks") correctly changed the assignment of the callback but missed the check one liner higher. Change it now too to using the recommended callback as the legacy one is going away soon.

Quoted 8 lines
Fixes fb52f3226cab ("ARM: s3c/gpio: use new line value setter callbacks")

---
Autobuilders pointed out only now that I missed the other line that needs changing in my previous patch. I'd like to still queue this for v6.17. Either through the SoC tree if it's not too late or through the GPIO tree together with my second PR for this merge window. Please kindly ack it.

This does not apply for current RC, so on top of v6.17-rc1.

Best regards,
Krzysztof

#2 lore raw
Quoted 18 lines · Krzysztof Kozlowski
Quoted 7 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Commit fb52f3226cab ("ARM: s3c/gpio: use new line value setter callbacks") correctly changed the assignment of the callback but missed the check one liner higher. Change it now too to using the recommended callback as the legacy one is going away soon.

Quoted 8 lines
Fixes fb52f3226cab ("ARM: s3c/gpio: use new line value setter callbacks")

---
Autobuilders pointed out only now that I missed the other line that needs changing in my previous patch. I'd like to still queue this for v6.17. Either through the SoC tree if it's not too late or through the GPIO tree together with my second PR for this merge window. Please kindly ack it.

Quoted 4 lines

This does not apply for current RC, so on top of v6.17-rc1.

Best regards,
Krzysztof

This is no longer needed with v6.17-rc1. The callbacks have been renamed back globally to the original names.

Bart