Skip to contentSkip to conversation

usb: gadget: uvc: avoid assignment in if conditions

PATCH In review Darshan Rathod 2 participants 2 messages Jul 30, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 usb: gadget: uvc: avoid assignment in if conditions

Refactored code to separate assignments from conditional checks. This improves readability and conforms to kernel coding style as reported by checkpatch.pl.

---
 drivers/usb/gadget/function/uvc_video.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/usb/gadget/function/uvc_video.c +6 -3
index fb77b0b21790..d77ee5fd9b21 100644
@@ -777,18 +777,21 @@ int uvcg_video_enable(struct uvc_video *video)
 	 */
 	video->is_enabled = true;
 
-	if ((ret = uvcg_queue_enable(&video->queue, 1)) < 0)
+	ret = uvcg_queue_enable(&video->queue, 1);
+	if (ret < 0)
 		return ret;
 
-	if ((ret = uvc_video_alloc_requests(video)) < 0)
+	ret = uvc_video_alloc_requests(video);
+	if (ret < 0)
 		return ret;
 
 	if (video->max_payload_size) {
 		video->encode = uvc_video_encode_bulk;
 		video->payload_size = 0;
-	} else
+	} else {
 		video->encode = video->queue.use_sg ?
 			uvc_video_encode_isoc_sg : uvc_video_encode_isoc;
+	}
 
 	video->req_int_count = 0;
 
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 1 line · Darshan Rathod

Refactored code to separate assignments from conditional checks.

That is not all you did here :(

Please don't work on coding style cleanups for code that you do not know is allowed to take those types of changes. And especially as a "first contribution", please work in a subsystem that this type of changes are explicitly asked for, like drivers/staging/

Work there first, get experience in the kernel development workflow, and then worry about other parts of the kernel. That saves maintainer time and energy in reviewing changes that are not correct :(

hope this helps,

greg k-h