Skip to contentSkip to conversation

i2c: cadence: Add shutdown handler

PATCH Superseded Ajay Neeli 1 participant 2 messages Jul 30, 2025 – Sep 25, 2025

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Ajay Neeli

author
#0 lore raw

PATCH v3 1/1 i2c: cadence: Add shutdown handler

Implement shutdown function for Cadence I2C driver to suspend the bus during system "reboot" or "shutdown".

Interrupts are disabled in the handler to avoid spurious events when the driver is in slave mode.

---
Changes v2->v3:
Corrected a typo that caused a build error in v2

Changes in v1->v2:
Disable interrupts

---
 drivers/i2c/busses/i2c-cadence.c | 34 +++++++++++++++++++++++++++-------
 1 file changed, 27 insertions(+), 7 deletions(-)
drivers/i2c/busses/i2c-cadence.c +27 -7
index 8df63aa..4f033a6 100644
@@ -192,6 +192,7 @@ enum cdns_i2c_slave_state {
  * @transfer_size:	The maximum number of bytes in one transfer
  * @atomic:		Mode of transfer
  * @err_status_atomic:	Error status in atomic mode
+ * @irq:		IRQ Number
  */
 struct cdns_i2c {
 	struct device		*dev;
@@ -224,6 +225,7 @@ struct cdns_i2c {
 	unsigned int transfer_size;
 	bool atomic;
 	int err_status_atomic;
+	int irq;
 };
 
 struct cdns_platform_data {
@@ -1495,7 +1497,7 @@ static int cdns_i2c_probe(struct platform_device *pdev)
 {
 	struct resource *r_mem;
 	struct cdns_i2c *id;
-	int ret, irq;
+	int ret;
 	const struct of_device_id *match;
 
 	id = devm_kzalloc(&pdev->dev, sizeof(*id), GFP_KERNEL);
@@ -1526,9 +1528,9 @@ static int cdns_i2c_probe(struct platform_device *pdev)
 	if (IS_ERR(id->membase))
 		return PTR_ERR(id->membase);
 
-	irq = platform_get_irq(pdev, 0);
-	if (irq < 0)
-		return irq;
+	id->irq = platform_get_irq(pdev, 0);
+	if (id->irq < 0)
+		return id->irq;
 
 	id->adap.owner = THIS_MODULE;
 	id->adap.dev.of_node = pdev->dev.of_node;
@@ -1590,10 +1592,10 @@ static int cdns_i2c_probe(struct platform_device *pdev)
 		goto err_clk_notifier_unregister;
 	}
 
-	ret = devm_request_irq(&pdev->dev, irq, cdns_i2c_isr, 0,
+	ret = devm_request_irq(&pdev->dev, id->irq, cdns_i2c_isr, 0,
 				 DRIVER_NAME, id);
 	if (ret) {
-		dev_err(&pdev->dev, "cannot get irq %d\n", irq);
+		dev_err(&pdev->dev, "cannot get irq %d\n", id->irq);
 		goto err_clk_notifier_unregister;
 	}
 	cdns_i2c_init(id);
@@ -1603,7 +1605,7 @@ static int cdns_i2c_probe(struct platform_device *pdev)
 		goto err_clk_notifier_unregister;
 
 	dev_info(&pdev->dev, "%u kHz mmio %08lx irq %d\n",
-		 id->i2c_clk / 1000, (unsigned long)r_mem->start, irq);
+		 id->i2c_clk / 1000, (unsigned long)r_mem->start, id->irq);
 
 	return 0;
 
@@ -1636,6 +1638,23 @@ static void cdns_i2c_remove(struct platform_device *pdev)
 	reset_control_assert(id->reset);
 }
 
+/**
+ * cdns_i2c_shutdown - Shutdown the i2c device
+ * @pdev:	Handle to the platform device structure
+ *
+ * This function handles shutdown sequence
+ */
+static void cdns_i2c_shutdown(struct platform_device *pdev)
+{
+	struct cdns_i2c *id = platform_get_drvdata(pdev);
+
+	/* Disable interrupts */
+	disable_irq(id->irq);
+
+	/* Initiate failure of client i2c transfers */
+	i2c_mark_adapter_suspended(&id->adap);
+}
+
 static struct platform_driver cdns_i2c_drv = {
 	.driver = {
 		.name  = DRIVER_NAME,
@@ -1644,6 +1663,7 @@ static void cdns_i2c_remove(struct platform_device *pdev)
 	},
 	.probe  = cdns_i2c_probe,
 	.remove = cdns_i2c_remove,
+	.shutdown = cdns_i2c_shutdown,
 };
 
 module_platform_driver(cdns_i2c_drv);
Signature · 1 line
1.8.3.1
#1 lore raw

[Public]

Ping!

Quoted 124 lines

-----Original Message-----
From: Ajay Neeli <[email protected]>
Sent: Wednesday, July 30, 2025 5:59 PM
To: git (AMD-Xilinx) <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: Simek, Michal <[email protected]>; Goud, Srinivas <[email protected]>; Pandey, Radhey Shyam <[email protected]>; Neeli, Ajay <[email protected]>
Subject: [PATCH v3] i2c: cadence: Add shutdown handler

Implement shutdown function for Cadence I2C driver to suspend the bus during system "reboot" or "shutdown".

Interrupts are disabled in the handler to avoid spurious events when the driver is in slave mode.

---
Changes v2->v3:
Corrected a typo that caused a build error in v2

Changes in v1->v2:
Disable interrupts

---
 drivers/i2c/busses/i2c-cadence.c | 34 +++++++++++++++++++++++++++-------
 1 file changed, 27 insertions(+), 7 deletions(-)
drivers/i2c/busses/i2c-cadence.c +27 -8
index 8df63aa..4f033a6 100644
@@ -192,6 +192,7 @@ enum cdns_i2c_slave_state {
  * @transfer_size:   The maximum number of bytes in one transfer
  * @atomic:          Mode of transfer
  * @err_status_atomic:       Error status in atomic mode
+ * @irq:             IRQ Number
  */
 struct cdns_i2c {
      struct device           *dev;
@@ -224,6 +225,7 @@ struct cdns_i2c {
      unsigned int transfer_size;
      bool atomic;
      int err_status_atomic;
+     int irq;
 };
 
 struct cdns_platform_data {
@@ -1495,7 +1497,7 @@ static int cdns_i2c_probe(struct platform_device *pdev)
 {
      struct resource *r_mem;
      struct cdns_i2c *id;
-     int ret, irq;
+     int ret;
      const struct of_device_id *match;
 
      id = devm_kzalloc(&pdev->dev, sizeof(*id), GFP_KERNEL);
@@ -1526,9 +1528,9 @@ static int cdns_i2c_probe(struct platform_device *pdev)
      if (IS_ERR(id->membase))
              return PTR_ERR(id->membase);
 
-     irq = platform_get_irq(pdev, 0);
-     if (irq < 0)
-             return irq;
+     id->irq = platform_get_irq(pdev, 0);
+     if (id->irq < 0)
+             return id->irq;
 
      id->adap.owner = THIS_MODULE;
      id->adap.dev.of_node = pdev->dev.of_node;
@@ -1590,10 +1592,10 @@ static int cdns_i2c_probe(struct platform_device *pdev)
              goto err_clk_notifier_unregister;
      }
 
-     ret = devm_request_irq(&pdev->dev, irq, cdns_i2c_isr, 0,
+     ret = devm_request_irq(&pdev->dev, id->irq, cdns_i2c_isr, 0,
                               DRIVER_NAME, id);
      if (ret) {
-             dev_err(&pdev->dev, "cannot get irq %d\n", irq);
+             dev_err(&pdev->dev, "cannot get irq %d\n", id->irq);
              goto err_clk_notifier_unregister;
      }
      cdns_i2c_init(id);
@@ -1603,7 +1605,7 @@ static int cdns_i2c_probe(struct platform_device *pdev)
              goto err_clk_notifier_unregister;
 
      dev_info(&pdev->dev, "%u kHz mmio %08lx irq %d\n",
-              id->i2c_clk / 1000, (unsigned long)r_mem->start, irq);
+              id->i2c_clk / 1000, (unsigned long)r_mem->start, id->irq);
 
      return 0;
 
@@ -1636,6 +1638,23 @@ static void cdns_i2c_remove(struct platform_device *pdev)
      reset_control_assert(id->reset);
 }
 
+/**
+ * cdns_i2c_shutdown - Shutdown the i2c device
+ * @pdev:    Handle to the platform device structure
+ *
+ * This function handles shutdown sequence
+ */
+static void cdns_i2c_shutdown(struct platform_device *pdev)
+{
+     struct cdns_i2c *id = platform_get_drvdata(pdev);
+
+     /* Disable interrupts */
+     disable_irq(id->irq);
+
+     /* Initiate failure of client i2c transfers */
+     i2c_mark_adapter_suspended(&id->adap);
+}
+
 static struct platform_driver cdns_i2c_drv = {
      .driver = {
              .name  = DRIVER_NAME,
@@ -1644,6 +1663,7 @@ static void cdns_i2c_remove(struct platform_device *pdev)
      },
      .probe  = cdns_i2c_probe,
      .remove = cdns_i2c_remove,
+     .shutdown = cdns_i2c_shutdown,
 };
 
 module_platform_driver(cdns_i2c_drv);
--

1.8.3.1