Skip to contentSkip to conversation

arm64: dts: qcom: qcm2290: Add TCSR download mode address

PATCH Applied Sumit Garg 3 participants 3 messages Jul 30, 2025 – Aug 12, 2025

Subsystems (3)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support
lore
Share & tools
lore

Sumit Garg

author
#0 lore raw

PATCH 1/1 arm64: dts: qcom: qcm2290: Add TCSR download mode address

From: Sumit Garg <[email protected]>

Allow configuration of download mode via qcom_scm driver via specifying download mode register address in the TCSR space. It is especially useful for a clean watchdog reset without entry into download mode.

The problem remained un-noticed until now since error reporting for missing download mode configuration feature was explicitly suppressed.

Signed-off-by Sumit Garg <[email protected]>
---
 arch/arm64/boot/dts/qcom/qcm2290.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/qcm2290.dtsi +1 -0
index f49ac1c1f8a3..08eadec59882 100644
@@ -154,6 +154,7 @@ scm: scm {
 			compatible = "qcom,scm-qcm2290", "qcom,scm";
 			clocks = <&rpmcc RPM_SMD_CE1_CLK>;
 			clock-names = "core";
+			qcom,dload-mode = <&tcsr_regs 0x13000>;
 			#reset-cells = <1>;
 			interconnects = <&system_noc MASTER_CRYPTO_CORE0 RPM_ALWAYS_TAG
 					 &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>;
Signature · 1 line
2.48.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Sumit Garg

From: Sumit Garg <[email protected]>

Allow configuration of download mode via qcom_scm driver via specifying download mode register address in the TCSR space. It is especially useful for a clean watchdog reset without entry into download mode.

The problem remained un-noticed until now since error reporting for missing download mode configuration feature was explicitly suppressed.

Signed-off-by Sumit Garg <[email protected]>
---
 arch/arm64/boot/dts/qcom/qcm2290.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/qcm2290.dtsi +0 -0
index f49ac1c1f8a3..08eadec59882 100644

arch/arm64/boot/dts/qcom/qcm2290.dtsi scm: scm { · line 157

Quoted 4 lines
arch/arm64/boot/dts/qcom/qcm2290.dtsi +1 -0
@@ -154,6 +154,7 @@ scm: scm {
 			compatible = "qcom,scm-qcm2290", "qcom,scm";
 			clocks = <&rpmcc RPM_SMD_CE1_CLK>;
 			clock-names = "core";
+			qcom,dload-mode = <&tcsr_regs 0x13000>;

Can confirm it's the right addr

Reviewed-by Konrad Dybcio <[email protected]>

Konrad

maintainer Applied
#2 lore raw
In reply to Sumit Garg
Quoted 8 lines · Sumit Garg

Allow configuration of download mode via qcom_scm driver via specifying download mode register address in the TCSR space. It is especially useful for a clean watchdog reset without entry into download mode.

The problem remained un-noticed until now since error reporting for missing download mode configuration feature was explicitly suppressed.

[...]

Applied, thanks!

[1/1] arm64: dts: qcom: qcm2290: Add TCSR download mode address

      commit: dc231840dca64793da7a80ff156fa1d99584f3ea

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>