Skip to contentSkip to conversation

mtd: map: add back asm/barrier.h inclusion

PATCH Applied Arnd Bergmann 3 participants 3 messages Jul 30, 2025 – Sep 1, 2025 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: map: add back asm/barrier.h inclusion

From: Arnd Bergmann <[email protected]>

The mb() macro is used in this header:

In file included from include/linux/mtd/qinfo.h:5,
from include/linux/mtd/pfow.h:8,
from drivers/mtd/lpddr/lpddr_cmds.c:14:
include/linux/mtd/map.h: In function 'inline_map_write':
include/linux/mtd/map.h:428:9: error: implicit declaration of function 'mb' [-Wimplicit-function-declaration]

Fixes 56eb7c13b97c ("mtd: map: Don't use "proxy" headers")
---
 include/linux/mtd/map.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/mtd/map.h +1 -0
index 288ef765a44e..75b0b2abc880 100644
@@ -14,6 +14,7 @@
 #include <linux/string.h>
 #include <linux/types.h>
 #include <linux/unaligned.h>
+#include <asm/barrier.h>
 
 struct device_node;
 struct module;
Signature · 1 line
2.39.5
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The mb() macro is used in this header:

In file included from include/linux/mtd/qinfo.h:5,
from include/linux/mtd/pfow.h:8,
from drivers/mtd/lpddr/lpddr_cmds.c:14:
include/linux/mtd/map.h: In function 'inline_map_write':
include/linux/mtd/map.h:428:9: error: implicit declaration of function 'mb' [-Wimplicit-function-declaration]

Oops, thanks!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Applied
#2 lore raw
In reply to Arnd Bergmann
Quoted 9 lines · Arnd Bergmann

The mb() macro is used in this header:

In file included from include/linux/mtd/qinfo.h:5,
from include/linux/mtd/pfow.h:8,
from drivers/mtd/lpddr/lpddr_cmds.c:14:
include/linux/mtd/map.h: In function 'inline_map_write':
include/linux/mtd/map.h:428:9: error: implicit declaration of function 'mb' [-Wimplicit-function-declaration]

[...]

Applied to mtd/next, thanks!

[1/1] mtd: map: add back asm/barrier.h inclusion

      commit: 6538d039c524304a00b8fac651982fdf1fe24cc3

Patche(s) should be available on mtd/linux.git and will be part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl