Skip to contentSkip to conversation

raw/ntb: immediate return if no doorbells

PATCH In review Tofig Aliev 2 participants 2 messages Jul 31, 2025 – Sep 24, 2025

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 raw/ntb: immediate return if no doorbells

Added immediate return from ntb_dev_intr_handler() if no doorbells.

---
Changes in v2:
Fixed incorrect patch file.

---
 drivers/raw/ntb/ntb.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/raw/ntb/ntb.c +3 -1
index 0ed4c14592..e298820e5f 100644
@@ -158,8 +158,10 @@ ntb_dev_intr_handler(void *param)
 	}
 
 	db_bits = (*hw->ntb_ops->db_read)(dev);
-	if (!db_bits)
+	if (!db_bits) {
 		NTB_LOG(ERR, "No doorbells");
+		return;
+	}
 
 	/* Doorbell 0 is for peer device ready. */
 	if (db_bits & 1) {
Signature · 1 line
2.43.0
#1 lore raw

31/07/2025 20:31, Tofig Aliev:

Quoted 2 lines

Added immediate return from ntb_dev_intr_handler() if no doorbells.

Please could you explain the consequence of this bug?

Should it be backported?

[...

Quoted 12 lines
drivers/raw/ntb/ntb.c +3 -1
@@ -158,8 +158,10 @@ ntb_dev_intr_handler(void *param)
 	}
 
 	db_bits = (*hw->ntb_ops->db_read)(dev);
-	if (!db_bits)
+	if (!db_bits) {
 		NTB_LOG(ERR, "No doorbells");
+		return;
+	}
 
 	/* Doorbell 0 is for peer device ready. */
 	if (db_bits & 1) {