WARNING in __ww_mutex_wound
Subsystems (2)
syzbot
syzbotHello,
syzbot found the following issue on:
HEAD commit: d086c886ceb9 Add linux-next specific files for 20250718 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=161204a2580000 kernel config: https://syzkaller.appspot.com/x/.config?x=69896dd7b8c4e81e dashboard link: https://syzkaller.appspot.com/bug?extid=602c4720aed62576cd79 compiler: Debian clang version 20.1.7 (++20250616065708+6146a88f6049-1~exp1~20250616065826.132), Debian LLD 20.1.7 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16fff4f0580000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=111204a2580000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/54504fbc2437/disk-d086c886.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/b427b00abffe/vmlinux-d086c886.xz
kernel image: https://storage.googleapis.com/syzbot-assets/5a87731b006b/bzImage-d086c886.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
------------[ cut here ]------------ WARNING: ./include/linux/sched.h:2173 at __clear_task_blocked_on include/linux/sched.h:2173 [inline], CPU#1: syz.1.8698/395 WARNING: ./include/linux/sched.h:2173 at __ww_mutex_wound+0x21a/0x2b0 kernel/locking/ww_mutex.h:346, CPU#1: syz.1.8698/395 Modules linked in: CPU: 1 UID: 0 PID: 395 Comm: syz.1.8698 Not tainted 6.16.0-rc6-next-20250718-syzkaller #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025 RIP: 0010:__clear_task_blocked_on include/linux/sched.h:2173 [inline] RIP: 0010:__ww_mutex_wound+0x21a/0x2b0 kernel/locking/ww_mutex.h:346 Code: 5f 5d c3 cc cc cc cc cc 90 0f 0b 90 e9 89 fe ff ff 90 0f 0b 90 e9 39 ff ff ff 90 0f 0b 90 4d 85 ff 0f 85 67 ff ff ff eb 95 90 <0f> 0b 90 eb 8f 48 c7 c1 70 00 e4 8f 80 e1 07 80 c1 03 38 c1 0f 8c RSP: 0018:ffffc900030e7720 EFLAGS: 00010046 RAX: ffff888024a1b000 RBX: dffffc0000000000 RCX: 8f1a7ab232ebe500 RDX: 00000000000003ef RSI: ffffffff8de5b067 RDI: ffffffff8c04d400 RBP: 0000000000000001 R08: ffff888024a224bf R09: 1ffff11004944497 R10: dffffc0000000000 R11: ffffed1004944498 R12: ffff88802dee8a78 R13: ffffc900030e7ae8 R14: ffff88802dee8000 R15: ffff888024a224b8 FS: 00007fe6e4a7f6c0(0000) GS:ffff8881258ab000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fe6e4a5ed58 CR3: 000000003115e000 CR4: 00000000003526f0 Call Trace: <TASK> __ww_mutex_add_waiter kernel/locking/ww_mutex.h:574 [inline] __mutex_lock_common kernel/locking/mutex.c:642 [inline] __ww_mutex_lock+0xba3/0x2930 kernel/locking/mutex.c:771 ww_mutex_lock_interruptible+0x3f/0x1c0 kernel/locking/mutex.c:904 modeset_lock+0x21a/0x650 drivers/gpu/drm/drm_modeset_lock.c:-1 drm_modeset_lock drivers/gpu/drm/drm_modeset_lock.c:398 [inline] drm_modeset_lock_all_ctx+0x62/0x300 drivers/gpu/drm/drm_modeset_lock.c:459 setplane_internal drivers/gpu/drm/drm_plane.c:1118 [inline] drm_mode_setplane+0x577/0xba0 drivers/gpu/drm/drm_plane.c:1175 drm_ioctl_kernel+0x2cc/0x390 drivers/gpu/drm/drm_ioctl.c:796 drm_ioctl+0x67f/0xb10 drivers/gpu/drm/drm_ioctl.c:893 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:598 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:584 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fe6e3b8e9a9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fe6e4a7f038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007fe6e3db5fa0 RCX: 00007fe6e3b8e9a9 RDX: 0000200000000080 RSI: 00000000c03064b7 RDI: 0000000000000003 RBP: 00007fe6e3c10d69 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fe6e3db5fa0 R15: 00007ffdf1fa90a8 </TASK>
---
This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at [email protected].
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
Hey,
This warning is introduced in linux-next as a4f0b6fef4b0 ("locking/mutex: Add p->blocked_on wrappers for correctness checks") Adding relevant people from that commit.
Kind regards,
~Maarten
Den 2025-07-29 kl. 23:59, skrev syzbot:
Quoted 93 lines
Hello,
syzbot found the following issue on:
HEAD commit: d086c886ceb9 Add linux-next specific files for 20250718 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=161204a2580000 kernel config: https://syzkaller.appspot.com/x/.config?x=69896dd7b8c4e81e dashboard link: https://syzkaller.appspot.com/bug?extid=602c4720aed62576cd79 compiler: Debian clang version 20.1.7 (++20250616065708+6146a88f6049-1~exp1~20250616065826.132), Debian LLD 20.1.7 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16fff4f0580000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=111204a2580000Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/54504fbc2437/disk-d086c886.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/b427b00abffe/vmlinux-d086c886.xz
kernel image: https://storage.googleapis.com/syzbot-assets/5a87731b006b/bzImage-d086c886.xzIMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by [email protected]------------[ cut here ]------------ WARNING: ./include/linux/sched.h:2173 at __clear_task_blocked_on include/linux/sched.h:2173 [inline], CPU#1: syz.1.8698/395 WARNING: ./include/linux/sched.h:2173 at __ww_mutex_wound+0x21a/0x2b0 kernel/locking/ww_mutex.h:346, CPU#1: syz.1.8698/395 Modules linked in: CPU: 1 UID: 0 PID: 395 Comm: syz.1.8698 Not tainted 6.16.0-rc6-next-20250718-syzkaller #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025 RIP: 0010:__clear_task_blocked_on include/linux/sched.h:2173 [inline] RIP: 0010:__ww_mutex_wound+0x21a/0x2b0 kernel/locking/ww_mutex.h:346 Code: 5f 5d c3 cc cc cc cc cc 90 0f 0b 90 e9 89 fe ff ff 90 0f 0b 90 e9 39 ff ff ff 90 0f 0b 90 4d 85 ff 0f 85 67 ff ff ff eb 95 90 <0f> 0b 90 eb 8f 48 c7 c1 70 00 e4 8f 80 e1 07 80 c1 03 38 c1 0f 8c RSP: 0018:ffffc900030e7720 EFLAGS: 00010046 RAX: ffff888024a1b000 RBX: dffffc0000000000 RCX: 8f1a7ab232ebe500 RDX: 00000000000003ef RSI: ffffffff8de5b067 RDI: ffffffff8c04d400 RBP: 0000000000000001 R08: ffff888024a224bf R09: 1ffff11004944497 R10: dffffc0000000000 R11: ffffed1004944498 R12: ffff88802dee8a78 R13: ffffc900030e7ae8 R14: ffff88802dee8000 R15: ffff888024a224b8 FS: 00007fe6e4a7f6c0(0000) GS:ffff8881258ab000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fe6e4a5ed58 CR3: 000000003115e000 CR4: 00000000003526f0 Call Trace: <TASK> __ww_mutex_add_waiter kernel/locking/ww_mutex.h:574 [inline] __mutex_lock_common kernel/locking/mutex.c:642 [inline] __ww_mutex_lock+0xba3/0x2930 kernel/locking/mutex.c:771 ww_mutex_lock_interruptible+0x3f/0x1c0 kernel/locking/mutex.c:904 modeset_lock+0x21a/0x650 drivers/gpu/drm/drm_modeset_lock.c:-1 drm_modeset_lock drivers/gpu/drm/drm_modeset_lock.c:398 [inline] drm_modeset_lock_all_ctx+0x62/0x300 drivers/gpu/drm/drm_modeset_lock.c:459 setplane_internal drivers/gpu/drm/drm_plane.c:1118 [inline] drm_mode_setplane+0x577/0xba0 drivers/gpu/drm/drm_plane.c:1175 drm_ioctl_kernel+0x2cc/0x390 drivers/gpu/drm/drm_ioctl.c:796 drm_ioctl+0x67f/0xb10 drivers/gpu/drm/drm_ioctl.c:893 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:598 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:584 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fe6e3b8e9a9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fe6e4a7f038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007fe6e3db5fa0 RCX: 00007fe6e3b8e9a9 RDX: 0000200000000080 RSI: 00000000c03064b7 RDI: 0000000000000003 RBP: 00007fe6e3c10d69 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fe6e3db5fa0 R15: 00007ffdf1fa90a8 </TASK>---
This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at [email protected].syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-titleIf you want syzbot to run the reproducer, reply with:
#syz test:git://repo/address.gitbranch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-reportIf you want to undo deduplication, reply with:
#syz undup
K Prateek Nayak
reviewerQuoted 38 lines · Maarten Lankhorst
Hey,
This warning is introduced in linux-next as
a4f0b6fef4b0("locking/mutex: Addp->blocked_onwrappers for correctness checks") Adding relevant people from that commit.Kind regards,
~MaartenDen 2025-07-29 kl. 23:59, skrev syzbot:
Quoted 29 lines
Hello,
syzbot found the following issue on:
HEAD commit: d086c886ceb9 Add linux-next specific files for 20250718 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=161204a2580000 kernel config: https://syzkaller.appspot.com/x/.config?x=69896dd7b8c4e81e dashboard link: https://syzkaller.appspot.com/bug?extid=602c4720aed62576cd79 compiler: Debian clang version 20.1.7 (++20250616065708+6146a88f6049-1~exp1~20250616065826.132), Debian LLD 20.1.7 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16fff4f0580000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=111204a2580000Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/54504fbc2437/disk-d086c886.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/b427b00abffe/vmlinux-d086c886.xz
kernel image: https://storage.googleapis.com/syzbot-assets/5a87731b006b/bzImage-d086c886.xzIMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by [email protected]------------[ cut here ]------------ WARNING: ./include/linux/sched.h:2173 at __clear_task_blocked_on include/linux/sched.h:2173 [inline], CPU#1: syz.1.8698/395 WARNING: ./include/linux/sched.h:2173 at __ww_mutex_wound+0x21a/0x2b0 kernel/locking/ww_mutex.h:346, CPU#1: syz.1.8698/395 Modules linked in: CPU: 1 UID: 0 PID: 395 Comm: syz.1.8698 Not tainted 6.16.0-rc6-next-20250718-syzkaller #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025 RIP: 0010:__clear_task_blocked_on include/linux/sched.h:2173 [inline] RIP: 0010:__ww_mutex_wound+0x21a/0x2b0 kernel/locking/ww_mutex.h:346
When wounding the lock owner, could it be possible that the lock owner is blocked on a different nested lock? Lock owner implies it is not blocked on the current lock we are trying to wound right?
I remember John mentioning seeing circular chains in find_proxy_task() which required this but looking at this call-chain I'm wondering if only the __ww_mutex_check_waiters() (or some other path) requires __clear_task_blocked_on() for that case.
Quoted 65 lines
Quoted 64 lines
Code: 5f 5d c3 cc cc cc cc cc 90 0f 0b 90 e9 89 fe ff ff 90 0f 0b 90 e9 39 ff ff ff 90 0f 0b 90 4d 85 ff 0f 85 67 ff ff ff eb 95 90 <0f> 0b 90 eb 8f 48 c7 c1 70 00 e4 8f 80 e1 07 80 c1 03 38 c1 0f 8c RSP: 0018:ffffc900030e7720 EFLAGS: 00010046 RAX: ffff888024a1b000 RBX: dffffc0000000000 RCX: 8f1a7ab232ebe500 RDX: 00000000000003ef RSI: ffffffff8de5b067 RDI: ffffffff8c04d400 RBP: 0000000000000001 R08: ffff888024a224bf R09: 1ffff11004944497 R10: dffffc0000000000 R11: ffffed1004944498 R12: ffff88802dee8a78 R13: ffffc900030e7ae8 R14: ffff88802dee8000 R15: ffff888024a224b8 FS: 00007fe6e4a7f6c0(0000) GS:ffff8881258ab000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fe6e4a5ed58 CR3: 000000003115e000 CR4: 00000000003526f0 Call Trace: <TASK> __ww_mutex_add_waiter kernel/locking/ww_mutex.h:574 [inline] __mutex_lock_common kernel/locking/mutex.c:642 [inline] __ww_mutex_lock+0xba3/0x2930 kernel/locking/mutex.c:771 ww_mutex_lock_interruptible+0x3f/0x1c0 kernel/locking/mutex.c:904 modeset_lock+0x21a/0x650 drivers/gpu/drm/drm_modeset_lock.c:-1 drm_modeset_lock drivers/gpu/drm/drm_modeset_lock.c:398 [inline] drm_modeset_lock_all_ctx+0x62/0x300 drivers/gpu/drm/drm_modeset_lock.c:459 setplane_internal drivers/gpu/drm/drm_plane.c:1118 [inline] drm_mode_setplane+0x577/0xba0 drivers/gpu/drm/drm_plane.c:1175 drm_ioctl_kernel+0x2cc/0x390 drivers/gpu/drm/drm_ioctl.c:796 drm_ioctl+0x67f/0xb10 drivers/gpu/drm/drm_ioctl.c:893 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:598 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:584 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fe6e3b8e9a9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fe6e4a7f038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007fe6e3db5fa0 RCX: 00007fe6e3b8e9a9 RDX: 0000200000000080 RSI: 00000000c03064b7 RDI: 0000000000000003 RBP: 00007fe6e3c10d69 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fe6e3db5fa0 R15: 00007ffdf1fa90a8 </TASK>---
This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at [email protected].syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-titleIf you want syzbot to run the reproducer, reply with:
#syz test:git://repo/address.gitbranch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-reportIf you want to undo deduplication, reply with:
#syz undup
Signature · 2 lines
Thanks and Regards, Prateek
Quoted 40 lines · On Wed, 30 Jul 2025 15:20:39 +0530 K Prateek Nayak wrote:
Quoted 38 lines · Maarten Lankhorst
Hey,
This warning is introduced in linux-next as
a4f0b6fef4b0("locking/mutex: Addp->blocked_onwrappers for correctness checks") Adding relevant people from that commit.Kind regards,
~MaartenDen 2025-07-29 kl. 23:59, skrev syzbot:
Quoted 29 lines
Hello,
syzbot found the following issue on:
HEAD commit: d086c886ceb9 Add linux-next specific files for 20250718 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=161204a2580000 kernel config: https://syzkaller.appspot.com/x/.config?x=69896dd7b8c4e81e dashboard link: https://syzkaller.appspot.com/bug?extid=602c4720aed62576cd79 compiler: Debian clang version 20.1.7 (++20250616065708+6146a88f6049-1~exp1~20250616065826.132), Debian LLD 20.1.7 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16fff4f0580000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=111204a2580000Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/54504fbc2437/disk-d086c886.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/b427b00abffe/vmlinux-d086c886.xz
kernel image: https://storage.googleapis.com/syzbot-assets/5a87731b006b/bzImage-d086c886.xzIMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by [email protected]------------[ cut here ]------------ WARNING: ./include/linux/sched.h:2173 at __clear_task_blocked_on include/linux/sched.h:2173 [inline], CPU#1: syz.1.8698/395 WARNING: ./include/linux/sched.h:2173 at __ww_mutex_wound+0x21a/0x2b0 kernel/locking/ww_mutex.h:346, CPU#1: syz.1.8698/395 Modules linked in: CPU: 1 UID: 0 PID: 395 Comm: syz.1.8698 Not tainted 6.16.0-rc6-next-20250718-syzkaller #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025 RIP: 0010:__clear_task_blocked_on include/linux/sched.h:2173 [inline] RIP: 0010:__ww_mutex_wound+0x21a/0x2b0 kernel/locking/ww_mutex.h:346
Quoted 9 lines
When wounding the lock owner, could it be possible that the lock owner is blocked on a different nested lock? Lock owner implies it is not blocked on the current lock we are trying to wound right?
I remember John mentioning seeing circular chains in
find_proxy_task()which required this but looking at this call-chain I'm wondering if only the__ww_mutex_check_waiters()(or some other path) requires__clear_task_blocked_on()for that case.
It is buggy to read and clear owner->blocked_on without owner->blocked_on->wait_lock held, no?
Quoted 6 lines · K Prateek Nayak
Quoted 5 lines · Maarten Lankhorst
Hey,
This warning is introduced in linux-next as
a4f0b6fef4b0("locking/mutex: Addp->blocked_onwrappers for correctness checks") Adding relevant people from that commit.
...
Quoted 9 lines
Quoted 8 lines
Quoted 8 lines
------------[ cut here ]------------ WARNING: ./include/linux/sched.h:2173 at __clear_task_blocked_on include/linux/sched.h:2173 [inline], CPU#1: syz.1.8698/395 WARNING: ./include/linux/sched.h:2173 at __ww_mutex_wound+0x21a/0x2b0 kernel/locking/ww_mutex.h:346, CPU#1: syz.1.8698/395 Modules linked in: CPU: 1 UID: 0 PID: 395 Comm: syz.1.8698 Not tainted 6.16.0-rc6-next-20250718-syzkaller #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025 RIP: 0010:__clear_task_blocked_on include/linux/sched.h:2173 [inline] RIP: 0010:__ww_mutex_wound+0x21a/0x2b0 kernel/locking/ww_mutex.h:346
Quoted 8 lines
When wounding the lock owner, could it be possible that the lock owner is blocked on a different nested lock? Lock owner implies it is not blocked on the current lock we are trying to wound right?
I remember John mentioning seeing circular chains in
find_proxy_task()which required this but looking at this call-chain I'm wondering if only the__ww_mutex_check_waiters()(or some other path) requires__clear_task_blocked_on()for that case.
So yeah, I have tripped over this a few times (fixing and often later re-introducing the problem) but usually later in my full proxy-exec series, and somehow missed that the single-rq hit this.
Obviously with __ww_mutex_die() we are clearing the blocked on relationship for the lock waiter, but in __ww_mutex_wound() we are waking the lock *owner*, who might be waiting on a different lock, so passing the held lock to the clear_task_blocked_on() checks trips these warnings.
Passing NULL instead of lock is the right call here, I'll just need to loosen the __clear_task_blocked_on() check for null as well.
I'll spin up a quick patch.
thanks
-john
RFC PATCH 1/1 locking: Fix __clear_task_blocked_on() warning from __ww_mutex_wound() path
In reply to syzbotThe __clear_task_blocked_on() helper added a number of sanity checks ensuring we hold the lock and that the task we are clearing blocked_on pointer (if set) matches the lock.
However, there is an edge case in the _ww_mutex_wound() logic where we need to clear the blocked_on pointer for the task that owns the lock, not the task that is waiting on the lock.
For this case the sanity checks aren't valid, so handle this by allowing a NULL lock to skip the additional checks.
This was easier to miss, I realized, as the test-ww_mutex driver only exercises the wait-die class of ww_mutexes.
I've got a follow up patch to extend the test so that it will exercise both.
---
Cc: Ingo Molnar <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Juri Lelli <[email protected]>
Cc: Vincent Guittot <[email protected]>
Cc: Dietmar Eggemann <[email protected]>
Cc: Valentin Schneider <[email protected]>
Cc: K Prateek Nayak <[email protected]>
Cc: Suleiman Souhlal <[email protected]>
Cc: Maarten Lankhorst <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- include/linux/sched.h | 19 ++++++++++--------- kernel/locking/ww_mutex.h | 6 +++++- 2 files changed, 15 insertions(+), 10 deletions(-)
include/linux/sched.h +10 -9
@@ -2166,15 +2166,16 @@ static inline void set_task_blocked_on(struct task_struct *p, struct mutex *m)static inline void __clear_task_blocked_on (struct task_struct *p,struct mutex *m) { -WARN_ON_ONCE (!m); -/* Currently we serialize blocked_on under the mutex::wait_lock */ -lockdep_assert_held_once (&m->wait_lock); -/* -* There may be cases where we re-clear already cleared -* blocked_on relationships, but make sure we are not -* clearing the relationship with a different lock. -*/ -WARN_ON_ONCE (m && p->blocked_on && p->blocked_on != m); +if (m) { +/* Currently we serialize blocked_on under the mutex::wait_lock */ +lockdep_assert_held_once (&m->wait_lock); +/* +* There may be cases where we re-clear already cleared +* blocked_on relationships, but make sure we are not +* clearing the relationship with a different lock. +*/ +WARN_ON_ONCE (m && p->blocked_on && p->blocked_on != m); + } p->blocked_on =NULL ; }
kernel/locking/ww_mutex.h +5 -1
@@ -342,8 +342,12 @@ static bool __ww_mutex_wound(struct MUTEX *lock,* When waking up the task to wound, be sure to clear the * blocked_on pointer. Otherwise we can see circular * blocked_on relationships that can't resolve. +* +* NOTE: We pass NULL here instead of lock, because we +* are waking the lock owner, who may be currently blocked +* on a different lock. */ -__clear_task_blocked_on (owner, lock); +__clear_task_blocked_on (owner,NULL );wake_q_add (wake_q, owner); }return true;
Signature · 1 line
2.50.1.565.gc32cd1483b-goog
K Prateek Nayak
reviewerRe: [RFC][PATCH] locking: Fix __clear_task_blocked_on() warning from __ww_mutex_wound() path
Hello John,
On 8/1/2025 1:43 AM, John Stultz wrote:
[..snip..]
Quoted 16 lines
include/linux/sched.h +0
-8@@ -2166,15 +2166,16 @@ static inline void set_task_blocked_on(struct task_struct *p, struct mutex *m)static inline void __clear_task_blocked_on (struct task_struct *p,struct mutex *m) { -WARN_ON_ONCE (!m); -/* Currently we serialize blocked_on under the mutex::wait_lock */ -lockdep_assert_held_once (&m->wait_lock); -/* -* There may be cases where we re-clear already cleared -* blocked_on relationships, but make sure we are not -* clearing the relationship with a different lock. -*/
include/linux/sched.h static inline void set_task_blocked_on(struct task_struct *p, struct mutex *m) · line 2177
Quoted 10 lines
include/linux/sched.h +9
-1-WARN_ON_ONCE (m && p->blocked_on && p->blocked_on != m); +if (m) { +/* Currently we serialize blocked_on under the mutex::wait_lock */ +lockdep_assert_held_once (&m->wait_lock); +/* +* There may be cases where we re-clear already cleared +* blocked_on relationships, but make sure we are not +* clearing the relationship with a different lock. +*/ +WARN_ON_ONCE (m && p->blocked_on && p->blocked_on != m);
Small concern since we don't hold the "owner->blocked_on->wait_lock" here when arriving from __ww_mutex_wound() as Hillf pointed out, can we run into a situation like:
CPU0 CPU1
(Owner of Mutex A, (Trying to acquire Mutex A)
trying to acquire Mutex B)
========================== ===========================
__mutex_lock_common(B)
... /* B->wait_lock held */
set_task_blocked_on(ownerA, B)
if (__mutex_trylock(B)) /* Returns true */ __mutex_lock_common(A)
goto acquired; /* Goes to below point */ ... /* A->wait_lock held */
__clear_task_blocked_on(ownerA, B); __ww_mutex_wound(ownerA)
WARN_ON_ONCE(m /* Mutex B*/ ...
&& ownerA->blocked_on /* Mutex B */ __clear_task_blocked_on(ownerA, NULL)
... ownerA->blocked_on = NULL;
&& ownerA->blocked_on /* NULL */ != m /* Mutex B */);
!!! SPLAT !!!At the very least I think we should make a local copy of "p->blocked_on" to see a consistent view throughout __clear_task_blocked_on() - task either sees it is blocked on the mutex and clear "p->blocked_on", or it sees it is blocked on nothing and still clears "p->blocked_on".
(Tested lightly with syzbot's C reproducer)
include/linux/sched.h +3 -1
@@ -2165,6 +2165,8 @@ static inline void set_task_blocked_on(struct task_struct *p, struct mutex *m)static inline void __clear_task_blocked_on (struct task_struct *p,struct mutex *m) {if (m) { +struct mutex *blocked_on = p->blocked_on; +/* Currently we serialize blocked_on under the mutex::wait_lock */ lockdep_assert_held_once (&m->wait_lock);/*
@@ -2172,7 +2174,7 @@ static inline void __clear_task_blocked_on(struct task_struct *p, struct mutex ** blocked_on relationships, but make sure we are not * clearing the relationship with a different lock. */ -WARN_ON_ONCE (m && p->blocked_on && p->blocked_on != m); +WARN_ON_ONCE (m && blocked_on && blocked_on != m); } p->blocked_on =NULL ; }
---
End result is the same, only that we avoid an unnecessary splat in this very unlikely case and save ourselves some head scratching later :)
Thoughts?
Quoted 22 lines
include/linux/sched.h +1
-0+ } p->blocked_on =NULL ; }kernel/locking/ww_mutex.h +5
-1@@ -342,8 +342,12 @@ static bool __ww_mutex_wound(struct MUTEX *lock,* When waking up the task to wound, be sure to clear the * blocked_on pointer. Otherwise we can see circular * blocked_on relationships that can't resolve. +* +* NOTE: We pass NULL here instead of lock, because we +* are waking the lock owner, who may be currently blocked +* on a different lock. */ -__clear_task_blocked_on (owner, lock); +__clear_task_blocked_on (owner,NULL );wake_q_add (wake_q, owner); }return true;
Signature · 2 lines
Thanks and Regards, Prateek
Re: [RFC][PATCH] locking: Fix __clear_task_blocked_on() warning from __ww_mutex_wound() path
Den 2025-08-01 kl. 07:09, skrev K Prateek Nayak:
Quoted 86 lines
Hello John,
On 8/1/2025 1:43 AM, John Stultz wrote:
[..snip..]
Quoted 16 lines
include/linux/sched.h +0
-8@@ -2166,15 +2166,16 @@ static inline void set_task_blocked_on(struct task_struct *p, struct mutex *m)static inline void __clear_task_blocked_on (struct task_struct *p,struct mutex *m) { -WARN_ON_ONCE (!m); -/* Currently we serialize blocked_on under the mutex::wait_lock */ -lockdep_assert_held_once (&m->wait_lock); -/* -* There may be cases where we re-clear already cleared -* blocked_on relationships, but make sure we are not -* clearing the relationship with a different lock. -*/ include/linux/sched.h static inline void set_task_blocked_on(struct task_struct *p, struct mutex *m) · line 2177
Quoted 10 lines
include/linux/sched.h +9
-1-WARN_ON_ONCE (m && p->blocked_on && p->blocked_on != m); +if (m) { +/* Currently we serialize blocked_on under the mutex::wait_lock */ +lockdep_assert_held_once (&m->wait_lock); +/* +* There may be cases where we re-clear already cleared +* blocked_on relationships, but make sure we are not +* clearing the relationship with a different lock. +*/ +WARN_ON_ONCE (m && p->blocked_on && p->blocked_on != m);Small concern since we don't hold the "
owner->blocked_on->wait_lock" here when arriving from__ww_mutex_wound()as Hillf pointed out, can we run into a situation like:CPU0 CPU1 (Owner of Mutex A, (Trying to acquire Mutex A) trying to acquire Mutex B) ========================== =========================== __mutex_lock_common(B) ... /* B->wait_lock held */ set_task_blocked_on(ownerA, B) if (__mutex_trylock(B)) /* Returns true */ __mutex_lock_common(A) goto acquired; /* Goes to below point */ ... /* A->wait_lock held */ __clear_task_blocked_on(ownerA, B); __ww_mutex_wound(ownerA) WARN_ON_ONCE(m /* Mutex B*/ ... && ownerA->blocked_on /* Mutex B */ __clear_task_blocked_on(ownerA, NULL) ... ownerA->blocked_on = NULL; && ownerA->blocked_on /* NULL */ != m /* Mutex B */); !!! SPLAT !!!At the very least I think we should make a local copy of "
p->blocked_on" to see a consistent view throughout__clear_task_blocked_on()- task either sees it is blocked on the mutex and clear "p->blocked_on", or it sees it is blocked on nothing and still clears "p->blocked_on".(Tested lightly with syzbot's C reproducer)
include/linux/sched.h +3
-2@@ -2165,6 +2165,8 @@ static inline void set_task_blocked_on(struct task_struct *p, struct mutex *m)static inline void __clear_task_blocked_on (struct task_struct *p,struct mutex *m) {if (m) { +struct mutex *blocked_on = p->blocked_on; +/* Currently we serialize blocked_on under the mutex::wait_lock */ lockdep_assert_held_once (&m->wait_lock);/* @@ -2172,7 +2174,7 @@ static inline void __clear_task_blocked_on(struct task_struct *p, struct mutex ** blocked_on relationships, but make sure we are not * clearing the relationship with a different lock. */ -WARN_ON_ONCE (m && p->blocked_on && p->blocked_on != m); +WARN_ON_ONCE (m && blocked_on && blocked_on != m); } p->blocked_on =NULL ; } ---
Quoted 4 lines
End result is the same, only that we avoid an unnecessary splat in this very unlikely case and save ourselves some head scratching later :)
Thoughts?
If this is required, than it should be blocked_on = READ_ONCE(p->blocked_on);
Also the WARN_ON_ONCE() can have the "m && " part taken out because it's always true now.
Quoted 24 lines
Quoted 23 lines
include/linux/sched.h +1
-0+ } p->blocked_on =NULL ; }kernel/locking/ww_mutex.h +5
-1@@ -342,8 +342,12 @@ static bool __ww_mutex_wound(struct MUTEX *lock,* When waking up the task to wound, be sure to clear the * blocked_on pointer. Otherwise we can see circular * blocked_on relationships that can't resolve. +* +* NOTE: We pass NULL here instead of lock, because we +* are waking the lock owner, who may be currently blocked +* on a different lock. */ -__clear_task_blocked_on (owner, lock); +__clear_task_blocked_on (owner,NULL );wake_q_add (wake_q, owner); }return true;
Re: [RFC][PATCH] locking: Fix __clear_task_blocked_on() warning from __ww_mutex_wound() path
In reply to K Prateek NayakQuoted 31 lines · K Prateek Nayak
At the very least I think we should make a local copy of "
p->blocked_on" to see a consistent view throughout__clear_task_blocked_on()- task either sees it is blocked on the mutex and clear "p->blocked_on", or it sees it is blocked on nothing and still clears "p->blocked_on".(Tested lightly with syzbot's C reproducer)
include/linux/sched.h +3
-2@@ -2165,6 +2165,8 @@ static inline void set_task_blocked_on(struct task_struct *p, struct mutex *m)static inline void __clear_task_blocked_on (struct task_struct *p,struct mutex *m) {if (m) { +struct mutex *blocked_on = p->blocked_on; +/* Currently we serialize blocked_on under the mutex::wait_lock */ lockdep_assert_held_once (&m->wait_lock);/* @@ -2172,7 +2174,7 @@ static inline void __clear_task_blocked_on(struct task_struct *p, struct mutex ** blocked_on relationships, but make sure we are not * clearing the relationship with a different lock. */ -WARN_ON_ONCE (m && p->blocked_on && p->blocked_on != m); +WARN_ON_ONCE (m && blocked_on && blocked_on != m); } p->blocked_on =NULL ; } ---
Quoted 2 lines
End result is the same, only that we avoid an unnecessary splat in this very unlikely case and save ourselves some head scratching later :)
Good point. Thanks for suggesting this! I'll rework to include both this and Maarten's suggestions.
Thank you for the feedback!
-john