Revert "gpio: pxa: Make irq_chip immutable"
Subsystems (2)
PATCH 1/1 Revert "gpio: pxa: Make irq_chip immutable"
From: Bartosz Golaszewski <[email protected]>
This reverts commit 20117cf426b6 ("gpio: pxa: Make irq_chip immutableas") as it caused a regression on samsung coreprimevelte and we've not been able to fix it so far.
--- drivers/gpio/gpio-pxa.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/gpio/gpio-pxa.c +1 -7
@@ -499,8 +499,6 @@ static void pxa_mask_muxed_gpio(struct irq_data *d) gfer =readl_relaxed (base +GFER_OFFSET ) & ~GPIO_bit (gpio);writel_relaxed (grer, base +GRER_OFFSET );writel_relaxed (gfer, base +GFER_OFFSET ); - -gpiochip_disable_irq (&pchip->chip, gpio); }static int pxa_gpio_set_wake (struct irq_data *d,unsigned int on)
@@ -520,21 +518,17 @@ static void pxa_unmask_muxed_gpio(struct irq_data *d)unsigned int gpio =irqd_to_hwirq (d);struct pxa_gpio_bank *c =gpio_to_pxabank (&pchip->chip, gpio); -gpiochip_enable_irq (&pchip->chip, gpio); - c->irq_mask |=GPIO_bit (gpio);update_edge_detect (c); } -static const struct irq_chip pxa_muxed_gpio_chip = { +static struct irq_chip pxa_muxed_gpio_chip = { .name ="GPIO" , .irq_ack = pxa_ack_muxed_gpio, .irq_mask = pxa_mask_muxed_gpio, .irq_unmask = pxa_unmask_muxed_gpio, .irq_set_type = pxa_gpio_irq_type, .irq_set_wake = pxa_gpio_set_wake, - .flags =IRQCHIP_IMMUTABLE , -GPIOCHIP_IRQ_RESOURCE_HELPERS , };static int pxa_gpio_nums (struct platform_device *pdev)
Signature · 1 line
2.48.1
Quoted 6 lines · On Friday, 1 August 2025 09:18:58 Central European Summer Time Bartosz…
From: Bartosz Golaszewski <[email protected]>
This reverts commit
20117cf426b6("gpio: pxa: Makeirq_chipimmutableas") as it caused a regression on samsung coreprimevelte and we've not been able to fix it so far.
Could the fix be backported to v6.16.y?
Regards,
--
Duje
Bartosz Golaszewski
AppliedFrom: Bartosz Golaszewski <[email protected]>
Quoted 5 lines · Bartosz Golaszewski
This reverts commit
20117cf426b6("gpio: pxa: Makeirq_chipimmutableas") as it caused a regression on samsung coreprimevelte and we've not been able to fix it so far.
Applied, thanks!
[1/1] Revert "gpio: pxa: Make irq_chip immutable"
https://git.kernel.org/brgl/linux/c/b644c640923b625340c603cdb8d8f456406eb4de
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>