Skip to contentSkip to conversation

Fix broken link with TH1520 GMAC when linkspeed changes

PATCH Superseded Yao Zi 4 participants 14 messages Aug 1, 2025 – Aug 6, 2025

Subsystems (7)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Yao Zi

author
#0 lore raw

v2 cover Fix broken link with TH1520 GMAC when linkspeed changes

It's noted that on TH1520 SoC, the GMAC's link becomes broken after the link speed is changed (for example, running ethtool -s eth0 speed 100 on the peer when negotiated to 1Gbps), but the GMAC could function normally if the speed is brought back to the initial.

Just like many other SoCs utilizing STMMAC IP, we need to adjust the TX clock supplying TH1520's GMAC through some SoC-specific glue registers when linkspeed changes. But it's found that after the full kernel startup, reading from them results in garbage and writing to them makes no effect, which is the cause of broken link.

Further testing shows perisys-apb4-hclk must be ungated for normal access to Th1520 GMAC APB glue registers, which is neither described in dt-binding nor acquired by the driver.

This series expands the dt-binding of TH1520's GMAC to allow an extra "APB glue registers interface clock", instructs the driver to acquire and enable the clock, and finally supplies CLK_PERISYS_APB4_HCLK for TH1520's GMACs in SoC devicetree.

Changed from v1
- Make apb clock essential in dt-binding
- Collect review tags
- Link to v1: https://lore.kernel.org/all/[email protected]/

Yao Zi (3):
dt-bindings: net: thead,th1520-gmac: Describe APB interface clock
net: stmmac: thead: Get and enable APB clock on initialization
riscv: dts: thead: Add APB clocks for TH1520 GMACs

 .../devicetree/bindings/net/thead,th1520-gmac.yaml     |  6 ++++--
 arch/riscv/boot/dts/thead/th1520.dtsi                  | 10 ++++++----
 drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c      |  6 ++++++
 3 files changed, 16 insertions(+), 6 deletions(-)
Signature · 1 line
2.50.1
author
#1 lore raw

PATCH v2 1/3 dt-bindings: net: thead,th1520-gmac: Describe APB interface clock

Besides ones for GMAC core and peripheral registers, the TH1520 GMAC requires one more clock for configuring APB glue registers. Describe it in the binding.

Fixes f920ce04c399 ("dt-bindings: net: Add T-HEAD dwmac support")
---
 .../devicetree/bindings/net/thead,th1520-gmac.yaml          | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml +4 -2
index 6d9de3303762..b3492a9aa4ef 100644
@@ -62,11 +62,13 @@ properties:
     items:
       - description: GMAC main clock
       - description: Peripheral registers interface clock
+      - description: APB glue registers interface clock
 
   clock-names:
     items:
       - const: stmmaceth
       - const: pclk
+      - const: apb
 
   interrupts:
     items:
@@ -88,8 +90,8 @@ examples:
         compatible = "thead,th1520-gmac", "snps,dwmac-3.70a";
         reg = <0xe7070000 0x2000>, <0xec003000 0x1000>;
         reg-names = "dwmac", "apb";
-        clocks = <&clk 1>, <&clk 2>;
-        clock-names = "stmmaceth", "pclk";
+        clocks = <&clk 1>, <&clk 2>, <&clk 3>;
+        clock-names = "stmmaceth", "pclk", "apb";
         interrupts = <66>;
         interrupt-names = "macirq";
         phy-mode = "rgmii-id";
Signature · 1 line
2.50.1
maintainer Reviewed-by on v2 1/3
#2 lore raw

Re: [PATCH net v2 1/3] dt-bindings: net: thead,th1520-gmac: Describe APB interface clock

Quoted 43 lines · Yao Zi

Besides ones for GMAC core and peripheral registers, the TH1520 GMAC requires one more clock for configuring APB glue registers. Describe it in the binding.

Fixes f920ce04c399 ("dt-bindings: net: Add T-HEAD dwmac support")
---
 .../devicetree/bindings/net/thead,th1520-gmac.yaml          | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml +4 -2
index 6d9de3303762..b3492a9aa4ef 100644
@@ -62,11 +62,13 @@ properties:
     items:
       - description: GMAC main clock
       - description: Peripheral registers interface clock
+      - description: APB glue registers interface clock
 
   clock-names:
     items:
       - const: stmmaceth
       - const: pclk
+      - const: apb
 
   interrupts:
     items:
@@ -88,8 +90,8 @@ examples:
         compatible = "thead,th1520-gmac", "snps,dwmac-3.70a";
         reg = <0xe7070000 0x2000>, <0xec003000 0x1000>;
         reg-names = "dwmac", "apb";
-        clocks = <&clk 1>, <&clk 2>;
-        clock-names = "stmmaceth", "pclk";
+        clocks = <&clk 1>, <&clk 2>, <&clk 3>;
+        clock-names = "stmmaceth", "pclk", "apb";
         interrupts = <66>;
         interrupt-names = "macirq";
         phy-mode = "rgmii-id";
Signature · 1 line
2.50.1

Thank you for making all 3 clocks required.

Drew

Acked-by on v2 1/3
#3 lore raw

Re: [PATCH net v2 1/3] dt-bindings: net: thead,th1520-gmac: Describe APB interface clock

In reply to Yao Zi
Quoted 7 lines · Yao Zi

Besides ones for GMAC core and peripheral registers, the TH1520 GMAC requires one more clock for configuring APB glue registers. Describe it in the binding.

Fixes f920ce04c399 ("dt-bindings: net: Add T-HEAD dwmac support")

You cannoy really test the binding, except part of build process and we do not consider building something equal to testing.

Quoted 3 lines
---
 .../devicetree/bindings/net/thead,th1520-gmac.yaml          | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Best regards,
Krzysztof

maintainer
#4 lore raw

Re: [PATCH net v2 1/3] dt-bindings: net: thead,th1520-gmac: Describe APB interface clock

Quoted 11 lines · Krzysztof Kozlowski
Quoted 7 lines · Yao Zi

Besides ones for GMAC core and peripheral registers, the TH1520 GMAC requires one more clock for configuring APB glue registers. Describe it in the binding.

Fixes f920ce04c399 ("dt-bindings: net: Add T-HEAD dwmac support")

You cannoy really test the binding, except part of build process and we do not consider building something equal to testing.

Good point. I've since provided my Reviewed-by: in this v2 thread so the
Tested-by: should be dropped if there or is another series or when applying this v2.

Thanks,
Drew

author
#5 lore raw

Re: [PATCH net v2 1/3] dt-bindings: net: thead,th1520-gmac: Describe APB interface clock

Quoted 10 lines · Drew Fustini
Quoted 9 lines · Krzysztof Kozlowski
Quoted 7 lines · Yao Zi

Besides ones for GMAC core and peripheral registers, the TH1520 GMAC requires one more clock for configuring APB glue registers. Describe it in the binding.

Fixes f920ce04c399 ("dt-bindings: net: Add T-HEAD dwmac support")
Quoted 6 lines
Quoted 2 lines

You cannoy really test the binding, except part of build process and we do not consider building something equal to testing.

Good point. I've since provided my Reviewed-by: in this v2 thread so the
Tested-by: should be dropped if there or is another series or when applying this v2.

I'll send v3 of this series soon, dropping the Tested-by and adding Krzysztof's Acked-by tag. Thanks for the guidance!

Quoted 2 lines

Thanks,
Drew

Best regards,
Yao Zi

author
#6 lore raw

PATCH v2 2/3 net: stmmac: thead: Get and enable APB clock on initialization

In reply to Yao Zi

It's necessary to adjust the MAC TX clock when the linkspeed changes, but it's noted such adjustment always fails on TH1520 SoC, and reading back from APB glue registers that control clock generation results in garbage, causing broken link.

With some testing, it's found a clock must be ungated for access to APB glue registers. Without any consumer, the clock is automatically disabled during late kernel startup. Let's get and enable it if it's described in devicetree.

Fixes 33a1a01e3afa ("net: stmmac: Add glue layer for T-HEAD TH1520 SoC")
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c +6 -0
index c72ee759aae5..95096244a846 100644
@@ -211,6 +211,7 @@ static int thead_dwmac_probe(struct platform_device *pdev)
 	struct stmmac_resources stmmac_res;
 	struct plat_stmmacenet_data *plat;
 	struct thead_dwmac *dwmac;
+	struct clk *apb_clk;
 	void __iomem *apb;
 	int ret;
 
@@ -224,6 +225,11 @@ static int thead_dwmac_probe(struct platform_device *pdev)
 		return dev_err_probe(&pdev->dev, PTR_ERR(plat),
 				     "dt configuration failed\n");
 
+	apb_clk = devm_clk_get_optional_enabled(&pdev->dev, "apb");
+	if (IS_ERR(apb_clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(apb_clk),
+				     "failed to get apb clock\n");
+
 	dwmac = devm_kzalloc(&pdev->dev, sizeof(*dwmac), GFP_KERNEL);
 	if (!dwmac)
 		return -ENOMEM;
Signature · 1 line
2.50.1
maintainer
#7 lore raw

Re: [PATCH net v2 2/3] net: stmmac: thead: Get and enable APB clock on initialization

Quoted 31 lines · Yao Zi

It's necessary to adjust the MAC TX clock when the linkspeed changes, but it's noted such adjustment always fails on TH1520 SoC, and reading back from APB glue registers that control clock generation results in garbage, causing broken link.

With some testing, it's found a clock must be ungated for access to APB glue registers. Without any consumer, the clock is automatically disabled during late kernel startup. Let's get and enable it if it's described in devicetree.

Fixes 33a1a01e3afa ("net: stmmac: Add glue layer for T-HEAD TH1520 SoC")
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c +1 -0
index c72ee759aae5..95096244a846 100644
@@ -211,6 +211,7 @@ static int thead_dwmac_probe(struct platform_device *pdev)
 	struct stmmac_resources stmmac_res;
 	struct plat_stmmacenet_data *plat;
 	struct thead_dwmac *dwmac;
+	struct clk *apb_clk;
 	void __iomem *apb;
 	int ret;
 

drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c static int thead_dwmac_probe(struct platform_device *pdev) · line 228

Quoted 4 lines
drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c +1 -0
@@ -224,6 +225,11 @@ static int thead_dwmac_probe(struct platform_device *pdev)
 		return dev_err_probe(&pdev->dev, PTR_ERR(plat),
 				     "dt configuration failed\n");
 
+	apb_clk = devm_clk_get_optional_enabled(&pdev->dev, "apb");

The description sounds like this should not be optional. The binding change also makes it not optional.

Rob

maintainer
#8 lore raw

Re: [PATCH net v2 2/3] net: stmmac: thead: Get and enable APB clock on initialization

Quoted 31 lines · Rob Herring
Quoted 30 lines · Yao Zi

It's necessary to adjust the MAC TX clock when the linkspeed changes, but it's noted such adjustment always fails on TH1520 SoC, and reading back from APB glue registers that control clock generation results in garbage, causing broken link.

With some testing, it's found a clock must be ungated for access to APB glue registers. Without any consumer, the clock is automatically disabled during late kernel startup. Let's get and enable it if it's described in devicetree.

Fixes 33a1a01e3afa ("net: stmmac: Add glue layer for T-HEAD TH1520 SoC")
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c +1 -0
index c72ee759aae5..95096244a846 100644
@@ -211,6 +211,7 @@ static int thead_dwmac_probe(struct platform_device *pdev)
 	struct stmmac_resources stmmac_res;
 	struct plat_stmmacenet_data *plat;
 	struct thead_dwmac *dwmac;
+	struct clk *apb_clk;
 	void __iomem *apb;
 	int ret;
 
Quoted 8 lines

drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c static int thead_dwmac_probe(struct platform_device *pdev) · line 228

Quoted 5 lines
drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c +1 -0
@@ -224,6 +225,11 @@ static int thead_dwmac_probe(struct platform_device *pdev)
 		return dev_err_probe(&pdev->dev, PTR_ERR(plat),
 				     "dt configuration failed\n");
 
+	apb_clk = devm_clk_get_optional_enabled(&pdev->dev, "apb");

The description sounds like this should not be optional. The binding change also makes it not optional.

Good point, it should be devm_clk_get_enabled() otherwise the link speed change bug will be possible. This series also changes the schema and dts so I don't think compatibility is a problem.

Thanks,
Drew

author
#9 lore raw

Re: [PATCH net v2 2/3] net: stmmac: thead: Get and enable APB clock on initialization

In reply to Rob Herring
Quoted 31 lines · Rob Herring
Quoted 30 lines · Yao Zi

It's necessary to adjust the MAC TX clock when the linkspeed changes, but it's noted such adjustment always fails on TH1520 SoC, and reading back from APB glue registers that control clock generation results in garbage, causing broken link.

With some testing, it's found a clock must be ungated for access to APB glue registers. Without any consumer, the clock is automatically disabled during late kernel startup. Let's get and enable it if it's described in devicetree.

Fixes 33a1a01e3afa ("net: stmmac: Add glue layer for T-HEAD TH1520 SoC")
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c +1 -0
index c72ee759aae5..95096244a846 100644
@@ -211,6 +211,7 @@ static int thead_dwmac_probe(struct platform_device *pdev)
 	struct stmmac_resources stmmac_res;
 	struct plat_stmmacenet_data *plat;
 	struct thead_dwmac *dwmac;
+	struct clk *apb_clk;
 	void __iomem *apb;
 	int ret;
 
Quoted 8 lines

drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c static int thead_dwmac_probe(struct platform_device *pdev) · line 228

Quoted 5 lines
drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c +1 -0
@@ -224,6 +225,11 @@ static int thead_dwmac_probe(struct platform_device *pdev)
 		return dev_err_probe(&pdev->dev, PTR_ERR(plat),
 				     "dt configuration failed\n");
 
+	apb_clk = devm_clk_get_optional_enabled(&pdev->dev, "apb");

The description sounds like this should not be optional. The binding change also makes it not optional.

Yes, it shouldn't be. But using the non-optional API will cause the driver fails to probe with the old (problematic) devicetree, IOW, it breaks the ABI. Comparing to unusable ethernet, failing to adjust the link speed sounds a minor point to me.

Maybe we could add a comment to explain why optional API is used, or just use the non-optional one if such ABI breakages are acceptable -- for which I'd like to wait for more opinions.

Quoted 2 lines

Rob

Thanks,
Yao Zi

maintainer
#10 lore raw

Re: [PATCH net v2 2/3] net: stmmac: thead: Get and enable APB clock on initialization

Quoted 41 lines · Yao Zi
Quoted 31 lines · Rob Herring
Quoted 30 lines · Yao Zi

It's necessary to adjust the MAC TX clock when the linkspeed changes, but it's noted such adjustment always fails on TH1520 SoC, and reading back from APB glue registers that control clock generation results in garbage, causing broken link.

With some testing, it's found a clock must be ungated for access to APB glue registers. Without any consumer, the clock is automatically disabled during late kernel startup. Let's get and enable it if it's described in devicetree.

Fixes 33a1a01e3afa ("net: stmmac: Add glue layer for T-HEAD TH1520 SoC")
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c +1 -0
index c72ee759aae5..95096244a846 100644
@@ -211,6 +211,7 @@ static int thead_dwmac_probe(struct platform_device *pdev)
 	struct stmmac_resources stmmac_res;
 	struct plat_stmmacenet_data *plat;
 	struct thead_dwmac *dwmac;
+	struct clk *apb_clk;
 	void __iomem *apb;
 	int ret;
 
Quoted 8 lines

drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c static int thead_dwmac_probe(struct platform_device *pdev) · line 228

Quoted 5 lines
drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c +1 -0
@@ -224,6 +225,11 @@ static int thead_dwmac_probe(struct platform_device *pdev)
 		return dev_err_probe(&pdev->dev, PTR_ERR(plat),
 				     "dt configuration failed\n");
 
+	apb_clk = devm_clk_get_optional_enabled(&pdev->dev, "apb");

The description sounds like this should not be optional. The binding change also makes it not optional.

Quoted 4 lines

Yes, it shouldn't be. But using the non-optional API will cause the driver fails to probe with the old (problematic) devicetree, IOW, it breaks the ABI. Comparing to unusable ethernet, failing to adjust the link speed sounds a minor point to me.

I've just read Conor's comment in the v1 again:

Nah, introduce the warnings. If the clock is required for operation, it should be marked as such. You've made it optional in the driver, which is the important part (backwards compatible) and you've got the dts patch in the series.

Thus I think the argument I made in my reply to this thread is incorrect and the driver should remain backwards compatible.

Quoted 3 lines

Maybe we could add a comment to explain why optional API is used, or just use the non-optional one if such ABI breakages are acceptable -- for which I'd like to wait for more opinions.

I think a comment in the code about why it uses the optional variant of the function is a good idea.

Thanks,
Drew

maintainer
#11 lore raw

Re: [PATCH net v2 2/3] net: stmmac: thead: Get and enable APB clock on initialization

Quoted 57 lines · Drew Fustini
Quoted 41 lines · Yao Zi
Quoted 31 lines · Rob Herring
Quoted 30 lines · Yao Zi

It's necessary to adjust the MAC TX clock when the linkspeed changes, but it's noted such adjustment always fails on TH1520 SoC, and reading back from APB glue registers that control clock generation results in garbage, causing broken link.

With some testing, it's found a clock must be ungated for access to APB glue registers. Without any consumer, the clock is automatically disabled during late kernel startup. Let's get and enable it if it's described in devicetree.

Fixes 33a1a01e3afa ("net: stmmac: Add glue layer for T-HEAD TH1520 SoC")
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c +1 -0
index c72ee759aae5..95096244a846 100644
@@ -211,6 +211,7 @@ static int thead_dwmac_probe(struct platform_device *pdev)
 	struct stmmac_resources stmmac_res;
 	struct plat_stmmacenet_data *plat;
 	struct thead_dwmac *dwmac;
+	struct clk *apb_clk;
 	void __iomem *apb;
 	int ret;
 
Quoted 8 lines

drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c static int thead_dwmac_probe(struct platform_device *pdev) · line 228

Quoted 5 lines
drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c +1 -0
@@ -224,6 +225,11 @@ static int thead_dwmac_probe(struct platform_device *pdev)
 		return dev_err_probe(&pdev->dev, PTR_ERR(plat),
 				     "dt configuration failed\n");
 
+	apb_clk = devm_clk_get_optional_enabled(&pdev->dev, "apb");

The description sounds like this should not be optional. The binding change also makes it not optional.

Quoted 4 lines

Yes, it shouldn't be. But using the non-optional API will cause the driver fails to probe with the old (problematic) devicetree, IOW, it breaks the ABI. Comparing to unusable ethernet, failing to adjust the link speed sounds a minor point to me.

I've just read Conor's comment in the v1 again:

Nah, introduce the warnings. If the clock is required for operation, it should be marked as such. You've made it optional in the driver, which is the important part (backwards compatible) and you've got the dts patch in the series.

Thus I think the argument I made in my reply to this thread is incorrect and the driver should remain backwards compatible.

Quoted 6 lines
Quoted 3 lines

Maybe we could add a comment to explain why optional API is used, or just use the non-optional one if such ABI breakages are acceptable -- for which I'd like to wait for more opinions.

I think a comment in the code about why it uses the optional variant of the function is a good idea.

I was chatting on devicetree irc channel, and I think that it would be good to add something like this to the commit message:

For the purposes of backwards compatibility, the probe will not fail if 'apb' is not found, but the link will break if the speed changes after probe.

Also, if devm_clk_get_optional_enabled("apb") fails, then I think it would be a good idea to warn the user that changing the link speed will not be supported.

Thanks,
Drew

author
#12 lore raw

Re: [PATCH net v2 2/3] net: stmmac: thead: Get and enable APB clock on initialization

Quoted 68 lines · Drew Fustini
Quoted 57 lines · Drew Fustini
Quoted 41 lines · Yao Zi
Quoted 31 lines · Rob Herring
Quoted 30 lines · Yao Zi

It's necessary to adjust the MAC TX clock when the linkspeed changes, but it's noted such adjustment always fails on TH1520 SoC, and reading back from APB glue registers that control clock generation results in garbage, causing broken link.

With some testing, it's found a clock must be ungated for access to APB glue registers. Without any consumer, the clock is automatically disabled during late kernel startup. Let's get and enable it if it's described in devicetree.

Fixes 33a1a01e3afa ("net: stmmac: Add glue layer for T-HEAD TH1520 SoC")
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c +1 -0
index c72ee759aae5..95096244a846 100644
@@ -211,6 +211,7 @@ static int thead_dwmac_probe(struct platform_device *pdev)
 	struct stmmac_resources stmmac_res;
 	struct plat_stmmacenet_data *plat;
 	struct thead_dwmac *dwmac;
+	struct clk *apb_clk;
 	void __iomem *apb;
 	int ret;
 
Quoted 8 lines

drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c static int thead_dwmac_probe(struct platform_device *pdev) · line 228

Quoted 5 lines
drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c +1 -0
@@ -224,6 +225,11 @@ static int thead_dwmac_probe(struct platform_device *pdev)
 		return dev_err_probe(&pdev->dev, PTR_ERR(plat),
 				     "dt configuration failed\n");
 
+	apb_clk = devm_clk_get_optional_enabled(&pdev->dev, "apb");

The description sounds like this should not be optional. The binding change also makes it not optional.

Quoted 4 lines

Yes, it shouldn't be. But using the non-optional API will cause the driver fails to probe with the old (problematic) devicetree, IOW, it breaks the ABI. Comparing to unusable ethernet, failing to adjust the link speed sounds a minor point to me.

I've just read Conor's comment in the v1 again:

Nah, introduce the warnings. If the clock is required for operation, it should be marked as such. You've made it optional in the driver, which is the important part (backwards compatible) and you've got the dts patch in the series.

Thus I think the argument I made in my reply to this thread is incorrect and the driver should remain backwards compatible.

Quoted 6 lines
Quoted 3 lines

Maybe we could add a comment to explain why optional API is used, or just use the non-optional one if such ABI breakages are acceptable -- for which I'd like to wait for more opinions.

I think a comment in the code about why it uses the optional variant of the function is a good idea.

I was chatting on devicetree irc channel, and I think that it would be good to add something like this to the commit message:

Quoted 7 lines

For the purposes of backwards compatibility, the probe will not fail if 'apb' is not found, but the link will break if the speed changes after probe.

Also, if devm_clk_get_optional_enabled("apb") fails, then I think it would be a good idea to warn the user that changing the link speed will not be supported.

Both sound reasonable to me, and I'll add them in v3, thanks.

Quoted 2 lines

Thanks,
Drew

Best regards,
Yao Zi

author
#13 lore raw

PATCH v2 3/3 riscv: dts: thead: Add APB clocks for TH1520 GMACs

In reply to Yao Zi

Describe perisys-apb4-hclk as the APB clock for TH1520 SoC, which is essential for accessing GMAC glue registers.

Fixes 7e756671a664 ("riscv: dts: thead: Add TH1520 ethernet nodes")
---
 arch/riscv/boot/dts/thead/th1520.dtsi | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
arch/riscv/boot/dts/thead/th1520.dtsi +6 -4
index 42724bf7e90e..03f1d7319049 100644
@@ -297,8 +297,9 @@ gmac1: ethernet@ffe7060000 {
 			reg-names = "dwmac", "apb";
 			interrupts = <67 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "macirq";
-			clocks = <&clk CLK_GMAC_AXI>, <&clk CLK_GMAC1>;
-			clock-names = "stmmaceth", "pclk";
+			clocks = <&clk CLK_GMAC_AXI>, <&clk CLK_GMAC1>,
+				 <&clk CLK_PERISYS_APB4_HCLK>;
+			clock-names = "stmmaceth", "pclk", "apb";
 			snps,pbl = <32>;
 			snps,fixed-burst;
 			snps,multicast-filter-bins = <64>;
@@ -319,8 +320,9 @@ gmac0: ethernet@ffe7070000 {
 			reg-names = "dwmac", "apb";
 			interrupts = <66 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "macirq";
-			clocks = <&clk CLK_GMAC_AXI>, <&clk CLK_GMAC0>;
-			clock-names = "stmmaceth", "pclk";
+			clocks = <&clk CLK_GMAC_AXI>, <&clk CLK_GMAC0>,
+				 <&clk CLK_PERISYS_APB4_HCLK>;
+			clock-names = "stmmaceth", "pclk", "apb";
 			snps,pbl = <32>;
 			snps,fixed-burst;
 			snps,multicast-filter-bins = <64>;
Signature · 1 line
2.50.1