Skip to contentSkip to conversation

dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers

PATCH Applied Rob Herring (Arm) 4 participants 5 messages Aug 1, 2025 – Aug 11, 2025

Subsystems (7)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers

An interrupt-controller node which is the parent provider for "interrupt-map" needs an "#address-cells" property. This fixes "interrupt_map" warnings in new dtc.

---
PCI maintainers, Please ack, I'll take this with the dtc update for 6.18.

 Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml    | 1 +
 .../devicetree/bindings/pci/marvell,armada-3700-pcie.yaml     | 4 ++++
 .../devicetree/bindings/pci/marvell,kirkwood-pcie.yaml        | 3 +++
 .../devicetree/bindings/pci/socionext,uniphier-pcie.yaml      | 4 ++++
 Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml  | 3 +++
 5 files changed, 15 insertions(+)
Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml +1 -0
index 5434c144d2ec..18e7981241b5 100644
@@ -108,6 +108,7 @@ examples:
     #include <dt-bindings/interrupt-controller/arm-gic.h>
 
     gic: interrupt-controller {
+        #address-cells = <0>;
         interrupt-controller;
         #interrupt-cells = <3>;
     };
Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml +4 -0
index 68090b3ca419..8403c79634ed 100644
@@ -42,6 +42,9 @@ properties:
     additionalProperties: false
 
     properties:
+      '#address-cells':
+        const: 0
+
       interrupt-controller: true
 
       '#interrupt-cells':
@@ -92,6 +95,7 @@ examples:
             reset-gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
 
             pcie_intc: interrupt-controller {
+                #address-cells = <0>;
                 interrupt-controller;
                 #interrupt-cells = <1>;
             };
Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml +3 -0
index 7be695320ddf..3d68bfbe6feb 100644
@@ -101,6 +101,9 @@ patternProperties:
         additionalProperties: false
 
         properties:
+          '#address-cells':
+            const: 0
+
           interrupt-controller: true
 
           '#interrupt-cells':
Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml +4 -0
index 638b99db0433..c07b0ed51613 100644
@@ -56,6 +56,9 @@ properties:
     additionalProperties: false
 
     properties:
+      '#address-cells':
+        const: 0
+
       interrupt-controller: true
 
       '#interrupt-cells':
@@ -109,6 +112,7 @@ examples:
                         <0 0 0  4  &pcie_intc 3>;
 
         pcie_intc: interrupt-controller {
+            #address-cells = <0>;
             interrupt-controller;
             #interrupt-cells = <1>;
             interrupt-parent = <&gic>;
Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml +3 -0
index 69b499c96c71..c704099f134b 100644
@@ -99,6 +99,9 @@ properties:
     additionalProperties: false
 
     properties:
+      '#address-cells':
+        const: 0
+
       interrupt-controller: true
 
       '#interrupt-cells':
Signature · 1 line
2.47.2
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Rob Herring (Arm)

An interrupt-controller node which is the parent provider for "interrupt-map" needs an "#address-cells" property. This fixes "interrupt_map" warnings in new dtc.

Quoted 98 lines

---
PCI maintainers, Please ack, I'll take this with the dtc update for 6.18.

 Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml    | 1 +
 .../devicetree/bindings/pci/marvell,armada-3700-pcie.yaml     | 4 ++++
 .../devicetree/bindings/pci/marvell,kirkwood-pcie.yaml        | 3 +++
 .../devicetree/bindings/pci/socionext,uniphier-pcie.yaml      | 4 ++++
 Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml  | 3 +++
 5 files changed, 15 insertions(+)
Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml +1 -0
index 5434c144d2ec..18e7981241b5 100644
@@ -108,6 +108,7 @@ examples:
     #include <dt-bindings/interrupt-controller/arm-gic.h>
 
     gic: interrupt-controller {
+        #address-cells = <0>;
         interrupt-controller;
         #interrupt-cells = <3>;
     };
Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml +4 -0
index 68090b3ca419..8403c79634ed 100644
@@ -42,6 +42,9 @@ properties:
     additionalProperties: false
 
     properties:
+      '#address-cells':
+        const: 0
+
       interrupt-controller: true
 
       '#interrupt-cells':
@@ -92,6 +95,7 @@ examples:
             reset-gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
 
             pcie_intc: interrupt-controller {
+                #address-cells = <0>;
                 interrupt-controller;
                 #interrupt-cells = <1>;
             };
Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml +3 -0
index 7be695320ddf..3d68bfbe6feb 100644
@@ -101,6 +101,9 @@ patternProperties:
         additionalProperties: false
 
         properties:
+          '#address-cells':
+            const: 0
+
           interrupt-controller: true
 
           '#interrupt-cells':
Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml +4 -0
index 638b99db0433..c07b0ed51613 100644
@@ -56,6 +56,9 @@ properties:
     additionalProperties: false
 
     properties:
+      '#address-cells':
+        const: 0
+
       interrupt-controller: true
 
       '#interrupt-cells':
@@ -109,6 +112,7 @@ examples:
                         <0 0 0  4  &pcie_intc 3>;
 
         pcie_intc: interrupt-controller {
+            #address-cells = <0>;
             interrupt-controller;
             #interrupt-cells = <1>;
             interrupt-parent = <&gic>;
Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml +3 -0
index 69b499c96c71..c704099f134b 100644
@@ -99,6 +99,9 @@ properties:
     additionalProperties: false
 
     properties:
+      '#address-cells':
+        const: 0
+
       interrupt-controller: true
 
       '#interrupt-cells':
Signature · 1 line
2.47.2
#2 lore raw
In reply to Rob Herring (Arm)
Quoted 5 lines · Rob Herring (Arm)

An interrupt-controller node which is the parent provider for "interrupt-map" needs an "#address-cells" property. This fixes "interrupt_map" warnings in new dtc.

Applied, thanks!

[1/1] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers

      commit: ddb81c5c911227f0c2ef4cc94a106ebfb3cb2d56

Best regards,

Signature · 1 line
Manivannan Sadhasivam <[email protected]>
author maintainer
#3 lore raw
Quoted 9 lines · Manivannan Sadhasivam
Quoted 5 lines · Rob Herring (Arm)

An interrupt-controller node which is the parent provider for "interrupt-map" needs an "#address-cells" property. This fixes "interrupt_map" warnings in new dtc.

Quoted 4 lines

Applied, thanks!

[1/1] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers

      commit: ddb81c5c911227f0c2ef4cc94a106ebfb3cb2d56

Please read the commit message.

I've already applied this to my tree.

Rob

#4 lore raw
Quoted 11 lines · Rob Herring
Quoted 9 lines · Manivannan Sadhasivam
Quoted 5 lines · Rob Herring (Arm)

An interrupt-controller node which is the parent provider for "interrupt-map" needs an "#address-cells" property. This fixes "interrupt_map" warnings in new dtc.

Quoted 9 lines
Quoted 4 lines

Applied, thanks!

[1/1] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers

      commit: ddb81c5c911227f0c2ef4cc94a106ebfb3cb2d56

Please read the commit message.

I've already applied this to my tree.

Sorry, didn't notice it. Dropped the patch from PCI tree now.

- Mani

Signature · 1 line
மணிவண்ணன் சதாசிவம்