nfsd: Don't force CRYPTO_LIB_SHA256 to be built-in
Subsystems (2)
PATCH 1/1 nfsd: Don't force CRYPTO_LIB_SHA256 to be built-in
Now that nfsd is accessing SHA-256 via the library API instead of via crypto_shash, there is a direct symbol dependency on the SHA-256 code and there is no benefit to be gained from forcing it to be built-in. Therefore, select CRYPTO_LIB_SHA256 from NFSD (conditional on NFSD_V4) instead of from NFSD_V4, so that it can be 'm' if NFSD is 'm'.
--- fs/nfsd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfsd/Kconfig +1 -1
@@ -3,10 +3,11 @@ config NFSD tristate "NFS server support" depends on INET depends on FILE_LOCKING depends on FSNOTIFY select CRC32 + select CRYPTO_LIB_SHA256 if NFSD_V4 select LOCKD select SUNRPC select EXPORTFS select NFS_COMMON select NFS_ACL_SUPPORT if NFSD_V2_ACL
@@ -75,11 +76,10 @@ config NFSD_V4 bool "NFS server support for NFS version 4" depends on NFSD && PROC_FS select FS_POSIX_ACL select RPCSEC_GSS_KRB5 select CRYPTO - select CRYPTO_LIB_SHA256 select CRYPTO_MD5 select GRACE_PERIOD select NFS_V4_2_SSC_HELPER if NFS_V4_2 help This option enables support in your system's NFS server for
base-commit: 186f3edfdd41f2ae87fc40a9ccba52a3bf930994
Signature · 1 line
2.50.1
Quoted 40 lines · Eric Biggers
Now that nfsd is accessing SHA-256 via the library API instead of via
crypto_shash, there is a direct symbol dependency on the SHA-256 code and there is no benefit to be gained from forcing it to be built-in. Therefore, selectCRYPTO_LIB_SHA256from NFSD (conditional onNFSD_V4) instead of fromNFSD_V4, so that it can be 'm' if NFSD is 'm'.Signed-off-by Eric Biggers <[email protected]>--- fs/nfsd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/nfsd/Kconfig +1
-1@@ -3,10 +3,11 @@ config NFSD tristate "NFS server support" depends on INET depends on FILE_LOCKING depends on FSNOTIFY select CRC32 + select CRYPTO_LIB_SHA256 if NFSD_V4 select LOCKD select SUNRPC select EXPORTFS select NFS_COMMON select NFS_ACL_SUPPORT if NFSD_V2_ACL@@ -75,11 +76,10 @@ config NFSD_V4 bool "NFS server support for NFS version 4" depends on NFSD && PROC_FS select FS_POSIX_ACL select RPCSEC_GSS_KRB5 select CRYPTO - select CRYPTO_LIB_SHA256 select CRYPTO_MD5 select GRACE_PERIOD select NFS_V4_2_SSC_HELPER if NFS_V4_2 help This option enables support in your system's NFS server for
Quoted 1 line
base-commit:
186f3edfdd41f2ae87fc40a9ccba52a3bf930994
Quoted 10 lines · Eric Biggers
Now that nfsd is accessing SHA-256 via the library API instead of via
crypto_shash, there is a direct symbol dependency on the SHA-256 code and there is no benefit to be gained from forcing it to be built-in. Therefore, selectCRYPTO_LIB_SHA256from NFSD (conditional onNFSD_V4) instead of fromNFSD_V4, so that it can be 'm' if NFSD is 'm'.Signed-off-by Eric Biggers <[email protected]>--- fs/nfsd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Looks like this patch hasn't been applied yet. Could it be taken through the nfs tree? Thanks,
- Eric
Quoted 12 lines · Eric Biggers
Quoted 10 lines · Eric Biggers
Now that nfsd is accessing SHA-256 via the library API instead of via
crypto_shash, there is a direct symbol dependency on the SHA-256 code and there is no benefit to be gained from forcing it to be built-in. Therefore, selectCRYPTO_LIB_SHA256from NFSD (conditional onNFSD_V4) instead of fromNFSD_V4, so that it can be 'm' if NFSD is 'm'.Signed-off-by Eric Biggers <[email protected]>--- fs/nfsd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 4 lines
Looks like this patch hasn't been applied yet. Could it be taken through the nfs tree? Thanks,
- Eric
For some reason, I marked this patch "superceded" in patchworks so it got lost. I can apply it today.
Signature · 1 line
Chuck Lever
Chuck Lever
maintainerFrom: Chuck Lever <[email protected]>
Quoted 8 lines · Eric Biggers
Now that nfsd is accessing SHA-256 via the library API instead of via
crypto_shash, there is a direct symbol dependency on the SHA-256 code and there is no benefit to be gained from forcing it to be built-in. Therefore, selectCRYPTO_LIB_SHA256from NFSD (conditional onNFSD_V4) instead of fromNFSD_V4, so that it can be 'm' if NFSD is 'm'.[...]
Applied to nfsd-testing, thanks!
[1/1] nfsd: Don't force CRYPTO_LIB_SHA256 to be built-in
commit: 9c0d70a41f389ff1f15fd38fa47be5c3dd13c915
--
Chuck Lever