Skip to contentSkip to conversation

net: tcp_ipv4.c: Add missing space

PATCH In review Osama Albahrani 2 participants 2 messages Aug 4, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: tcp_ipv4.c: Add missing space

This commit resolves the following checkpatch.pl error:

```
ERROR: spaces required around that '=' (ctx:VxW)
+	.twsk_destructor= tcp_twsk_destructor,
 	                ^
```

Assuming the purpose was to align the equal signs, I also added a space in the previous line.

---
 net/ipv4/tcp_ipv4.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/ipv4/tcp_ipv4.c +2 -2
index 84d3d556ed80..2585e176b031 100644
@@ -2458,8 +2458,8 @@ int tcp_v4_rcv(struct sk_buff *skb)
 }
 
 static struct timewait_sock_ops tcp_timewait_sock_ops = {
-	.twsk_obj_size	= sizeof(struct tcp_timewait_sock),
-	.twsk_destructor= tcp_twsk_destructor,
+	.twsk_obj_size		= sizeof(struct tcp_timewait_sock),
+	.twsk_destructor	= tcp_twsk_destructor,
 };
 
 void inet_sk_rx_dst_set(struct sock *sk, const struct sk_buff *skb)
Signature · 1 line
2.50.1
#1 lore raw
Quoted 9 lines · Osama Albahrani

This commit resolves the following checkpatch.pl error:

```
ERROR: spaces required around that '=' (ctx:VxW)
+       .twsk_destructor= tcp_twsk_destructor,
                        ^
```
Quoted 5 lines

Assuming the purpose was to align the equal signs, I also added a space in the previous line.

---

I have a patch removing .twsk_destructor completely, waiting for net-next to open next week.

(DCCP has been removed a while ago)

So I would vote for not bothering with your patch.