Skip to contentSkip to conversation

drm/amdgpu: add missing vram lost check for LEGACY RESET

PATCH In review Alex Deucher 3 participants 3 messages Aug 4, 2025 – Aug 6, 2025

Subsystems (2)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amdgpu: add missing vram lost check for LEGACY RESET

Legacy resets reset the memory controllers so VRAM contents may be unreliable after reset.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -0
index 3fb41c42cc051..6119302aa0661 100644
@@ -3274,6 +3274,7 @@ static bool amdgpu_device_check_vram_lost(struct amdgpu_device *adev)
 	 * always assumed to be lost.
 	 */
 	switch (amdgpu_asic_reset_method(adev)) {
+	case AMD_RESET_METHOD_LEGACY:
 	case AMD_RESET_METHOD_LINK:
 	case AMD_RESET_METHOD_BACO:
 	case AMD_RESET_METHOD_MODE1:
Signature · 1 line
2.50.1
#1 lore raw

Ping?

Quoted 24 lines · Alex Deucher

Legacy resets reset the memory controllers so VRAM contents may be unreliable after reset.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
index 3fb41c42cc051..6119302aa0661 100644
@@ -3274,6 +3274,7 @@ static bool amdgpu_device_check_vram_lost(struct amdgpu_device *adev)
         * always assumed to be lost.
         */
        switch (amdgpu_asic_reset_method(adev)) {
+       case AMD_RESET_METHOD_LEGACY:
        case AMD_RESET_METHOD_LINK:
        case AMD_RESET_METHOD_BACO:
        case AMD_RESET_METHOD_MODE1:
--

2.50.1

Reviewed-by on v1 1/1
#2 lore raw
In reply to Alex Deucher

[AMD Official Use Only - AMD Internal Distribution Only]

Regards,
Hawking
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: Monday, August 4, 2025 23:43
To: [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: [PATCH] drm/amdgpu: add missing vram lost check for LEGACY RESET

Legacy resets reset the memory controllers so VRAM contents may be unreliable after reset.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -0
index 3fb41c42cc051..6119302aa0661 100644
@@ -3274,6 +3274,7 @@ static bool amdgpu_device_check_vram_lost(struct amdgpu_device *adev)
         * always assumed to be lost.
         */
        switch (amdgpu_asic_reset_method(adev)) {
+       case AMD_RESET_METHOD_LEGACY:
        case AMD_RESET_METHOD_LINK:
        case AMD_RESET_METHOD_BACO:
        case AMD_RESET_METHOD_MODE1:

--
2.50.1