Skip to contentSkip to conversation

bcachefs: Add missing else statement

PATCH Applied Alan Huang 2 participants 2 messages Aug 4, 2025

lore
Share & tools
lore

Alan Huang

author
#0 lore raw

PATCH 1/1 bcachefs: Add missing else statement

The if condition was broken, ret was always assigned to BCH_ERR_fsck_delete_bkey

---
 fs/bcachefs/error.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/bcachefs/error.h +2 -1
index 0c3c3a24fc6f..213814787dd6 100644
@@ -173,7 +173,8 @@ do {									\
 	if (!bch2_err_matches(_ret, BCH_ERR_fsck_fix) &&		\
 	    !bch2_err_matches(_ret, BCH_ERR_fsck_ignore))		\
 		ret = _ret;						\
-	ret = bch_err_throw(c, fsck_delete_bkey);			\
+	else								\
+		ret = bch_err_throw(c, fsck_delete_bkey);		\
 	goto fsck_err;							\
 } while (0)
 
Signature · 1 line
2.49.0
#1 lore raw
Quoted 3 lines · Alan Huang

The if condition was broken, ret was always assigned to BCH_ERR_fsck_delete_bkey

Applied

Quoted 21 lines
---
 fs/bcachefs/error.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/bcachefs/error.h +2 -1
index 0c3c3a24fc6f..213814787dd6 100644
@@ -173,7 +173,8 @@ do {									\
 	if (!bch2_err_matches(_ret, BCH_ERR_fsck_fix) &&		\
 	    !bch2_err_matches(_ret, BCH_ERR_fsck_ignore))		\
 		ret = _ret;						\
-	ret = bch_err_throw(c, fsck_delete_bkey);			\
+	else								\
+		ret = bch_err_throw(c, fsck_delete_bkey);		\
 	goto fsck_err;							\
 } while (0)
 
Signature · 1 line
2.49.0