vsock: add namespace support to vhost-vsock
Subsystems (11)
v4 cover vsock: add namespace support to vhost-vsock
This series adds namespace support to vhost-vsock. It does not add namespaces to any of the guest transports (virtio-vsock, hyperv, or vmci).
The current revision only supports two modes: local or global. Local mode is complete isolation of namespaces, while global mode is complete sharing between namespaces of CIDs (the original behavior).
Future may include supporting a mixed mode, which I expect to be more complicated because socket lookups will have to include new logic and API changes to behave differently based on if the lookup is part of a mixed mode CID allocation, a global CID allocation, a mixed-to-global connection (allowed), or a global-to-mixed connection (not allowed).
Modes are per-netns and write-once. This allows a system to configure namespaces independently (some may share CIDs, others are completely isolated). This also supports future mixed use cases, where there may be namespaces in global mode spinning up VMs while there are mixed mode namespaces that provide services to the VMs, but are not allowed to allocate from the global CID pool.
Thanks again for everyone's help and reviews!
To: Stefano Garzarella <[email protected]>
To: Shuah Khan <[email protected]>
To: David S. Miller <[email protected]>
To: Eric Dumazet <[email protected]>
To: Jakub Kicinski <[email protected]>
To: Paolo Abeni <[email protected]>
To: Simon Horman <[email protected]>
To: Stefan Hajnoczi <[email protected]>
To: Michael S. Tsirkin <[email protected]>
To: Jason Wang <[email protected]>
To: Xuan Zhuo <[email protected]>
To: Eugenio Pérez <[email protected]>
To: K. Y. Srinivasan <[email protected]>
To: Haiyang Zhang <[email protected]>
To: Wei Liu <[email protected]>
To: Dexuan Cui <[email protected]>
To: Bryan Tan <[email protected]>
To: Vishnu Dasa <[email protected]>
To: Broadcom internal kernel review list <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Changes in v4:
- removed RFC tag
- implemented loopback support
- renamed new tests to better reflect behavior
- completed suite of tests with permutations of ns modes and vsock_test as guest/host
- simplified socat bridging with unix socket instead of tcp + veth
- only use vsock_test for success case, socat for failure case (context in commit message)
- lots of cleanup
Changes in v3:
- add notion of "modes"
- add procfs /proc/net/vsock_ns_mode
- local and global modes only
- no /dev/vhost-vsock-netns
- vmtest.sh already merged, so new patch just adds new tests for NS
- Link to v2:
https://lore.kernel.org/kvm/[email protected]
Changes in v2:
- only support vhost-vsock namespaces
- all g2h namespaces retain old behavior, only common API changes impacted by vhost-vsock changes
- add /dev/vhost-vsock-netns for "opt-in"
- leave /dev/vhost-vsock to old behavior
- removed netns module param
- Link to v1:
https://lore.kernel.org/r/[email protected]
Changes in v1:
- added 'netns' module param to vsock.ko to enable the network namespace support (disabled by default)
- added 'vsock_net_eq()' to check the "net" assigned to a socket only when 'netns' support is enabled
- Link to RFC: https://patchwork.ozlabs.org/cover/1202235/
---
Bobby Eshleman (12):
vsock: a per-net vsock NS mode state
vsock: add net to vsock skb cb
vsock: add netns to af_vsock core vsock/virtio: add netns to virtio transport common vhost/vsock: add netns support vsock/virtio: use the global netns
hv_sock: add netns hooks
vsock/vmci: add netns hooks vsock/loopback: add netns support selftests/vsock: improve logging in vmtest.sh selftests/vsock: invoke vsock_test through helpers selftests/vsock: add namespace tests
MAINTAINERS | 1 + drivers/vhost/vsock.c | 48 +- include/linux/virtio_vsock.h | 12 + include/net/af_vsock.h | 59 +- include/net/net_namespace.h | 4 + include/net/netns/vsock.h | 21 + net/vmw_vsock/af_vsock.c | 204 +++++- net/vmw_vsock/hyperv_transport.c | 2 +- net/vmw_vsock/virtio_transport.c | 5 +- net/vmw_vsock/virtio_transport_common.c | 14 +- net/vmw_vsock/vmci_transport.c | 4 +- net/vmw_vsock/vsock_loopback.c | 59 +- tools/testing/selftests/vsock/vmtest.sh | 1088 ++++++++++++++++++++++++++----- 13 files changed, 1330 insertions(+), 191 deletions(-)
---
base-commit: dd500e4aecf25e48e874ca7628697969df679493
change-id: 20250325-vsock-vmtest-b3a21d2102c2
Best regards,
Signature · 1 line
Bobby Eshleman <[email protected]>
RFC PATCH v4 1/12 vsock: a per-net vsock NS mode state
From: Bobby Eshleman <[email protected]>
Add the per-net vsock NS mode state. This only adds the structure for holding the mode necessary and some of the definitions, but does not integrate the functionality yet.
--- MAINTAINERS | 1 + include/net/af_vsock.h | 42 ++++++++++++++++++++++++++++++++++++++++++ include/net/net_namespace.h | 4 ++++ include/net/netns/vsock.h | 18 ++++++++++++++++++ 4 files changed, 65 insertions(+)
MAINTAINERS +1 -0
@@ -26208,6 +26208,7 @@ L: [email protected] S: Maintained F: drivers/vhost/vsock.c F: include/linux/virtio_vsock.h +F: include/net/netns/vsock.h F: include/uapi/linux/virtio_vsock.h F: net/vmw_vsock/virtio_transport.c F: net/vmw_vsock/virtio_transport_common.c
include/net/af_vsock.h +42 -0
52 lines not on this page · raw message
include/net/net_namespace.h +4 -0
@@ -37,6 +37,7 @@#include <net/netns/smc.h> #include <net/netns/bpf.h> #include <net/netns/mctp.h> +#include <net/netns/vsock.h> #include <net/net_trackers.h> #include <linux/ns_common.h> #include <linux/idr.h>
@@ -196,6 +197,9 @@ struct net {/* Move to a better place when the config guard is removed. */ struct mutex rtnl_mutex;#endif +#if IS_ENABLED (CONFIG_VSOCKETS ) +struct netns_vsock vsock; +#endif } __randomize_layout;#include <linux/seq_file_net.h>
include/net/netns/vsock.h new file +18 -0
@@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __NET_NET_NAMESPACE_VSOCK_H +#define __NET_NET_NAMESPACE_VSOCK_H + +#include <linux/types.h> + +#define VSOCK_NET_MODE_GLOBAL 1 +#define VSOCK_NET_MODE_LOCAL (1 << 1) + +struct netns_vsock { +struct ctl_table_header *vsock_hdr; +spinlock_t lock; + +/* protected by lock */ +u8 ns_mode; +bool written; +}; +#endif /* __NET_NET_NAMESPACE_VSOCK_H */
Signature · 1 line
2.47.3
RFC PATCH v4 2/12 vsock: add net to vsock skb cb
In reply to Bobby EshlemanFrom: Bobby Eshleman <[email protected]>
Add a net pointer to the vsock skb and helpers for getting/setting it. This is in preparation for adding vsock NS support.
--- include/linux/virtio_vsock.h | 11 +++++++++++ 1 file changed, 11 insertions(+)
include/linux/virtio_vsock.h +11 -0
@@ -13,6 +13,7 @@ struct virtio_vsock_skb_cb {bool reply;bool tap_delivered;u32 offset; +struct net *net; };#define VIRTIO_VSOCK_SKB_CB (skb) ((struct virtio_vsock_skb_cb *)((skb)->cb))
@@ -111,6 +112,16 @@ static inline size_t virtio_vsock_skb_len(struct sk_buff *skb)return (size_t )(skb_end_pointer (skb) - skb->head); } +static inline struct net *virtio_vsock_skb_net (struct sk_buff *skb) +{ +return VIRTIO_VSOCK_SKB_CB (skb)->net; +} + +static inline void virtio_vsock_skb_set_net (struct sk_buff *skb,struct net *net) +{ +VIRTIO_VSOCK_SKB_CB (skb)->net = net; +} +#define VIRTIO_VSOCK_DEFAULT_RX_BUF_SIZE (1024 * 4)#define VIRTIO_VSOCK_MAX_BUF_SIZE 0xFFFFFFFFUL#define VIRTIO_VSOCK_MAX_PKT_BUF_SIZE (1024 * 64)
Signature · 1 line
2.47.3
RFC PATCH v4 3/12 vsock: add netns to af_vsock core
In reply to Bobby EshlemanFrom: Bobby Eshleman <[email protected]>
Add netns functionality (initialization, passing to transports, procfs, etc...) to the af_vsock socket layer. Later patches that add netns support to transports depend on this patch.
--- include/net/af_vsock.h | 13 +++- net/vmw_vsock/af_vsock.c | 198 +++++++++++++++++++++++++++++++++++++++++++---- 2 files changed, 194 insertions(+), 17 deletions(-)
include/net/af_vsock.h +10 -3
@@ -144,7 +144,7 @@ struct vsock_transport { int flags);int (*seqpacket_enqueue)(struct vsock_sock *vsk,struct msghdr *msg,size_t len); -bool (*seqpacket_allow)(u32 remote_cid); +bool (*seqpacket_allow)(struct vsock_sock *vsk,u32 remote_cid);u32 (*seqpacket_has_data)(struct vsock_sock *vsk);/* Notification. */
@@ -214,9 +214,10 @@ void vsock_enqueue_accept(struct sock *listener, struct sock *connected);void vsock_insert_connected (struct vsock_sock *vsk);void vsock_remove_bound (struct vsock_sock *vsk);void vsock_remove_connected (struct vsock_sock *vsk); -struct sock *vsock_find_bound_socket (struct sockaddr_vm *addr); +struct sock *vsock_find_bound_socket (struct sockaddr_vm *addr,struct net *net);struct sock *vsock_find_connected_socket (struct sockaddr_vm *src, -struct sockaddr_vm *dst); +struct sockaddr_vm *dst, +struct net *net);void vsock_remove_sock (struct vsock_sock *vsk);void vsock_for_each_connected_socket (struct vsock_transport *transport,void (*fn)(struct sock *sk));
@@ -258,6 +259,12 @@ static inline bool vsock_msgzerocopy_allow(const struct vsock_transport *t)return t->msgzerocopy_allow && t->msgzerocopy_allow (); } +extern struct net __vsock_global_net; +static inline struct net *vsock_global_net (void ) +{ +return &__vsock_global_net; +} +static inline u8 vsock_net_mode (struct net *net) {u8 ret;
net/vmw_vsock/af_vsock.c +184 -14
308 lines not on this page · raw message
Signature · 1 line
2.47.3
kernel test robot
build botRe: [PATCH RFC net-next v4 03/12] vsock: add netns to af_vsock core
kernel test robot noticed the following build warnings:
Hi Bobby,
[This is a private test report for your RFC patch.] kernel test robot noticed the following build warnings:
[auto build test WARNING on dd500e4aecf25e48e874ca7628697969df679493]
url: https://github.com/intel-lab-lkp/linux/commits/Bobby-Eshleman/vsock-a-per-net-vsock-NS-mode-state/20250806-130409 base: dd500e4aecf25e48e874ca7628697969df679493 patch link: https://lore.kernel.org/r/20250805-vsock-vmtest-v4-3-059ec51ab111%40meta.com patch subject: [PATCH RFC net-next v4 03/12] vsock: add netns to af_vsock core config: riscv-randconfig-002-20250807 (https://download.01.org/0day-ci/archive/20250807/[email protected]/config) compiler: riscv32-linux-gcc (GCC) 8.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250807/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
net/vmw_vsock/af_vsock.c: In function 'vsock_sysctl_init_net':
>> net/vmw_vsock/af_vsock.c:2794:1: warning: label 'err_sysctl' defined but not used [-Wunused-label]
err_sysctl:
^~~~~~~~~~vim +/err_sysctl +2794 net/vmw_vsock/af_vsock.c
2791
2792 return 0;
2793
> 2794 err_sysctl:
2795 vsock_sysctl_unregister(net);
2796 return -ENOMEM;
2797 }
2798
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
RFC PATCH v4 4/12 vsock/virtio: add netns to virtio transport common
In reply to Bobby EshlemanFrom: Bobby Eshleman <[email protected]>
Add support to the virtio-vsock common code for passing around net namespace pointers (tx and rx). The series still requires vhost/virtio transport support to be added by future patches.
--- include/linux/virtio_vsock.h | 1 + net/vmw_vsock/virtio_transport_common.c | 14 ++++++++++++-- 2 files changed, 13 insertions(+), 2 deletions(-)
include/linux/virtio_vsock.h +1 -0
@@ -160,6 +160,7 @@ struct virtio_vsock_pkt_info {u32 remote_cid, remote_port;struct vsock_sock *vsk;struct msghdr *msg; +struct net *net;u32 pkt_len;u16 type;u16 op;
net/vmw_vsock/virtio_transport_common.c +12 -2
@@ -313,6 +313,8 @@ static struct sk_buff *virtio_transport_alloc_skb(struct virtio_vsock_pkt_info * info->flags, zcopy); +virtio_vsock_skb_set_net (skb, info->net); +return skb; out:kfree_skb (skb);
@@ -524,6 +526,7 @@ static int virtio_transport_send_credit_update(struct vsock_sock *vsk)struct virtio_vsock_pkt_info info = { .op =VIRTIO_VSOCK_OP_CREDIT_UPDATE , .vsk = vsk, + .net =sock_net (sk_vsock (vsk)), };return virtio_transport_send_pkt_info (vsk, &info);
@@ -1064,6 +1067,7 @@ int virtio_transport_connect(struct vsock_sock *vsk)struct virtio_vsock_pkt_info info = { .op =VIRTIO_VSOCK_OP_REQUEST , .vsk = vsk, + .net =sock_net (sk_vsock (vsk)), };return virtio_transport_send_pkt_info (vsk, &info);
@@ -1079,6 +1083,7 @@ int virtio_transport_shutdown(struct vsock_sock *vsk, int mode) (mode &SEND_SHUTDOWN ? VIRTIO_VSOCK_SHUTDOWN_SEND : 0), .vsk = vsk, + .net = sock_net(sk_vsock(vsk)), };return virtio_transport_send_pkt_info (vsk, &info);
@@ -1105,6 +1110,7 @@ virtio_transport_stream_enqueue(struct vsock_sock *vsk, .msg = msg, .pkt_len = len, .vsk = vsk, + .net = sock_net(sk_vsock(vsk)), };return virtio_transport_send_pkt_info (vsk, &info);
@@ -1142,6 +1148,7 @@ static int virtio_transport_reset(struct vsock_sock *vsk, .op = VIRTIO_VSOCK_OP_RST, .reply = !!skb, .vsk = vsk, + .net = sock_net(sk_vsock(vsk)), };/* Send RST only if the original pkt is not a RST pkt */
@@ -1162,6 +1169,7 @@ static int virtio_transport_reset_no_sock(const struct virtio_transport *t, .op = VIRTIO_VSOCK_OP_RST, .type = le16_to_cpu(hdr->type), .reply = true, + .net = virtio_vsock_skb_net(skb), };struct sk_buff *reply;
@@ -1462,6 +1470,7 @@ virtio_transport_send_response(struct vsock_sock *vsk, .remote_port = le32_to_cpu(hdr->src_port), .reply = true, .vsk = vsk, + .net = sock_net(sk_vsock(vsk)), };return virtio_transport_send_pkt_info (vsk, &info);
@@ -1576,6 +1585,7 @@ void virtio_transport_recv_pkt(struct virtio_transport *t, struct sk_buff *skb) {struct virtio_vsock_hdr *hdr =virtio_vsock_hdr (skb); +struct net *net =virtio_vsock_skb_net (skb);struct sockaddr_vm src, dst;struct vsock_sock *vsk;struct sock *sk;
@@ -1603,9 +1613,9 @@ void virtio_transport_recv_pkt(struct virtio_transport *t,/* The socket must be in connected or bound table * otherwise send reset back */ - sk =vsock_find_connected_socket (&src, &dst); + sk =vsock_find_connected_socket (&src, &dst, net);if (!sk) { - sk =vsock_find_bound_socket (&dst); + sk =vsock_find_bound_socket (&dst, net);if (!sk) { (void )virtio_transport_reset_no_sock (t, skb); goto free_pkt;
Signature · 1 line
2.47.3
RFC PATCH v4 5/12 vhost/vsock: add netns support
In reply to Bobby EshlemanFrom: Bobby Eshleman <[email protected]>
Add the ability to isolate vsock flows using namespaces.
The namespace for a VM is inherited from the PID that opened the vhost-vsock device.
--- drivers/vhost/vsock.c | 48 ++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 38 insertions(+), 10 deletions(-)
drivers/vhost/vsock.c +38 -10
@@ -46,6 +46,8 @@ static DEFINE_READ_MOSTLY_HASHTABLE(vhost_vsock_hash, 8);struct vhost_vsock {struct vhost_dev dev;struct vhost_virtqueue vqs[2 ]; +struct net *net; +netns_tracker ns_tracker;/* Link to global vhost_vsock_hash, writes use vhost_vsock_mutex */ struct hlist_node hash;
@@ -59,6 +61,22 @@ struct vhost_vsock {bool seqpacket_allow; }; +static void vhost_vsock_net_set (struct vhost_vsock *vsock,struct net *net) +{ +if (net_eq (net,vsock_global_net ())) + vsock->net =vsock_global_net (); +else + vsock->net =get_net_track (net, &vsock->ns_tracker,GFP_KERNEL ); +} + +static void vhost_vsock_net_put (struct vhost_vsock *vsock) +{ +if (net_eq (vsock->net,vsock_global_net ())) +return ; + +put_net_track (vsock->net, &vsock->ns_tracker); +} +static u32 vhost_transport_get_local_cid (void ) {return VHOST_VSOCK_DEFAULT_HOST_CID ;
@@ -67,7 +85,7 @@ static u32 vhost_transport_get_local_cid(void)/* Callers that dereference the return value must hold vhost_vsock_mutex or the * RCU read lock. */ -static struct vhost_vsock *vhost_vsock_get (u32 guest_cid) +static struct vhost_vsock *vhost_vsock_get (u32 guest_cid,struct net *net) {struct vhost_vsock *vsock;
@@ -78,9 +96,8 @@ static struct vhost_vsock *vhost_vsock_get(u32 guest_cid)if (other_cid ==0 )continue ; -if (other_cid == guest_cid) +if (other_cid == guest_cid &&vsock_net_check_mode (net, vsock->net))return vsock; - }return NULL ;
@@ -272,13 +289,14 @@ static int vhost_transport_send_pkt(struct sk_buff *skb) {struct virtio_vsock_hdr *hdr =virtio_vsock_hdr (skb); +struct net *net =virtio_vsock_skb_net (skb);struct vhost_vsock *vsock;int len = skb->len;rcu_read_lock ();/* Find the vhost_vsock according to guest context id */ - vsock =vhost_vsock_get (le64_to_cpu (hdr->dst_cid)); + vsock =vhost_vsock_get (le64_to_cpu (hdr->dst_cid), net);if (!vsock) {rcu_read_unlock ();kfree_skb (skb);
@@ -305,7 +323,7 @@ vhost_transport_cancel_pkt(struct vsock_sock *vsk)rcu_read_lock ();/* Find the vhost_vsock according to guest context id */ - vsock =vhost_vsock_get (vsk->remote_addr.svm_cid); + vsock =vhost_vsock_get (vsk->remote_addr.svm_cid,sock_net (sk_vsock (vsk)));if (!vsock) goto out;
@@ -403,7 +421,7 @@ static bool vhost_transport_msgzerocopy_allow(void)return true; } -static bool vhost_transport_seqpacket_allow (u32 remote_cid); +static bool vhost_transport_seqpacket_allow (struct vsock_sock *vsk,u32 remote_cid);static struct virtio_transport vhost_transport = { .transport = {
@@ -459,13 +477,14 @@ static struct virtio_transport vhost_transport = { .send_pkt = vhost_transport_send_pkt, }; -static bool vhost_transport_seqpacket_allow (u32 remote_cid) +static bool vhost_transport_seqpacket_allow (struct vsock_sock *vsk,u32 remote_cid) { +struct net *net =sock_net (sk_vsock (vsk));struct vhost_vsock *vsock;bool seqpacket_allow = false;rcu_read_lock (); - vsock =vhost_vsock_get (remote_cid); + vsock =vhost_vsock_get (remote_cid, net);if (vsock) seqpacket_allow = vsock->seqpacket_allow;
@@ -525,6 +544,7 @@ static void vhost_vsock_handle_tx_kick(struct vhost_work *work)continue ; } +virtio_vsock_skb_set_net (skb, vsock->net); total_len +=sizeof (*hdr) + skb->len;/* Deliver to monitoring devices all received packets */
@@ -651,10 +671,16 @@ static void vhost_vsock_free(struct vhost_vsock *vsock)static int vhost_vsock_dev_open (struct inode *inode,struct file *file) { +struct vhost_virtqueue **vqs;struct vhost_vsock *vsock; +struct net *net;int ret; + net =get_net_ns_by_pid (current->pid); +if (IS_ERR (net)) +return PTR_ERR (net); +/* This struct is large and allocation could fail, fall back to vmalloc * if there is no other way. */
@@ -668,6 +694,7 @@ static int vhost_vsock_dev_open(struct inode *inode, struct file *file) goto out; } +vhost_vsock_net_set (vsock, net); vsock->guest_cid =0 ;/* no CID assigned yet */ vsock->seqpacket_allow = false;
@@ -707,7 +734,7 @@ static void vhost_vsock_reset_orphans(struct sock *sk)*/ /* If the peer is still valid, no need to reset connection */ -if (vhost_vsock_get (vsk->remote_addr.svm_cid)) +if (vhost_vsock_get (vsk->remote_addr.svm_cid,sock_net (sk)))return ;/* If the close timeout is pending, let it expire. This avoids races
@@ -752,6 +779,7 @@ static int vhost_vsock_dev_release(struct inode *inode, struct file *file)virtio_vsock_skb_queue_purge (&vsock->send_pkt_queue);vhost_dev_cleanup (&vsock->dev); +vhost_vsock_net_put (vsock);kfree (vsock->dev.vqs);vhost_vsock_free (vsock);return 0 ;
@@ -778,7 +806,7 @@ static int vhost_vsock_set_cid(struct vhost_vsock *vsock, u64 guest_cid)/* Refuse if CID is already in use */ mutex_lock (&vhost_vsock_mutex); - other =vhost_vsock_get (guest_cid); + other =vhost_vsock_get (guest_cid, vsock->net);if (other && other != vsock) {mutex_unlock (&vhost_vsock_mutex);return -EADDRINUSE ;
Signature · 1 line
2.47.3
RFC PATCH v4 6/12 vsock/virtio: use the global netns
In reply to Bobby EshlemanFrom: Bobby Eshleman <[email protected]>
This changes virtio-vsock to always use the global netns dummy so that all guest vsock continues to operate in global mode. The guest vsock behavior is unchanged.
--- net/vmw_vsock/virtio_transport.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
net/vmw_vsock/virtio_transport.c +3 -2
@@ -536,7 +536,7 @@ static bool virtio_transport_msgzerocopy_allow(void)return true; } -static bool virtio_transport_seqpacket_allow (u32 remote_cid); +static bool virtio_transport_seqpacket_allow (struct vsock_sock *vsk,u32 remote_cid);static struct virtio_transport virtio_transport = { .transport = {
@@ -593,7 +593,7 @@ static struct virtio_transport virtio_transport = { .can_msgzerocopy = virtio_transport_can_msgzerocopy, }; -static bool virtio_transport_seqpacket_allow (u32 remote_cid) +static bool virtio_transport_seqpacket_allow (struct vsock_sock *vsk,u32 remote_cid) {struct virtio_vsock *vsock;bool seqpacket_allow;
@@ -649,6 +649,7 @@ static void virtio_transport_rx_work(struct work_struct *work) }virtio_vsock_skb_rx_put (skb); +virtio_vsock_skb_set_net (skb,vsock_global_net ());virtio_transport_deliver_tap_pkt (skb);virtio_transport_recv_pkt (&virtio_transport, skb); }
Signature · 1 line
2.47.3
RFC PATCH v4 7/12 hv_sock: add netns hooks
In reply to Bobby EshlemanFrom: Bobby Eshleman <[email protected]>
Make NS changes not break hyperv. Guest vsocks still remain in the global namespace always, so the behavior is unchanged.
--- net/vmw_vsock/hyperv_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/vmw_vsock/hyperv_transport.c +1 -1
@@ -313,7 +313,7 @@ static void hvs_open_connection(struct vmbus_channel *chan)return ;hvs_addr_init (&addr, conn_from_host ? if_type : if_instance); - sk =vsock_find_bound_socket (&addr); + sk =vsock_find_bound_socket (&addr,vsock_global_net ());if (!sk)return ;
Signature · 1 line
2.47.3
RFC PATCH v4 8/12 vsock/vmci: add netns hooks
In reply to Bobby EshlemanFrom: Bobby Eshleman <[email protected]>
Add hooks for new internal NS calls to avoid breaking vmci. Guest vsocks remain in global mode namespaces, so behavior is unchanged.
--- net/vmw_vsock/vmci_transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/vmw_vsock/vmci_transport.c +2 -2
@@ -703,9 +703,9 @@ static int vmci_transport_recv_stream_cb(void *data, struct vmci_datagram *dg)vsock_addr_init (&src, pkt->dg.src.context, pkt->src_port);vsock_addr_init (&dst, pkt->dg.dst.context, pkt->dst_port); - sk =vsock_find_connected_socket (&src, &dst); + sk =vsock_find_connected_socket (&src, &dst,vsock_global_net ());if (!sk) { - sk =vsock_find_bound_socket (&dst); + sk =vsock_find_bound_socket (&dst,vsock_global_net ());if (!sk) {/* We could not find a socket for this specified * address. If this packet is a RST, we just drop it.
Signature · 1 line
2.47.3
RFC PATCH v4 9/12 vsock/loopback: add netns support
In reply to Bobby EshlemanFrom: Bobby Eshleman <[email protected]>
Add NS support to vsock loopback. Sockets in a global mode netns communicate with each other, regardless of namespace. Sockets in a local mode netns may only communicate with other sockets within the same namespace.
--- include/net/af_vsock.h | 4 +++ include/net/netns/vsock.h | 3 +++ net/vmw_vsock/af_vsock.c | 8 +++++- net/vmw_vsock/vsock_loopback.c | 59 +++++++++++++++++++++++++++++++++++------- 4 files changed, 63 insertions(+), 11 deletions(-)
include/net/af_vsock.h +4 -0
@@ -305,4 +305,8 @@ static inline bool vsock_net_check_mode(struct net *n1, struct net *n2) (vsock_net_mode (n1) ==VSOCK_NET_MODE_GLOBAL && vsock_net_mode(n2) == VSOCK_NET_MODE_GLOBAL); } + +int vsock_loopback_init_net (struct net *net); +void vsock_loopback_exit_net (struct net *net); +#endif /* __AF_VSOCK_H__ */
include/net/netns/vsock.h +3 -0
@@ -7,6 +7,8 @@#define VSOCK_NET_MODE_GLOBAL 1#define VSOCK_NET_MODE_LOCAL (1 << 1) +struct vsock_loopback ; +struct netns_vsock {struct ctl_table_header *vsock_hdr;spinlock_t lock;
@@ -14,5 +16,6 @@ struct netns_vsock {/* protected by lock */ u8 ns_mode;bool written; + struct vsock_loopback *loopback; };#endif /* __NET_NET_NAMESPACE_VSOCK_H */
net/vmw_vsock/af_vsock.c +7 -1
@@ -2778,9 +2778,12 @@ static __net_init int vsock_sysctl_init_net(struct net *net) { vsock_net_init(net); - if (vsock_sysctl_register(net)) + if (vsock_loopback_init_net(net)) return -ENOMEM; + if (vsock_sysctl_register(net)) + goto err_loopback; + #ifdef CONFIG_PROC_FS if (!proc_create_net_single_write("vsock_ns_mode", 0644, net->proc_net, vsock_proc_ns_mode_show,
@@ -2793,12 +2796,15 @@ static __net_init int vsock_sysctl_init_net(struct net *net) err_sysctl:vsock_sysctl_unregister (net); +err_loopback: +vsock_loopback_exit_net (net);return -ENOMEM ; } static __net_exit void vsock_sysctl_exit_net(struct net *net) {vsock_sysctl_unregister (net); +vsock_loopback_exit_net (net); }static struct pernet_operations vsock_sysctl_ops__net_initdata = {
net/vmw_vsock/vsock_loopback.c +49 -10
98 lines not on this page · raw message
Signature · 1 line
2.47.3
Simon Horman
reviewerRe: [PATCH RFC net-next v4 09/12] vsock/loopback: add netns support
Quoted 8 lines · Bobby Eshleman
From: Bobby Eshleman <[email protected]>
Add NS support to vsock loopback. Sockets in a global mode netns communicate with each other, regardless of namespace. Sockets in a local mode netns may only communicate with other sockets within the same namespace.
Signed-off-by Bobby Eshleman <[email protected]>
...
Quoted 1 line
net/vmw_vsock/vsock_loopback.c +0
-0
...
net/vmw_vsock/vsock_loopback.c static int vsock_loopback_cancel_pkt(struct vsock_sock *vsk) · line 60
Quoted 6 lines
net/vmw_vsock/vsock_loopback.c +1
-1@@ -46,7 +57,7 @@ static int vsock_loopback_cancel_pkt(struct vsock_sock *vsk)return 0 ; } -static bool vsock_loopback_seqpacket_allow (u32 remote_cid); +static bool vsock_loopback_seqpacket_allow (struct vsock_sock *vsk,u32 remote_cid);
This change needs to be squashed into
PATCH 3/12 vsock: add netns to af_vsock core
To avoid build breakage.
Likewise with the other change to vsock_loopback_seqpacket_allow below. And I think also for a number of other changes made by PATCH 3/12.
Please make sure that patches don't introduce transient build failures. It breaks bisection.
On the topic of vsock_loopback_seqpacket_allow, also:
* Please line wrap this so that the code is 80 columns wide or less, as is still preferred for Networking code.
Flagged by checkpatch.pl --max-line-length=80
* Can we move the definition of vsock_loopback_seqpacket_allow() here? The function itself is is trivial. And doing so would avoid a forward declaration.
Quoted 3 lines
net/vmw_vsock/vsock_loopback.c +0
-0static bool vsock_loopback_msgzerocopy_allow (void ) {return true;
...
Quoted 4 lines
net/vmw_vsock/vsock_loopback.c +4
-0+int vsock_loopback_init_net (struct net *net) +{ + net->vsock.loopback =kmalloc (GFP_KERNEL ,sizeof (struct vsock_loopback )); +if (!net->vsock.loopback)
net/vmw_vsock/vsock_loopback.c static void vsock_loopback_work(struct work_struct *work) · line 177
Quoted 10 lines
net/vmw_vsock/vsock_loopback.c +10
-0+return -ENOMEM ; + +return vsock_loopback_init_vsock (net->vsock.loopback); +} + +void vsock_loopback_exit_net (struct net *net) +{ +vsock_loopback_deinit_vsock (net->vsock.loopback); +kfree (net->vsock.loopback); +}
I think EXPORT_SYMBOL_GPL is needed for both vsock_loopback_exit_net and vsock_loopback_init_net for the case where CONFIG_VSOCKETS=m
Also, in Kconfig VSOCKETS_LOOPBACK depends on VSOCKETS. But this code adds a reverse dependency. As it stands it's possible to configure VSOCKETS without VSOCKETS_LOOPBACK, which will not compile.
Perhaps stub implementations of vsock_loopback_init_net and vsock_loopback_exit_net should be implemented in af_vsock.h if VSOCKETS_LOOPBACK is not enabled?
...
Signature · 1 line
pw-bot: changes-requested
Re: [PATCH RFC net-next v4 09/12] vsock/loopback: add netns support
Quoted 3 lines · Simon Horman
Quoted 2 lines · Bobby Eshleman
From: Bobby Eshleman <[email protected]>
...
Quoted 11 lines
This change needs to be squashed into
PATCH 3/12 vsock: add netns toaf_vsockcoreTo avoid build breakage.
Likewise with the other change to
vsock_loopback_seqpacket_allowbelow. And I think also for a number of other changes made by PATCH 3/12.Please make sure that patches don't introduce transient build failures. It breaks bisection.
Will do, thanks!
Quoted 37 lines
On the topic of
vsock_loopback_seqpacket_allow, also:* Please line wrap this so that the code is 80 columns wide or less, as is still preferred for Networking code.
Flagged by checkpatch.pl --max-line-length=80* Can we move the definition of
vsock_loopback_seqpacket_allow()here? The function itself is is trivial. And doing so would avoid a forward declaration.Quoted 3 lines
static bool
vsock_loopback_msgzerocopy_allow(void){
return true;...
Quoted 4 lines
net/vmw_vsock/vsock_loopback.c +4
-0+int vsock_loopback_init_net (struct net *net) +{ + net->vsock.loopback =kmalloc (GFP_KERNEL ,sizeof (struct vsock_loopback )); +if (!net->vsock.loopback)net/vmw_vsock/vsock_loopback.c static void vsock_loopback_work(struct work_struct *work) · line 177
Quoted 10 lines
net/vmw_vsock/vsock_loopback.c +10
-0+return -ENOMEM ; + +return vsock_loopback_init_vsock (net->vsock.loopback); +} + +void vsock_loopback_exit_net (struct net *net) +{ +vsock_loopback_deinit_vsock (net->vsock.loopback); +kfree (net->vsock.loopback); +}I think
EXPORT_SYMBOL_GPLis needed for bothvsock_loopback_exit_netandvsock_loopback_init_netfor the case whereCONFIG_VSOCKETS=m
Quoted 8 lines
Also, in
KconfigVSOCKETS_LOOPBACKdepends on VSOCKETS. But this code adds a reverse dependency. As it stands it's possible to configure VSOCKETS withoutVSOCKETS_LOOPBACK, which will not compile.Perhaps stub implementations of
vsock_loopback_init_netandvsock_loopback_exit_netshould be implemented inaf_vsock.hifVSOCKETS_LOOPBACKis not enabled?
Roger that, makes sense. Thanks for the review!
Best,
Bobby
kernel test robot
build botRe: [PATCH RFC net-next v4 09/12] vsock/loopback: add netns support
In reply to Bobby Eshlemankernel test robot noticed the following build errors:
Hi Bobby,
[This is a private test report for your RFC patch.] kernel test robot noticed the following build errors:
[auto build test ERROR on dd500e4aecf25e48e874ca7628697969df679493]
url: https://github.com/intel-lab-lkp/linux/commits/Bobby-Eshleman/vsock-a-per-net-vsock-NS-mode-state/20250806-130409 base: dd500e4aecf25e48e874ca7628697969df679493 patch link: https://lore.kernel.org/r/20250805-vsock-vmtest-v4-9-059ec51ab111%40meta.com patch subject: [PATCH RFC net-next v4 09/12] vsock/loopback: add netns support config: csky-randconfig-001-20250807 (https://download.01.org/0day-ci/archive/20250807/[email protected]/config) compiler: csky-linux-gcc (GCC) 15.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250807/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
csky-linux-ld: net/vmw_vsock/af_vsock.o: in function `vsock_sysctl_init_net':
>> net/vmw_vsock/af_vsock.c:2781:(.init.text+0x162): undefined reference to `vsock_loopback_init_net' >> csky-linux-ld: net/vmw_vsock/af_vsock.c:2800:(.init.text+0x1e8): undefined reference to `vsock_loopback_exit_net' >> csky-linux-ld: net/vmw_vsock/af_vsock.c:2802:(.init.text+0x200): undefined reference to `vsock_loopback_init_net' csky-linux-ld: net/vmw_vsock/af_vsock.c:2802:(.init.text+0x228): undefined reference to `vsock_loopback_exit_net' csky-linux-ld: net/vmw_vsock/af_vsock.o: in function `vsock_sysctl_exit_net': >> net/vmw_vsock/af_vsock.c:2807:(.ref.text+0x1c): undefined reference to `vsock_loopback_exit_net' >> csky-linux-ld: net/vmw_vsock/af_vsock.c:2808:(.ref.text+0x30): undefined reference to `vsock_loopback_exit_net'
vim +2781 net/vmw_vsock/af_vsock.c
2776
2777 static __net_init int vsock_sysctl_init_net(struct net *net)
2778 {
2779 vsock_net_init(net);
2780
> 2781 if (vsock_loopback_init_net(net))
2782 return -ENOMEM;
2783
2784 if (vsock_sysctl_register(net))
2785 goto err_loopback;
2786
2787 #ifdef CONFIG_PROC_FS
2788 if (!proc_create_net_single_write("vsock_ns_mode", 0644, net->proc_net,
2789 vsock_proc_ns_mode_show,
2790 vsock_proc_ns_mode_write,
2791 NULL))
2792 goto err_sysctl;
2793 #endif
2794
2795 return 0;
2796
2797 err_sysctl:
2798 vsock_sysctl_unregister(net);
2799 err_loopback:
> 2800 vsock_loopback_exit_net(net);
2801 return -ENOMEM;
> 2802 }
2803
2804 static __net_exit void vsock_sysctl_exit_net(struct net *net)
2805 {
2806 vsock_sysctl_unregister(net);
> 2807 vsock_loopback_exit_net(net);
> 2808 }2809
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
RFC PATCH v4 10/12 selftests/vsock: improve logging in vmtest.sh
In reply to Bobby EshlemanFrom: Bobby Eshleman <[email protected]>
Improve logging by adding configurable log levels. Additionally, improve usability of logging functions. Remove the test name prefix from logging functions so that logging calls can be made deeper into the call stack without passing down the test name or setting some global. Teach log function to accept a LOG_PREFIX variable to avoid unnecessary argument shifting.
--- tools/testing/selftests/vsock/vmtest.sh | 75 ++++++++++++++++----------------- 1 file changed, 37 insertions(+), 38 deletions(-)
tools/testing/selftests/vsock/vmtest.sh +37 -38
@@ -51,7 +51,12 @@ readonly TEST_DESCS=( "Run vsock_test using the loopback transport in the VM." ) -VERBOSE=0 +readonly LOG_LEVEL_DEBUG=0 +readonly LOG_LEVEL_INFO=1 +readonly LOG_LEVEL_WARN=2 +readonly LOG_LEVEL_ERROR=3 + +VERBOSE="${LOG_LEVEL_WARN}" usage() { local name
@@ -196,7 +201,7 @@ vm_start() { qemu=$(command -v "${QEMU}") - if [[ "${VERBOSE}" -eq 1 ]]; then + if [[ ${VERBOSE} -le ${LOG_LEVEL_DEBUG} ]]; then verbose_opt="--verbose" logfile=/dev/stdout fi
@@ -271,60 +276,56 @@ EOF host_wait_for_listener() { wait_for_listener "${TEST_HOST_PORT_LISTENER}" "${WAIT_PERIOD}" "${WAIT_PERIOD_MAX}" -} - -__log_stdin() { - cat | awk '{ printf "%s:\t%s\n","'"${prefix}"'", $0 }' -} -__log_args() { - echo "$*" | awk '{ printf "%s:\t%s\n","'"${prefix}"'", $0 }' } log() { - local prefix="$1" + local redirect + local prefix - shift - local redirect= - if [[ ${VERBOSE} -eq 0 ]]; then + if [[ ${VERBOSE} -gt ${LOG_LEVEL_INFO} ]]; then redirect=/dev/null else redirect=/dev/stdout fi + prefix="${LOG_PREFIX:-}" + if [[ "$#" -eq 0 ]]; then - __log_stdin | tee -a "${LOG}" > ${redirect} + if [[ -n "${prefix}" ]]; then + cat | awk -v prefix="${prefix}" '{printf "%s: %s\n", prefix, $0}' + else + cat + fi else - __log_args "$@" | tee -a "${LOG}" > ${redirect} - fi + if [[ -n "${prefix}" ]]; then + echo "${prefix}: " "$@" + else + echo "$@" + fi + fi | tee -a "${LOG}" > ${redirect} } -log_setup() { - log "setup" "$@" +log_host() { + LOG_PREFIX=host log $@ } -log_host() { - local testname=$1 +log_guest() { + LOG_PREFIX=guest log $@ +} - shift - log "test:${testname}:host" "$@" } -log_guest() { - local testname=$1 - shift - log "test:${testname}:guest" "$@" } test_vm_server_host_client() { - local testname="${FUNCNAME[0]#test_}" vm_ssh -- "${VSOCK_TEST}" \ --mode=server \ --control-port="${TEST_GUEST_PORT}" \ --peer-cid=2 \ - 2>&1 | log_guest "${testname}" & + 2>&1 | log_guest & vm_wait_for_listener "${TEST_GUEST_PORT}"
@@ -332,18 +333,17 @@ test_vm_server_host_client() { --mode=client \ --control-host=127.0.0.1 \ --peer-cid="${VSOCK_CID}" \ - --control-port="${TEST_HOST_PORT}" 2>&1 | log_host "${testname}" + --control-port="${TEST_HOST_PORT}" 2>&1 | log_host return $? } test_vm_client_host_server() { - local testname="${FUNCNAME[0]#test_}" ${VSOCK_TEST} \ --mode "server" \ --control-port "${TEST_HOST_PORT_LISTENER}" \ - --peer-cid "${VSOCK_CID}" 2>&1 | log_host "${testname}" & + --peer-cid "${VSOCK_CID}" 2>&1 | log_host & host_wait_for_listener
@@ -351,19 +351,18 @@ test_vm_client_host_server() { --mode=client \ --control-host=10.0.2.2 \ --peer-cid=2 \ - --control-port="${TEST_HOST_PORT_LISTENER}" 2>&1 | log_guest "${testname}" + --control-port="${TEST_HOST_PORT_LISTENER}" 2>&1 | log_guest return $? } test_vm_loopback() { - local testname="${FUNCNAME[0]#test_}" local port=60000 # non-forwarded local port vm_ssh -- "${VSOCK_TEST}" \ --mode=server \ --control-port="${port}" \ - --peer-cid=1 2>&1 | log_guest "${testname}" & + --peer-cid=1 2>&1 | log_guest & vm_wait_for_listener "${port}"
@@ -371,7 +370,7 @@ test_vm_loopback() { --mode=client \ --control-host="127.0.0.1" \ --control-port="${port}" \ - --peer-cid=1 2>&1 | log_guest "${testname}" + --peer-cid=1 2>&1 | log_guest return $? }
@@ -429,7 +428,7 @@ QEMU="qemu-system-$(uname -m)" while getopts :hvsq:b o do case $o in - v) VERBOSE=1;; + v) VERBOSE=$(( VERBOSE - 1 ));; b) BUILD=1;; q) QEMU=$OPTARG;; h|*) usage;;
@@ -452,10 +451,10 @@ handle_build echo "1..${#ARGS[@]}" -log_setup "Booting up VM" +log_host "Booting up VM" vm_start vm_wait_for_ssh -log_setup "VM booted up" +log_host "VM booted up" cnt_pass=0 cnt_fail=0
Signature · 1 line
2.47.3
RFC PATCH v4 11/12 selftests/vsock: invoke vsock_test through helpers
In reply to Bobby EshlemanFrom: Bobby Eshleman <[email protected]>
Add helper calls vm_vsock_test() and host_vsock_test() to invoke the vsock_test binary. This encapsulates several items of repeat logic, such as waiting for the server to reach listening state and enabling/disabling the bash option pipefail to avoid pipe-style logging from hiding failures.
--- tools/testing/selftests/vsock/vmtest.sh | 120 ++++++++++++++++++++++++++++---- 1 file changed, 108 insertions(+), 12 deletions(-)
tools/testing/selftests/vsock/vmtest.sh +108 -12
@@ -248,6 +248,7 @@ wait_for_listener() local port=$1 local interval=$2 local max_intervals=$3 + local old_pipefail local protocol=tcp local pattern local i
@@ -256,6 +257,13 @@ wait_for_listener() # for tcp protocol additionally check the socket state [ "${protocol}" = "tcp" ] && pattern="${pattern}0A" + + # 'grep -q' exits on match, sending SIGPIPE to 'awk', which exits with + # an error, causing the if-condition to fail when pipefail is set. + # Instead, temporarily disable pipefail and restore it later. + old_pipefail=$(set -o | awk '/^pipefail[[:space:]]+(on|off)$/{print $2}') + set +o pipefail + for i in $(seq "${max_intervals}"); do if awk '{print $2" "$4}' /proc/net/"${protocol}"* | \ grep -q "${pattern}"; then
@@ -263,6 +271,10 @@ wait_for_listener() fi sleep "${interval}" done + + if [[ "${old_pipefail}" == on ]]; then + set -o pipefail + fi } vm_wait_for_listener() {
@@ -314,28 +326,112 @@ log_guest() { LOG_PREFIX=guest log $@ } +vm_vsock_test() { + local ns=$1 + local mode=$2 + local rc + + set -o pipefail + if [[ "${mode}" == client ]]; then + local host=$3 + local cid=$4 + local port=$5 + + # log output and use pipefail to respect vsock_test errors + vm_ssh "${ns}" -- "${VSOCK_TEST}" \ + --mode=client \ + --control-host="${host}" \ + --peer-cid="${cid}" \ + --control-port="${port}" \ + 2>&1 | log_guest + rc=$? + else + local cid=$3 + local port=$4 + + # log output and use pipefail to respect vsock_test errors + vm_ssh "${ns}" -- "${VSOCK_TEST}" \ + --mode=server \ + --peer-cid="${cid}" \ + --control-port="${port}" \ + 2>&1 | log_guest & + rc=$? + + if [[ $rc -ne 0 ]]; then + set +o pipefail + return $rc + fi + + vm_wait_for_listener "${ns}" "${port}" + rc=$? + fi + set +o pipefail + + return $rc } +host_vsock_test() { + local ns=$1 + local mode=$2 + local cmd + + if [[ "${ns}" == none ]]; then + cmd="${VSOCK_TEST}" + else + cmd="ip netns exec ${ns} ${VSOCK_TEST}" + fi + + # log output and use pipefail to respect vsock_test errors + set -o pipefail + if [[ "${mode}" == client ]]; then + local host=$3 + local cid=$4 + local port=$5 + + ${cmd} \ + --mode="${mode}" \ + --peer-cid="${cid}" \ + --control-host="${host}" \ + --control-port="${port}" 2>&1 | log_host + rc=$? + else + local cid=$3 + local port=$4 + + ${cmd} \ + --mode="${mode}" \ + --peer-cid="${cid}" \ + --control-port="${port}" 2>&1 | log_host & + rc=$? + + if [[ $rc -ne 0 ]]; then + return $rc + fi + + host_wait_for_listener "${ns}" "${port}" "${WAIT_PERIOD}" "${WAIT_PERIOD_MAX}" + rc=$? + fi + set +o pipefail + return $rc } test_vm_server_host_client() { + vm_vsock_test "none" "server" 2 "${TEST_GUEST_PORT}" + host_vsock_test "none" "client" "127.0.0.1" "${VSOCK_CID}" "${TEST_HOST_PORT}" +} - vm_ssh -- "${VSOCK_TEST}" \ - --mode=server \ - --control-port="${TEST_GUEST_PORT}" \ - --peer-cid=2 \ - 2>&1 | log_guest & +test_vm_client_host_server() { + host_vsock_test "none" "server" "${VSOCK_CID}" "${TEST_HOST_PORT_LISTENER}" + vm_vsock_test "none" "client" "10.0.2.2" 2 "${TEST_HOST_PORT_LISTENER}" +} - vm_wait_for_listener "${TEST_GUEST_PORT}" +test_vm_loopback() { + vm_vsock_test "none" "server" 1 "${TEST_HOST_PORT_LISTENER}" + vm_vsock_test "none" "client" "127.0.0.1" 1 "${TEST_HOST_PORT_LISTENER}" +} - ${VSOCK_TEST} \ - --mode=client \ - --control-host=127.0.0.1 \ - --peer-cid="${VSOCK_CID}" \ - --control-port="${TEST_HOST_PORT}" 2>&1 | log_host - return $? } test_vm_client_host_server() {
Signature · 1 line
2.47.3
RFC PATCH v4 12/12 selftests/vsock: add namespace tests
In reply to Bobby EshlemanFrom: Bobby Eshleman <[email protected]>
Add tests for namespace support in vsock. Use socat for basic connection failure tests and vsock_test for full functionality tests when communication is expected to succeed. vsock_test is not used for failure cases because in theory vsock_test could allow connection and some traffic flow but fail on some other case (e.g., fail on MSG_ZEROCOPY).
Tests cover all cases of clients and servers being in all variants of local ns, global ns, host process, and VM process.
Legacy tests are retained and executed in the init ns.
--- tools/testing/selftests/vsock/vmtest.sh | 909 ++++++++++++++++++++++++++++---- 1 file changed, 804 insertions(+), 105 deletions(-)
tools/testing/selftests/vsock/vmtest.sh +804 -105
@@ -7,6 +7,7 @@ # * virtme-ng # * busybox-static (used by virtme-ng) # * qemu (used by virtme-ng) +# * socat readonly SCRIPT_DIR="$(cd -P -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd -P)" readonly KERNEL_CHECKOUT=$(realpath "${SCRIPT_DIR}"/../../../../)
@@ -23,7 +24,7 @@ readonly VSOCK_CID=1234 readonly WAIT_PERIOD=3 readonly WAIT_PERIOD_MAX=60 readonly WAIT_TOTAL=$(( WAIT_PERIOD * WAIT_PERIOD_MAX )) -readonly QEMU_PIDFILE=$(mktemp /tmp/qemu_vsock_vmtest_XXXX.pid) +readonly WAIT_QEMU=5 # virtme-ng offers a netdev for ssh when using "--ssh", but we also need a # control port forwarded for vsock_test. Because virtme-ng doesn't support
@@ -33,23 +34,125 @@ readonly QEMU_PIDFILE=$(mktemp /tmp/qemu_vsock_vmtest_XXXX.pid) # add the kernel cmdline options that virtme-init uses to setup the interface. readonly QEMU_TEST_PORT_FWD="hostfwd=tcp::${TEST_HOST_PORT}-:${TEST_GUEST_PORT}" readonly QEMU_SSH_PORT_FWD="hostfwd=tcp::${SSH_HOST_PORT}-:${SSH_GUEST_PORT}" -readonly QEMU_OPTS="\ - -netdev user,id=n0,${QEMU_TEST_PORT_FWD},${QEMU_SSH_PORT_FWD} \ - -device virtio-net-pci,netdev=n0 \ - -device vhost-vsock-pci,guest-cid=${VSOCK_CID} \ - --pidfile ${QEMU_PIDFILE} \ -" readonly KERNEL_CMDLINE="\ virtme.dhcp net.ifnames=0 biosdevname=0 \ virtme.ssh virtme_ssh_channel=tcp virtme_ssh_user=$USER \ " readonly LOG=$(mktemp /tmp/vsock_vmtest_XXXX.log) -readonly TEST_NAMES=(vm_server_host_client vm_client_host_server vm_loopback) +readonly TEST_NAMES=( + vm_server_host_client + vm_client_host_server + vm_loopback + host_vsock_ns_mode_ok + host_vsock_ns_mode_write_once_ok + global_same_cid_fails + local_same_cid_ok + global_local_same_cid_ok + local_global_same_cid_ok + diff_ns_global_host_connect_to_global_vm_ok + diff_ns_global_host_connect_to_local_vm_fails + diff_ns_global_vm_connect_to_global_host_ok + diff_ns_global_vm_connect_to_local_host_fails + diff_ns_local_host_connect_to_local_vm_fails + diff_ns_local_vm_connect_to_local_host_fails + diff_ns_global_to_local_loopback_local_fails + diff_ns_local_to_global_loopback_fails + diff_ns_local_to_local_loopback_fails + diff_ns_global_to_global_loopback_ok + same_ns_local_loopback_ok + same_ns_local_host_connect_to_local_vm_ok + same_ns_local_vm_connect_to_local_host_ok +) + readonly TEST_DESCS=( + # vm_server_host_client "Run vsock_test in server mode on the VM and in client mode on the host." + + # vm_client_host_server "Run vsock_test in client mode on the VM and in server mode on the host." + + # vm_loopback "Run vsock_test using the loopback transport in the VM." + + # host_vsock_ns_mode_ok + "Check /proc/net/vsock_ns_mode strings on the host." + + # host_vsock_ns_mode_write_once_ok + "Check /proc/net/vsock_ns_mode is write-once on the host." + + # global_same_cid_fails + "Check QEMU fails to start two VMs with same CID in two different global namespaces." + + # local_same_cid_ok + "Check QEMU successfully starts two VMs with same CID in two different local namespaces." + + # global_local_same_cid_ok + "Check QEMU successfully starts one VM in a global ns and then another VM in a local ns with the same CID." + + # local_global_same_cid_ok + "Check QEMU successfully starts one VM in a local ns and then another VM in a global ns with the same CID." + + # diff_ns_global_host_connect_to_global_vm_ok + "Run vsock_test client in global ns with server in VM in another global ns." + + # diff_ns_global_host_connect_to_local_vm_fails + "Run socat to test a process in a global ns fails to connect to a VM in a local ns." + + # diff_ns_global_vm_connect_to_global_host_ok + "Run vsock_test client in VM in a global ns with server in another global ns." + + # diff_ns_global_vm_connect_to_local_host_fails + "Run socat to test a VM in a global ns fails to connect to a host process in a local ns." + + # diff_ns_local_host_connect_to_local_vm_fails + "Run socat to test a host process in a local ns fails to connect to a VM in another local ns." + + # diff_ns_local_vm_connect_to_local_host_fails + "Run socat to test a VM in a local ns fails to connect to a host process in another local ns." + + # diff_ns_global_to_local_loopback_local_fails + "Run socat to test a loopback vsock in a global ns fails to connect to a vsock in a local ns." + + # diff_ns_local_to_global_loopback_fails + "Run socat to test a loopback vsock in a local ns fails to connect to a vsock in a global ns." + + # diff_ns_local_to_local_loopback_fails + "Run socat to test a loopback vsock in a local ns fails to connect to a vsock in another local ns." + + # diff_ns_global_to_global_loopback_ok + "Run socat to test a loopback vsock in a global ns successfuly connects to a vsock in another global ns." + + # same_ns_local_loopback_ok + "Run socat to test a loopback vsock in a local ns successfuly connects to a vsock in the same ns." + + # same_ns_local_host_connect_to_local_vm_ok + "Run vsock_test client in a local ns with server in VM in same ns." + + # same_ns_local_vm_connect_to_local_host_ok + "Run vsock_test client in VM in a local ns with server in same ns." +) + +readonly USE_SHARED_VM=(vm_server_host_client vm_client_host_server vm_loopback) +readonly USE_INIT_NETNS=( + global_same_cid_fails + local_same_cid_ok + global_local_same_cid_ok + local_global_same_cid_ok + diff_ns_global_host_connect_to_global_vm_ok + diff_ns_global_host_connect_to_local_vm_fails + diff_ns_global_vm_connect_to_global_host_ok + diff_ns_global_vm_connect_to_local_host_fails + diff_ns_local_host_connect_to_local_vm_fails + diff_ns_local_vm_connect_to_local_host_fails + diff_ns_global_to_local_loopback_local_fails + diff_ns_local_to_global_loopback_fails + diff_ns_local_to_local_loopback_fails + diff_ns_global_to_global_loopback_ok + same_ns_local_loopback_ok + same_ns_local_host_connect_to_local_vm_ok + same_ns_local_vm_connect_to_local_host_ok ) +readonly MODES=("local" "global") readonly LOG_LEVEL_DEBUG=0 readonly LOG_LEVEL_INFO=1
@@ -58,6 +161,12 @@ readonly LOG_LEVEL_ERROR=3 VERBOSE="${LOG_LEVEL_WARN}" +# Test pass/fail counters +cnt_pass=0 +cnt_fail=0 +cnt_skip=0 +cnt_total=0 + usage() { local name local desc
@@ -77,7 +186,7 @@ usage() { for ((i = 0; i < ${#TEST_NAMES[@]}; i++)); do name=${TEST_NAMES[${i}]} desc=${TEST_DESCS[${i}]} - printf "\t%-35s%-35s\n" "${name}" "${desc}" + printf "\t%-55s%-35s\n" "${name}" "${desc}" done echo
@@ -89,21 +198,87 @@ die() { exit "${KSFT_FAIL}" } +add_namespaces() { + # add namespaces local0, local1, global0, and global1 + for mode in "${MODES[@]}"; do + ip netns add "${mode}0" 2>/dev/null + ip netns add "${mode}1" 2>/dev/null + done +} + +init_namespaces() { + for mode in "${MODES[@]}"; do + ns_set_mode "${mode}0" "${mode}" + ns_set_mode "${mode}1" "${mode}" + + log_host "set ns ${mode}0 to mode ${mode}" + log_host "set ns ${mode}1 to mode ${mode}" + + # we need lo for qemu port forwarding + ip netns exec "${mode}0" ip link set dev lo up + ip netns exec "${mode}1" ip link set dev lo up + done +} + +del_namespaces() { + for mode in "${MODES[@]}"; do + ip netns del "${mode}0" + ip netns del "${mode}1" + log_host "removed ns ${mode}0" + log_host "removed ns ${mode}1" + done &>/dev/null +} + +ns_set_mode() { + local ns=$1 + local mode=$2 + + echo "${mode}" | ip netns exec "${ns}" \ + tee /proc/net/vsock_ns_mode &>/dev/null +} + vm_ssh() { - ssh -q -o UserKnownHostsFile=/dev/null -p ${SSH_HOST_PORT} localhost "$@" + local ns_exec + + if [[ "${1}" == none ]]; then + local ns_exec="" + else + local ns_exec="ip netns exec ${1}" + fi + + shift + + ${ns_exec} ssh -q -o UserKnownHostsFile=/dev/null -p ${SSH_HOST_PORT} localhost $* + return $? } cleanup() { - if [[ -s "${QEMU_PIDFILE}" ]]; then - pkill -SIGTERM -F "${QEMU_PIDFILE}" > /dev/null 2>&1 - fi + del_namespaces +} - # If failure occurred during or before qemu start up, then we need - # to clean this up ourselves. - if [[ -e "${QEMU_PIDFILE}" ]]; then - rm "${QEMU_PIDFILE}" - fi +terminate_pidfiles() { + local pidfile + + for pidfile in "$@"; do + if [[ -s "${pidfile}" ]]; then + pkill -SIGTERM -F "${pidfile}" 2>&1 > /dev/null + fi + + # If failure occurred during or before qemu start up, then we need + # to clean this up ourselves. + if [[ -e "${pidfile}" ]]; then + rm -f "${pidfile}" + fi + done +} + +terminate_pids() { + local pid + + for pid in "$@"; do + kill -SIGTERM "${pid}" &>/dev/null || : + done } check_args() {
@@ -133,7 +308,7 @@ check_args() { } check_deps() { - for dep in vng ${QEMU} busybox pkill ssh; do + for dep in vng ${QEMU} busybox pkill ssh socat; do if [[ ! -x $(command -v "${dep}") ]]; then echo -e "skip: dependency ${dep} not found!\n" exit "${KSFT_SKIP}"
@@ -170,6 +345,20 @@ check_vng() { fi } +check_socat() { + local support_string + + support_string="$(socat -V)" + + if [[ "${support_string}" != *"WITH_VSOCK 1"* ]]; then + die "err: socat is missing vsock support" + fi + + if [[ "${support_string}" != *"WITH_UNIX 1"* ]]; then + die "err: socat is missing unix support" + fi +} + handle_build() { if [[ ! "${BUILD}" -eq 1 ]]; then return
@@ -194,9 +383,14 @@ handle_build() { } vm_start() { + local cid=$1 + local ns=$2 + local pidfile=$3 local logfile=/dev/null local verbose_opt="" + local qemu_opts="" local kernel_opt="" + local ns_exec="" local qemu qemu=$(command -v "${QEMU}")
@@ -206,27 +400,37 @@ vm_start() { logfile=/dev/stdout fi + qemu_opts="\ + -netdev user,id=n0,${QEMU_TEST_PORT_FWD},${QEMU_SSH_PORT_FWD} \ + -device virtio-net-pci,netdev=n0 \ + ${QEMU_OPTS} -device vhost-vsock-pci,guest-cid=${cid} \ + --pidfile ${pidfile} + " + if [[ "${BUILD}" -eq 1 ]]; then kernel_opt="${KERNEL_CHECKOUT}" fi - vng \ + if [[ "${ns}" != "none" ]]; then + ns_exec="ip netns exec ${ns}" + fi + + ${ns_exec} vng \ --run \ ${kernel_opt} \ ${verbose_opt} \ - --qemu-opts="${QEMU_OPTS}" \ + --qemu-opts="${qemu_opts}" \ --qemu="${qemu}" \ --user root \ --append "${KERNEL_CMDLINE}" \ --rw &> ${logfile} & - if ! timeout ${WAIT_TOTAL} \ - bash -c 'while [[ ! -s '"${QEMU_PIDFILE}"' ]]; do sleep 1; done; exit 0'; then - die "failed to boot VM" - fi + timeout "${WAIT_QEMU}" \ + bash -c 'while [[ ! -s '"${pidfile}"' ]]; do sleep 1; done; exit 0' } vm_wait_for_ssh() { + local ns=$1 local i i=0
@@ -234,7 +438,8 @@ vm_wait_for_ssh() { if [[ ${i} -gt ${WAIT_PERIOD_MAX} ]]; then die "Timed out waiting for guest ssh" fi - if vm_ssh -- true; then + + if vm_ssh "${ns}" -- true; then break fi i=$(( i + 1 ))
@@ -269,6 +474,7 @@ wait_for_listener() grep -q "${pattern}"; then break fi + sleep "${interval}" done
@@ -278,17 +484,29 @@ wait_for_listener() } vm_wait_for_listener() { - local port=$1 + local ns=$1 + local port=$2 + + log "Waiting for listener on port ${port} on vm" - vm_ssh <<EOF + vm_ssh "${ns}" <<EOF $(declare -f wait_for_listener) wait_for_listener ${port} ${WAIT_PERIOD} ${WAIT_PERIOD_MAX} EOF } host_wait_for_listener() { - wait_for_listener "${TEST_HOST_PORT_LISTENER}" "${WAIT_PERIOD}" "${WAIT_PERIOD_MAX}" + local ns=$1 + local port=$2 + if [[ "${ns}" == none ]]; then + wait_for_listener "${port}" "${WAIT_PERIOD}" "${WAIT_PERIOD_MAX}" + else + ip netns exec "${ns}" bash <<-EOF + $(declare -f wait_for_listener) + wait_for_listener ${port} ${WAIT_PERIOD} ${WAIT_PERIOD_MAX} + EOF + fi } log() {
@@ -431,47 +649,499 @@ test_vm_loopback() { vm_vsock_test "none" "client" "127.0.0.1" 1 "${TEST_HOST_PORT_LISTENER}" } +test_host_vsock_ns_mode_ok() { + add_namespaces + + for mode in "${MODES[@]}"; do + if ! ns_set_mode "${mode}0" "${mode}"; then + del_namespaces + return "${KSFT_FAIL}" + fi + done + del_namespaces } -test_vm_client_host_server() { +test_host_vsock_ns_mode_write_once_ok() { + add_namespaces - ${VSOCK_TEST} \ - --mode "server" \ - --control-port "${TEST_HOST_PORT_LISTENER}" \ - --peer-cid "${VSOCK_CID}" 2>&1 | log_host & + for mode in "${MODES[@]}"; do + local ns="${mode}0" + if ! ns_set_mode "${ns}" "${mode}"; then + del_namespaces + return "${KSFT_FAIL}" + fi - host_wait_for_listener + # try writing again and expect failure + if ns_set_mode "${ns}" "${mode}"; then + del_namespaces + return "${KSFT_FAIL}" + fi + done - vm_ssh -- "${VSOCK_TEST}" \ - --mode=client \ - --control-host=10.0.2.2 \ - --peer-cid=2 \ - --control-port="${TEST_HOST_PORT_LISTENER}" 2>&1 | log_guest + del_namespaces - return $? + return "${KSFT_PASS}" } -test_vm_loopback() { - local port=60000 # non-forwarded local port +namespaces_can_boot_same_cid() { + local ns0=$1 + local ns1=$2 + local pidfile1 pidfile2 + local cid=20 + readonly cid + local rc - vm_ssh -- "${VSOCK_TEST}" \ - --mode=server \ - --control-port="${port}" \ - --peer-cid=1 2>&1 | log_guest & + pidfile1=$(mktemp /tmp/qemu_vsock_vmtest_XXXX.pid) + vm_start "${cid}" "${ns0}" "${pidfile1}" - vm_wait_for_listener "${port}" + pidfile2=$(mktemp /tmp/qemu_vsock_vmtest_XXXX.pid) + vm_start "${cid}" "${ns1}" "${pidfile2}" - vm_ssh -- "${VSOCK_TEST}" \ - --mode=client \ - --control-host="127.0.0.1" \ - --control-port="${port}" \ - --peer-cid=1 2>&1 | log_guest + rc=$? + terminate_pidfiles "${pidfile1}" "${pidfile2}" - return $? + return $rc +} + +test_global_same_cid_fails() { + if namespaces_can_boot_same_cid "global0" "global1"; then + return "${KSFT_FAIL}" + fi + + return "${KSFT_PASS}" +} + +test_local_global_same_cid_ok() { + if namespaces_can_boot_same_cid "local0" "global0"; then + return "${KSFT_PASS}" + fi + + return "${KSFT_FAIL}" +} + +test_global_local_same_cid_ok() { + if namespaces_can_boot_same_cid "global0" "local0"; then + return "${KSFT_PASS}" + fi + + return "${KSFT_FAIL}" +} + +test_local_same_cid_ok() { + if namespaces_can_boot_same_cid "local0" "local0"; then + return "${KSFT_FAIL}" + fi + + return "${KSFT_PASS}" +} + +test_diff_ns_global_host_connect_to_global_vm_ok() { + local pids pid pidfile + local ns0 ns1 port + declare -a pids + local unixfile + ns0="global0" + ns1="global1" + port=1234 + local rc + + pidfile=$(mktemp /tmp/qemu_vsock_vmtest_XXXX.pid) + + if ! vm_start "${VSOCK_CID}" "${ns0}" "${pidfile}"; then + return "${KSFT_FAIL}" + fi + + unixfile=$(mktemp -u /tmp/XXXX.sock) + ip netns exec "${ns1}" \ + socat TCP-LISTEN:"${TEST_HOST_PORT}",fork \ + UNIX-CONNECT:"${unixfile}" & + pids+=($!) + host_wait_for_listener "${ns1}" "${TEST_HOST_PORT}" + + ip netns exec "${ns0}" socat UNIX-LISTEN:"${unixfile}",fork \ + TCP-CONNECT:localhost:"${TEST_HOST_PORT}" & + pids+=($!) + + vm_vsock_test "${ns0}" "server" 2 "${TEST_GUEST_PORT}" + vm_wait_for_listener "${ns0}" "${TEST_GUEST_PORT}" + host_vsock_test "${ns1}" "client" "127.0.0.1" "${VSOCK_CID}" "${TEST_HOST_PORT}" + rc=$? + + for pid in "${pids[@]}"; do + if [[ "$(jobs -p)" = *"${pid}"* ]]; then + kill -SIGTERM "${pid}" &>/dev/null + fi + done + + terminate_pidfiles "${pidfile}" + + if [[ $rc -ne 0 ]]; then + return "${KSFT_FAIL}" + fi + + return "${KSFT_PASS}" } -run_test() { +test_diff_ns_global_host_connect_to_local_vm_fails() { + local ns0="global0" + local ns1="local0" + local port=12345 + local pidfile + local result + local pid + + outfile=$(mktemp) + + pidfile=$(mktemp /tmp/qemu_vsock_vmtest_XXXX.pid) + if ! vm_start "${VSOCK_CID}" "${ns1}" "${pidfile}"; then + log_host "failed to start vm (cid=${VSOCK_CID}, ns=${ns0})" + return $KSFT_FAIL + fi + + vm_wait_for_ssh "${ns1}" + vm_ssh "${ns1}" -- socat VSOCK-LISTEN:"${port}" STDOUT > "${outfile}" & + echo TEST | ip netns exec "${ns0}" \ + socat STDIN VSOCK-CONNECT:"${VSOCK_CID}":"${port}" 2>/dev/null + + terminate_pidfiles "${pidfile}" + + result=$(cat "${outfile}") + rm -f "${outfile}" + + if [[ "${result}" != TEST ]]; then + return $KSFT_PASS + fi + + return $KSFT_FAIL +} + +test_diff_ns_global_vm_connect_to_global_host_ok() { + local ns0="global0" + local ns1="global1" + local port=12345 + local unixfile + local pidfile + local pids + + declare -a pids + + log_host "Setup socat bridge from ns ${ns0} to ns ${ns1} over port ${port}" + + unixfile=$(mktemp -u /tmp/XXXX.sock) + + ip netns exec "${ns0}" \ + socat TCP-LISTEN:"${port}" UNIX-CONNECT:"${unixfile}" & + pids+=($!) + + ip netns exec "${ns1}" \ + socat UNIX-LISTEN:"${unixfile}" TCP-CONNECT:127.0.0.1:"${port}" & + pids+=($!) + + log_host "Launching ${VSOCK_TEST} in ns ${ns1}" + host_vsock_test "${ns1}" "server" "${VSOCK_CID}" "${port}" + + pidfile=$(mktemp /tmp/qemu_vsock_vmtest_XXXX.pid) + if ! vm_start "${VSOCK_CID}" "${ns0}" "${pidfile}"; then + log_host "failed to start vm (cid=${cid}, ns=${ns0})" + terminate_pids "${pids[@]}" + rm -f "${unixfile}" + return $KSFT_FAIL + fi + + vm_wait_for_ssh "${ns0}" + vm_vsock_test "${ns0}" "client" "10.0.2.2" 2 "${port}" + rc=$? + + terminate_pidfiles "${pidfile}" + terminate_pids "${pids[@]}" + rm -f "${unixfile}" + + if [[ ! $rc -eq 0 ]]; then + return "${KSFT_FAIL}" + fi + + return "${KSFT_PASS}" + +} + +test_diff_ns_global_vm_connect_to_local_host_fails() { + local ns0="global0" + local ns1="local0" + local port=12345 + local pidfile + local result + local pid + + log_host "Launching socat in ns ${ns1}" + outfile=$(mktemp) + ip netns exec "${ns1}" socat VSOCK-LISTEN:${port} STDOUT &> "${outfile}" & + pid=$! + + pidfile=$(mktemp /tmp/qemu_vsock_vmtest_XXXX.pid) + if ! vm_start "${VSOCK_CID}" "${ns0}" "${pidfile}"; then + log_host "failed to start vm (cid=${cid}, ns=${ns0})" + terminate_pids "${pid}" + rm -f "${outfile}" + return $KSFT_FAIL + fi + + vm_wait_for_ssh "${ns0}" + + vm_ssh "${ns0}" -- \ + bash -c "echo TEST | socat STDIN VSOCK-CONNECT:2:${port}" 2>&1 | log_guest + + terminate_pidfiles "${pidfile}" + terminate_pids "${pid}" + + result=$(cat "${outfile}") + rm -f "${outfile}" + + if [[ "${result}" != TEST ]]; then + return "${KSFT_PASS}" + fi + + return "${KSFT_FAIL}" +} + +test_diff_ns_local_host_connect_to_local_vm_fails() { + local ns0="local0" + local ns1="local1" + local port=12345 + local pidfile + local result + local pid + + outfile=$(mktemp) + + pidfile=$(mktemp /tmp/qemu_vsock_vmtest_XXXX.pid) + if ! vm_start "${VSOCK_CID}" "${ns1}" "${pidfile}"; then + log_host "failed to start vm (cid=${cid}, ns=${ns0})" + return $KSFT_FAIL + fi + + vm_wait_for_ssh "${ns1}" + vm_ssh "${ns1}" -- socat VSOCK-LISTEN:"${port}" STDOUT > "${outfile}" & + echo TEST | ip netns exec "${ns0}" \ + socat STDIN VSOCK-CONNECT:"${VSOCK_CID}":"${port}" 2>/dev/null + + terminate_pidfiles "${pidfile}" + + result=$(cat "${outfile}") + rm -f "${outfile}" + + if [[ "${result}" != TEST ]]; then + return $KSFT_PASS + fi + + return $KSFT_FAIL +} + +test_diff_ns_local_vm_connect_to_local_host_fails() { + local ns0="local0" + local ns1="local1" + local port=12345 + local pidfile + local result + local pid + + log_host "Launching socat in ns ${ns1}" + outfile=$(mktemp) + ip netns exec "${ns1}" socat VSOCK-LISTEN:"${port}" STDOUT &> "${outfile}" & + pid=$! + + pidfile=$(mktemp /tmp/qemu_vsock_vmtest_XXXX.pid) + if ! vm_start "${VSOCK_CID}" "${ns0}" "${pidfile}"; then + log_host "failed to start vm (cid=${cid}, ns=${ns0})" + rm -f "${outfile}" + return "${KSFT_FAIL}" + fi + + vm_wait_for_ssh "${ns0}" + + vm_ssh "${ns0}" -- \ + bash -c "echo TEST | socat STDIN VSOCK-CONNECT:2:${port}" 2>&1 | log_guest + + terminate_pidfiles "${pidfile}" + terminate_pids "${pid}" + + result=$(cat "${outfile}") + rm -f "${outfile}" + + if [[ "${result}" != TEST ]]; then + return "${KSFT_PASS}" + fi + + return "${KSFT_FAIL}" +} + +__test_loopback_two_netns() { + local ns0=$1 + local ns1=$2 + local port=12345 + local result + local pid + + log_host "Launching socat in ns ${ns1}" + outfile=$(mktemp) + ip netns exec "${ns1}" socat VSOCK-LISTEN:"${port}" STDOUT > "${outfile}" 2>/dev/null & + pid=$! + + log_host "Launching socat in ns ${ns0}" + echo TEST | ip netns exec "${ns0}" socat STDIN VSOCK-CONNECT:1:"${port}" 2>/dev/null + terminate_pids "${pid}" + + result=$(cat "${outfile}") + rm -f "${outfile}" + + if [[ "${result}" == TEST ]]; then + return 0 + fi + + return 1 +} + +test_diff_ns_global_to_local_loopback_local_fails() { + if ! __test_loopback_two_netns "global0" "local0"; then + return "${KSFT_PASS}" + fi + + return "${KSFT_FAIL}" +} + +test_diff_ns_local_to_global_loopback_fails() { + if ! __test_loopback_two_netns "local0" "global0"; then + return "${KSFT_PASS}" + fi + + return "${KSFT_FAIL}" +} + +test_diff_ns_local_to_local_loopback_fails() { + if ! __test_loopback_two_netns "local0" "local1"; then + return "${KSFT_PASS}" + fi + + return "${KSFT_FAIL}" +} + +test_diff_ns_global_to_global_loopback_ok() { + if __test_loopback_two_netns "global0" "global1"; then + return "${KSFT_PASS}" + fi + + return "${KSFT_FAIL}" +} + +test_same_ns_local_loopback_ok() { + if __test_loopback_two_netns "local0" "local0"; then + return "${KSFT_PASS}" + fi + + return "${KSFT_FAIL}" +} + +test_same_ns_local_host_connect_to_local_vm_ok() { + local ns="local0" + local port=1234 + local pidfile + local rc + + pidfile=$(mktemp /tmp/qemu_vsock_vmtest_XXXX.pid) + + if ! vm_start "${VSOCK_CID}" "${ns}" "${pidfile}"; then + return "${KSFT_FAIL}" + fi + + vm_vsock_test "${ns}" "server" 2 "${TEST_GUEST_PORT}" + host_vsock_test "${ns}" "client" "127.0.0.1" "${VSOCK_CID}" "${TEST_HOST_PORT}" + rc=$? + + terminate_pidfiles "${pidfile}" + + if [[ $rc -ne 0 ]]; then + return "${KSFT_FAIL}" + fi + + return "${KSFT_PASS}" +} + +test_same_ns_local_vm_connect_to_local_host_ok() { + local ns="local0" + local port=1234 + local pidfile + local rc + + pidfile=$(mktemp /tmp/qemu_vsock_vmtest_XXXX.pid) + + if ! vm_start "${VSOCK_CID}" "${ns}" "${pidfile}"; then + return "${KSFT_FAIL}" + fi + + vm_vsock_test "${ns}" "server" 2 "${TEST_GUEST_PORT}" + host_vsock_test "${ns}" "client" "127.0.0.1" "${VSOCK_CID}" "${TEST_HOST_PORT}" + rc=$? + + terminate_pidfiles "${pidfile}" + + if [[ $rc -ne 0 ]]; then + return "${KSFT_FAIL}" + fi + + return "${KSFT_PASS}" +} + +shared_vm_test() { + local tname + + tname="${1}" + + for testname in "${USE_SHARED_VM[@]}"; do + if [[ "${tname}" == "${testname}" ]]; then + return 0 + fi + done + + return 1 +} + + +init_netns_test() { + local tname + + tname="${1}" + + for testname in "${USE_INIT_NETNS[@]}"; do + if [[ "${tname}" == "${testname}" ]]; then + return 0 + fi + done + + return 1 +} + +check_result() { + local rc num + + rc=$1 + num=$(( cnt_total + 1 )) + + if [[ ${rc} -eq $KSFT_PASS ]]; then + cnt_pass=$(( cnt_pass + 1 )) + echo "ok ${num} ${arg}" + elif [[ ${rc} -eq $KSFT_SKIP ]]; then + cnt_skip=$(( cnt_skip + 1 )) + echo "ok ${num} ${arg} # SKIP" + elif [[ ${rc} -eq $KSFT_FAIL ]]; then + cnt_fail=$(( cnt_fail + 1 )) + echo "not ok ${num} ${arg} # exit=$rc" + fi + + cnt_total=$(( cnt_total + 1 )) +} + +run_shared_vm_tests() { + local start_shared_vm pidfile local host_oops_cnt_before local host_warn_cnt_before local vm_oops_cnt_before
@@ -483,40 +1153,90 @@ run_test() { local name local rc - host_oops_cnt_before=$(dmesg | grep -c -i 'Oops') - host_warn_cnt_before=$(dmesg --level=warn | wc -l) - vm_oops_cnt_before=$(vm_ssh -- dmesg | grep -c -i 'Oops') - vm_warn_cnt_before=$(vm_ssh -- dmesg --level=warn | wc -l) + start_shared_vm=0 - name=$(echo "${1}" | awk '{ print $1 }') - eval test_"${name}" - rc=$? + for arg in "${ARGS[@]}"; do + if shared_vm_test "${arg}"; then + start_shared_vm=1 + break + fi + done - host_oops_cnt_after=$(dmesg | grep -i 'Oops' | wc -l) - if [[ ${host_oops_cnt_after} -gt ${host_oops_cnt_before} ]]; then - echo "FAIL: kernel oops detected on host" | log_host "${name}" - rc=$KSFT_FAIL + pidfile="" + if [[ "${start_shared_vm}" == 1 ]]; then + pidfile=$(mktemp $PIDFILE_TEMPLATE) + log_host "Booting up VM" + vm_start "${VSOCK_CID}" "none" "${pidfile}" + vm_wait_for_ssh "none" + log_host "VM booted up" fi - host_warn_cnt_after=$(dmesg --level=warn | wc -l) - if [[ ${host_warn_cnt_after} -gt ${host_warn_cnt_before} ]]; then - echo "FAIL: kernel warning detected on host" | log_host "${name}" - rc=$KSFT_FAIL - fi + for arg in "${ARGS[@]}"; do + if ! shared_vm_test "${arg}"; then + continue + fi - vm_oops_cnt_after=$(vm_ssh -- dmesg | grep -i 'Oops' | wc -l) - if [[ ${vm_oops_cnt_after} -gt ${vm_oops_cnt_before} ]]; then - echo "FAIL: kernel oops detected on vm" | log_host "${name}" - rc=$KSFT_FAIL - fi + host_oops_cnt_before=$(dmesg | grep -c -i 'Oops') + host_warn_cnt_before=$(dmesg --level=warn | wc -l) + vm_oops_cnt_before=$(vm_ssh none -- dmesg | grep -c -i 'Oops') + vm_warn_cnt_before=$(vm_ssh none -- dmesg --level=warn | wc -l) + + name=$(echo "${arg}" | awk '{ print $1 }') + log_host "Executing test_${name}" + eval test_"${name}" + rc=$? + + host_oops_cnt_after=$(dmesg | grep -i 'Oops' | wc -l) + if [[ ${host_oops_cnt_after} -gt ${host_oops_cnt_before} ]]; then + echo "FAIL: kernel oops detected on host" | log_host "${name}" + rc=$KSFT_FAIL + fi + + host_warn_cnt_after=$(dmesg --level=warn | wc -l) + if [[ ${host_warn_cnt_after} -gt ${host_warn_cnt_before} ]]; then + echo "FAIL: kernel warning detected on host" | log_host "${name}" + rc=$KSFT_FAIL + fi - vm_warn_cnt_after=$(vm_ssh -- dmesg --level=warn | wc -l) - if [[ ${vm_warn_cnt_after} -gt ${vm_warn_cnt_before} ]]; then - echo "FAIL: kernel warning detected on vm" | log_host "${name}" - rc=$KSFT_FAIL + vm_oops_cnt_after=$(vm_ssh none -- dmesg | grep -i 'Oops' | wc -l) + if [[ ${vm_oops_cnt_after} -gt ${vm_oops_cnt_before} ]]; then + echo "FAIL: kernel oops detected on vm" | log_host "${name}" + rc=$KSFT_FAIL + fi + + vm_warn_cnt_after=$(vm_ssh none -- dmesg --level=warn | wc -l) + if [[ ${vm_warn_cnt_after} -gt ${vm_warn_cnt_before} ]]; then + echo "FAIL: kernel warning detected on vm" | log_host "${name}" + rc=$KSFT_FAIL + fi + + check_result "${rc}" + done + + if [[ -n "${pidfile}" ]]; then + log_host "VM terminate" + terminate_pidfiles "${pidfile}" fi +} + +run_isolated_vm_tests() { + for arg in "${ARGS[@]}"; do + if shared_vm_test "${arg}"; then + continue + fi - return "${rc}" + add_namespaces + if init_netns_test "${arg}"; then + init_namespaces + fi + + name=$(echo "${arg}" | awk '{ print $1 }') + log_host "Executing test_${name}" + eval test_"${name}" + check_result $? + + del_namespaces + done } QEMU="qemu-system-$(uname -m)"
@@ -543,34 +1263,13 @@ fi check_args "${ARGS[@]}" check_deps check_vng +check_socat handle_build echo "1..${#ARGS[@]}" -log_host "Booting up VM" -vm_start -vm_wait_for_ssh -log_host "VM booted up" - -cnt_pass=0 -cnt_fail=0 -cnt_skip=0 -cnt_total=0 -for arg in "${ARGS[@]}"; do - run_test "${arg}" - rc=$? - if [[ ${rc} -eq $KSFT_PASS ]]; then - cnt_pass=$(( cnt_pass + 1 )) - echo "ok ${cnt_total} ${arg}" - elif [[ ${rc} -eq $KSFT_SKIP ]]; then - cnt_skip=$(( cnt_skip + 1 )) - echo "ok ${cnt_total} ${arg} # SKIP" - elif [[ ${rc} -eq $KSFT_FAIL ]]; then - cnt_fail=$(( cnt_fail + 1 )) - echo "not ok ${cnt_total} ${arg} # exit=$rc" - fi - cnt_total=$(( cnt_total + 1 )) -done +run_shared_vm_tests +run_isolated_vm_tests echo "SUMMARY: PASS=${cnt_pass} SKIP=${cnt_skip} FAIL=${cnt_fail}" echo "Log: ${LOG}"
Signature · 1 line
2.47.3
On Tue, Aug 05, 2025 at 02:49:08PM -0700, Bobby Eshleman wrote:
...
Quoted 6 lines
Thanks again for everyone's help and reviews!
Changes in v4:
- removed RFC tag
My bad, I didn't notice I still had the rfc tag before sending out with b4.
This is ready for review and not really an RFC. All test cases passing, etc...
-Bobby
Simon Horman
reviewerQuoted 8 lines · Bobby Eshleman
On Tue, Aug 05, 2025 at 02:49:08PM -0700, Bobby Eshleman wrote:
...
Quoted 4 lines
Thanks again for everyone's help and reviews!
Quoted 8 lines
Quoted 2 lines
Changes in v4:
- removed RFC tagMy bad, I didn't notice I still had the rfc tag before sending out with b4.
This is ready for review and not really an RFC. All test cases passing, etc...
Ack. But net-next is currently closed for the merge-window.
So please don't post non-RFC patches for it until it reopens, around the 11th August.
Quoted 2 lines · Simon Horman
Quoted 1 line · Bobby Eshleman
On Tue, Aug 05, 2025 at 02:49:08PM -0700, Bobby Eshleman wrote:
...
Quoted 5 lines
Ack. But net-next is currently closed for the merge-window.
So please don't post non-RFC patches for it until it reopens, around the 11th August.
Got it, thanks!
Stefano Garzarella
maintainerHi Bobby,
Quoted 14 lines · Bobby Eshleman
This series adds namespace support to vhost-vsock. It does not add namespaces to any of the guest transports (virtio-vsock, hyperv, or vmci).
The current revision only supports two modes: local or global. Local mode is complete isolation of namespaces, while global mode is complete sharing between namespaces of CIDs (the original behavior).
Future may include supporting a mixed mode, which I expect to be more complicated because socket lookups will have to include new logic and API changes to behave differently based on if the lookup is part of a mixed mode CID allocation, a global CID allocation, a mixed-to-global connection (allowed), or a global-to-mixed connection (not allowed).
Quoted 8 lines
Modes are per-netns and write-once. This allows a system to configure namespaces independently (some may share CIDs, others are completely isolated). This also supports future mixed use cases, where there may be namespaces in global mode spinning up VMs while there are mixed mode namespaces that provide services to the VMs, but are not allowed to allocate from the global CID pool.
Thanks again for everyone's help and reviews!
Thanks for your work!
As I mentioned to you, I'll be off for the next 2 weeks, so I'll take a look when I'm back, but feel free to send new versions if you receive enough comments on this.
Thanks,
Stefano
Quoted 103 lines
Signed-off-by Bobby Eshleman <[email protected]>To: Stefano Garzarella <[email protected]>
To: Shuah Khan <[email protected]>
To: David S. Miller <[email protected]>
To: Eric Dumazet <[email protected]>
To: Jakub Kicinski <[email protected]>
To: Paolo Abeni <[email protected]>
To: Simon Horman <[email protected]>
To: Stefan Hajnoczi <[email protected]>
To: Michael S. Tsirkin <[email protected]>
To: Jason Wang <[email protected]>
To: Xuan Zhuo <[email protected]>
To: Eugenio Pérez <[email protected]>
To: K. Y. Srinivasan <[email protected]>
To: Haiyang Zhang <[email protected]>
To: Wei Liu <[email protected]>
To: Dexuan Cui <[email protected]>
To: Bryan Tan <[email protected]>
To: Vishnu Dasa <[email protected]>
To: Broadcom internal kernel review list <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]Changes in v4:
- removed RFC tag
- implemented loopback support
- renamed new tests to better reflect behavior
- completed suite of tests with permutations of ns modes andvsock_testas guest/host
- simplified socat bridging with unix socket instead of tcp + veth
- only usevsock_testfor success case, socat for failure case (context in commit message)
- lots of cleanupChanges in v3:
- add notion of "modes"
- add procfs/proc/net/vsock_ns_mode
- local and global modes only
- no/dev/vhost-vsock-netns
-vmtest.shalready merged, so new patch just adds new tests for NS
- Link to v2:
https://lore.kernel.org/kvm/[email protected]Changes in v2:
- only support vhost-vsock namespaces
- all g2h namespaces retain old behavior, only common API changes impacted by vhost-vsock changes
- add/dev/vhost-vsock-netnsfor "opt-in"
- leave/dev/vhost-vsockto old behavior
- removed netns module param
- Link to v1:
https://lore.kernel.org/r/[email protected]Changes in v1:
- added 'netns' module param to vsock.ko to enable the network namespace support (disabled by default)
- added 'vsock_net_eq()' to check the "net" assigned to a socket only when 'netns' support is enabled
- Link to RFC: https://patchwork.ozlabs.org/cover/1202235/---
Bobby Eshleman (12):
vsock: a per-net vsock NS mode state
vsock: add net to vsock skb cb
vsock: add netns toaf_vsockcore vsock/virtio: add netns to virtio transport common vhost/vsock: add netns support vsock/virtio: use the global netns
hv_sock: add netns hooks
vsock/vmci: add netns hooks vsock/loopback: add netns support selftests/vsock: improve logging invmtest.shselftests/vsock: invokevsock_testthrough helpers selftests/vsock: add namespace testsMAINTAINERS | 1 + drivers/vhost/vsock.c | 48 +- include/linux/virtio_vsock.h | 12 + include/net/af_vsock.h | 59 +- include/net/net_namespace.h | 4 + include/net/netns/vsock.h | 21 + net/vmw_vsock/af_vsock.c | 204 +++++- net/vmw_vsock/hyperv_transport.c | 2 +- net/vmw_vsock/virtio_transport.c | 5 +- net/vmw_vsock/virtio_transport_common.c | 14 +- net/vmw_vsock/vmci_transport.c | 4 +- net/vmw_vsock/vsock_loopback.c | 59 +- tools/testing/selftests/vsock/vmtest.sh | 1088 ++++++++++++++++++++++++++----- 13 files changed, 1330 insertions(+), 191 deletions(-)---
base-commit:dd500e4aecf25e48e874ca7628697969df679493
change-id: 20250325-vsock-vmtest-b3a21d2102c2Best regards,
Signature · 1 line
Bobby Eshleman <[email protected]>
Quoted 2 lines · Stefano Garzarella
Hi Bobby,
...
Quoted 10 lines
Thanks for your work!
As I mentioned to you, I'll be off for the next 2 weeks, so I'll take a look when I'm back, but feel free to send new versions if you receive enough comments on this.
Thanks,
Stefano
Thanks Stefano, enjoy your time off!
Best,
Bobby