f2fs: fix to return -EOPNOTSUPP for uncached write
Chao Yu
maintainerPATCH v2 1/1 f2fs: fix to return -EOPNOTSUPP for uncached write
f2fs doesn't support uncached write yet, for write() w/ IOCB_DONTCACHE flag, let's return -EOPNOTSUPP instead of ignoring IOCB_DONTCACHE flag and write w/o uncached IO.
---
v2:
- fix author info
fs/f2fs/file.c | 5 +++++ 1 file changed, 5 insertions(+)
fs/f2fs/file.c +5 -0
@@ -5185,6 +5185,11 @@ static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from) goto out; } +if (iocb->ki_flags &IOCB_DONTCACHE ) { + ret = -EOPNOTSUPP ; + goto out; + } +if (!f2fs_is_compress_backend_ready (inode)) { ret = -EOPNOTSUPP ; goto out;
Signature · 1 line
2.49.0
Quoted 3 lines · Chao Yu
f2fs doesn't support uncached write yet, for
write()w/IOCB_DONTCACHEflag, let's return-EOPNOTSUPPinstead of ignoringIOCB_DONTCACHEflag and write w/o uncached IO.
Didn't we agree that write support should be pursued first before bifurcating the read/write DONTCACHE support?
Signature · 1 line
Jens Axboe
Chao Yu
maintainerQuoted 7 lines · Jens Axboe
Quoted 3 lines · Chao Yu
f2fs doesn't support uncached write yet, for
write()w/IOCB_DONTCACHEflag, let's return-EOPNOTSUPPinstead of ignoringIOCB_DONTCACHEflag and write w/o uncached IO.Didn't we agree that write support should be pursued first before bifurcating the read/write DONTCACHE support?
Yeah, no worries, this is just used for test purpose, will drop this once Qi Han prepare the new patchset supporting dontcache in both read and write path. :)
Thanks,