drivers/soc/aspeed: Add AST27XX SoC ID support
Ryan Chen
reviewerPATCH 1/1 drivers/soc/aspeed: Add AST27XX SoC ID support
Extend the ASPEED SoC info driver to support AST27XX silicon IDs.
--- drivers/soc/aspeed/aspeed-socinfo.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/soc/aspeed/aspeed-socinfo.c +4 -0
@@ -27,6 +27,10 @@ static struct { { "AST2620", 0x05010203 }, { "AST2605", 0x05030103 }, { "AST2625", 0x05030403 }, +/* AST2700 */ + { "AST2750", 0x06000003 }, + { "AST2700", 0x06000103 }, + { "AST2720", 0x06000203 }, };static const char *siliconid_to_name (u32 siliconid)
Signature · 1 line
2.34.1
Andrew Jeffery
maintainerHi Ryan,
Regarding the patch subject, can you please follow the patterns established by other commits under drivers/soc ?
Separately, can we concentrate efforts on trying to get the platform definition bits upstream for the AST2700? Arnd's recent newsoc PR adds several new SoCs (as the tag name suggests), which is a helpful reference:
https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=soc-newsoc-6.17
Cheers,
Andrew
Quoted 22 lines · Ryan Chen
Extend the ASPEED SoC info driver to support AST27XX silicon IDs.
Signed-off-by Ryan Chen <[email protected]>---
drivers/soc/aspeed/aspeed-socinfo.c | 4 ++++1 file changed, 4 insertions(+)drivers/soc/aspeed/aspeed-socinfo.c +4
-0@@ -27,6 +27,10 @@ static struct { { "AST2620", 0x05010203 }, { "AST2605", 0x05030103 }, { "AST2625", 0x05030403 }, + /* AST2700 */ + { "AST2750", 0x06000003 }, + { "AST2700", 0x06000103 }, + { "AST2720", 0x06000203 }, };
static const char *siliconid_to_name(u32 siliconid)
Ryan Chen
reviewerQuoted 6 lines
Subject: Re: [PATCH]
drivers/soc/aspeed: Add AST27XX SoC ID supportHi Ryan,
Regarding the patch subject, can you please follow the patterns established by other commits under
drivers/soc?
My mistake.
Will update subject : Soc: aspeed: socinfo: Add AST27xx silicon IDs
Quoted 8 lines
Separately, can we concentrate efforts on trying to get the platform definition bits upstream for the AST2700? Arnd's recent newsoc PR adds several new SoCs (as the tag name suggests), which is a helpful
reference:https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=soc-newsoc-
6.17
Yes, will take look into this.
It will be my another patch reference for ast2700.
https://patchwork.ozlabs.org/project/linux-aspeed/list/?series=460647
Quoted 29 lines
Cheers,
Andrew
Quoted 23 lines · Ryan Chen
Extend the ASPEED SoC info driver to support AST27XX silicon IDs.
Signed-off-by Ryan Chen <[email protected]>---
drivers/soc/aspeed/aspeed-socinfo.c | 4 ++++1 file changed, 4 insertions(+)drivers/soc/aspeed/aspeed-socinfo.c +4
-0@@ -27,6 +27,10 @@ static struct { { "AST2620", 0x05010203 }, { "AST2605", 0x05030103 }, { "AST2625", 0x05030403 }, + /* AST2700 */ + { "AST2750", 0x06000003 }, + { "AST2700", 0x06000103 }, + { "AST2720", 0x06000203 }, }; static const char *siliconid_to_name(u32 siliconid)