Skip to contentSkip to conversation

mk: fix typo in module.mk

PATCH In review Li Wang via ltp 2 participants 3 messages Aug 2, 2025 – Aug 5, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mk: fix typo in module.mk

---
 include/mk/module.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/mk/module.mk +1 -1
index 10914084c..c3cbf9c21 100644
@@ -7,7 +7,7 @@
 # REQ_VERSION_MAJOR and REQ_VERSION_PATCH must be defined beforehand.
 
 $(if $(REQ_VERSION_MAJOR),,$(error You must define REQ_VERSION_MAJOR))
-$(if $(REQ_VERSION_PATCH),,$(error You must define REQ_VERSION_MINOR))
+$(if $(REQ_VERSION_PATCH),,$(error You must define REQ_VERSION_PATCH))
 
 ifeq ($(WITH_MODULES),no)
 SKIP := 1
Signature · 5 lines
2.50.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v1 1/1
#1 lore raw

Hi Li,

Quoted 3 lines

$(if $(REQ_VERSION_MAJOR),,$(error You must define REQ_VERSION_MAJOR))
-$(if $(REQ_VERSION_PATCH),,$(error You must define REQ_VERSION_MINOR)) +$(if $(REQ_VERSION_PATCH),,$(error You must define REQ_VERSION_PATCH))

Good catch!

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
author Applied
#2 lore raw
Quoted 10 lines · Petr Vorel

Hi Li,

Quoted 3 lines

$(if $(REQ_VERSION_MAJOR),,$(error You must define REQ_VERSION_MAJOR))
-$(if $(REQ_VERSION_PATCH),,$(error You must define REQ_VERSION_MINOR)) +$(if $(REQ_VERSION_PATCH),,$(error You must define REQ_VERSION_PATCH))

Good catch!

Merged, thanks!

Signature · 5 lines
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp