Hid: Intel-thc-hid: Intel-quicki2c: Enhance driver re-install flow
Subsystems (2)
Even Xu
maintainerPATCH 1/1 Hid: Intel-thc-hid: Intel-quicki2c: Enhance driver re-install flow
After driver module is removed and during re-install stage, if there is continueous user touching on the screen, it is a risk impacting THC hardware initialization which causes driver installation failure.
This patch enhances this flow by quiescing the external touch interrupt after driver is removed which keeps THC hardware ignore external interrupt during this remove and re-install stage.
--- drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c | 1 + 1 file changed, 1 insertion(+)
drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c +1 -0
@@ -419,6 +419,7 @@ static struct quicki2c_device *quicki2c_dev_init(struct pci_dev *pdev, void __io*/ static void quicki2c_dev_deinit (struct quicki2c_device *qcdev) { +thc_interrupt_quiesce (qcdev->thc_hw, true);thc_interrupt_enable (qcdev->thc_hw, false);thc_ltr_unconfig (qcdev->thc_hw);thc_wot_unconfig (qcdev->thc_hw);
Signature · 1 line
2.40.1
Quoted 11 lines · Even Xu
After driver module is removed and during re-install stage, if there is continueous user touching on the screen, it is a risk impacting THC hardware initialization which causes driver installation failure.
This patch enhances this flow by quiescing the external touch interrupt after driver is removed which keeps THC hardware ignore external interrupt during this remove and re-install stage.
Signed-off-by Even Xu <[email protected]>Tested-by Rui Zhang <[email protected]>Fixes 66b59bfce6d9 ("HID: intel-thc-hid: intel-quicki2c: Complete THC QuickI2C driver")
(please use the uppercase/lowercase in shortlog consistently with how HID subsystem has been using it ... I've fixed that manually for this one).
Applied to hid.git#for-6.17/upstream-fixes, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs