Skip to contentSkip to conversation

convert sound: realtek: alc5623 from txt to yaml

PATCH In review Mahdi Khosravi 2 participants 4 messages Jul 30, 2025 – Aug 6, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 convert sound: realtek: alc5623 from txt to yaml

I converted the alc5623 audio codec binding from text to DT schema. This is my first try and I used make dt_binding_check & make dtbs_check to verify without getting any errors.

---
 .../devicetree/bindings/sound/alc5623.txt     | 25 ----------
 .../bindings/sound/realtek,alc5623.yaml       | 49 +++++++++++++++++++
 2 files changed, 49 insertions(+), 25 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/alc5623.txt
 create mode 100644 Documentation/devicetree/bindings/sound/realtek,alc5623.yaml
Documentation/devicetree/bindings/sound/alc5623.txt deleted +0 -25
deleted file mode 100644
index 26c86c98d671..000000000000
@@ -1,25 +0,0 @@
-ALC5621/ALC5622/ALC5623 audio Codec
-
-Required properties:
-
- - compatible:	"realtek,alc5623"
- - reg:		the I2C address of the device.
-
-Optional properties:
-
- - add-ctrl:	  Default register value for Reg-40h, Additional Control
-		  Register. If absent or has the value of 0, the
-		  register is untouched.
-
- - jack-det-ctrl: Default register value for Reg-5Ah, Jack Detect
-		  Control Register. If absent or has value 0, the
-		  register is untouched.
-
-Example:
-
-	alc5621: alc5621@1a {
-		compatible = "alc5621";
-		reg = <0x1a>;
-		add-ctrl = <0x3700>;
-		jack-det-ctrl = <0x4810>;
-	};
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml new file +49 -0

49 lines not on this page · raw message

Signature · 1 line
2.50.1
#1 lore raw
Quoted 3 lines · Mahdi Khosravi

I converted the alc5623 audio codec binding from text to DT schema. This is my first try and I used make dt_binding_check & make dtbs_check to verify without getting any errors.

Take a look at your compatible and then look at your example. realtek,alc5632 is completely different. Just DTS using it in the kernel.

Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Documentation/devicetree/bindings/sound/realtek,alc5623.yaml line 7

Quoted 13 lines
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml new file +7 -0
new file mode 100644
index 000000000000..98524d06458c
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/realtek,alc5623.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ALC5621/ALC5622/ALC5623 audio Codec

s/audio/Audio/. Keep it consistent.

Documentation/devicetree/bindings/sound/realtek,alc5623.yaml line 10

Quoted 3 lines
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml new file +3 -0
+
+maintainers:
+  - Mahdi Khosravi <[email protected]>

That's DAI, no? At least looking at driver? Then you miss dai-common reference.

Quoted 9 lines
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml new file +9 -0
+
+properties:
+  compatible:
+    const: realtek,alc5623
+
+  reg:
+    maxItems: 1
+
+  add-ctrl:

Documentation/devicetree/bindings/sound/realtek,alc5623.yaml line 29

Quoted 10 lines
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml new file +10 -0
+    description:
+      Default register value for Reg-40h, Additional Control Register. If absent
+      or has the value of 0, the register is untouched.
+    type: object
+
+  jack-det-ctrl:
+    description:
+      Default register value for Reg-5Ah, Jack Detect Control Register. If absent
+      or has value 0, the register is untouched.
+    type: object

None of these are objects. This wasn't tested due to your compatible issue. :/

Documentation/devicetree/bindings/sound/realtek,alc5623.yaml line 35

Quoted 6 lines
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml new file +6 -0
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false

unevaluatedProperties after adding dai-common ref.

Documentation/devicetree/bindings/sound/realtek,alc5623.yaml line 44

Quoted 9 lines
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml new file +9 -0
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec@1a {
+            compatible = "realtek,alc5632";

Best regards,
Krzysztof

#2 lore raw

PATCH v2 1/1 ASoC: dt-bindings: realtek,alc5623: convert binding to YAML

In reply to Mahdi Khosravi

I converted the alc5623 audio codec binding from text to DT schema. This is my first try and I used make dt_binding_check & make dtbs_check to verify without getting any errors.

Changes since v1:
- Add dai-common ref
- switch add-ctrl/jack-det-ctrl to allOf uint32
- use unevaluatedProperties
- fix example compatible

---
 .../devicetree/bindings/sound/alc5623.txt     | 25 ---------
 .../bindings/sound/realtek,alc5623.yaml       | 54 +++++++++++++++++++
 2 files changed, 54 insertions(+), 25 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/alc5623.txt
 create mode 100644 Documentation/devicetree/bindings/sound/realtek,alc5623.yaml
Documentation/devicetree/bindings/sound/alc5623.txt deleted +0 -25
deleted file mode 100644
index 26c86c98d671..000000000000
@@ -1,25 +0,0 @@
-ALC5621/ALC5622/ALC5623 audio Codec
-
-Required properties:
-
- - compatible:	"realtek,alc5623"
- - reg:		the I2C address of the device.
-
-Optional properties:
-
- - add-ctrl:	  Default register value for Reg-40h, Additional Control
-		  Register. If absent or has the value of 0, the
-		  register is untouched.
-
- - jack-det-ctrl: Default register value for Reg-5Ah, Jack Detect
-		  Control Register. If absent or has value 0, the
-		  register is untouched.
-
-Example:
-
-	alc5621: alc5621@1a {
-		compatible = "alc5621";
-		reg = <0x1a>;
-		add-ctrl = <0x3700>;
-		jack-det-ctrl = <0x4810>;
-	};
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml new file +54 -0

54 lines not on this page · raw message

Signature · 1 line
2.50.1
#3 lore raw

Re: [PATCH v2] ASoC: dt-bindings: realtek,alc5623: convert binding to YAML

Quoted 3 lines · Mahdi Khosravi

I converted the alc5623 audio codec binding from text to DT schema. This is my first try and I used make dt_binding_check & make dtbs_check to verify without getting any errors.

Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets.

Quoted 2 lines

Changes since v1:

This goes to changelog, so under ---.

Quoted 4 lines

- Add dai-common ref
- switch add-ctrl/jack-det-ctrl to allOf uint32
- use unevaluatedProperties
- fix example compatible

Subject: "convert to DT Schema"
Not to YAML.

Quoted 3 lines

---

...

Quoted 19 lines
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml new file +13 -0
new file mode 100644
index 000000000000..0b9dc324f04d
@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/realtek,alc5623.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ALC5621/ALC5622/ALC5623 Audio Codec
+
+maintainers:
+  - Mahdi Khosravi <[email protected]>
+
+allOf:
+  - $ref: dai-common.yaml#

Documentation/devicetree/bindings/sound/realtek,alc5623.yaml line 23

Quoted 10 lines
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml new file +10 -0
+
+properties:
+  compatible:
+    const: realtek,alc5623
+
+  reg:
+    maxItems: 1
+
+  add-ctrl:
+    description: >

Why did > appear?

Documentation/devicetree/bindings/sound/realtek,alc5623.yaml line 26

Quoted 3 lines
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml new file +3 -0
+      Default register value for Reg-40h, Additional Control Register.
+      If absent or zero, the register is left untouched.
+    allOf:

Drop allOf, just $ref. Look at other bindings or example-schema.

Documentation/devicetree/bindings/sound/realtek,alc5623.yaml line 35

Quoted 9 lines
Documentation/devicetree/bindings/sound/realtek,alc5623.yaml new file +9 -0
+      - $ref: /schemas/types.yaml#/definitions/uint32
+
+  jack-det-ctrl:
+    description: >
+      Default register value for Reg-5Ah, Jack Detect Control Register.
+      If absent or zero, the register is left untouched.
+    allOf:
+      - $ref: /schemas/types.yaml#/definitions/uint32
+

Best regards,
Krzysztof