Skip to contentSkip to conversation

net/ice: fix Rx vector offload flags

PATCH In review Bruce Richardson 2 participants 3 messages Aug 7, 2025 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/ice: fix Rx vector offload flags

The vector PMD datapaths for ice do not support QinQ, so we need to update the vector offload flags to not use the general RX_OFFLOAD_VLAN flag (which sets all vlan-related options) and replace it with the individually supported VLAN options.

Fixes 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path")
---
 drivers/net/intel/ice/ice_rxtx_vec_common.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/intel/ice/ice_rxtx_vec_common.h +2 -1
index 9430a99ba5..e41fd8fc7c 100644
@@ -72,7 +72,8 @@ _ice_rx_queue_release_mbufs_vec(struct ci_rx_queue *rxq)
 #define ICE_RX_VECTOR_OFFLOAD (				\
 		RTE_ETH_RX_OFFLOAD_CHECKSUM |		\
 		RTE_ETH_RX_OFFLOAD_SCTP_CKSUM |		\
-		RTE_ETH_RX_OFFLOAD_VLAN |			\
+		RTE_ETH_RX_OFFLOAD_VLAN_STRIP |		\
+		RTE_ETH_RX_OFFLOAD_VLAN_FILTER |	\
 		RTE_ETH_RX_OFFLOAD_RSS_HASH)
 
 #define ICE_VECTOR_PATH		0
Signature · 1 line
2.48.1
Acked-by on v1 1/1
#1 lore raw
Quoted 29 lines

The vector PMD datapaths for ice do not support QinQ, so we need to update the vector offload flags to not use the general RX_OFFLOAD_VLAN flag (which sets all vlan-related options) and replace it with the individually supported VLAN options.

Fixes 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path")
---
 drivers/net/intel/ice/ice_rxtx_vec_common.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/intel/ice/ice_rxtx_vec_common.h +2 -1
index 9430a99ba5..e41fd8fc7c 100644
@@ -72,7 +72,8 @@ _ice_rx_queue_release_mbufs_vec(struct ci_rx_queue
 *rxq)
 #define ICE_RX_VECTOR_OFFLOAD (				\
 		RTE_ETH_RX_OFFLOAD_CHECKSUM |		\
 		RTE_ETH_RX_OFFLOAD_SCTP_CKSUM |		\
-		RTE_ETH_RX_OFFLOAD_VLAN |			\
+		RTE_ETH_RX_OFFLOAD_VLAN_STRIP |		\
+		RTE_ETH_RX_OFFLOAD_VLAN_FILTER |	\
 		RTE_ETH_RX_OFFLOAD_RSS_HASH)
 
Quoted 3 lines

#define ICE_VECTOR_PATH 0
--
2.48.1

LGTM.

author Applied
#2 lore raw
Quoted 29 lines · Ciara
Quoted 29 lines

The vector PMD datapaths for ice do not support QinQ, so we need to update the vector offload flags to not use the general RX_OFFLOAD_VLAN flag (which sets all vlan-related options) and replace it with the individually supported VLAN options.

Fixes 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path")
---
 drivers/net/intel/ice/ice_rxtx_vec_common.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/intel/ice/ice_rxtx_vec_common.h +2 -1
index 9430a99ba5..e41fd8fc7c 100644
@@ -72,7 +72,8 @@ _ice_rx_queue_release_mbufs_vec(struct ci_rx_queue
 *rxq)
 #define ICE_RX_VECTOR_OFFLOAD (				\
 		RTE_ETH_RX_OFFLOAD_CHECKSUM |		\
 		RTE_ETH_RX_OFFLOAD_SCTP_CKSUM |		\
-		RTE_ETH_RX_OFFLOAD_VLAN |			\
+		RTE_ETH_RX_OFFLOAD_VLAN_STRIP |		\
+		RTE_ETH_RX_OFFLOAD_VLAN_FILTER |	\
 		RTE_ETH_RX_OFFLOAD_RSS_HASH)
 
Quoted 8 lines
Quoted 3 lines

#define ICE_VECTOR_PATH 0
--
2.48.1

LGTM.

Applied to dpdk-next-net-intel.

/Bruce