Skip to contentSkip to conversation

dt-bindings: mfd: aspeed-lpc: Add missing "clocks" property on lpc-snoop node

PATCH Applied Rob Herring (Arm) 3 participants 3 messages Aug 7, 2025 – Sep 2, 2025

Subsystems (3)
Device tree bindings Multifunction devices (MFD) Arm/Aspeed machine support
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: mfd: aspeed-lpc: Add missing "clocks" property on lpc-snoop node

The ASpeed lpc-snoop nodes have a "clocks" property which isn't documented. It looks like all the LPC child devices have the same clock source. Perhaps it is the parent device that should have the clock, but it's too late for that. The driver for lpc-snoop requires a clock to be present.

Signed-off-by Rob Herring (Arm) <[email protected]>
---
 Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml +3 -0
index d88854e60b7f..f329223cec07 100644
@@ -137,6 +137,9 @@ patternProperties:
       reg:
         maxItems: 1
 
+      clocks:
+        maxItems: 1
+
       interrupts:
         maxItems: 1
Signature · 1 line
2.47.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Rob Herring (Arm)

The ASpeed lpc-snoop nodes have a "clocks" property which isn't documented. It looks like all the LPC child devices have the same clock source. Perhaps it is the parent device that should have the clock, but it's too late for that. The driver for lpc-snoop requires a clock to be present.

Signed-off-by Rob Herring (Arm) <[email protected]>

Thanks Rob.

Acked-by Andrew Jeffery <[email protected]>
maintainer Applied
#2 lore raw

Re: (subset) [PATCH] dt-bindings: mfd: aspeed-lpc: Add missing "clocks" property on lpc-snoop node

In reply to Rob Herring (Arm)
Quoted 8 lines · Rob Herring (Arm)

The ASpeed lpc-snoop nodes have a "clocks" property which isn't documented. It looks like all the LPC child devices have the same clock source. Perhaps it is the parent device that should have the clock, but it's too late for that. The driver for lpc-snoop requires a clock to be present.

[...]

Applied, thanks!

[1/1] dt-bindings: mfd: aspeed-lpc: Add missing "clocks" property on lpc-snoop node

      commit: 737b9ec4514ea0423eb049a3c27d8a22d61d03b5

--
Lee Jones [李琼斯]