Skip to contentSkip to conversation

ASoC: codec: sma1307: replace spelling mistake with new error message

PATCH In review Colin Ian King 2 participants 5 messages Aug 8, 2025 – Aug 12, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: codec: sma1307: replace spelling mistake with new error message

There is a spelling mistake in a failure message, replace the message with something a little more meaningful.

---
 sound/soc/codecs/sma1307.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/sma1307.c +1 -1
index b3d401ada176..6a601e7134ea 100644
@@ -1749,7 +1749,7 @@ static void sma1307_setting_loaded(struct sma1307_priv *sma1307, const char *fil
 	       sma1307->set.header_size * sizeof(int));
 
 	if ((sma1307->set.checksum >> 8) != SMA1307_SETTING_CHECKSUM) {
-		dev_err(sma1307->dev, "%s: failed by dismatch \"%s\"\n",
+		dev_err(sma1307->dev, "%s: checksum failed \"%s\"\n",
 			__func__, setting_file);
 		sma1307->set.status = false;
 		return;
Signature · 1 line
2.50.1
maintainer
#1 lore raw

sound/soc/codecs/sma1307.c static void sma1307_setting_loaded(struct sma1307_priv *sma1307, const char *fil · line 1752

Quoted 6 lines · Colin Ian King

There is a spelling mistake in a failure message, replace the message with something a little more meaningful.

sound/soc/codecs/sma1307.c +1 -1
 	if ((sma1307->set.checksum >> 8) != SMA1307_SETTING_CHECKSUM) {
-		dev_err(sma1307->dev, "%s: failed by dismatch \"%s\"\n",
+		dev_err(sma1307->dev, "%s: checksum failed \"%s\"\n",

It's definitely an unusual term and the reword makes sense but that does make sense to me as a word, I don't think it's a spelling error as such.

#2 lore raw
Quoted 11 lines · Mark Brown

sound/soc/codecs/sma1307.c static void sma1307_setting_loaded(struct sma1307_priv *sma1307, const char *fil · line 1752

Quoted 6 lines · Colin Ian King

There is a spelling mistake in a failure message, replace the message with something a little more meaningful.

  	if ((sma1307->set.checksum >> 8) != SMA1307_SETTING_CHECKSUM) {
sound/soc/codecs/sma1307.c +1 -1
-		dev_err(sma1307->dev, "%s: failed by dismatch \"%s\"\n",
+		dev_err(sma1307->dev, "%s: checksum failed \"%s\"\n",

It's definitely an unusual term and the reword makes sense but that does make sense to me as a word, I don't think it's a spelling error as such.

"Dismatch" is not a standard English word. It's likely a misspelling of "mismatch" or a neologism formed by adding the prefix "dis-" to "match". I understand it a niche term, I just think it is preferable not to use it for folk who's first language isn't English.

Colin

maintainer
#3 lore raw
Quoted 9 lines · Colin King (gmail)
Quoted 7 lines · Mark Brown

sound/soc/codecs/sma1307.c static void sma1307_setting_loaded(struct sma1307_priv *sma1307, const char *fil · line 1752

Quoted 2 lines · Colin Ian King
sound/soc/codecs/sma1307.c +1 -1
-		dev_err(sma1307->dev, "%s: failed by dismatch \"%s\"\n",
+		dev_err(sma1307->dev, "%s: checksum failed \"%s\"\n",

It's definitely an unusual term and the reword makes sense but that does make sense to me as a word, I don't think it's a spelling error as such.

Quoted 4 lines

"Dismatch" is not a standard English word. It's likely a misspelling of "mismatch" or a neologism formed by adding the prefix "dis-" to "match". I understand it a niche term, I just think it is preferable not to use it for folk who's first language isn't English.

My comment was specifically that it doesn't look like a spelling mistake.

maintainer
#4 lore raw
In reply to Colin Ian King
Quoted 4 lines · Colin Ian King

There is a spelling mistake in a failure message, replace the message with something a little more meaningful.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: codec: sma1307: replace spelling mistake with new error message

      commit: 7cdadac0d2b3614d04651be7104a89a1998efec0

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark