iio: adc: ad799x: reference voltage capability
Subsystems (2)
v2 cover iio: adc: ad799x: reference voltage capability
This patch series refactors 6b104e7895ab16b9b7f466c5f2ca282b87f661e8 in order to add the capability of the chip to have an external reference voltage into the chip_info struct.
And so avoid ugly conditional checks on the chip id.
In addition the AD7994 is marked to have the external reference voltage as well.
Changes in v2 compared to v1 [1]:
* remove has_vref from the chips that do not support it, rely on the default false value
* remove useless message "Supplied reference not supported" shown for all the chips with has_vref = false
* refactor check on regulator being err or zero
* add external reference to ad7994 as oneliner
[1] https://lore.kernel.org/linux-iio/[email protected]/
Stefano Manni (2):
iio: adc: ad799x: add reference voltage capability to chip_info
iio: adc: ad799x: add reference voltage to ad7994
drivers/iio/adc/ad799x.c | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-)
Signature · 1 line
2.48.1
PATCH v2 1/2 iio: adc: ad799x: add reference voltage capability to chip_info
If the chip supports an external reference voltage on REFIN pin then the "vref-supply" regulator may be used.
This commit partially refactors 6b104e7895ab16b9b7f466c5f2ca282b87f661e8 to add the capability of the chip to have an external voltage reference and then remove the ugly conditional check on chip id.
--- drivers/iio/adc/ad799x.c | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-)
drivers/iio/adc/ad799x.c +12 -17
@@ -114,11 +114,13 @@ struct ad799x_chip_config {* @num_channels: number of channels * @noirq_config: device configuration w/o IRQ * @irq_config: device configuration w/IRQ +* @has_vref: device supports external reference voltage */ struct ad799x_chip_info {int num_channels;const struct ad799x_chip_config noirq_config;const struct ad799x_chip_config irq_config; +bool has_vref; };struct ad799x_state {
@@ -604,6 +606,7 @@ static const struct iio_event_spec ad799x_events[] = {static const struct ad799x_chip_info ad799x_chip_info_tbl[] = { [ad7991] = { .num_channels =5 , + .has_vref = true, .noirq_config = { .channel = {AD799X_CHANNEL (0 ,12 ),
@@ -617,6 +620,7 @@ static const struct ad799x_chip_info ad799x_chip_info_tbl[] = { }, [ad7995] = { .num_channels = 5, + .has_vref = true, .noirq_config = { .channel = { AD799X_CHANNEL(0, 10),
@@ -630,6 +634,7 @@ static const struct ad799x_chip_info ad799x_chip_info_tbl[] = { }, [ad7999] = { .num_channels = 5, + .has_vref = true, .noirq_config = { .channel = { AD799X_CHANNEL(0, 8),
@@ -809,32 +814,22 @@ static int ad799x_probe(struct i2c_client *client)return ret;/* check if an external reference is supplied */ - st->vref =devm_regulator_get_optional (&client->dev,"vref" ); - -if (IS_ERR (st->vref)) { -if (PTR_ERR (st->vref) == -ENODEV ) { +if (chip_info->has_vref) { + st->vref =devm_regulator_get_optional (&client->dev,"vref" ); + ret =PTR_ERR_OR_ZERO (st->vref); +if (ret) { +if (ret != -ENODEV ) + goto error_disable_reg; st->vref =NULL ;dev_info (&client->dev,"Using VCC reference voltage\n" ); - }else { - ret =PTR_ERR (st->vref); - goto error_disable_reg; } - } -if (st->vref) { -/* -* Use external reference voltage if supported by hardware. -* This is optional if voltage / regulator present, use VCC otherwise. -*/ -if ((st->id == ad7991) || (st->id == ad7995) || (st->id == ad7999)) { +if (st->vref) {dev_info (&client->dev,"Using external reference voltage\n" ); extra_config |=AD7991_REF_SEL ; ret =regulator_enable (st->vref);if (ret) goto error_disable_reg; - }else { - st->vref =NULL ; -dev_warn (&client->dev,"Supplied reference not supported\n" ); } }
Signature · 1 line
2.48.1
Re: [PATCH v2 1/2] iio: adc: ad799x: add reference voltage capability to chip_info
Quoted 8 lines · Stefano Manni
If the chip supports an external reference voltage on REFIN pin then the "vref-supply" regulator may be used.
This commit partially refactors
6b104e7895ab16b9b7f466c5f2ca282b87f661e8to add the capability of the chip to have an external voltage reference and then remove the ugly conditional check on chip id.
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH v2 2/2 iio: adc: ad799x: add reference voltage to ad7994
In reply to Stefano ManniAD7994 supports external reference voltage on REFIN pin so if a vref-supply has been defined it shall be used.
--- drivers/iio/adc/ad799x.c | 1 + 1 file changed, 1 insertion(+)
drivers/iio/adc/ad799x.c +1 -0
@@ -692,6 +692,7 @@ static const struct ad799x_chip_info ad799x_chip_info_tbl[] = { }, [ad7994] = { .num_channels = 5, + .has_vref = true, .noirq_config = { .channel = { AD799X_CHANNEL(0, 12),
Signature · 1 line
2.48.1
Re: [PATCH v2 2/2] iio: adc: ad799x: add reference voltage to ad7994
Quoted 4 lines · Stefano Manni
AD7994 supports external reference voltage on REFIN pin so if a vref-supply has been defined it shall be used.
Now LGTM
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 16 lines · Stefano Manni
This patch series refactors
6b104e7895ab16b9b7f466c5f2ca282b87f661e8in order to add the capability of the chip to have an external reference voltage into thechip_infostruct.
And so avoid ugly conditional checks on the chip id.In addition the AD7994 is marked to have the external reference voltage as well.
Changes in v2 compared to v1 [1]:
* removehas_vreffrom the chips that do not support it, rely on the default false value
* remove useless message "Supplied reference not supported" shown for all the chips withhas_vref= false
* refactor check on regulator being err or zero
* add external reference to ad7994 as oneliner
Quoted 9 lines
[1] https://lore.kernel.org/linux-iio/[email protected]/
Stefano Manni (2):
iio: adc: ad799x: add reference voltage capability tochip_info
iio: adc: ad799x: add reference voltage to ad7994drivers/iio/adc/ad799x.c | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-)
Jonathan Cameron
maintainerQuoted 23 lines · On Thu, 7 Aug 2025 10:47:29 -0500 David Lechner <[email protected]> wrote:
Quoted 22 lines · Stefano Manni
This patch series refactors
6b104e7895ab16b9b7f466c5f2ca282b87f661e8in order to add the capability of the chip to have an external reference voltage into thechip_infostruct.
And so avoid ugly conditional checks on the chip id.In addition the AD7994 is marked to have the external reference voltage as well.
Changes in v2 compared to v1 [1]:
* removehas_vreffrom the chips that do not support it, rely on the default false value
* remove useless message "Supplied reference not supported" shown for all the chips withhas_vref= false
* refactor check on regulator being err or zero
* add external reference to ad7994 as oneliner[1] https://lore.kernel.org/linux-iio/[email protected]/
Stefano Manni (2):
iio: adc: ad799x: add reference voltage capability tochip_info
iio: adc: ad799x: add reference voltage to ad7994
Quoted 6 lines
Quoted 3 lines
drivers/iio/adc/ad799x.c | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-)Reviewed-by David Lechner <[email protected]>
Applied to the testing branch of iio.git. I'll rebase on rc1 once it's available.
thanks,
Jonathan