Skip to contentSkip to conversation

drm/tests: modeset: Add drm connector atomic_[duplicate/destroy]_state

PATCH Superseded Xiaolei Wang 3 participants 3 messages Aug 11, 2025 – Aug 21, 2025

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/tests: modeset: Add drm connector atomic_[duplicate/destroy]_state

Commit 66671944e176 ("drm/tests: helpers: Add atomic helpers") added the atomic state path, so adding the drm connector atomic_[duplicate/destroy]_state is also necessary.

WARNING: CPU: 0 PID: 96 at drivers/gpu/drm/drm_connector.c:234 drm_connector_init_only+0x934/0xee0
 Call trace:
  drm_connector_init_only+0x934/0xee0 (P)
  drmm_connector_init+0xe0/0x1b0
  drm_client_modeset_test_init+0x290/0x534
  kunit_try_run_case+0x110/0x3b4
  kunit_generic_run_threadfn_adapter+0x80/0xec
  kthread+0x3b8/0x6c0
  ret_from_fork+0x10/0x20
---
 drivers/gpu/drm/tests/drm_client_modeset_test.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/tests/drm_client_modeset_test.c +4 -0
index 3f44fe5e92e4..e702a27c2368 100644
@@ -12,6 +12,7 @@
 #include <drm/drm_modes.h>
 #include <drm/drm_modeset_helper_vtables.h>
 #include <drm/drm_probe_helper.h>
+#include <drm/drm_atomic_state_helper.h>
 
 struct drm_client_modeset_test_priv {
 	struct drm_device *drm;
@@ -48,6 +49,9 @@ static const struct drm_connector_helper_funcs drm_client_modeset_connector_help
 };
 
 static const struct drm_connector_funcs drm_client_modeset_connector_funcs = {
+	.reset                  = drm_atomic_helper_connector_reset,
+	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
+	.atomic_destroy_state   = drm_atomic_helper_connector_destroy_state,
 };
 
 static int drm_client_modeset_test_init(struct kunit *test)
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Xiaolei Wang

Commit 66671944e176 ("drm/tests: helpers: Add atomic helpers") added the atomic state path, so adding the drm connector atomic_[duplicate/destroy]_state is also necessary.

WARNING: CPU: 0 PID: 96 at drivers/gpu/drm/drm_connector.c:234 drm_connector_init_only+0x934/0xee0

[ ... ]

Thanks!
Maxime

Reviewed-by on v1 1/1
#2 lore raw
In reply to Xiaolei Wang
Quoted 14 lines · Xiaolei Wang

Commit 66671944e176 ("drm/tests: helpers: Add atomic helpers") added the atomic state path, so adding the drm connector atomic_[duplicate/destroy]_state is also necessary.

WARNING: CPU: 0 PID: 96 at drivers/gpu/drm/drm_connector.c:234 drm_connector_init_only+0x934/0xee0
 Call trace:
  drm_connector_init_only+0x934/0xee0 (P)
  drmm_connector_init+0xe0/0x1b0
  drm_client_modeset_test_init+0x290/0x534
  kunit_try_run_case+0x110/0x3b4
  kunit_generic_run_threadfn_adapter+0x80/0xec
  kthread+0x3b8/0x6c0
  ret_from_fork+0x10/0x20
Quoted 5 lines
---
 drivers/gpu/drm/tests/drm_client_modeset_test.c | 4 ++++
 1 file changed, 4 insertions(+)
Fixes 66671944e176 ("drm/tests: helpers: Add atomic helpers")
Signature · 2 lines
With best wishes
Dmitry