Skip to contentSkip to conversation

selftests/futex: fix format-security warnings in futex_priv_hash

PATCH New Nai-Chen Cheng 1 participant 1 message Aug 12, 2025

Subsystems (2)
Kselftest Futex
lore
Share & tools
lore

Nai-Chen Cheng

author
#0 lore raw

PATCH v2 1/1 selftests/futex: fix format-security warnings in futex_priv_hash

Fix format-security warnings by using proper format strings when passing message variables to ksft_exit_fail_msg(), ksft_test_result_pass(), and ksft_test_result_skip() function.

This prevents potential security issues and eliminates compiler warnings when building with -Wformat-security.

Signed-off-by Nai-Chen Cheng <[email protected]>

---

Changes in v2:
- Fix typo in subject: "selftest" -> "selftests"
- Retested compilation and functionality
- Link to v1: https://lore.kernel.org/all/[email protected]/

---

tools/testing/selftests/futex/functional/futex_priv_hash.c +5 -5
index 24a92dc94eb8..19651087c4de 100644
@@ -184,10 +184,10 @@ int main(int argc, char *argv[])
 	futex_slots1 = futex_hash_slots_get();
 	if (futex_slots1 <= 0) {
 		ksft_print_msg("Current hash buckets: %d\n", futex_slots1);
-		ksft_exit_fail_msg(test_msg_auto_create);
+		ksft_exit_fail_msg("%s", test_msg_auto_create);
 	}
 
-	ksft_test_result_pass(test_msg_auto_create);
+	ksft_test_result_pass("%s", test_msg_auto_create);
 
 	online_cpus = sysconf(_SC_NPROCESSORS_ONLN);
 	ret = pthread_barrier_init(&barrier_main, NULL, MAX_THREADS + 1);

@@ -212,11 +212,11 @@ int main(int argc, char *argv[])
 		if (futex_slotsn < 0 || futex_slots1 == futex_slotsn) {
 			ksft_print_msg("Expected increase of hash buckets but got: %d -> %d\n",
 				       futex_slots1, futex_slotsn);
-			ksft_exit_fail_msg(test_msg_auto_inc);
+			ksft_exit_fail_msg("%s", test_msg_auto_inc);
 		}
-		ksft_test_result_pass(test_msg_auto_inc);
+		ksft_test_result_pass("%s", test_msg_auto_inc);
 	} else {
-		ksft_test_result_skip(test_msg_auto_inc);
+		ksft_test_result_skip("%s", test_msg_auto_inc);
 	}
 	ret = pthread_mutex_unlock(&global_lock);
Signature · 1 line
2.43.0