Skip to contentSkip to conversation

rust: auxiliary: Use `c_` types from prelude instead of

PATCH In review Abhinav Ananthu 3 participants 4 messages Aug 12, 2025 – Aug 15, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rust: auxiliary: Use `c_` types from prelude instead of

Update auxiliary FFI callback signatures to reference the c_ types provided by the kernel prelude, rather than accessing them via kernel::ffi::.

---
 rust/kernel/auxiliary.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
rust/kernel/auxiliary.rs +1 -1
index d2cfe1eeefb6..030e31333689 100644
@@ -56,7 +56,7 @@ impl<T: Driver + 'static> Adapter<T> {
     extern "C" fn probe_callback(
         adev: *mut bindings::auxiliary_device,
         id: *const bindings::auxiliary_device_id,
-    ) -> kernel::ffi::c_int {
+    ) -> c_int {
         // SAFETY: The auxiliary bus only ever calls the probe callback with a valid pointer to a
         // `struct auxiliary_device`.
         //
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 26 lines · Abhinav Ananthu

Update auxiliary FFI callback signatures to reference the c_ types provided by the kernel prelude, rather than accessing them via kernel::ffi::.

---
 rust/kernel/auxiliary.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
rust/kernel/auxiliary.rs +1 -1
index d2cfe1eeefb6..030e31333689 100644
@@ -56,7 +56,7 @@ impl<T: Driver + 'static> Adapter<T> {
     extern "C" fn probe_callback(
         adev: *mut bindings::auxiliary_device,
         id: *const bindings::auxiliary_device_id,
-    ) -> kernel::ffi::c_int {
+    ) -> c_int {
         // SAFETY: The auxiliary bus only ever calls the probe callback with a valid pointer to a
         // `struct auxiliary_device`.
         //
Signature · 1 line
2.34.1

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

maintainer
#2 lore raw
In reply to Abhinav Ananthu
Quoted 5 lines · Abhinav Ananthu

Update auxiliary FFI callback signatures to reference the c_ types provided by the kernel prelude, rather than accessing them via kernel::ffi::.

This looks good now, I'll later on pick this one up.

One additional note, when sending updates on previous patches, please make sure to increase the version number of the patch, see also [1].

Also, please add a note about what changes you made between versions below the '---' line of the commit.

- Danilo

[1] https://docs.kernel.org/process/submitting-patches.html#subject-line