Skip to contentSkip to conversation

u-boot-riscv/master

GIT PULL Leo Liang 3 participants 5 messages Aug 12, 2025 – Aug 13, 2025

lore
Share & tools
lore

Leo Liang

author
#0 lore raw

Hi Tom,

The following changes since commit acfacf452441d0a659e3afbd55fd6061aa17e647:

Prepare v2025.10-rc2 (2025-08-11 13:47:46 -0600)

are available in the Git repository at:

https://source.denx.de/u-boot/custodians/u-boot-riscv.git

for you to fetch changes up to bddcd6bcba081aaaaafe30d1b8f9f3c83f069bde:

starfive: fix return code of mac write_eeprom (2025-08-12 15:34:39 +0800)

CI result shows no issue: https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/27348
----------------------------------------------------------------
- Board: mbv: Prepare MBV for CI
- Board: MPFS Icicle Kit cleanup
- Board: Add Andes Voyager board support
- RISCV: Update SYS_BOOTM_LEN to commonly used value
- starfive: fix return code of mac write_eeprom
----------------------------------------------------------------
Heinrich Schuchardt (1):
starfive: fix return code of mac write_eeprom

Jamie Gibbons (6):
configs: microchip_mpfs_icicle: enable CONFIG_OF_BOARD_SETUP
board: microchip: mpfs_icicle: make use of ft_board_setup()
mailbox: add PolarFire SoC mailbox driver
misc: add PolarFire SoC system controller
board: microchip: mpfs_icicle: enable new driver configs
board: microchip: mpfs_icicle: update to use system controller

Leo Yu-Chi Liang (6):
riscv: board: Add Andes Voyager board Kconfig support
riscv: dts: andes: Add Voyager device tree
board: MAINTAINERS: Add Voyager board maintainer
board: andestech: Add Voyager board support
configs: andes: add Voyager board defconfig
doc: board: voyager: Add documentation for Voyager

Martin Herren (4):
riscv: Set SYS_BOOTM_LEN explicitly to 0x800000
riscv: Set SYS_BOOTM_LEN default to 0x4000000
riscv: Remove default SYS_BOOTM_LEN from defconfig
riscv: Increase Microchip Icicle's SYS_BOOTM_LEN

Michal Simek (4):
xilinx: mbv: Disable OF_HAS_PRIOR_STAGE
xilinx: mbv: Add missing mmu-type cpu property
xilinx: mbv: Fix dt properties in interrupt controller node
xilinx: mbv: Use separate DTB for binman nodes

 arch/riscv/Kconfig                                 |   4 +
 arch/riscv/dts/Makefile                            |   2 +
 arch/riscv/dts/qilai-voyager.dts                   | 227 +++++++++++++++++++++
 arch/riscv/dts/voyager-u-boot.dtsi                 |  52 +++++
 arch/riscv/dts/xilinx-binman.dts                   |  12 ++
 arch/riscv/dts/xilinx-mbv32.dts                    |   8 +-
 arch/riscv/dts/xilinx-mbv64.dts                    |   8 +-
 board/andestech/voyager/Kconfig                    |  44 ++++
 board/andestech/voyager/MAINTAINERS                |   7 +
 board/andestech/voyager/Makefile                   |   6 +
 board/andestech/voyager/voyager.c                  |  71 +++++++
 board/microchip/mpfs_icicle/Kconfig                |   4 +
 board/microchip/mpfs_icicle/mpfs_icicle.c          | 121 ++++++-----
 .../starfive/visionfive2/visionfive2-i2c-eeprom.c  |   8 +-
 board/xilinx/mbv/Kconfig                           |   1 -
 boot/Kconfig                                       |   2 +-
 configs/ae350_rv32_defconfig                       |   1 -
 configs/ae350_rv32_falcon_defconfig                |   1 -
 configs/ae350_rv32_falcon_xip_defconfig            |   1 -
 configs/ae350_rv32_spl_defconfig                   |   1 -
 configs/ae350_rv32_spl_xip_defconfig               |   1 -
 configs/ae350_rv32_xip_defconfig                   |   1 -
 configs/ae350_rv64_defconfig                       |   1 -
 configs/ae350_rv64_falcon_defconfig                |   1 -
 configs/ae350_rv64_falcon_xip_defconfig            |   1 -
 configs/ae350_rv64_spl_defconfig                   |   1 -
 configs/ae350_rv64_spl_xip_defconfig               |   1 -
 configs/ae350_rv64_xip_defconfig                   |   1 -
 configs/ibex-ast2700_defconfig                     |   1 -
 configs/k230_canmv_defconfig                       |   1 +
 configs/microchip_mpfs_icicle_defconfig            |   4 +
 configs/milkv_duo_defconfig                        |   1 -
 configs/qemu-riscv32_defconfig                     |   1 -
 configs/qemu-riscv32_smode_defconfig               |   1 -
 configs/qemu-riscv32_spl_defconfig                 |   1 -
 configs/qemu-riscv64_defconfig                     |   1 -
 configs/qemu-riscv64_smode_defconfig               |   1 -
 configs/qemu-riscv64_spl_defconfig                 |   1 -
 configs/sifive_unleashed_defconfig                 |   1 -
 configs/sifive_unmatched_defconfig                 |   1 -
 configs/sipeed_licheerv_nano_defconfig             |   1 -
 configs/sipeed_maix_bitm_defconfig                 |   1 +
 configs/sipeed_maix_smode_defconfig                |   1 +
 configs/starfive_visionfive2_defconfig             |   1 -
 configs/th1520_lpi4a_defconfig                     |   1 -
 configs/voyager_spl_defconfig                      |  66 ++++++
 configs/xilinx_mbv32_defconfig                     |   2 +
 configs/xilinx_mbv32_smode_defconfig               |   2 +
 configs/xilinx_mbv64_defconfig                     |   2 +
 configs/xilinx_mbv64_smode_defconfig               |   2 +
 doc/board/andestech/index.rst                      |   1 +
 doc/board/andestech/voyager.rst                    |  81 ++++++++
 drivers/mailbox/Kconfig                            |   7 +
 drivers/mailbox/Makefile                           |   1 +
 drivers/mailbox/mpfs-mbox.c                        | 177 ++++++++++++++++
 drivers/misc/Kconfig                               |   9 +
 drivers/misc/Makefile                              |   1 +
 drivers/misc/mpfs_syscontroller.c                  | 157 ++++++++++++++
 include/configs/voyager.h                          |  40 ++++
 include/mpfs-mailbox.h                             |  67 ++++++
 60 files changed, 1121 insertions(+), 103 deletions(-)
 create mode 100644 arch/riscv/dts/qilai-voyager.dts
 create mode 100644 arch/riscv/dts/voyager-u-boot.dtsi
 create mode 100644 arch/riscv/dts/xilinx-binman.dts
 create mode 100644 board/andestech/voyager/Kconfig
 create mode 100644 board/andestech/voyager/MAINTAINERS
 create mode 100644 board/andestech/voyager/Makefile
 create mode 100644 board/andestech/voyager/voyager.c
 create mode 100644 configs/voyager_spl_defconfig
 create mode 100644 doc/board/andestech/voyager.rst
 create mode 100644 drivers/mailbox/mpfs-mbox.c
 create mode 100644 drivers/misc/mpfs_syscontroller.c
 create mode 100644 include/configs/voyager.h
 create mode 100644 include/mpfs-mailbox.h

Best regards,
Leo

#1 lore raw
Quoted 14 lines · Leo Liang

Hi Tom,

The following changes since commit acfacf452441d0a659e3afbd55fd6061aa17e647:

Prepare v2025.10-rc2 (2025-08-11 13:47:46 -0600)

are available in the Git repository at:

https://source.denx.de/u-boot/custodians/u-boot-riscv.git

for you to fetch changes up to bddcd6bcba081aaaaafe30d1b8f9f3c83f069bde:

starfive: fix return code of mac write_eeprom (2025-08-12 15:34:39 +0800)

Quoted 7 lines

CI result shows no issue: https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/27348
----------------------------------------------------------------
- Board: mbv: Prepare MBV for CI
- Board: MPFS Icicle Kit cleanup
- Board: Add Andes Voyager board support
- RISCV: Update SYS_BOOTM_LEN to commonly used value
- starfive: fix return code of mac write_eeprom

So, there's a few problems here. First, checkpatch.pl finds spacing and spelling issues, which I would normally just fixup in place. But second, voyager_spl doesn't build:
riscv64: + voyager_spl
+(voyager_spl) In file included from include/linux/printk.h:4,

+(voyager_spl)                  from include/linux/kernel.h:5,
+(voyager_spl)                  from include/linux/libfdt_env.h:13,
+(voyager_spl)                  from include/linux/libfdt.h:6,
+(voyager_spl)                  from include/fdtdec.h:17,
+(voyager_spl)                  from include/dm/ofnode.h:11,
+(voyager_spl)                  from include/dm/device.h:13,
+(voyager_spl)                  from include/dm.h:13,
+(voyager_spl)                  from common/spl/spl.c:13:

+(voyager_spl) common/spl/spl.c: In function 'spl_set_header_raw_uboot':
+(voyager_spl) common/spl/spl.c:281:27: error: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long int' [-Werror=format=]
+(voyager_spl) 281 | log_debug("Default load addr %x (u_boot_pos=%lx)\n",
+(voyager_spl) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+(voyager_spl) include/log.h:234:24: note: in definition of macro 'log'
+(voyager_spl) 234 | printf(_fmt, ##_args); \
+(voyager_spl) | ^~~~
+(voyager_spl) common/spl/spl.c:281:17: note: in expansion of macro 'log_debug'
+(voyager_spl) | ^~~~~~~~~
+(voyager_spl) common/spl/spl.c:281:47: note: format string is defined here

+(voyager_spl)       |                                              ~^
+(voyager_spl)       |                                               |
+(voyager_spl)       |                                               unsigned int
+(voyager_spl)       |                                              %lx

+(voyager_spl) cc1: all warnings being treated as errors
+(voyager_spl) make[3]: *** [scripts/Makefile.build:296: spl/common/spl/spl.o] Error 1 +(voyager_spl) make[2]: *** [scripts/Makefile.xpl:547: spl/common/spl] Error 2 +(voyager_spl) make[1]: *** [Makefile:2358: spl/u-boot-spl] Error 2 +(voyager_spl) make: *** [Makefile:198: sub-make] Error 2

Please fix and re-submit, thanks.

Signature · 1 line
Tom
author
#2 lore raw
Quoted 67 lines · Tom Rini

[EXTERNAL MAIL]

Date: Tue, 12 Aug 2025 09:22:24 -0600
From: Tom Rini <[email protected]>
To: Leo Liang <[email protected]>
Cc: [email protected], [email protected],
[email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [GIT PULL] u-boot-riscv/master

Quoted 14 lines · Leo Liang

Hi Tom,

The following changes since commit acfacf452441d0a659e3afbd55fd6061aa17e647:

Prepare v2025.10-rc2 (2025-08-11 13:47:46 -0600)

are available in the Git repository at:

https://source.denx.de/u-boot/custodians/u-boot-riscv.git

for you to fetch changes up to bddcd6bcba081aaaaafe30d1b8f9f3c83f069bde:

starfive: fix return code of mac write_eeprom (2025-08-12 15:34:39 +0800)

Quoted 7 lines

CI result shows no issue: https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/27348
----------------------------------------------------------------
- Board: mbv: Prepare MBV for CI
- Board: MPFS Icicle Kit cleanup
- Board: Add Andes Voyager board support
- RISCV: Update SYS_BOOTM_LEN to commonly used value
- starfive: fix return code of mac write_eeprom

So, there's a few problems here. First, checkpatch.pl finds spacing and spelling issues, which I would normally just fixup in place. But second, voyager_spl doesn't build:
riscv64: + voyager_spl

(quoted diff) +28 -0
+(voyager_spl) In file included from include/linux/printk.h:4,
+(voyager_spl)                  from include/linux/kernel.h:5,
+(voyager_spl)                  from include/linux/libfdt_env.h:13,
+(voyager_spl)                  from include/linux/libfdt.h:6,
+(voyager_spl)                  from include/fdtdec.h:17,
+(voyager_spl)                  from include/dm/ofnode.h:11,
+(voyager_spl)                  from include/dm/device.h:13,
+(voyager_spl)                  from include/dm.h:13,
+(voyager_spl)                  from common/spl/spl.c:13:
+(voyager_spl) common/spl/spl.c: In function 'spl_set_header_raw_uboot':
+(voyager_spl) common/spl/spl.c:281:27: error: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long int' [-Werror=format=]
+(voyager_spl)   281 |                 log_debug("Default load addr %x (u_boot_pos=%lx)\n",
+(voyager_spl)       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+(voyager_spl) include/log.h:234:24: note: in definition of macro 'log'
+(voyager_spl)   234 |                 printf(_fmt, ##_args); \
+(voyager_spl)       |                        ^~~~
+(voyager_spl) common/spl/spl.c:281:17: note: in expansion of macro 'log_debug'
+(voyager_spl)       |                 ^~~~~~~~~
+(voyager_spl) common/spl/spl.c:281:47: note: format string is defined here
+(voyager_spl)       |                                              ~^
+(voyager_spl)       |                                               |
+(voyager_spl)       |                                               unsigned int
+(voyager_spl)       |                                              %lx
+(voyager_spl) cc1: all warnings being treated as errors
+(voyager_spl) make[3]: *** [scripts/Makefile.build:296: spl/common/spl/spl.o] Error 1
+(voyager_spl) make[2]: *** [scripts/Makefile.xpl:547: spl/common/spl] Error 2
+(voyager_spl) make[1]: *** [Makefile:2358: spl/u-boot-spl] Error 2
+(voyager_spl) make: *** [Makefile:198: sub-make] Error 2
Quoted 1 line

Please fix and re-submit, thanks.

Hi Tom,

Sorry! I will fix these and re-submit ASAP.

Best regards,
Leo

Quoted 3 lines
Signature · 2 lines
-- 
Tom
#3 lore raw
Quoted 87 lines · Leo Liang
Quoted 79 lines · Tom Rini

[EXTERNAL MAIL]

Date: Tue, 12 Aug 2025 09:22:24 -0600
From: Tom Rini [email protected]
To: Leo Liang [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [GIT PULL] u-boot-riscv/master

Quoted 21 lines · Leo Liang

Hi Tom,

The following changes since commit acfacf452441d0a659e3afbd55fd6061aa17e647:

Prepare v2025.10-rc2 (2025-08-11 13:47:46 -0600)

are available in the Git repository at:

https://source.denx.de/u-boot/custodians/u-boot-riscv.git

for you to fetch changes up to bddcd6bcba081aaaaafe30d1b8f9f3c83f069bde:

starfive: fix return code of mac write_eeprom (2025-08-12 15:34:39 +0800)

Quoted 7 lines

CI result shows no issue: https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/27348
----------------------------------------------------------------
- Board: mbv: Prepare MBV for CI
- Board: MPFS Icicle Kit cleanup
- Board: Add Andes Voyager board support
- RISCV: Update SYS_BOOTM_LEN to commonly used value
- starfive: fix return code of mac write_eeprom

So, there's a few problems here. First, checkpatch.pl finds spacing and spelling issues, which I would normally just fixup in place. But second, voyager_spl doesn't build:
riscv64: + voyager_spl

(quoted diff) +28 -0
+(voyager_spl) In file included from include/linux/printk.h:4,
+(voyager_spl) from include/linux/kernel.h:5,
+(voyager_spl) from include/linux/libfdt_env.h:13,
+(voyager_spl) from include/linux/libfdt.h:6,
+(voyager_spl) from include/fdtdec.h:17,
+(voyager_spl) from include/dm/ofnode.h:11,
+(voyager_spl) from include/dm/device.h:13,
+(voyager_spl) from include/dm.h:13,
+(voyager_spl) from common/spl/spl.c:13:
+(voyager_spl) common/spl/spl.c: In function 'spl_set_header_raw_uboot':
+(voyager_spl) common/spl/spl.c:281:27: error: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long int' [-Werror=format=]
+(voyager_spl) 281 | log_debug("Default load addr %x (u_boot_pos=%lx)\n",
+(voyager_spl) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+(voyager_spl) include/log.h:234:24: note: in definition of macro 'log'
+(voyager_spl) 234 | printf(_fmt, ##_args); \
+(voyager_spl) | ^~~~
+(voyager_spl) common/spl/spl.c:281:17: note: in expansion of macro 'log_debug'
+(voyager_spl) | ^~~~~~~~~
+(voyager_spl) common/spl/spl.c:281:47: note: format string is defined here
+(voyager_spl) | ~^
+(voyager_spl) | |
+(voyager_spl) | unsigned int
+(voyager_spl) | %lx
+(voyager_spl) cc1: all warnings being treated as errors
+(voyager_spl) make[3]: *** [scripts/Makefile.build:296: spl/common/spl/spl.o] Error 1
+(voyager_spl) make[2]: *** [scripts/Makefile.xpl:547: spl/common/spl] Error 2
+(voyager_spl) make[1]: *** [Makefile:2358: spl/u-boot-spl] Error 2
+(voyager_spl) make: *** [Makefile:198: sub-make] Error 2
Quoted 1 line

Please fix and re-submit, thanks.

Quoted 8 lines

Hi Tom,

Sorry! I will fix these and re-submit ASAP.

Best regards,
Leo

Hi Leo,

As you'll resubmit, may I propose two little cleanups ?

You merged my change to the default SYS_BOOTM_LEN, so this config for both configs/microchip_mpfs_icicle_defconfig and configs/voyager_spl_defconfig could be removed as it corresponds to the now default one.

For the Icicle board, the config has been unnecessarily re-added in the configs: microchip_mpfs_icicle: enable CONFIG_OF_BOARD_SETUP commit.

For the Voyager board it is a new board that I didn't address in my patch as it was not yet merged.

This way the defconfigs stay minimal and clean.

Thanks and best regards,

Martin

author
#4 lore raw
Quoted 58 lines · Martin Herren

[EXTERNAL MAIL]

Quoted 39 lines
Quoted 34 lines

So, there's a few problems here. First, checkpatch.pl finds spacing and spelling issues, which I would normally just fixup in place. But second, voyager_spl doesn't build:
riscv64: + voyager_spl

(quoted diff) +28 -0
+(voyager_spl) In file included from include/linux/printk.h:4,
+(voyager_spl) from include/linux/kernel.h:5,
+(voyager_spl) from include/linux/libfdt_env.h:13,
+(voyager_spl) from include/linux/libfdt.h:6,
+(voyager_spl) from include/fdtdec.h:17,
+(voyager_spl) from include/dm/ofnode.h:11,
+(voyager_spl) from include/dm/device.h:13,
+(voyager_spl) from include/dm.h:13,
+(voyager_spl) from common/spl/spl.c:13:
+(voyager_spl) common/spl/spl.c: In function 'spl_set_header_raw_uboot':
+(voyager_spl) common/spl/spl.c:281:27: error: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long int' [-Werror=format=]
+(voyager_spl) 281 | log_debug("Default load addr %x (u_boot_pos=%lx)\n",
+(voyager_spl) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+(voyager_spl) include/log.h:234:24: note: in definition of macro 'log'
+(voyager_spl) 234 | printf(_fmt, ##_args); \
+(voyager_spl) | ^~~~
+(voyager_spl) common/spl/spl.c:281:17: note: in expansion of macro 'log_debug'
+(voyager_spl) | ^~~~~~~~~
+(voyager_spl) common/spl/spl.c:281:47: note: format string is defined here
+(voyager_spl) | ~^
+(voyager_spl) | |
+(voyager_spl) | unsigned int
+(voyager_spl) | %lx
+(voyager_spl) cc1: all warnings being treated as errors
+(voyager_spl) make[3]: *** [scripts/Makefile.build:296: spl/common/spl/spl.o] Error 1
+(voyager_spl) make[2]: *** [scripts/Makefile.xpl:547: spl/common/spl] Error 2
+(voyager_spl) make[1]: *** [Makefile:2358: spl/u-boot-spl] Error 2
+(voyager_spl) make: *** [Makefile:198: sub-make] Error 2
Quoted 1 line

Please fix and re-submit, thanks.

Quoted 8 lines

Hi Tom,

Sorry! I will fix these and re-submit ASAP.

Best regards,
Leo

Hi Leo,

As you'll resubmit, may I propose two little cleanups ?

You merged my change to the default SYS_BOOTM_LEN, so this config for both configs/microchip_mpfs_icicle_defconfig and configs/voyager_spl_defconfig could be removed as it corresponds to the now default one.

For the Icicle board, the config has been unnecessarily re-added in the configs: microchip_mpfs_icicle: enable CONFIG_OF_BOARD_SETUP commit.

Quoted 7 lines

For the Voyager board it is a new board that I didn't address in my patch as it was not yet merged.

This way the defconfigs stay minimal and clean.

Thanks and best regards,

Martin

Hi Martin,

Thanks for the proposal.
I will fix them up in place and send out the PR to Tom.

Best regards,
Leo