Skip to contentSkip to conversation

Check in_sack firstly in tcp_match_skb_to_sack()

PATCH In review Xin Guo 2 participants 2 messages Aug 12, 2025 – Aug 15, 2025

Subsystems (3)
lore
Share & tools
lore

Xin Guo

author
#0 lore raw

PATCH 1/1 Check in_sack firstly in tcp_match_skb_to_sack()

This is because only when in_sack is equal to false the pkt_len can be greater than or equal to skb->len, so checking the in_sack firstly will make the logic more clear.

---
 net/ipv4/tcp_input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/tcp_input.c +1 -1
index 71b76e98371a..293fb2cc8969 100644
@@ -1375,7 +1375,7 @@ static int tcp_match_skb_to_sack(struct sock *sk, struct sk_buff *skb,
 			pkt_len = new_len;
 		}
 
-		if (pkt_len >= skb->len && !in_sack)
+		if (!in_sack && pkt_len >= skb->len)
 			return 0;
 
 		err = tcp_fragment(sk, TCP_FRAG_IN_RTX_QUEUE, skb,
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 4 lines · On Tue, 12 Aug 2025 23:23:22 +0800 Xin Guo wrote:

This is because only when in_sack is equal to false the pkt_len can be greater than or equal to skb->len, so checking the in_sack firstly will make the logic more clear.

no acks/review tags seem to be forthcoming so not sure this is enough of an improvement to justify patching