Skip to contentSkip to conversation

selftests/bpf: Fix typo in kprobe_multi_test.c

PATCH In review Shubham Sharma 2 participants 3 messages Aug 12, 2025 – Aug 14, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/bpf: Fix typo in kprobe_multi_test.c

Fixed a spelling mistake:
- comparision -> comparison

---
 tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c +1 -1
index e19ef509ebf8..f377bea0b82d 100644
@@ -463,7 +463,7 @@ static bool skip_entry(char *name)
 	return false;
 }
 
-/* Do comparision by ignoring '.llvm.<hash>' suffixes. */
+/* Do comparison by ignoring '.llvm.<hash>' suffixes. */
 static int compare_name(const char *name1, const char *name2)
 {
 	const char *res1, *res2;
Signature · 1 line
2.43.0
#1 lore raw
Quoted 14 lines · Shubham Sharma

Fixed a spelling mistake:
- comparision -> comparison

---
 tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c +0 -0
index e19ef509ebf8..f377bea0b82d 100644

tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c static bool skip_entry(char *name) · line 466

Quoted 5 lines
tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c +1 -1
@@ -463,7 +463,7 @@ static bool skip_entry(char *name)
        return false;
 }
 
-/* Do comparision by ignoring '.llvm.<hash>' suffixes. */
+/* Do comparison by ignoring '.llvm.<hash>' suffixes. */

Is this the only typo in the entire BPF selftests? If we are doing single character comment fixes, let's do it as one bigger pass, instead of tons of tiny patches?

pw-bot: cr

Quoted 6 lines
tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c +0 -1
 static int compare_name(const char *name1, const char *name2)
 {
        const char *res1, *res2;
--

2.43.0

#2 lore raw
Quoted 19 lines · Andrii Nakryiko
Quoted 17 lines · Shubham Sharma

Fixed a spelling mistake:
- comparision -> comparison

---
 tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c +0 -0
index e19ef509ebf8..f377bea0b82d 100644
@@ -463,7 +463,7 @@ static bool skip_entry(char *name)
        return false;
 }
 
Quoted 16 lines

tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c static bool skip_entry(char *name) · line 466

Quoted 2 lines
tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c +1 -1
-/* Do comparision by ignoring '.llvm.<hash>' suffixes. */
+/* Do comparison by ignoring '.llvm.<hash>' suffixes. */

Is this the only typo in the entire BPF selftests? If we are doing single character comment fixes, let's do it as one bigger pass, instead of tons of tiny patches?

pw-bot: cr

Quoted 6 lines
tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c +0 -1
 static int compare_name(const char *name1, const char *name2)
 {
        const char *res1, *res2;
--

2.43.0

Thank you for the feedback. I understand that small, single-character fixes are better grouped into a larger patch to avoid multiple tiny commits.
I’ll review the BPF selftests code for similar typos and send a combined patch instead.

Thanks,
Shubham Sharma