net: Add SYS_FAULT_MII_ADDR to Kconfig
PATCH 1/1 net: Add SYS_FAULT_MII_ADDR to Kconfig
The support found under SYS_FAULT_ECHO_LINK_DOWN requires that the SYS_FAULT_MII_ADDR symbol also be set. This wasn't previously found in Kconfig, so add it now.
---
This was found as part of testing "allyesconfig". I'm not sure if there's anything useful that could be put in the "help" text here.
--- README | 3 --- net/Kconfig | 4 ++++ 2 files changed, 4 insertions(+), 3 deletions(-)
README +0 -3
@@ -1249,9 +1249,6 @@ Note: once the monitor has been relocated, then it will complain if the default environment is used; a new CRC is computed as soon as you use the "saveenv" command to store a valid environment. -- CONFIG_SYS_FAULT_MII_ADDR: - MII address of the PHY to check for the Ethernet link state. - - CONFIG_DISPLAY_BOARDINFO Display information about the board that U-Boot is running on when U-Boot starts up. The board function checkboard() is called
net/Kconfig +4 -0
@@ -60,6 +60,10 @@ config SYS_FAULT_ECHO_LINK_DOWN this option is active, then CONFIG_SYS_FAULT_MII_ADDR also needs to be configured. +config SYS_FAULT_MII_ADDR + hex "MII address of the PHY to check for the Ethernet link state" + depends on SYS_FAULT_ECHO_LINK_DOWN + config TFTP_PORT bool "Set TFTP UDP source/destination ports via the environment" help
Signature · 1 line
2.43.0
Hi Tom,
Quoted 31 lines · Tom Rini
The support found under
SYS_FAULT_ECHO_LINK_DOWNrequires that theSYS_FAULT_MII_ADDRsymbol also be set. This wasn't previously found inKconfig, so add it now.Signed-off-by Tom Rini <[email protected]>---
This was found as part of testing "allyesconfig". I'm not sure if there's anything useful that could be put in the "help" text here.--- README | 3 --- net/Kconfig | 4 ++++ 2 files changed, 4 insertions(+), 3 deletions(-)>README +0
-3@@ -1249,9 +1249,6 @@ Note: once the monitor has been relocated, then it will complain if the default environment is used; a new CRC is computed as soon as you use the "saveenv" command to store a valid environment. -- CONFIG_SYS_FAULT_MII_ADDR: - MII address of the PHY to check for the Ethernet link state. - - CONFIG_DISPLAY_BOARDINFO Display information about the board that U-Boot is running on when U-Boot starts up. The board function checkboard() is callednet/Kconfig +0
-0
net/Kconfig config SYS_FAULT_ECHO_LINK_DOWN · line 69
Quoted 10 lines
net/Kconfig +4
-0@@ -60,6 +60,10 @@ config SYS_FAULT_ECHO_LINK_DOWN this option is active, then CONFIG_SYS_FAULT_MII_ADDR also needs to be configured. +config SYS_FAULT_MII_ADDR + hex "MII address of the PHY to check for the Ethernet link state" + depends on SYS_FAULT_ECHO_LINK_DOWN + config TFTP_PORT bool "Set TFTP UDP source/destination ports via the environment" help
This breaks qemu_m68k in CI [1].
[1] https://source.denx.de/u-boot/custodians/u-boot-net/-/jobs/1224987
More specifically:
$ tools/buildman/buildman -o /tmp/build -w -E -W -e --board M5208EVBE
Building current source for 1 boards (1 thread, 24 jobs per thread)
m68k: + M5208EVBE
+.config:598:warning: symbol value '' invalid for SYS_FAULT_MII_ADDR
+
+Error in reading or end of file.
+make[3]: *** [scripts/kconfig/Makefile:75: syncconfig] Terminated
+make[2]: *** [Makefile:647: syncconfig] Terminated
+make: *** [Makefile:198: sub-make] Terminated
+(** did you define an int/hex Kconfig with no default? **)
0 0 1 /1 M5208EVBE
Completed: 1 total built, 1 newly), duration 0:00:04, rate 0.25Cheers,
Signature · 1 line
Jerome
Quoted 62 lines · Jerome Forissier
Hi Tom,
Quoted 31 lines · Tom Rini
The support found under
SYS_FAULT_ECHO_LINK_DOWNrequires that theSYS_FAULT_MII_ADDRsymbol also be set. This wasn't previously found inKconfig, so add it now.Signed-off-by Tom Rini <[email protected]>---
This was found as part of testing "allyesconfig". I'm not sure if there's anything useful that could be put in the "help" text here.--- README | 3 --- net/Kconfig | 4 ++++ 2 files changed, 4 insertions(+), 3 deletions(-)>README +0
-3@@ -1249,9 +1249,6 @@ Note: once the monitor has been relocated, then it will complain if the default environment is used; a new CRC is computed as soon as you use the "saveenv" command to store a valid environment. -- CONFIG_SYS_FAULT_MII_ADDR: - MII address of the PHY to check for the Ethernet link state. - - CONFIG_DISPLAY_BOARDINFO Display information about the board that U-Boot is running on when U-Boot starts up. The board function checkboard() is callednet/Kconfig +0
-0net/Kconfig config SYS_FAULT_ECHO_LINK_DOWN · line 69
Quoted 10 lines
net/Kconfig +4
-0@@ -60,6 +60,10 @@ config SYS_FAULT_ECHO_LINK_DOWN this option is active, then CONFIG_SYS_FAULT_MII_ADDR also needs to be configured. +config SYS_FAULT_MII_ADDR + hex "MII address of the PHY to check for the Ethernet link state" + depends on SYS_FAULT_ECHO_LINK_DOWN + config TFTP_PORT bool "Set TFTP UDP source/destination ports via the environment" helpThis breaks
qemu_m68kin CI [1].[1] https://source.denx.de/u-boot/custodians/u-boot-net/-/jobs/1224987
More specifically:
$ tools/buildman/buildman -o /tmp/build -w -E -W -e --board M5208EVBE Building current source for 1 boards (1 thread, 24 jobs per thread) m68k: + M5208EVBE +.config:598:warning: symbol value '' invalid for SYS_FAULT_MII_ADDR(quoted diff) +6
-0+ +Error in reading or end of file. +make[3]: *** [scripts/kconfig/Makefile:75: syncconfig] Terminated +make[2]: *** [Makefile:647: syncconfig] Terminated +make: *** [Makefile:198: sub-make] Terminated +(** did you define an int/hex Kconfig with no default? **) 0 0 1 /1 M5208EVBE
Quoted 1 line
Completed: 1 total built, 1 newly), duration 0:00:04, rate 0.25
Oh hunh, OK, sorry about that. This is one of those odd symbols then. I hesitated on adding the full dependencies which were also CONFIG_LED_STATUS and CONFIG_LED_STATUS_RED, which no one has, and I guess I should have. The platforms which set SYS_FAULT_ECHO_LINK_DOWN today (44 of them) don't actually do anything here because the only caller of miiphy_link requires all of the above. I'll respin this patch all the same, soon. Thanks!
Signature · 1 line
Tom