Add Texas Instruments BQ25703A Charger
Subsystems (5)
v6 cover Add Texas Instruments BQ25703A Charger
From: Chris Morgan <[email protected]>
Add support for the Texas Instruments BQ25703A charger manager. The device integrates a boost converter with the charger manager. This series adds the device as an MFD with separate regulator and power supply drivers. This allows us to manage a circular dependency with a type-c port manager which depends on the regulator for usb-otg but supplies power to the BQ25703A charger.
---
Changes since RFC
- Corrected some minor issues with code and device-tree labels.
- Replaced most of the manufacturer specific device-tree properties with monitored-battery properties.
Changes since V2
- Added reference to power-supply.yaml and removed note for i2c address per recommendation from Sebastian.
- Corrected documentation error for charger driver found by kernel test robot.
- Corrected duplicate POWER_SUPPLY_USB_TYPE_PD entry and corrected ichg logic in power supply changed function.
- Corrected missing linux/bitfield.h header in regulator driver found by kernel test robot.
Changes since V3
- Changed name of regulator from usb_otg_vbus to just vbus to align with datasheet.
- Additional cleanup of the device tree documentation.
Changes since V4
- Replaced instances of dev_err followed by a return in the probe functions with a return of dev_err_probe instead.
- Simplified cell definition of main driver for probe.
- Updated copyright year to 2025 on copyright strings.
Changes since V5
- Removed erroneous Reviewed-by tag from mfd patch.
- Made mfd_cells static const in mfd probe function.
- Removed unneeded enum from header file.
Chris Morgan (5):
dt-bindings: mfd: ti,bq25703a: Add TI BQ25703A Charger
mfd: bq257xx: Add support for BQ25703A core driver
power: supply: bq257xx: Add support for BQ257XX charger
regulator: bq257xx: Add bq257xx boost regulator driver
arm64: dts: rockchip: Add USB and charger to Gameforce Ace
.../devicetree/bindings/mfd/ti,bq25703a.yaml | 117 +++ .../dts/rockchip/rk3588s-gameforce-ace.dts | 122 +++ drivers/mfd/Kconfig | 11 + drivers/mfd/Makefile | 1 + drivers/mfd/bq257xx.c | 97 +++ drivers/power/supply/Kconfig | 7 + drivers/power/supply/Makefile | 1 + drivers/power/supply/bq257xx_charger.c | 750 ++++++++++++++++++ drivers/regulator/Kconfig | 8 + drivers/regulator/Makefile | 1 + drivers/regulator/bq257xx-regulator.c | 188 +++++ include/linux/mfd/bq257xx.h | 104 +++ 12 files changed, 1407 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/ti,bq25703a.yaml create mode 100644 drivers/mfd/bq257xx.c create mode 100644 drivers/power/supply/bq257xx_charger.c create mode 100644 drivers/regulator/bq257xx-regulator.c create mode 100644 include/linux/mfd/bq257xx.h
Signature · 1 line
2.43.0
PATCH v6 1/5 dt-bindings: mfd: ti,bq25703a: Add TI BQ25703A Charger
From: Chris Morgan <[email protected]>
Document the Texas instruments BQ25703A series of charger managers/ buck/boost regulators.
--- .../devicetree/bindings/mfd/ti,bq25703a.yaml | 117 ++++++++++++++++++ 1 file changed, 117 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/ti,bq25703a.yaml
Documentation/devicetree/bindings/mfd/ti,bq25703a.yaml new file +117 -0
@@ -0,0 +1,117 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/ti,bq25703a.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: BQ25703A Charger Manager/Buck/Boost Converter + +maintainers: + - Chris Morgan <[email protected]> + +allOf: + - $ref: /schemas/power/supply/power-supply.yaml# + +properties: + compatible: + const: ti,bq25703a + + reg: + const: 0x6b + + input-current-limit-microamp: + description: + Maximum total input current allowed used for both charging and + powering the device. + minimum: 50000 + maximum: 6400000 + default: 3250000 + + interrupts: + maxItems: 1 + + monitored-battery: + description: + A minimum of constant-charge-current-max-microamp, + constant-charge-voltage-max-microvolt, and + voltage-min-design-microvolt are required. + + regulators: + type: object + additionalProperties: false + description: + Boost converter regulator output of bq257xx. + + properties: + vbus: + type: object + $ref: /schemas/regulator/regulator.yaml + additionalProperties: false + + properties: + regulator-name: true + regulator-min-microamp: + minimum: 0 + maximum: 6350000 + regulator-max-microamp: + minimum: 0 + maximum: 6350000 + regulator-min-microvolt: + minimum: 4480000 + maximum: 20800000 + regulator-max-microvolt: + minimum: 4480000 + maximum: 20800000 + enable-gpios: + description: + The BQ25703 may require both a register write and a GPIO + toggle to enable the boost regulator. + + required: + - regulator-name + - regulator-min-microamp + - regulator-max-microamp + - regulator-min-microvolt + - regulator-max-microvolt + +unevaluatedProperties: false + +required: + - compatible + - reg + - input-current-limit-microamp + - monitored-battery + - power-supplies + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/pinctrl/rockchip.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + bq25703: charger@6b { + compatible = "ti,bq25703a"; + reg = <0x6b>; + input-current-limit-microamp = <5000000>; + interrupt-parent = <&gpio0>; + interrupts = <RK_PD5 IRQ_TYPE_LEVEL_LOW>; + monitored-battery = <&battery>; + power-supplies = <&fusb302>; + + regulators { + usb_otg_vbus: vbus { + enable-gpios = <&gpio4 RK_PA6 GPIO_ACTIVE_HIGH>; + regulator-max-microamp = <960000>; + regulator-max-microvolt = <5088000>; + regulator-min-microamp = <512000>; + regulator-min-microvolt = <4992000>; + regulator-name = "usb_otg_vbus"; + }; + }; + }; + }; + +...
Signature · 1 line
2.43.0
PATCH v6 2/5 mfd: bq257xx: Add support for BQ25703A core driver
In reply to Chris MorganFrom: Chris Morgan <[email protected]>
The Texas Instruments BQ25703A is an integrated charger manager and boost converter.
The MFD driver initalizes the device for the regulator driver and power supply driver.
--- drivers/mfd/Kconfig | 11 ++++ drivers/mfd/Makefile | 1 + drivers/mfd/bq257xx.c | 97 +++++++++++++++++++++++++++++++++ include/linux/mfd/bq257xx.h | 104 ++++++++++++++++++++++++++++++++++++ 4 files changed, 213 insertions(+) create mode 100644 drivers/mfd/bq257xx.c create mode 100644 include/linux/mfd/bq257xx.h
drivers/mfd/Kconfig +11 -0
@@ -1641,6 +1641,17 @@ config MFD_TI_LMU LM36274. It consists of backlight, LED and regulator driver. It provides consistent device controls for lighting functions. +config MFD_BQ257XX + tristate "TI BQ257XX Buck/Boost Charge Controller" + depends on I2C + select MFD_CORE + select REGMAP_I2C + help + Support Texas Instruments BQ25703 Buck/Boost converter with + charge controller. It consists of regulators that provide + system voltage and OTG voltage, and a charger manager for + batteries containing one or more cells. + config MFD_OMAP_USB_HOST bool "TI OMAP USBHS core and TLL driver" depends on USB_EHCI_HCD_OMAP || USB_OHCI_HCD_OMAP3
drivers/mfd/Makefile +1 -0
@@ -13,6 +13,7 @@ obj-$(CONFIG_MFD_SM501) += sm501.o obj-$(CONFIG_ARCH_BCM2835) += bcm2835-pm.o obj-$(CONFIG_MFD_BCM590XX) += bcm590xx.o obj-$(CONFIG_MFD_BD9571MWV) += bd9571mwv.o +obj-$(CONFIG_MFD_BQ257XX) += bq257xx.o obj-$(CONFIG_MFD_CGBC) += cgbc-core.o obj-$(CONFIG_MFD_CROS_EC_DEV) += cros_ec_dev.o obj-$(CONFIG_MFD_CS42L43) += cs42l43.o
drivers/mfd/bq257xx.c new file +97 -0
97 lines not on this page · raw message
include/linux/mfd/bq257xx.h new file +104 -0
104 lines not on this page · raw message
Signature · 1 line
2.43.0
PATCH v6 3/5 power: supply: bq257xx: Add support for BQ257XX charger
In reply to Chris MorganFrom: Chris Morgan <[email protected]>
Add support for the charger function of the BQ257XX. The device is capable of charging batteries with a layout of 1 to 4 cells in series.
--- drivers/power/supply/Kconfig | 7 + drivers/power/supply/Makefile | 1 + drivers/power/supply/bq257xx_charger.c | 750 +++++++++++++++++++++++++ 3 files changed, 758 insertions(+) create mode 100644 drivers/power/supply/bq257xx_charger.c
drivers/power/supply/Kconfig +7 -0
@@ -767,6 +767,13 @@ config CHARGER_BQ2515X rail, ADC for battery and system monitoring, and push-button controller. +config CHARGER_BQ257XX + tristate "TI BQ257XX battery charger family" + depends on MFD_BQ257XX + help + Say Y to enable support for the TI BQ257XX family of battery + charging integrated circuits. + config CHARGER_BQ25890 tristate "TI BQ25890 battery charger driver" depends on I2C
drivers/power/supply/Makefile +1 -0
@@ -97,6 +97,7 @@ obj-$(CONFIG_CHARGER_BQ24190) += bq24190_charger.o obj-$(CONFIG_CHARGER_BQ24257) += bq24257_charger.o obj-$(CONFIG_CHARGER_BQ24735) += bq24735-charger.o obj-$(CONFIG_CHARGER_BQ2515X) += bq2515x_charger.o +obj-$(CONFIG_CHARGER_BQ257XX) += bq257xx_charger.o obj-$(CONFIG_CHARGER_BQ25890) += bq25890_charger.o obj-$(CONFIG_CHARGER_BQ25980) += bq25980_charger.o obj-$(CONFIG_CHARGER_BQ256XX) += bq256xx_charger.o
drivers/power/supply/bq257xx_charger.c new file +750 -0
750 lines not on this page · raw message
Signature · 1 line
2.43.0
Dan Carpenter
build botRe: [PATCH V6 3/5] power: supply: bq257xx: Add support for BQ257XX charger
BCC: [email protected] CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Chris Morgan…
BCC: [email protected]
CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Chris Morgan <[email protected]>
TO: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: Chris Morgan <[email protected]>
CC: Sebastian Reichel <[email protected]>
Hi Chris,
kernel test robot noticed the following build warnings:
[auto build test WARNING on broonie-regulator/for-next]
[also build test WARNING on sre-power-supply/for-next rockchip/for-next linus/master v6.17-rc2 next-20250818] [cannot apply to lee-mfd/for-mfd-next lee-mfd/for-mfd-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chris-Morgan/dt-bindings-mfd-ti-bq25703a-Add-TI-BQ25703A-Charger/20250813-054704 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next patch link: https://lore.kernel.org/r/20250812214300.123129-4-macroalpha82%40gmail.com patch subject: [PATCH V6 3/5] power: supply: bq257xx: Add support for BQ257XX charger
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: parisc-randconfig-r072-20250818 (https://download.01.org/0day-ci/archive/20250818/[email protected]/config)
compiler: hppa-linux-gcc (GCC) 8.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/
smatch warnings:drivers/power/supply/bq257xx_charger.c:392 bq25703_hw_init() warn: potential ! vs ~ typo
vim +392 drivers/power/supply/bq257xx_charger.c
7f3b6f1e51a925 Chris Morgan 2025-08-12 351
7f3b6f1e51a925 Chris Morgan 2025-08-12 352 /**
7f3b6f1e51a925 Chris Morgan 2025-08-12 353 * bq25703_hw_init() - Set all the required registers to init the charger
7f3b6f1e51a925 Chris Morgan 2025-08-12 354 * @pdata: driver platform data
7f3b6f1e51a925 Chris Morgan 2025-08-12 355 *
7f3b6f1e51a925 Chris Morgan 2025-08-12 356 * Initialize the BQ25703 by first disabling the watchdog timer (which
7f3b6f1e51a925 Chris Morgan 2025-08-12 357 * shuts off the charger in the absence of periodic writes). Then, set
7f3b6f1e51a925 Chris Morgan 2025-08-12 358 * the charge current, charge voltage, minimum system voltage, and
7f3b6f1e51a925 Chris Morgan 2025-08-12 359 * input current limit. Disable low power mode to allow ADCs and
7f3b6f1e51a925 Chris Morgan 2025-08-12 360 * interrupts. Enable the ADC, start the ADC, set the ADC scale to
7f3b6f1e51a925 Chris Morgan 2025-08-12 361 * full, and enable each individual ADC channel.
7f3b6f1e51a925 Chris Morgan 2025-08-12 362 *
7f3b6f1e51a925 Chris Morgan 2025-08-12 363 * Return: Returns 0 on success or error code on error.
7f3b6f1e51a925 Chris Morgan 2025-08-12 364 */
7f3b6f1e51a925 Chris Morgan 2025-08-12 365 static int bq25703_hw_init(struct bq257xx_chg *pdata)
7f3b6f1e51a925 Chris Morgan 2025-08-12 366 {
7f3b6f1e51a925 Chris Morgan 2025-08-12 367 struct regmap *regmap = pdata->bq->regmap;
7f3b6f1e51a925 Chris Morgan 2025-08-12 368 int ret = 0;
7f3b6f1e51a925 Chris Morgan 2025-08-12 369
7f3b6f1e51a925 Chris Morgan 2025-08-12 370 regmap_update_bits(regmap, BQ25703_CHARGE_OPTION_0,
7f3b6f1e51a925 Chris Morgan 2025-08-12 371 BQ25703_WDTMR_ADJ_MASK,
7f3b6f1e51a925 Chris Morgan 2025-08-12 372 FIELD_PREP(BQ25703_WDTMR_ADJ_MASK,
7f3b6f1e51a925 Chris Morgan 2025-08-12 373 BQ25703_WDTMR_DISABLE));
7f3b6f1e51a925 Chris Morgan 2025-08-12 374
7f3b6f1e51a925 Chris Morgan 2025-08-12 375 ret = pdata->chip->bq257xx_set_ichg(pdata, pdata->ichg_max);
7f3b6f1e51a925 Chris Morgan 2025-08-12 376 if (ret)
7f3b6f1e51a925 Chris Morgan 2025-08-12 377 return ret;
7f3b6f1e51a925 Chris Morgan 2025-08-12 378
7f3b6f1e51a925 Chris Morgan 2025-08-12 379 ret = pdata->chip->bq257xx_set_vbatreg(pdata, pdata->vbat_max);
7f3b6f1e51a925 Chris Morgan 2025-08-12 380 if (ret)
7f3b6f1e51a925 Chris Morgan 2025-08-12 381 return ret;
7f3b6f1e51a925 Chris Morgan 2025-08-12 382
7f3b6f1e51a925 Chris Morgan 2025-08-12 383 ret = bq25703_set_min_vsys(pdata, pdata->vsys_min);
7f3b6f1e51a925 Chris Morgan 2025-08-12 384 if (ret)
7f3b6f1e51a925 Chris Morgan 2025-08-12 385 return ret;
7f3b6f1e51a925 Chris Morgan 2025-08-12 386
7f3b6f1e51a925 Chris Morgan 2025-08-12 387 ret = pdata->chip->bq257xx_set_iindpm(pdata, pdata->iindpm_max);
7f3b6f1e51a925 Chris Morgan 2025-08-12 388 if (ret)
7f3b6f1e51a925 Chris Morgan 2025-08-12 389 return ret;
7f3b6f1e51a925 Chris Morgan 2025-08-12 390
7f3b6f1e51a925 Chris Morgan 2025-08-12 391 regmap_update_bits(regmap, BQ25703_CHARGE_OPTION_0,
7f3b6f1e51a925 Chris Morgan 2025-08-12 @392 BQ25703_EN_LWPWR, !BQ25703_EN_LWPWR);
7f3b6f1e51a925 Chris Morgan 2025-08-12 393
7f3b6f1e51a925 Chris Morgan 2025-08-12 394 regmap_update_bits(regmap, BQ25703_ADC_OPTION,
7f3b6f1e51a925 Chris Morgan 2025-08-12 395 BQ25703_ADC_CONV_EN, BQ25703_ADC_CONV_EN);
7f3b6f1e51a925 Chris Morgan 2025-08-12 396
7f3b6f1e51a925 Chris Morgan 2025-08-12 397 regmap_update_bits(regmap, BQ25703_ADC_OPTION,
7f3b6f1e51a925 Chris Morgan 2025-08-12 398 BQ25703_ADC_START, BQ25703_ADC_START);
7f3b6f1e51a925 Chris Morgan 2025-08-12 399
7f3b6f1e51a925 Chris Morgan 2025-08-12 400 regmap_update_bits(regmap, BQ25703_ADC_OPTION,
7f3b6f1e51a925 Chris Morgan 2025-08-12 401 BQ25703_ADC_FULL_SCALE, BQ25703_ADC_FULL_SCALE);
7f3b6f1e51a925 Chris Morgan 2025-08-12 402
7f3b6f1e51a925 Chris Morgan 2025-08-12 403 regmap_update_bits(regmap, BQ25703_ADC_OPTION,
7f3b6f1e51a925 Chris Morgan 2025-08-12 404 BQ25703_ADC_CH_MASK,
7f3b6f1e51a925 Chris Morgan 2025-08-12 405 (BQ25703_ADC_CMPIN_EN | BQ25703_ADC_VBUS_EN |
7f3b6f1e51a925 Chris Morgan 2025-08-12 406 BQ25703_ADC_PSYS_EN | BQ25703_ADC_IIN_EN |
7f3b6f1e51a925 Chris Morgan 2025-08-12 407 BQ25703_ADC_IDCHG_EN | BQ25703_ADC_ICHG_EN |
7f3b6f1e51a925 Chris Morgan 2025-08-12 408 BQ25703_ADC_VSYS_EN | BQ25703_ADC_VBAT_EN));
7f3b6f1e51a925 Chris Morgan 2025-08-12 409
7f3b6f1e51a925 Chris Morgan 2025-08-12 410 return ret;
7f3b6f1e51a925 Chris Morgan 2025-08-12 411 }
7f3b6f1e51a925 Chris Morgan 2025-08-12 412 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Re: [PATCH V6 3/5] power: supply: bq257xx: Add support for BQ257XX charger
Quoted 51 lines · Dan Carpenter
Hi Chris,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chris-Morgan/dt-bindings-mfd-ti-bq25703a-Add-TI-BQ25703A-Charger/20250813-054704 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next patch link: https://lore.kernel.org/r/20250812214300.123129-4-macroalpha82%40gmail.com patch subject: [PATCH V6 3/5] power: supply: bq257xx: Add support for BQ257XX charger config: parisc-randconfig-r072-20250818 (https://download.01.org/0day-ci/archive/20250818/[email protected]/config) compiler: hppa-linux-gcc (GCC) 8.5.0If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/smatch warnings:
drivers/power/supply/bq257xx_charger.c:392bq25703_hw_init()warn: potential ! vs ~ typovim +392
drivers/power/supply/bq257xx_charger.c7f3b6f1e51a925 Chris Morgan 2025-08-12 365 static int bq25703_hw_init(struct bq257xx_chg *pdata) 7f3b6f1e51a925 Chris Morgan 2025-08-12 366 { 7f3b6f1e51a925 Chris Morgan 2025-08-12 367 struct regmap *regmap = pdata->bq->regmap; 7f3b6f1e51a925 Chris Morgan 2025-08-12 368 int ret = 0; 7f3b6f1e51a925 Chris Morgan 2025-08-12 369 7f3b6f1e51a925 Chris Morgan 2025-08-12 370 regmap_update_bits(regmap, BQ25703_CHARGE_OPTION_0, 7f3b6f1e51a925 Chris Morgan 2025-08-12 371 BQ25703_WDTMR_ADJ_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 372 FIELD_PREP(BQ25703_WDTMR_ADJ_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 373 BQ25703_WDTMR_DISABLE)); 7f3b6f1e51a925 Chris Morgan 2025-08-12 374 7f3b6f1e51a925 Chris Morgan 2025-08-12 375 ret = pdata->chip->bq257xx_set_ichg(pdata, pdata->ichg_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 376 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 377 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 378 7f3b6f1e51a925 Chris Morgan 2025-08-12 379 ret = pdata->chip->bq257xx_set_vbatreg(pdata, pdata->vbat_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 380 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 381 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 382 7f3b6f1e51a925 Chris Morgan 2025-08-12 383 ret = bq25703_set_min_vsys(pdata, pdata->vsys_min); 7f3b6f1e51a925 Chris Morgan 2025-08-12 384 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 385 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 386 7f3b6f1e51a925 Chris Morgan 2025-08-12 387 ret = pdata->chip->bq257xx_set_iindpm(pdata, pdata->iindpm_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 388 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 389 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 390 7f3b6f1e51a925 Chris Morgan 2025-08-12 391 regmap_update_bits(regmap, BQ25703_CHARGE_OPTION_0,
Quoted 4 lines
7f3b6f1e51a925Chris Morgan 2025-08-12 @392BQ25703_EN_LWPWR, !BQ25703_EN_LWPWR);Yeah. This really looks like it should be bitwise negate ~ instead of logical negate !.
Since BQ25703_EN_LWPWR is defined as 1 and I want to write 0 here (to disable low power mode) I was under the assumption either should work. That said, I'll happily switch to the bitwise negate (~) and resubmit.
Quoted 12 lines
7f3b6f1e51a925 Chris Morgan 2025-08-12 393 7f3b6f1e51a925 Chris Morgan 2025-08-12 394 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 395 BQ25703_ADC_CONV_EN, BQ25703_ADC_CONV_EN); 7f3b6f1e51a925 Chris Morgan 2025-08-12 396 7f3b6f1e51a925 Chris Morgan 2025-08-12 397 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 398 BQ25703_ADC_START, BQ25703_ADC_START); 7f3b6f1e51a925 Chris Morgan 2025-08-12 399 7f3b6f1e51a925 Chris Morgan 2025-08-12 400 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 401 BQ25703_ADC_FULL_SCALE, BQ25703_ADC_FULL_SCALE); 7f3b6f1e51a925 Chris Morgan 2025-08-12 402 7f3b6f1e51a925 Chris Morgan 2025-08-12 403 regmap_update_bits(regmap, BQ25703_ADC_OPTION,
Quoted 13 lines
7f3b6f1e51a925 Chris Morgan 2025-08-12 404 BQ25703_ADC_CH_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 405 (BQ25703_ADC_CMPIN_EN | BQ25703_ADC_VBUS_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 406 BQ25703_ADC_PSYS_EN | BQ25703_ADC_IIN_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 407 BQ25703_ADC_IDCHG_EN | BQ25703_ADC_ICHG_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 408 BQ25703_ADC_VSYS_EN | BQ25703_ADC_VBAT_EN)); 7f3b6f1e51a925 Chris Morgan 2025-08-12 409 7f3b6f1e51a925 Chris Morgan 2025-08-12 410 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 411 }Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Thank you,
Chris
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH V6 3/5] power: supply: bq257xx: Add support for BQ257XX charger
Quoted 54 lines · Chris Morgan
Quoted 53 lines · Dan Carpenter
Hi Chris,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chris-Morgan/dt-bindings-mfd-ti-bq25703a-Add-TI-BQ25703A-Charger/20250813-054704 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next patch link: https://lore.kernel.org/r/20250812214300.123129-4-macroalpha82%40gmail.com patch subject: [PATCH V6 3/5] power: supply: bq257xx: Add support for BQ257XX charger config: parisc-randconfig-r072-20250818 (https://download.01.org/0day-ci/archive/20250818/[email protected]/config) compiler: hppa-linux-gcc (GCC) 8.5.0If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/smatch warnings:
drivers/power/supply/bq257xx_charger.c:392bq25703_hw_init()warn: potential ! vs ~ typovim +392
drivers/power/supply/bq257xx_charger.c7f3b6f1e51a925 Chris Morgan 2025-08-12 365 static int bq25703_hw_init(struct bq257xx_chg *pdata) 7f3b6f1e51a925 Chris Morgan 2025-08-12 366 { 7f3b6f1e51a925 Chris Morgan 2025-08-12 367 struct regmap *regmap = pdata->bq->regmap; 7f3b6f1e51a925 Chris Morgan 2025-08-12 368 int ret = 0; 7f3b6f1e51a925 Chris Morgan 2025-08-12 369 7f3b6f1e51a925 Chris Morgan 2025-08-12 370 regmap_update_bits(regmap, BQ25703_CHARGE_OPTION_0, 7f3b6f1e51a925 Chris Morgan 2025-08-12 371 BQ25703_WDTMR_ADJ_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 372 FIELD_PREP(BQ25703_WDTMR_ADJ_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 373 BQ25703_WDTMR_DISABLE)); 7f3b6f1e51a925 Chris Morgan 2025-08-12 374 7f3b6f1e51a925 Chris Morgan 2025-08-12 375 ret = pdata->chip->bq257xx_set_ichg(pdata, pdata->ichg_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 376 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 377 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 378 7f3b6f1e51a925 Chris Morgan 2025-08-12 379 ret = pdata->chip->bq257xx_set_vbatreg(pdata, pdata->vbat_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 380 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 381 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 382 7f3b6f1e51a925 Chris Morgan 2025-08-12 383 ret = bq25703_set_min_vsys(pdata, pdata->vsys_min); 7f3b6f1e51a925 Chris Morgan 2025-08-12 384 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 385 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 386 7f3b6f1e51a925 Chris Morgan 2025-08-12 387 ret = pdata->chip->bq257xx_set_iindpm(pdata, pdata->iindpm_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 388 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 389 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 390 7f3b6f1e51a925 Chris Morgan 2025-08-12 391 regmap_update_bits(regmap, BQ25703_CHARGE_OPTION_0,
7f3b6f1e51a925Chris Morgan 2025-08-12 @392BQ25703_EN_LWPWR, !BQ25703_EN_LWPWR);
Quoted 6 lines
Quoted 2 lines
Yeah. This really looks like it should be bitwise negate ~ instead of logical negate !.
Since
BQ25703_EN_LWPWRis defined as 1 and I want to write 0 here (to disable low power mode) I was under the assumption either should work. That said, I'll happily switch to the bitwise negate (~) and resubmit.
Sorry, hadn't drank my morning coffee yet before I sent the last message and should have attempted it first before replying. When I make the requested change I get a compile time error of "conversion from ‘long unsigned int’ to ‘unsigned int’ changes value from ‘18446744073709518847’ to ‘4294934527’". What I'm really trying to accomplish here is to simply write a 0 to turn off low power mode, and do so in a manner that's easy to understand. I think since a bitwise negate gives a compile error and a logical negate throws a smatch warning, the most sensible thing to do is simply express this as a 0 instead of a defined value and write a comment why I'm doing that.
Quoted 22 lines
Quoted 22 lines
7f3b6f1e51a925 Chris Morgan 2025-08-12 393 7f3b6f1e51a925 Chris Morgan 2025-08-12 394 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 395 BQ25703_ADC_CONV_EN, BQ25703_ADC_CONV_EN); 7f3b6f1e51a925 Chris Morgan 2025-08-12 396 7f3b6f1e51a925 Chris Morgan 2025-08-12 397 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 398 BQ25703_ADC_START, BQ25703_ADC_START); 7f3b6f1e51a925 Chris Morgan 2025-08-12 399 7f3b6f1e51a925 Chris Morgan 2025-08-12 400 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 401 BQ25703_ADC_FULL_SCALE, BQ25703_ADC_FULL_SCALE); 7f3b6f1e51a925 Chris Morgan 2025-08-12 402 7f3b6f1e51a925 Chris Morgan 2025-08-12 403 regmap_update_bits(regmap, BQ25703_ADC_OPTION, 7f3b6f1e51a925 Chris Morgan 2025-08-12 404 BQ25703_ADC_CH_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 405 (BQ25703_ADC_CMPIN_EN | BQ25703_ADC_VBUS_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 406 BQ25703_ADC_PSYS_EN | BQ25703_ADC_IIN_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 407 BQ25703_ADC_IDCHG_EN | BQ25703_ADC_ICHG_EN | 7f3b6f1e51a925 Chris Morgan 2025-08-12 408 BQ25703_ADC_VSYS_EN | BQ25703_ADC_VBAT_EN)); 7f3b6f1e51a925 Chris Morgan 2025-08-12 409 7f3b6f1e51a925 Chris Morgan 2025-08-12 410 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 411 }
Quoted 7 lines
Quoted 4 lines
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wikiThank you,
Chris
Thank you,
Chris
Re: [PATCH V6 3/5] power: supply: bq257xx: Add support for BQ257XX charger
Quoted 62 lines · Chris Morgan
Quoted 54 lines · Chris Morgan
Quoted 53 lines · Dan Carpenter
Hi Chris,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chris-Morgan/dt-bindings-mfd-ti-bq25703a-Add-TI-BQ25703A-Charger/20250813-054704 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next patch link: https://lore.kernel.org/r/20250812214300.123129-4-macroalpha82%40gmail.com patch subject: [PATCH V6 3/5] power: supply: bq257xx: Add support for BQ257XX charger config: parisc-randconfig-r072-20250818 (https://download.01.org/0day-ci/archive/20250818/[email protected]/config) compiler: hppa-linux-gcc (GCC) 8.5.0If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/smatch warnings:
drivers/power/supply/bq257xx_charger.c:392bq25703_hw_init()warn: potential ! vs ~ typovim +392
drivers/power/supply/bq257xx_charger.c7f3b6f1e51a925 Chris Morgan 2025-08-12 365 static int bq25703_hw_init(struct bq257xx_chg *pdata) 7f3b6f1e51a925 Chris Morgan 2025-08-12 366 { 7f3b6f1e51a925 Chris Morgan 2025-08-12 367 struct regmap *regmap = pdata->bq->regmap; 7f3b6f1e51a925 Chris Morgan 2025-08-12 368 int ret = 0; 7f3b6f1e51a925 Chris Morgan 2025-08-12 369 7f3b6f1e51a925 Chris Morgan 2025-08-12 370 regmap_update_bits(regmap, BQ25703_CHARGE_OPTION_0, 7f3b6f1e51a925 Chris Morgan 2025-08-12 371 BQ25703_WDTMR_ADJ_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 372 FIELD_PREP(BQ25703_WDTMR_ADJ_MASK, 7f3b6f1e51a925 Chris Morgan 2025-08-12 373 BQ25703_WDTMR_DISABLE)); 7f3b6f1e51a925 Chris Morgan 2025-08-12 374 7f3b6f1e51a925 Chris Morgan 2025-08-12 375 ret = pdata->chip->bq257xx_set_ichg(pdata, pdata->ichg_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 376 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 377 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 378 7f3b6f1e51a925 Chris Morgan 2025-08-12 379 ret = pdata->chip->bq257xx_set_vbatreg(pdata, pdata->vbat_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 380 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 381 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 382 7f3b6f1e51a925 Chris Morgan 2025-08-12 383 ret = bq25703_set_min_vsys(pdata, pdata->vsys_min); 7f3b6f1e51a925 Chris Morgan 2025-08-12 384 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 385 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 386 7f3b6f1e51a925 Chris Morgan 2025-08-12 387 ret = pdata->chip->bq257xx_set_iindpm(pdata, pdata->iindpm_max); 7f3b6f1e51a925 Chris Morgan 2025-08-12 388 if (ret) 7f3b6f1e51a925 Chris Morgan 2025-08-12 389 return ret; 7f3b6f1e51a925 Chris Morgan 2025-08-12 390 7f3b6f1e51a925 Chris Morgan 2025-08-12 391 regmap_update_bits(regmap, BQ25703_CHARGE_OPTION_0,
7f3b6f1e51a925Chris Morgan 2025-08-12 @392BQ25703_EN_LWPWR, !BQ25703_EN_LWPWR);Quoted 6 lines
Quoted 2 lines
Yeah. This really looks like it should be bitwise negate ~ instead of logical negate !.
Since
BQ25703_EN_LWPWRis defined as 1 and I want to write 0 here (to disable low power mode) I was under the assumption either should work. That said, I'll happily switch to the bitwise negate (~) and resubmit.
Quoted 11 lines
Sorry, hadn't drank my morning coffee yet before I sent the last message and should have attempted it first before replying. When I make the requested change I get a compile time error of "conversion from ‘long unsigned int’ to ‘unsigned int’ changes value from ‘18446744073709518847’ to ‘4294934527’". What I'm really trying to accomplish here is to simply write a 0 to turn off low power mode, and do so in a manner that's easy to understand. I think since a bitwise negate gives a compile error and a logical negate throws a smatch warning, the most sensible thing to do is simply express this as a 0 instead of a defined value and write a comment why I'm doing that.
Yeah... Or you could do "#define BQ25703_DISABLE_LWPWR 0".
regards,
dan carpenter
PATCH v6 4/5 regulator: bq257xx: Add bq257xx boost regulator driver
In reply to Chris MorganFrom: Chris Morgan <[email protected]>
Add support for the boost regulator found in the Texas Instruments BQ25703. The boost regulator is capable of outputting between 4.48 and 20.8 volts and between 0 and 6.35 amps.
--- drivers/regulator/Kconfig | 8 ++ drivers/regulator/Makefile | 1 + drivers/regulator/bq257xx-regulator.c | 188 ++++++++++++++++++++++++++ 3 files changed, 197 insertions(+) create mode 100644 drivers/regulator/bq257xx-regulator.c
drivers/regulator/Kconfig +8 -0
@@ -297,6 +297,14 @@ config REGULATOR_BD96801 This driver can also be built as a module. If so, the module will be called bd96801-regulator. +config REGULATOR_BQ257XX + tristate "TI BQ257XX regulator family" + depends on MFD_BQ257XX + depends on GPIOLIB || COMPILE_TEST + help + Say Y to enable support for the boost regulator function of + the BQ257XX family of charger circuits. + config REGULATOR_CPCAP tristate "Motorola CPCAP regulator" depends on MFD_CPCAP
drivers/regulator/Makefile +1 -0
@@ -38,6 +38,7 @@ obj-$(CONFIG_REGULATOR_BD71828) += bd71828-regulator.o obj-$(CONFIG_REGULATOR_BD718XX) += bd718x7-regulator.o obj-$(CONFIG_REGULATOR_BD9571MWV) += bd9571mwv-regulator.o obj-$(CONFIG_REGULATOR_BD957XMUF) += bd9576-regulator.o +obj-$(CONFIG_REGULATOR_BQ257XX) += bq257xx-regulator.o obj-$(CONFIG_REGULATOR_DA903X) += da903x-regulator.o obj-$(CONFIG_REGULATOR_BD96801) += bd96801-regulator.o obj-$(CONFIG_REGULATOR_DA9052) += da9052-regulator.o
drivers/regulator/bq257xx-regulator.c new file +188 -0
188 lines not on this page · raw message
Signature · 1 line
2.43.0
Dan Carpenter
build botRe: [PATCH V6 4/5] regulator: bq257xx: Add bq257xx boost regulator driver
BCC: [email protected] CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Chris Morgan…
BCC: [email protected]
CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Chris Morgan <[email protected]>
TO: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: Chris Morgan <[email protected]>
Hi Chris,
kernel test robot noticed the following build warnings:
[auto build test WARNING on broonie-regulator/for-next]
[also build test WARNING on sre-power-supply/for-next rockchip/for-next linus/master v6.17-rc1 next-20250813] [cannot apply to lee-mfd/for-mfd-next lee-mfd/for-mfd-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chris-Morgan/dt-bindings-mfd-ti-bq25703a-Add-TI-BQ25703A-Charger/20250813-054704 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next patch link: https://lore.kernel.org/r/20250812214300.123129-5-macroalpha82%40gmail.com patch subject: [PATCH V6 4/5] regulator: bq257xx: Add bq257xx boost regulator driver
:::::: branch date: 28 hours ago
:::::: commit date: 28 hours ago
config: m68k-randconfig-r073-20250814 (https://download.01.org/0day-ci/archive/20250814/[email protected]/config)
compiler: m68k-linux-gcc (GCC) 15.1.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/
smatch warnings:drivers/regulator/bq257xx-regulator.c:161 bq257xx_regulator_probe() error: uninitialized symbol 'init_data'.
vim +/init_data +161 drivers/regulator/bq257xx-regulator.c
d6db7dce7cd965 Chris Morgan 2025-08-12 137
d6db7dce7cd965 Chris Morgan 2025-08-12 138 static int bq257xx_regulator_probe(struct platform_device *pdev)
d6db7dce7cd965 Chris Morgan 2025-08-12 139 {
d6db7dce7cd965 Chris Morgan 2025-08-12 140 struct device *dev = &pdev->dev;
d6db7dce7cd965 Chris Morgan 2025-08-12 141 struct bq257xx_device *bq = dev_get_drvdata(pdev->dev.parent);
d6db7dce7cd965 Chris Morgan 2025-08-12 142 struct bq257xx_reg_data *pdata;
d6db7dce7cd965 Chris Morgan 2025-08-12 143 struct device_node *np = dev->of_node;
d6db7dce7cd965 Chris Morgan 2025-08-12 144 struct regulator_init_data *init_data;
d6db7dce7cd965 Chris Morgan 2025-08-12 145 struct regulator_config cfg = {};
d6db7dce7cd965 Chris Morgan 2025-08-12 146
d6db7dce7cd965 Chris Morgan 2025-08-12 147 pdev->dev.of_node = pdev->dev.parent->of_node;
d6db7dce7cd965 Chris Morgan 2025-08-12 148 pdev->dev.of_node_reused = true;
d6db7dce7cd965 Chris Morgan 2025-08-12 149
d6db7dce7cd965 Chris Morgan 2025-08-12 150 pdata = devm_kzalloc(&pdev->dev, sizeof(struct bq257xx_reg_data), GFP_KERNEL);
d6db7dce7cd965 Chris Morgan 2025-08-12 151 if (!pdata)
d6db7dce7cd965 Chris Morgan 2025-08-12 152 return -ENOMEM;
d6db7dce7cd965 Chris Morgan 2025-08-12 153
d6db7dce7cd965 Chris Morgan 2025-08-12 154 pdata->bq = bq;
d6db7dce7cd965 Chris Morgan 2025-08-12 155 pdata->desc = bq25703_vbus_desc;
d6db7dce7cd965 Chris Morgan 2025-08-12 156
d6db7dce7cd965 Chris Morgan 2025-08-12 157 platform_set_drvdata(pdev, pdata);
d6db7dce7cd965 Chris Morgan 2025-08-12 158 bq257xx_reg_dt_parse_gpio(pdev);
d6db7dce7cd965 Chris Morgan 2025-08-12 159
d6db7dce7cd965 Chris Morgan 2025-08-12 160 cfg.dev = &pdev->dev;
d6db7dce7cd965 Chris Morgan 2025-08-12 @161 cfg.init_data = init_data;
d6db7dce7cd965 Chris Morgan 2025-08-12 162 cfg.driver_data = pdata;
d6db7dce7cd965 Chris Morgan 2025-08-12 163 cfg.of_node = np;
d6db7dce7cd965 Chris Morgan 2025-08-12 164 cfg.regmap = dev_get_regmap(pdev->dev.parent, NULL);
d6db7dce7cd965 Chris Morgan 2025-08-12 165 if (!cfg.regmap)
d6db7dce7cd965 Chris Morgan 2025-08-12 166 return -ENODEV;
d6db7dce7cd965 Chris Morgan 2025-08-12 167
d6db7dce7cd965 Chris Morgan 2025-08-12 168 pdata->bq257xx_reg = devm_regulator_register(dev, &pdata->desc, &cfg);
d6db7dce7cd965 Chris Morgan 2025-08-12 169 if (IS_ERR(pdata->bq257xx_reg)) {
d6db7dce7cd965 Chris Morgan 2025-08-12 170 return dev_err_probe(&pdev->dev, PTR_ERR(pdata->bq257xx_reg),
d6db7dce7cd965 Chris Morgan 2025-08-12 171 "error registering bq257xx regulator");
d6db7dce7cd965 Chris Morgan 2025-08-12 172 }
d6db7dce7cd965 Chris Morgan 2025-08-12 173
d6db7dce7cd965 Chris Morgan 2025-08-12 174 return 0;
d6db7dce7cd965 Chris Morgan 2025-08-12 175 }
d6db7dce7cd965 Chris Morgan 2025-08-12 176 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Dan Carpenter
build botRe: [PATCH V6 4/5] regulator: bq257xx: Add bq257xx boost regulator driver
In reply to Chris MorganBCC: [email protected] CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Chris Morgan…
BCC: [email protected]
CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Chris Morgan <[email protected]>
TO: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: Chris Morgan <[email protected]>
Hi Chris,
kernel test robot noticed the following build warnings:
[auto build test WARNING on broonie-regulator/for-next]
[also build test WARNING on sre-power-supply/for-next rockchip/for-next linus/master v6.17-rc2 next-20250820] [cannot apply to lee-mfd/for-mfd-next lee-mfd/for-mfd-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chris-Morgan/dt-bindings-mfd-ti-bq25703a-Add-TI-BQ25703A-Charger/20250813-054704 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next patch link: https://lore.kernel.org/r/20250812214300.123129-5-macroalpha82%40gmail.com patch subject: [PATCH V6 4/5] regulator: bq257xx: Add bq257xx boost regulator driver
:::::: branch date: 8 days ago
:::::: commit date: 8 days ago
config: xtensa-randconfig-r073-20250819 (https://download.01.org/0day-ci/archive/20250821/[email protected]/config)
compiler: xtensa-linux-gcc (GCC) 9.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/
smatch warnings:drivers/regulator/bq257xx-regulator.c:132 bq257xx_reg_dt_parse_gpio() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +132 drivers/regulator/bq257xx-regulator.c
d6db7dce7cd965 Chris Morgan 2025-08-12 105
d6db7dce7cd965 Chris Morgan 2025-08-12 106 /* Get optional GPIO for OTG regulator enable. */
d6db7dce7cd965 Chris Morgan 2025-08-12 107 static void bq257xx_reg_dt_parse_gpio(struct platform_device *pdev)
d6db7dce7cd965 Chris Morgan 2025-08-12 108 {
d6db7dce7cd965 Chris Morgan 2025-08-12 109 struct device_node *child, *subchild;
d6db7dce7cd965 Chris Morgan 2025-08-12 110 struct bq257xx_reg_data *pdata = platform_get_drvdata(pdev);
d6db7dce7cd965 Chris Morgan 2025-08-12 111
d6db7dce7cd965 Chris Morgan 2025-08-12 112 child = of_get_child_by_name(pdev->dev.of_node,
d6db7dce7cd965 Chris Morgan 2025-08-12 113 pdata->desc.regulators_node);
d6db7dce7cd965 Chris Morgan 2025-08-12 114 if (!child)
d6db7dce7cd965 Chris Morgan 2025-08-12 115 return;
d6db7dce7cd965 Chris Morgan 2025-08-12 116
d6db7dce7cd965 Chris Morgan 2025-08-12 117 subchild = of_get_child_by_name(child, pdata->desc.of_match);
d6db7dce7cd965 Chris Morgan 2025-08-12 118 if (!subchild)
d6db7dce7cd965 Chris Morgan 2025-08-12 119 return;
d6db7dce7cd965 Chris Morgan 2025-08-12 120
d6db7dce7cd965 Chris Morgan 2025-08-12 121 of_node_put(child);
d6db7dce7cd965 Chris Morgan 2025-08-12 122
d6db7dce7cd965 Chris Morgan 2025-08-12 123 pdata->otg_en_gpio = devm_fwnode_gpiod_get_index(&pdev->dev,
d6db7dce7cd965 Chris Morgan 2025-08-12 124 of_fwnode_handle(subchild),
d6db7dce7cd965 Chris Morgan 2025-08-12 125 "enable", 0,
d6db7dce7cd965 Chris Morgan 2025-08-12 126 GPIOD_OUT_LOW,
d6db7dce7cd965 Chris Morgan 2025-08-12 127 pdata->desc.of_match);
d6db7dce7cd965 Chris Morgan 2025-08-12 128
d6db7dce7cd965 Chris Morgan 2025-08-12 129 of_node_put(subchild);
d6db7dce7cd965 Chris Morgan 2025-08-12 130
d6db7dce7cd965 Chris Morgan 2025-08-12 131 if (IS_ERR_OR_NULL(pdata->otg_en_gpio)) {
d6db7dce7cd965 Chris Morgan 2025-08-12 @132 dev_err(&pdev->dev, "Error getting enable gpio: %ld\n",
d6db7dce7cd965 Chris Morgan 2025-08-12 133 PTR_ERR(pdata->otg_en_gpio));
d6db7dce7cd965 Chris Morgan 2025-08-12 134 return;
d6db7dce7cd965 Chris Morgan 2025-08-12 135 }
d6db7dce7cd965 Chris Morgan 2025-08-12 136 }d6db7dce7cd965 Chris Morgan 2025-08-12 137
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
PATCH v6 5/5 arm64: dts: rockchip: Add USB and charger to Gameforce Ace
In reply to Chris MorganFrom: Chris Morgan <[email protected]>
Add support for the BQ25703A charger manager and boost regulator to the Gameforce Ace. Add the USB-C port and PHY as well as they all depend on each other for operation.
--- .../dts/rockchip/rk3588s-gameforce-ace.dts | 122 ++++++++++++++++++ 1 file changed, 122 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dts +122 -0
@@ -612,6 +612,56 @@ &i2c6 { pinctrl-0 = <&i2c6m3_xfer>; status = "okay"; + fusb302: typec@22 { + compatible = "fcs,fusb302"; + reg = <0x22>; + interrupt-parent = <&gpio0>; + interrupts = <RK_PC7 IRQ_TYPE_LEVEL_LOW>; + pinctrl-0 = <&usbc0_int>; + pinctrl-names = "default"; + vbus-supply = <&usb_otg_vbus>; + + connector { + compatible = "usb-c-connector"; + data-role = "dual"; + label = "USB-C"; + op-sink-microwatt = <1000000>; + power-role = "dual"; + self-powered; + sink-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM) + PDO_FIXED(9000, 3000, PDO_FIXED_USB_COMM) + PDO_FIXED(12000, 3000, PDO_FIXED_USB_COMM)>; + source-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>; + try-power-role = "sink"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + usbc0_orien_sw: endpoint { + remote-endpoint = <&usbdp_phy0_orientation_switch>; + }; + }; + + port@1 { + reg = <1>; + usbc0_role_sw: endpoint { + remote-endpoint = <&dwc3_0_role_switch>; + }; + }; + + port@2 { + reg = <2>; + dp_altmode_mux: endpoint { + remote-endpoint = <&usbdp_phy0_dp_altmode_mux>; + }; + }; + }; + }; + }; + rtc_hym8563: rtc@51 { compatible = "haoyu,hym8563"; reg = <0x51>;
@@ -640,8 +690,34 @@ battery@62 { 0x2F 0x00 0x64 0xA5 0xB5 0x1C 0xF0 0x49>; cellwise,monitor-interval-ms = <5000>; monitored-battery = <&battery>; + power-supplies = <&bq25703>; status = "okay"; }; + + bq25703: charger@6b { + compatible = "ti,bq25703a"; + reg = <0x6b>; + input-current-limit-microamp = <5000000>; + interrupt-parent = <&gpio0>; + interrupts = <RK_PD5 IRQ_TYPE_LEVEL_LOW>; + monitored-battery = <&battery>; + pinctrl-0 = <&charger_int_h>; + pinctrl-names = "default"; + power-supplies = <&fusb302>; + + regulators { + usb_otg_vbus: vbus { + enable-gpios = <&gpio4 RK_PA6 GPIO_ACTIVE_HIGH>; + pinctrl-0 = <&boost_enable_h>; + pinctrl-names = "default"; + regulator-max-microamp = <960000>; + regulator-max-microvolt = <5088000>; + regulator-min-microamp = <512000>; + regulator-min-microvolt = <4992000>; + regulator-name = "usb_otg_vbus"; + }; + }; + }; }; &i2c7 {
@@ -853,6 +929,12 @@ usbc0_int: usbc0-int { rockchip,pins = <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_up>; }; + + usbc_sbu_dc: usbc-sbu-dc { + rockchip,pins = + <4 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>, + <4 RK_PA1 RK_FUNC_GPIO &pcfg_pull_none>; + }; }; vcc3v3-lcd {
@@ -1286,6 +1368,46 @@ bluetooth { }; }; +&usb_host0_xhci { + usb-role-switch; + status = "okay"; + + port { + #address-cells = <1>; + #size-cells = <0>; + dwc3_0_role_switch: endpoint@0 { + reg = <0>; + remote-endpoint = <&usbc0_role_sw>; + }; + }; +}; + +&usbdp_phy0 { + mode-switch; + orientation-switch; + pinctrl-0 = <&usbc_sbu_dc>; + pinctrl-names = "default"; + sbu1-dc-gpios = <&gpio4 RK_PA0 GPIO_ACTIVE_HIGH>; + sbu2-dc-gpios = <&gpio4 RK_PA1 GPIO_ACTIVE_HIGH>; + rockchip,dp-lane-mux = <2 3>; + status = "okay"; + + port { + #address-cells = <1>; + #size-cells = <0>; + + usbdp_phy0_orientation_switch: endpoint@0 { + reg = <0>; + remote-endpoint = <&usbc0_orien_sw>; + }; + + usbdp_phy0_dp_altmode_mux: endpoint@1 { + reg = <1>; + remote-endpoint = <&dp_altmode_mux>; + }; + }; +}; + &vop { status = "okay"; };
Signature · 1 line
2.43.0