Skip to contentSkip to conversation

package/tinyssh: fix build issues with GCC 14

PATCH Applied Florian Larysch 2 participants 3 messages Aug 12, 2025 – Aug 21, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/tinyssh: fix build issues with GCC 14

tinyssh 20240101 fails to build on GCC 14 because of a missing include for a forward declaration. Import the upstream patch that fixes it.

---
There have been a number of newer releases since 20240101 that also include this fix, but there also have been some build system changes as well as a license change. For this reason and for porting this to stable it makes sense to fix this issue separately first.

 ...issing-bug.h-include-for-global_die-.patch | 33 +++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 package/tinyssh/0001-packet_put-Add-missing-bug.h-include-for-global_die-.patch
package/tinyssh/0001-packet_put-Add-missing-bug.h-include-for-global_die-.patch new file +33 -0
new file mode 100644
index 0000000000..99649d4690
@@ -0,0 +1,33 @@
+From f863e60d93006019855a0431ea5cd71c8f1fc173 Mon Sep 17 00:00:00 2001
+From: Haelwenn Monnier <[email protected]>
+Date: Tue, 9 Jan 2024 20:15:29 +0100
+Subject: [PATCH] packet_put: Add missing bug.h include for global_die (#84)
+
+```
+packet_put.c:53:9: error: call to undeclared function 'global_die'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
+        global_die(111);
+        ^
+1 error generated.
+```
+
+Upstream: https://github.com/janmojzis/tinyssh/commit/f863e60d93006019855a0431ea5cd71c8f1fc173
+Signed-off-by: Florian Larysch <[email protected]>
+---
+ tinyssh/packet_put.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tinyssh/packet_put.c b/tinyssh/packet_put.c
+index 17e8d84..7f46ff6 100644
+--- a/tinyssh/packet_put.c
++++ b/tinyssh/packet_put.c
+@@ -6,6 +6,7 @@ Public domain.
+ 
+ #include "uint32_pack_big.h"
+ #include "buf.h"
++#include "bug.h"
+ #include "sshcrypto.h"
+ #include "ssh.h"
+ #include "log.h"
+-- 
+2.50.1
+
Signature · 6 lines
2.50.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 10 lines · On Tue, 12 Aug 2025 23:57:37 +0200 Florian Larysch <[email protected]> wrote:

tinyssh 20240101 fails to build on GCC 14 because of a missing include for a forward declaration. Import the upstream patch that fixes it.

---
There have been a number of newer releases since 20240101 that also include this fix, but there also have been some build system changes as well as a license change. For this reason and for porting this to stable it makes sense to fix this issue separately first.

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Florian Larysch

In reply of:

Quoted 5 lines

tinyssh 20240101 fails to build on GCC 14 because of a missing include for a forward declaration. Import the upstream patch that fixes it.

Applied to 2025.02.x & 2025.05.x. Thanks

Quoted 56 lines

---
There have been a number of newer releases since 20240101 that also include this fix, but there also have been some build system changes as well as a license change. For this reason and for porting this to stable it makes sense to fix this issue separately first.

 ...issing-bug.h-include-for-global_die-.patch | 33 +++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 package/tinyssh/0001-packet_put-Add-missing-bug.h-include-for-global_die-.patch
package/tinyssh/0001-packet_put-Add-missing-bug.h-include-for-global_die-.patch new file +33 -0
new file mode 100644
index 0000000000..99649d4690
@@ -0,0 +1,33 @@
+From f863e60d93006019855a0431ea5cd71c8f1fc173 Mon Sep 17 00:00:00 2001
+From: Haelwenn Monnier <[email protected]>
+Date: Tue, 9 Jan 2024 20:15:29 +0100
+Subject: [PATCH] packet_put: Add missing bug.h include for global_die (#84)
+
+```
+packet_put.c:53:9: error: call to undeclared function 'global_die'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
+        global_die(111);
+        ^
+1 error generated.
+```
+
+Upstream: https://github.com/janmojzis/tinyssh/commit/f863e60d93006019855a0431ea5cd71c8f1fc173
+Signed-off-by: Florian Larysch <[email protected]>
+---
+ tinyssh/packet_put.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tinyssh/packet_put.c b/tinyssh/packet_put.c
+index 17e8d84..7f46ff6 100644
+--- a/tinyssh/packet_put.c
++++ b/tinyssh/packet_put.c
+@@ -6,6 +6,7 @@ Public domain.
+ 
+ #include "uint32_pack_big.h"
+ #include "buf.h"
++#include "bug.h"
+ #include "sshcrypto.h"
+ #include "ssh.h"
+ #include "log.h"
+-- 
+2.50.1
+
Signature · 6 lines
2.50.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot