Skip to contentSkip to conversation

Input: gpio-keys - do not print gpio number if using gpiod

PATCH New Andrew Davis 1 participant 1 message Aug 13, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: gpio-keys - do not print gpio number if using gpiod

The value in button->gpio is not valid when in this branch which is for the case of gpiod. Do not print this out as it will always be 0 here.

While here, there is no reason to assign irq to error, use irq directly. Lastly, dev_err_probe() returns the given error value, so we can return directly the result of dev_err_probe() making this a single line.

---
 drivers/input/keyboard/gpio_keys.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/input/keyboard/gpio_keys.c +2 -7
index f9db86da0818b..05f8ccdfba920 100644
@@ -580,13 +580,8 @@ static int gpio_keys_setup_key(struct platform_device *pdev,
 			bdata->irq = button->irq;
 		} else {
 			irq = gpiod_to_irq(bdata->gpiod);
-			if (irq < 0) {
-				error = irq;
-				dev_err_probe(dev, error,
-					      "Unable to get irq number for GPIO %d\n",
-					      button->gpio);
-				return error;
-			}
+			if (irq < 0)
+				return dev_err_probe(dev, irq, "Unable to get irq from GPIO\n");
 			bdata->irq = irq;
 		}
 
Signature · 1 line
2.39.2