f2fs/018: check data eof after partial truncation on compressed cluster
PATCH v2 1/3 f2fs/018: check data eof after partial truncation on compressed cluster
This is a regression testcase, it is added to check below case and its variants:
- write 16k data into compressed file (data will be compressed)
- truncate file to 12k (truncate partial data in compressed cluster)
- truncate file to 20k
- verify data in range of [12k, 16k] to see whether data is all zero or not
---
v2:
- add missing _require_xfs_io_command "truncate"
- add missing _require_fio $fio_config
- use $XFS_IO_PROG instead of xfs_io
- avoid mkfs&mount .. umount for each round test
tests/f2fs/018 | 77 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/018.out | 2 ++ 2 files changed, 79 insertions(+) create mode 100755 tests/f2fs/018 create mode 100644 tests/f2fs/018.out
tests/f2fs/018 new file +77 -0
@@ -0,0 +1,77 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/018 +# +# This is a regression test to check whether page eof will be +# zero or not after we truncate partial data in compressed +# cluster. +# +. ./common/preamble +_begin_fstest auto quick rw compress + +_fixed_by_kernel_commit ba8dac350faf \ + "f2fs: fix to zero post-eof page" +_fixed_by_kernel_commit xxxxxxxxxxxx \ + "f2fs: fix to zero data after EOF for compressed file correctly" + +_require_xfs_io_command "truncate" +_require_scratch + +testfile=$SCRATCH_MNT/testfile +fio_config=$tmp.fio + +cat >$fio_config <<EOF +[global] +filename=$testfile +rw=read +verify=pattern +verify_pattern=0x00 +do_verify=1 +verify_only +offset=0 +size=4k +numjobs=1 +EOF +_require_fio $fio_config + +_scratch_mkfs "-O extra_attr,compression" >> $seqres.full || _fail "mkfs failed" +_scratch_mount "-o compress_extension=*" >> $seqres.full + +check_data_eof() +{ + local eof_start=$1 + local eof_size=$2 + local filesize=$3 + local offset1=$4 + local offset2=$5 + local offset3=$6 + + + $XFS_IO_PROG -f -c "pwrite 0 $filesize" -c "fsync" $testfile >> $seqres.full + $XFS_IO_PROG -c "truncate $offset1" $testfile + $XFS_IO_PROG -c "truncate $offset2" $testfile + + if [ "$offset3" ]; then + xfs_io -c "truncate $offset3" $testfile + fi + + $FIO_PROG --name=verify-data --filename=$testfile --rw=read --verify=pattern \ + --verify_pattern=0x00 --do_verify=1 --verify_only --offset=$eof_start \ + --size=$eof_size >> $seqres.full 2>&1 || _fail "eof data is not zero" + + rm -f $testfile +} + +check_data_eof 12k 4k 16k 12k 20k +check_data_eof 10k 6k 16k 10k 20k +check_data_eof 12k 4k 16k 8k 12k 20k +check_data_eof 10k 6k 16k 8k 10k 20k + +_scratch_unmount + +echo "Silence is golden" + +status=0 +exit
tests/f2fs/018.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 018 +Silence is golden
Signature · 1 line
2.49.0
PATCH v2 2/3 f2fs/019: do sanity check on mapping table
This is a regression test:
1. create a file
2. write file to create a direct node at special offset
3. use inject.f2fs to inject nid of direct node w/ ino of the inode
4. check whether f2fs kernel module will detect and report such corruption in the fil
---
v2:
- use _require_scratch_nocheck instead of _require_scratch
- use $XFS_IO_PROG instead of xfs_io
- add comments for why exporting MKFS_OPTIONS=""
tests/f2fs/019 | 42 ++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/019.out | 2 ++ 2 files changed, 44 insertions(+) create mode 100755 tests/f2fs/019 create mode 100644 tests/f2fs/019.out
tests/f2fs/019 new file +42 -0
@@ -0,0 +1,42 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/019 +# +# This is a regression test: +# 1. create a file +# 2. write file to create a direct node at special offset +# 3. use inject.f2fs to inject nid of direct node w/ ino of the inode +# 4. check whether f2fs kernel module will detect and report such +# corruption in the file +# +. ./common/preamble +_begin_fstest auto quick rw + +_fixed_by_kernel_commit 77de19b6867f \ + "f2fs: fix to avoid out-of-boundary access in dnode page" + +_require_scratch_nocheck +_require_command "$F2FS_INJECT_PROG" inject.f2fs + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +testfile=$SCRATCH_MNT/testfile + +_scratch_mkfs >> $seqres.full +_scratch_mount + +$XFS_IO_PROG -f -c "pwrite 3738M 1M" -c "fsync" $testfile >> $seqres.full + +_scratch_unmount + +$F2FS_INJECT_PROG --node --mb addr --nid 5 --idx 937 --val 4 $SCRATCH_DEV >> $seqres.full + +_scratch_mount +$XFS_IO_PROG -c "pread 3700M 40M" $testfile +_scratch_unmount + +status=0 +exit
tests/f2fs/019.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 019 +pread: Structure needs cleaning
Signature · 1 line
2.49.0
Re: [PATCH v2 2/3] f2fs/019: do sanity check on mapping table
Quoted 10 lines · Chao Yu
This is a regression test:
1. create a file
2. write file to create a direct node at special offset
3. use inject.f2fs to inject nid of direct node w/ ino of the inode
4. check whether f2fs kernel module will detect and report such corruption in the filCc Jaegeuk Kim <[email protected]>Signed-off-by Chao Yu <[email protected]>---
This version looks good to me, thanks for this new test coverage :)
Quoted 69 lines
v2:
- use_require_scratch_nocheckinstead of_require_scratch
- use $XFS_IO_PROG instead ofxfs_io
- add comments for why exporting MKFS_OPTIONS=""tests/f2fs/019 | 42 ++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/019.out | 2 ++ 2 files changed, 44 insertions(+) create mode 100755 tests/f2fs/019 create mode 100644 tests/f2fs/019.outtests/f2fs/019 new file +42
-0@@ -0,0 +1,42 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/019 +# +# This is a regression test: +# 1. create a file +# 2. write file to create a direct node at special offset +# 3. use inject.f2fs to inject nid of direct node w/ ino of the inode +# 4. check whether f2fs kernel module will detect and report such +# corruption in the file +# +. ./common/preamble +_begin_fstest auto quick rw + +_fixed_by_kernel_commit 77de19b6867f \ + "f2fs: fix to avoid out-of-boundary access in dnode page" + +_require_scratch_nocheck +_require_command "$F2FS_INJECT_PROG" inject.f2fs + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +testfile=$SCRATCH_MNT/testfile + +_scratch_mkfs >> $seqres.full +_scratch_mount + +$XFS_IO_PROG -f -c "pwrite 3738M 1M" -c "fsync" $testfile >> $seqres.full + +_scratch_unmount + +$F2FS_INJECT_PROG --node --mb addr --nid 5 --idx 937 --val 4 $SCRATCH_DEV >> $seqres.full + +_scratch_mount +$XFS_IO_PROG -c "pread 3700M 40M" $testfile +_scratch_unmount + +status=0 +exittests/f2fs/019.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 019 +pread: Structure needs cleaningSignature · 1 line
2.49.0
PATCH v2 3/3 f2fs/020: do sanity check on i_xattr_nid
In reply to Chao YuThis is a regression test:
1. create directory
2. add a new xattr entry to create xattr node
3. use inject.f2fs to inject nid of xattr node w/ ino in a file
4. check whether f2fs kernel module will detect and report such corruption in the file
---
v3:
- use _require_scratch_nocheck instead of _require_scratch
- add missing _require_attrs user
- add comments for why exporting MKFS_OPTIONS=""
tests/f2fs/020 | 51 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/020.out | 2 ++ 2 files changed, 53 insertions(+) create mode 100755 tests/f2fs/020 create mode 100644 tests/f2fs/020.out
tests/f2fs/020 new file +51 -0
@@ -0,0 +1,51 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/020 +# +# This is a regression test: +# 1. create directory +# 2. add a new xattr entry to create xattr node +# 3. use inject.f2fs to inject nid of xattr node w/ ino in a file +# 4. check whether f2fs kernel module will detect and report such +# corruption in the file +# +. ./common/preamble +_begin_fstest auto quick rw + +. ./common/attr + +_fixed_by_kernel_commit 061cf3a84bde \ + "f2fs: fix to do sanity check on ino and xnid" + +_require_scratch_nocheck +_require_command "$F2FS_INJECT_PROG" inject.f2fs +_require_attrs user + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +testdir=$SCRATCH_MNT/testdir + +_scratch_mkfs >> $seqres.full +_scratch_mount "-o user_xattr,noinline_xattr" + +mkdir $testdir +# add a new xattr entry to create xattr node +$SETFATTR_PROG -n user.abc -v 123 $testdir + +_scratch_unmount + +# inject i_xattr_nid w/ nid of inode node +$F2FS_INJECT_PROG --node --mb i_xattr_nid --nid 4 --val 4 $SCRATCH_DEV >> $seqres.full + +_scratch_mount +# may potentially trigger a deadlock w/ double inode_lock on parent's inode +mkdir $testdir/dir >> $seqres.full 2>&1 +_scratch_unmount + +echo "Silence is golden" + +status=0 +exit
tests/f2fs/020.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 020 +Silence is golden
Signature · 1 line
2.49.0
Re: [PATCH v2 3/3] f2fs/020: do sanity check on i_xattr_nid
Quoted 62 lines · Chao Yu
This is a regression test:
1. create directory
2. add a new xattr entry to create xattr node
3. use inject.f2fs to inject nid of xattr node w/ ino in a file
4. check whether f2fs kernel module will detect and report such corruption in the fileCc Jaegeuk Kim <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v3:
- use_require_scratch_nocheckinstead of_require_scratch
- add missing_require_attrsuser
- add comments for why exporting MKFS_OPTIONS=""tests/f2fs/020 | 51 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/020.out | 2 ++ 2 files changed, 53 insertions(+) create mode 100755 tests/f2fs/020 create mode 100644 tests/f2fs/020.outtests/f2fs/020 new file +36
-0@@ -0,0 +1,51 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/020 +# +# This is a regression test: +# 1. create directory +# 2. add a new xattr entry to create xattr node +# 3. use inject.f2fs to inject nid of xattr node w/ ino in a file +# 4. check whether f2fs kernel module will detect and report such +# corruption in the file +# +. ./common/preamble +_begin_fstest auto quick rw + +. ./common/attr + +_fixed_by_kernel_commit 061cf3a84bde \ + "f2fs: fix to do sanity check on ino and xnid" + +_require_scratch_nocheck +_require_command "$F2FS_INJECT_PROG" inject.f2fs +_require_attrs user + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +testdir=$SCRATCH_MNT/testdir + +_scratch_mkfs >> $seqres.full +_scratch_mount "-o user_xattr,noinline_xattr" + +mkdir $testdir +# add a new xattr entry to create xattr node +$SETFATTR_PROG -n user.abc -v 123 $testdir
tests/f2fs/020 line 46
Quoted 10 lines
tests/f2fs/020 new file +10
-0+ +_scratch_unmount + +# inject i_xattr_nid w/ nid of inode node +$F2FS_INJECT_PROG --node --mb i_xattr_nid --nid 4 --val 4 $SCRATCH_DEV >> $seqres.full + +_scratch_mount +# may potentially trigger a deadlock w/ double inode_lock on parent's inode +mkdir $testdir/dir >> $seqres.full 2>&1 +_scratch_unmount
Can you provide a test result to prove this test case trigger a failure on general kernel (not debug kernel). If it can, then this version is good to me :)
Thanks,
Zorro
Quoted 16 lines
tests/f2fs/020 new file +5
-0+ +echo "Silence is golden" + +status=0 +exittests/f2fs/020.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 020 +Silence is goldenSignature · 1 line
2.49.0
Re: [PATCH v2 3/3] f2fs/020: do sanity check on i_xattr_nid
Quoted 60 lines · Zorro Lang
Quoted 59 lines · Chao Yu
This is a regression test:
1. create directory
2. add a new xattr entry to create xattr node
3. use inject.f2fs to inject nid of xattr node w/ ino in a file
4. check whether f2fs kernel module will detect and report such corruption in the fileCc Jaegeuk Kim <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v3:
- use_require_scratch_nocheckinstead of_require_scratch
- add missing_require_attrsuser
- add comments for why exporting MKFS_OPTIONS=""tests/f2fs/020 | 51 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/020.out | 2 ++ 2 files changed, 53 insertions(+) create mode 100755 tests/f2fs/020 create mode 100644 tests/f2fs/020.outtests/f2fs/020 new file +33
-0@@ -0,0 +1,51 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/020 +# +# This is a regression test: +# 1. create directory +# 2. add a new xattr entry to create xattr node +# 3. use inject.f2fs to inject nid of xattr node w/ ino in a file +# 4. check whether f2fs kernel module will detect and report such +# corruption in the file +# +. ./common/preamble +_begin_fstest auto quick rw + +. ./common/attr + +_fixed_by_kernel_commit 061cf3a84bde \ + "f2fs: fix to do sanity check on ino and xnid" + +_require_scratch_nocheck +_require_command "$F2FS_INJECT_PROG" inject.f2fs +_require_attrs user + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +testdir=$SCRATCH_MNT/testdir + +_scratch_mkfs >> $seqres.full +_scratch_mount "-o user_xattr,noinline_xattr" +
Quoted 8 lines
tests/f2fs/020 line 41
Quoted 8 lines
tests/f2fs/020 new file +8
-0+mkdir $testdir +# add a new xattr entry to create xattr node +$SETFATTR_PROG -n user.abc -v 123 $testdir + +_scratch_unmount + +# inject i_xattr_nid w/ nid of inode node +$F2FS_INJECT_PROG --node --mb i_xattr_nid --nid 4 --val 4 $SCRATCH_DEV >> $seqres.full
Zorro, I missed one thing, this testcase relies on a f2fs-tools patch, please apply this before running the testcase.
Do I need to create a _require_* function for f2fs to verify whether f2fs-tools support the required feature or not?
Quoted 2 lines
tests/f2fs/020 line 43
Quoted 2 lines
tests/f2fs/020 new file +2
-0+ +_scratch_mount
Oh, I may missed to add "-o acl,user_xattr" here.
Quoted 7 lines
tests/f2fs/020 line 46
Quoted 3 lines
tests/f2fs/020 new file +3
-0+# may potentially trigger a deadlock w/ double inode_lock on parent's inode +mkdir $testdir/dir >> $seqres.full 2>&1 +_scratch_unmountCan you provide a test result to prove this test case trigger a failure on general kernel (not debug kernel). If it can, then this version is good to me :)
Well, expectation is it will hang kernel, so that the f2fs/020 will stop here once we encounter the issue.
Thanks,
Quoted 21 lines
Thanks,
ZorroQuoted 16 lines
tests/f2fs/020 new file +5
-0+ +echo "Silence is golden" + +status=0 +exittests/f2fs/020.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 020 +Silence is goldenSignature · 1 line
2.49.0
Re: [PATCH v2 3/3] f2fs/020: do sanity check on i_xattr_nid
Quoted 73 lines · Chao Yu
Quoted 60 lines · Zorro Lang
Quoted 59 lines · Chao Yu
This is a regression test:
1. create directory
2. add a new xattr entry to create xattr node
3. use inject.f2fs to inject nid of xattr node w/ ino in a file
4. check whether f2fs kernel module will detect and report such corruption in the fileCc Jaegeuk Kim <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v3:
- use_require_scratch_nocheckinstead of_require_scratch
- add missing_require_attrsuser
- add comments for why exporting MKFS_OPTIONS=""tests/f2fs/020 | 51 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/020.out | 2 ++ 2 files changed, 53 insertions(+) create mode 100755 tests/f2fs/020 create mode 100644 tests/f2fs/020.outtests/f2fs/020 new file +33
-0@@ -0,0 +1,51 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/020 +# +# This is a regression test: +# 1. create directory +# 2. add a new xattr entry to create xattr node +# 3. use inject.f2fs to inject nid of xattr node w/ ino in a file +# 4. check whether f2fs kernel module will detect and report such +# corruption in the file +# +. ./common/preamble +_begin_fstest auto quick rw + +. ./common/attr + +_fixed_by_kernel_commit 061cf3a84bde \ + "f2fs: fix to do sanity check on ino and xnid" + +_require_scratch_nocheck +_require_command "$F2FS_INJECT_PROG" inject.f2fs +_require_attrs user + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +testdir=$SCRATCH_MNT/testdir + +_scratch_mkfs >> $seqres.full +_scratch_mount "-o user_xattr,noinline_xattr" +Quoted 8 lines
tests/f2fs/020 line 41
Quoted 8 lines
tests/f2fs/020 new file +8
-0+mkdir $testdir +# add a new xattr entry to create xattr node +$SETFATTR_PROG -n user.abc -v 123 $testdir + +_scratch_unmount + +# inject i_xattr_nid w/ nid of inode node +$F2FS_INJECT_PROG --node --mb i_xattr_nid --nid 4 --val 4 $SCRATCH_DEV >> $seqres.fullZorro, I missed one thing, this testcase relies on a f2fs-tools patch, please apply this before running the testcase.
Quoted 4 lines
Do I need to create a _require_* function for f2fs to verify whether f2fs-tools support the required feature or not?
Actually for further f2fs testing (depends on injection), we'd better to have related functions, you can refer to:
_require_xfs_db_command
Or more xfs_db related functions in common/xfs if you need.
If you don't want to add this _require_ function in this patch (this's not the only one f2fs case uses inject.f2fs), I think you can send another patchset to do that later (just let this case fails on old f2fs temporarily :).
Thanks,
Zorro
Quoted 41 lines
Quoted 3 lines
tests/f2fs/020 line 43
Quoted 3 lines
tests/f2fs/020 new file +2
-0+ +_scratch_mountOh, I may missed to add "-o acl,user_xattr" here.
Quoted 7 lines
tests/f2fs/020 line 46
Quoted 3 lines
tests/f2fs/020 new file +3
-0+# may potentially trigger a deadlock w/ double inode_lock on parent's inode +mkdir $testdir/dir >> $seqres.full 2>&1 +_scratch_unmountCan you provide a test result to prove this test case trigger a failure on general kernel (not debug kernel). If it can, then this version is good to me :)
Well, expectation is it will hang kernel, so that the f2fs/020 will stop here once we encounter the issue.
Thanks,
Quoted 21 lines
Thanks,
ZorroQuoted 16 lines
tests/f2fs/020 new file +5
-0+ +echo "Silence is golden" + +status=0 +exittests/f2fs/020.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 020 +Silence is goldenSignature · 1 line
2.49.0
Re: [PATCH v2 3/3] f2fs/020: do sanity check on i_xattr_nid
Quoted 79 lines · Zorro Lang
Quoted 73 lines · Chao Yu
Quoted 60 lines · Zorro Lang
Quoted 59 lines · Chao Yu
This is a regression test:
1. create directory
2. add a new xattr entry to create xattr node
3. use inject.f2fs to inject nid of xattr node w/ ino in a file
4. check whether f2fs kernel module will detect and report such corruption in the fileCc Jaegeuk Kim <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v3:
- use_require_scratch_nocheckinstead of_require_scratch
- add missing_require_attrsuser
- add comments for why exporting MKFS_OPTIONS=""tests/f2fs/020 | 51 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/020.out | 2 ++ 2 files changed, 53 insertions(+)create mode 100755 tests/f2fs/020
create mode 100644 tests/f2fs/020.outtests/f2fs/020 new file +33
-0@@ -0,0 +1,51 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/020 +# +# This is a regression test: +# 1. create directory +# 2. add a new xattr entry to create xattr node +# 3. use inject.f2fs to inject nid of xattr node w/ ino in a file +# 4. check whether f2fs kernel module will detect and report such +# corruption in the file +# +. ./common/preamble +_begin_fstest auto quick rw + +. ./common/attr + +_fixed_by_kernel_commit 061cf3a84bde \ + "f2fs: fix to do sanity check on ino and xnid" + +_require_scratch_nocheck +_require_command "$F2FS_INJECT_PROG" inject.f2fs +_require_attrs user + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +testdir=$SCRATCH_MNT/testdir + +_scratch_mkfs >> $seqres.full +_scratch_mount "-o user_xattr,noinline_xattr" +Quoted 8 lines
tests/f2fs/020 line 41
Quoted 8 lines
tests/f2fs/020 new file +8
-0+mkdir $testdir +# add a new xattr entry to create xattr node +$SETFATTR_PROG -n user.abc -v 123 $testdir + +_scratch_unmount + +# inject i_xattr_nid w/ nid of inode node +$F2FS_INJECT_PROG --node --mb i_xattr_nid --nid 4 --val 4 $SCRATCH_DEV >> $seqres.fullZorro, I missed one thing, this testcase relies on a f2fs-tools patch, please apply this before running the testcase.
Quoted 4 lines
Do I need to create a _require_* function for f2fs to verify whether f2fs-tools support the required feature or not?
Quoted 6 lines
Actually for further f2fs testing (depends on injection), we'd better to have related functions, you can refer to:
_require_xfs_db_commandOr more
xfs_dbrelated functions in common/xfs if you need.
Thanks for the information.
Quoted 4 lines
If you don't want to add this _require_ function in this patch (this's not the only one f2fs case uses inject.f2fs), I think you can send another patchset to do that later (just let this case fails on old f2fs temporarily :).
Okay, will introduce _require_ function in separated patch. :)
Thanks,
Quoted 46 lines
Thanks,
ZorroQuoted 41 lines
Quoted 3 lines
tests/f2fs/020 line 43
Quoted 3 lines
tests/f2fs/020 new file +2
-0+ +_scratch_mountOh, I may missed to add "-o acl,user_xattr" here.
Quoted 7 lines
tests/f2fs/020 line 46
Quoted 3 lines
tests/f2fs/020 new file +3
-0+# may potentially trigger a deadlock w/ double inode_lock on parent's inode +mkdir $testdir/dir >> $seqres.full 2>&1 +_scratch_unmountCan you provide a test result to prove this test case trigger a failure on general kernel (not debug kernel). If it can, then this version is good to me :)
Well, expectation is it will hang kernel, so that the f2fs/020 will stop here once we encounter the issue.
Thanks,
Quoted 21 lines
Thanks,
ZorroQuoted 16 lines
tests/f2fs/020 new file +5
-0+ +echo "Silence is golden" + +status=0 +exittests/f2fs/020.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 020 +Silence is goldenSignature · 1 line
2.49.0
Quoted 55 lines · Chao Yu
This is a regression testcase, it is added to check below case and its variants:
- write 16k data into compressed file (data will be compressed)
- truncate file to 12k (truncate partial data in compressed cluster)
- truncate file to 20k
- verify data in range of [12k, 16k] to see whether data is all zero or notCc Jaegeuk Kim <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v2:
- add missing_require_xfs_io_command"truncate"
- add missing_require_fio$fio_config
- use $XFS_IO_PROG instead ofxfs_io
- avoid mkfs&mount .. umount for each round testtests/f2fs/018 | 77 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/018.out | 2 ++ 2 files changed, 79 insertions(+) create mode 100755 tests/f2fs/018 create mode 100644 tests/f2fs/018.outtests/f2fs/018 new file +27
-0@@ -0,0 +1,77 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/018 +# +# This is a regression test to check whether page eof will be +# zero or not after we truncate partial data in compressed +# cluster. +# +. ./common/preamble +_begin_fstest auto quick rw compress + +_fixed_by_kernel_commit ba8dac350faf \ + "f2fs: fix to zero post-eof page" +_fixed_by_kernel_commit xxxxxxxxxxxx \ + "f2fs: fix to zero data after EOF for compressed file correctly" + +_require_xfs_io_command "truncate" +_require_scratch + +testfile=$SCRATCH_MNT/testfile +fio_config=$tmp.fio + +cat >$fio_config <<EOF +[global] +filename=$testfile
tests/f2fs/018 line 37
Quoted 10 lines
tests/f2fs/018 new file +10
-0+rw=read +verify=pattern +verify_pattern=0x00 +do_verify=1 +verify_only +offset=0 +size=4k +numjobs=1 +EOF +_require_fio $fio_config
Hmm... that looks strange if you create fio config file but don't use it later :-D
How about:
build_fio_config()
{
local offset=$1
local size=$2
cat >$fio_config <<EOF
[global]
filename=$testfile
rw=read
verify=pattern
verify_pattern=0x00
do_verify=1verify_only
offset=$offset
size=$size
numjobs=1
EOF
}
build_fio_config 0 4k_require_fio $fio_config
Quoted 4 lines
tests/f2fs/018 new file +4
-0+ +_scratch_mkfs "-O extra_attr,compression" >> $seqres.full || _fail "mkfs failed" +_scratch_mount "-o compress_extension=*" >> $seqres.full +
tests/f2fs/018 line 51
Quoted 10 lines
tests/f2fs/018 new file +10
-0+check_data_eof() +{ + local eof_start=$1 + local eof_size=$2 + local filesize=$3 + local offset1=$4 + local offset2=$5 + local offset3=$6 + +
rm -f $testfile
tests/f2fs/018 line 57
Quoted 6 lines
tests/f2fs/018 new file +6
-0+ $XFS_IO_PROG -f -c "pwrite 0 $filesize" -c "fsync" $testfile >> $seqres.full + $XFS_IO_PROG -c "truncate $offset1" $testfile + $XFS_IO_PROG -c "truncate $offset2" $testfile + + if [ "$offset3" ]; then + xfs_io -c "truncate $offset3" $testfile
^^^^^^
$XFS_IO_PROGtests/f2fs/018 line 62
Quoted 5 lines
tests/f2fs/018 new file +5
-0+ fi + + $FIO_PROG --name=verify-data --filename=$testfile --rw=read --verify=pattern \ + --verify_pattern=0x00 --do_verify=1 --verify_only --offset=$eof_start \ + --size=$eof_size >> $seqres.full 2>&1 || _fail "eof data is not zero"
build_fio_config $eof_start $eof_size
$FIO_PROG $fio_config >> $seqres.full 2>&1
tests/f2fs/018 line 64
Quoted 2 lines
tests/f2fs/018 new file +2
-0+ + rm -f $testfile
Move this line to above, then
return $?
tests/f2fs/018 line 70
Quoted 6 lines
tests/f2fs/018 new file +6
-0+} + +check_data_eof 12k 4k 16k 12k 20k +check_data_eof 10k 6k 16k 10k 20k +check_data_eof 12k 4k 16k 8k 12k 20k +check_data_eof 10k 6k 16k 8k 10k 20k
run_check check_data_eof 12k 4k 16k 12k 20krun_check check_data_eof 10k 6k 16k 10k 20krun_check check_data_eof 12k 4k 16k 8k 12k 20krun_check check_data_eof 10k 6k 16k 8k 10k 20k
This can help you to know which line fails if one of them is failed. Or you always get "eof data is not zero", no matter which line fails :)
tests/f2fs/018 line 72
Quoted 2 lines
tests/f2fs/018 new file +2
-0+ +_scratch_unmount
This unmount looks useless, due to SCRATCH_DEV is always unmounted after a test done.
Thanks,
Zorro
Quoted 16 lines
tests/f2fs/018 new file +5
-0+ +echo "Silence is golden" + +status=0 +exittests/f2fs/018.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 018 +Silence is goldenSignature · 1 line
2.49.0
Quoted 47 lines · Zorro Lang
Quoted 46 lines · Chao Yu
This is a regression testcase, it is added to check below case and its variants:
- write 16k data into compressed file (data will be compressed)
- truncate file to 12k (truncate partial data in compressed cluster)
- truncate file to 20k
- verify data in range of [12k, 16k] to see whether data is all zero or notCc Jaegeuk Kim <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v2:
- add missing_require_xfs_io_command"truncate"
- add missing_require_fio$fio_config
- use $XFS_IO_PROG instead ofxfs_io
- avoid mkfs&mount .. umount for each round testtests/f2fs/018 | 77 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/018.out | 2 ++ 2 files changed, 79 insertions(+) create mode 100755 tests/f2fs/018 create mode 100644 tests/f2fs/018.outtests/f2fs/018 new file +18
-0@@ -0,0 +1,77 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/018 +# +# This is a regression test to check whether page eof will be +# zero or not after we truncate partial data in compressed +# cluster. +# +. ./common/preamble +_begin_fstest auto quick rw compress + +_fixed_by_kernel_commit ba8dac350faf \ + "f2fs: fix to zero post-eof page" +_fixed_by_kernel_commit xxxxxxxxxxxx \ + "f2fs: fix to zero data after EOF for compressed file correctly" +
Quoted 8 lines
tests/f2fs/018 line 26
Quoted 8 lines
tests/f2fs/018 new file +8
-0+_require_xfs_io_command "truncate" +_require_scratch + +testfile=$SCRATCH_MNT/testfile +fio_config=$tmp.fio + +cat >$fio_config <<EOF +[global]
I updated task name from global to verify-data to avoid "No job(s) defined" error from fio.
Quoted 21 lines
tests/f2fs/018 line 37
Quoted 11 lines
tests/f2fs/018 new file +11
-0+filename=$testfile +rw=read +verify=pattern +verify_pattern=0x00 +do_verify=1 +verify_only +offset=0 +size=4k +numjobs=1 +EOF +_require_fio $fio_configHmm... that looks strange if you create fio config file but don't use it later :-D
How about:
build_fio_config()
{
local offset=$1
local size=$2
Quoted 12 lines
cat >$fio_config <<EOF
[global]
filename=$testfile
rw=read
verify=pattern
verify_pattern=0x00
do_verify=1verify_only
offset=$offset
size=$size
numjobs=1
EOF
cat $fio_config >> $seqres.full
To record fio config in seqres.full
Quoted 4 lines
}
build_fio_config0 4k_require_fio$fio_config
Add _cleanup() to remove $testfile created in last testcase.
Quoted 55 lines
Quoted 5 lines
tests/f2fs/018 new file +4
-0+ +_scratch_mkfs "-O extra_attr,compression" >> $seqres.full || _fail "mkfs failed" +_scratch_mount "-o compress_extension=*" >> $seqres.full +tests/f2fs/018 line 51
Quoted 10 lines
tests/f2fs/018 new file +10
-0+check_data_eof() +{ + local eof_start=$1 + local eof_size=$2 + local filesize=$3 + local offset1=$4 + local offset2=$5 + local offset3=$6 + +rm -f $testfile
tests/f2fs/018 line 57
Quoted 6 lines
tests/f2fs/018 new file +6
-0+ $XFS_IO_PROG -f -c "pwrite 0 $filesize" -c "fsync" $testfile >> $seqres.full + $XFS_IO_PROG -c "truncate $offset1" $testfile + $XFS_IO_PROG -c "truncate $offset2" $testfile + + if [ "$offset3" ]; then + xfs_io -c "truncate $offset3" $testfile^^^^^^ $XFS_IO_PROGtests/f2fs/018 line 62
Quoted 5 lines
tests/f2fs/018 new file +5
-0+ fi + + $FIO_PROG --name=verify-data --filename=$testfile --rw=read --verify=pattern \ + --verify_pattern=0x00 --do_verify=1 --verify_only --offset=$eof_start \ + --size=$eof_size >> $seqres.full 2>&1 || _fail "eof data is not zero"
build_fio_config$eof_start $eof_size
$FIO_PROG $fio_config >> $seqres.full 2>&1tests/f2fs/018 line 64
Quoted 2 lines
tests/f2fs/018 new file +2
-0+ + rm -f $testfileMove this line to above, then
return $?
tests/f2fs/018 line 70
Quoted 6 lines
tests/f2fs/018 new file +6
-0+} + +check_data_eof 12k 4k 16k 12k 20k +check_data_eof 10k 6k 16k 10k 20k +check_data_eof 12k 4k 16k 8k 12k 20k +check_data_eof 10k 6k 16k 8k 10k 20k
run_checkcheck_data_eof12k 4k 16k 12k 20krun_checkcheck_data_eof10k 6k 16k 10k 20krun_checkcheck_data_eof12k 4k 16k 8k 12k 20krun_checkcheck_data_eof10k 6k 16k 8k 10k 20k
Quoted 2 lines
This can help you to know which line fails if one of them is failed. Or you always get "eof data is not zero", no matter which line fails :)
Looks nice!
Quoted 5 lines
tests/f2fs/018 line 72
Quoted 3 lines
tests/f2fs/018 new file +2
-0+ +_scratch_unmountThis unmount looks useless, due to
SCRATCH_DEVis always unmounted after a test done.
Thanks for all your suggestion, will update v3.
Thanks,
Quoted 21 lines
Thanks,
ZorroQuoted 16 lines
tests/f2fs/018 new file +5
-0+ +echo "Silence is golden" + +status=0 +exittests/f2fs/018.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 018 +Silence is goldenSignature · 1 line
2.49.0