PCI: Drop superfluous pci_epc_features initialization
Subsystems (16)
cover PCI: Drop superfluous pci_epc_features initialization
Hello all,
struct pci_epc_features has static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.
Series is based on pci/next.
Feel free to squash to a single commit if that is preferable.
Kind regards,
Niklas
Niklas Cassel (13):
PCI: cadence-ep: Drop superfluous pci_epc_features initialization
PCI: rcar-ep: Drop superfluous pci_epc_features initialization
PCI: rockchip-ep: Drop superfluous pci_epc_features initialization
PCI: dra7xx: Drop superfluous pci_epc_features initialization
PCI: imx6: Drop superfluous pci_epc_features initialization
PCI: keystone: Drop superfluous pci_epc_features initialization
PCI: artpec6: Drop superfluous pci_epc_features initialization
PCI: designware-plat: Drop superfluous pci_epc_features initialization
PCI: dw-rockchip: Drop superfluous pci_epc_features initialization
PCI: keembay: Drop superfluous pci_epc_features initialization
PCI: qcom-ep: Drop superfluous pci_epc_features initialization
PCI: rcar-gen4: Drop superfluous pci_epc_features initialization
PCI: tegra194: Drop superfluous pci_epc_features initialization
drivers/pci/controller/cadence/pcie-cadence-ep.c | 2 -- drivers/pci/controller/dwc/pci-dra7xx.c | 1 - drivers/pci/controller/dwc/pci-imx6.c | 4 ---- drivers/pci/controller/dwc/pci-keystone.c | 1 - drivers/pci/controller/dwc/pcie-artpec6.c | 2 -- drivers/pci/controller/dwc/pcie-designware-plat.c | 1 - drivers/pci/controller/dwc/pcie-dw-rockchip.c | 2 -- drivers/pci/controller/dwc/pcie-keembay.c | 1 - drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 - drivers/pci/controller/dwc/pcie-rcar-gen4.c | 2 -- drivers/pci/controller/dwc/pcie-tegra194.c | 2 -- drivers/pci/controller/pcie-rcar-ep.c | 2 -- drivers/pci/controller/pcie-rockchip-ep.c | 1 - 13 files changed, 22 deletions(-)
Signature · 1 line
2.50.1
PATCH 1/13 PCI: cadence-ep: Drop superfluous pci_epc_features initialization
struct pci_epc_features has static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.
--- drivers/pci/controller/cadence/pcie-cadence-ep.c | 2 -- 1 file changed, 2 deletions(-)
drivers/pci/controller/cadence/pcie-cadence-ep.c +0 -2
@@ -608,14 +608,12 @@ static int cdns_pcie_ep_start(struct pci_epc *epc) }static const struct pci_epc_features cdns_pcie_epc_vf_features = { - .linkup_notifier = false, .msi_capable = true, .msix_capable = true, .align =65536 , };static const struct pci_epc_features cdns_pcie_epc_features = { - .linkup_notifier = false, .msi_capable = true, .msix_capable = true, .align =256 ,
Signature · 1 line
2.50.1
PATCH 2/13 PCI: rcar-ep: Drop superfluous pci_epc_features initialization
In reply to Niklas Casselstruct pci_epc_features has static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.
--- drivers/pci/controller/pcie-rcar-ep.c | 2 -- 1 file changed, 2 deletions(-)
drivers/pci/controller/pcie-rcar-ep.c +0 -2
@@ -436,9 +436,7 @@ static void rcar_pcie_ep_stop(struct pci_epc *epc) }static const struct pci_epc_features rcar_pcie_epc_features = { - .linkup_notifier = false, .msi_capable = true, - .msix_capable = false,/* use 64-bit BARs so mark BAR[1,3,5] as reserved */ .bar[BAR_0 ] = { .type =BAR_FIXED , .fixed_size =128 , .only_64bit = true, },
Signature · 1 line
2.50.1
Re: [PATCH 02/13] PCI: rcar-ep: Drop superfluous pci_epc_features initialization
Quoted 5 lines · Niklas Cassel
struct
pci_epc_featureshas static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.Signed-off-by Niklas Cassel <[email protected]>
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
PATCH 3/13 PCI: rockchip-ep: Drop superfluous pci_epc_features initialization
In reply to Niklas Casselstruct pci_epc_features has static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.
--- drivers/pci/controller/pcie-rockchip-ep.c | 1 - 1 file changed, 1 deletion(-)
drivers/pci/controller/pcie-rockchip-ep.c +0 -1
@@ -694,7 +694,6 @@ static int rockchip_pcie_ep_setup_irq(struct pci_epc *epc)static const struct pci_epc_features rockchip_pcie_epc_features = { .linkup_notifier = true, .msi_capable = true, - .msix_capable = false, .intx_capable = true, .align =ROCKCHIP_PCIE_AT_SIZE_ALIGN , };
Signature · 1 line
2.50.1
PATCH 4/13 PCI: dra7xx: Drop superfluous pci_epc_features initialization
In reply to Niklas Casselstruct pci_epc_features has static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.
--- drivers/pci/controller/dwc/pci-dra7xx.c | 1 - 1 file changed, 1 deletion(-)
drivers/pci/controller/dwc/pci-dra7xx.c +0 -1
@@ -426,7 +426,6 @@ static int dra7xx_pcie_raise_irq(struct dw_pcie_ep *ep, u8 func_no,static const struct pci_epc_features dra7xx_pcie_epc_features = { .linkup_notifier = true, .msi_capable = true, - .msix_capable = false, }; static const struct pci_epc_features*
Signature · 1 line
2.50.1
PATCH 5/13 PCI: imx6: Drop superfluous pci_epc_features initialization
In reply to Niklas Casselstruct pci_epc_features has static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.
--- drivers/pci/controller/dwc/pci-imx6.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/pci/controller/dwc/pci-imx6.c +0 -4
@@ -1387,9 +1387,7 @@ static int imx_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no, }static const struct pci_epc_features imx8m_pcie_epc_features = { - .linkup_notifier = false, .msi_capable = true, - .msix_capable = false, .bar[BAR_1 ] = { .type =BAR_RESERVED , }, .bar[BAR_3 ] = { .type =BAR_RESERVED , }, .bar[BAR_4 ] = { .type =BAR_FIXED , .fixed_size =SZ_256 , },
@@ -1398,9 +1396,7 @@ static const struct pci_epc_features imx8m_pcie_epc_features = { };static const struct pci_epc_features imx8q_pcie_epc_features = { - .linkup_notifier = false, .msi_capable = true, - .msix_capable = false, .bar[BAR_1 ] = { .type =BAR_RESERVED , }, .bar[BAR_3 ] = { .type =BAR_RESERVED , }, .bar[BAR_5 ] = { .type =BAR_RESERVED , },
Signature · 1 line
2.50.1
PATCH 6/13 PCI: keystone: Drop superfluous pci_epc_features initialization
In reply to Niklas Casselstruct pci_epc_features has static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.
--- drivers/pci/controller/dwc/pci-keystone.c | 1 - 1 file changed, 1 deletion(-)
drivers/pci/controller/dwc/pci-keystone.c +0 -1
@@ -960,7 +960,6 @@ static int ks_pcie_am654_raise_irq(struct dw_pcie_ep *ep, u8 func_no, }static const struct pci_epc_features ks_pcie_am654_epc_features = { - .linkup_notifier = false, .msi_capable = true, .msix_capable = true, .bar[BAR_0 ] = { .type =BAR_RESERVED , },
Signature · 1 line
2.50.1
PATCH 7/13 PCI: artpec6: Drop superfluous pci_epc_features initialization
In reply to Niklas Casselstruct pci_epc_features has static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.
--- drivers/pci/controller/dwc/pcie-artpec6.c | 2 -- 1 file changed, 2 deletions(-)
drivers/pci/controller/dwc/pcie-artpec6.c +0 -2
@@ -370,9 +370,7 @@ static int artpec6_pcie_raise_irq(struct dw_pcie_ep *ep, u8 func_no, }static const struct pci_epc_features artpec6_pcie_epc_features = { - .linkup_notifier = false, .msi_capable = true, - .msix_capable = false, }; static const struct pci_epc_features *
Signature · 1 line
2.50.1
PATCH 8/13 PCI: designware-plat: Drop superfluous pci_epc_features initialization
In reply to Niklas Casselstruct pci_epc_features has static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.
--- drivers/pci/controller/dwc/pcie-designware-plat.c | 1 - 1 file changed, 1 deletion(-)
drivers/pci/controller/dwc/pcie-designware-plat.c +0 -1
@@ -61,7 +61,6 @@ static int dw_plat_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no, }static const struct pci_epc_features dw_plat_pcie_epc_features = { - .linkup_notifier = false, .msi_capable = true, .msix_capable = true, };
Signature · 1 line
2.50.1
PATCH 9/13 PCI: dw-rockchip: Drop superfluous pci_epc_features initialization
In reply to Niklas Casselstruct pci_epc_features has static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.
--- drivers/pci/controller/dwc/pcie-dw-rockchip.c | 2 -- 1 file changed, 2 deletions(-)
drivers/pci/controller/dwc/pcie-dw-rockchip.c +0 -2
@@ -325,7 +325,6 @@ static const struct pci_epc_features rockchip_pcie_epc_features_rk3568 = { .linkup_notifier = true, .msi_capable = true, .msix_capable = true, - .intx_capable = false, .align = SZ_64K, .bar[BAR_0] = { .type = BAR_RESIZABLE, }, .bar[BAR_1] = { .type = BAR_RESIZABLE, },
@@ -346,7 +345,6 @@ static const struct pci_epc_features rockchip_pcie_epc_features_rk3588 = { .linkup_notifier = true, .msi_capable = true, .msix_capable = true, - .intx_capable = false, .align = SZ_64K, .bar[BAR_0] = { .type = BAR_RESIZABLE, }, .bar[BAR_1] = { .type = BAR_RESIZABLE, },
Signature · 1 line
2.50.1
PATCH 10/13 PCI: keembay: Drop superfluous pci_epc_features initialization
In reply to Niklas Casselstruct pci_epc_features has static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.
--- drivers/pci/controller/dwc/pcie-keembay.c | 1 - 1 file changed, 1 deletion(-)
drivers/pci/controller/dwc/pcie-keembay.c +0 -1
@@ -309,7 +309,6 @@ static int keembay_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no, }static const struct pci_epc_features keembay_pcie_epc_features = { - .linkup_notifier = false, .msi_capable = true, .msix_capable = true, .bar[BAR_0 ] = { .only_64bit = true, },
Signature · 1 line
2.50.1
PATCH 11/13 PCI: qcom-ep: Drop superfluous pci_epc_features initialization
In reply to Niklas Casselstruct pci_epc_features has static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.
--- drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 - 1 file changed, 1 deletion(-)
drivers/pci/controller/dwc/pcie-qcom-ep.c +0 -1
@@ -831,7 +831,6 @@ static void qcom_pcie_ep_init_debugfs(struct qcom_pcie_ep *pcie_ep)static const struct pci_epc_features qcom_pcie_epc_features = { .linkup_notifier = true, .msi_capable = true, - .msix_capable = false, .align =SZ_4K , .bar[BAR_0 ] = { .only_64bit = true, }, .bar[BAR_1 ] = { .type =BAR_RESERVED , },
Signature · 1 line
2.50.1
PATCH 12/13 PCI: rcar-gen4: Drop superfluous pci_epc_features initialization
In reply to Niklas Casselstruct pci_epc_features has static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.
--- drivers/pci/controller/dwc/pcie-rcar-gen4.c | 2 -- 1 file changed, 2 deletions(-)
drivers/pci/controller/dwc/pcie-rcar-gen4.c +0 -2
@@ -398,9 +398,7 @@ static int rcar_gen4_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no, }static const struct pci_epc_features rcar_gen4_pcie_epc_features = { - .linkup_notifier = false, .msi_capable = true, - .msix_capable = false, .bar[BAR_1 ] = { .type =BAR_RESERVED , }, .bar[BAR_3 ] = { .type =BAR_RESERVED , }, .bar[BAR_4 ] = { .type =BAR_FIXED , .fixed_size =256 },
Signature · 1 line
2.50.1
Re: [PATCH 12/13] PCI: rcar-gen4: Drop superfluous pci_epc_features initialization
Quoted 5 lines · Niklas Cassel
struct
pci_epc_featureshas static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.Signed-off-by Niklas Cassel <[email protected]>
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
PATCH 13/13 PCI: tegra194: Drop superfluous pci_epc_features initialization
In reply to Niklas Casselstruct pci_epc_features has static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.
--- drivers/pci/controller/dwc/pcie-tegra194.c | 2 -- 1 file changed, 2 deletions(-)
drivers/pci/controller/dwc/pcie-tegra194.c +0 -2
@@ -1998,8 +1998,6 @@ static int tegra_pcie_ep_raise_irq(struct dw_pcie_ep *ep, u8 func_no,static const struct pci_epc_features tegra_pcie_epc_features = { .linkup_notifier = true, - .msi_capable = false, - .msix_capable = false, .bar[BAR_0 ] = { .type =BAR_FIXED , .fixed_size =SZ_1M , .only_64bit = true, }, .bar[BAR_1 ] = { .type =BAR_RESERVED , },
Signature · 1 line
2.50.1
Quoted 29 lines · Niklas Cassel
Hello all,
struct
pci_epc_featureshas static storage duration, so all struct members are zero initialized implicitly. Thus, remove explicit zero initialization of struct members.Series is based on pci/next.
Feel free to squash to a single commit if that is preferable.
Kind regards,
NiklasNiklas Cassel (13):
PCI: cadence-ep: Drop superfluouspci_epc_featuresinitialization
PCI: rcar-ep: Drop superfluouspci_epc_featuresinitialization
PCI: rockchip-ep: Drop superfluouspci_epc_featuresinitialization
PCI: dra7xx: Drop superfluouspci_epc_featuresinitialization
PCI: imx6: Drop superfluouspci_epc_featuresinitialization
PCI: keystone: Drop superfluouspci_epc_featuresinitialization
PCI: artpec6: Drop superfluouspci_epc_featuresinitialization
PCI: designware-plat: Drop superfluouspci_epc_featuresinitialization
PCI: dw-rockchip: Drop superfluouspci_epc_featuresinitialization
PCI: keembay: Drop superfluouspci_epc_featuresinitialization
PCI: qcom-ep: Drop superfluouspci_epc_featuresinitialization
PCI: rcar-gen4: Drop superfluouspci_epc_featuresinitialization
PCI: tegra194: Drop superfluouspci_epc_featuresinitialization
Quoted 14 lines
drivers/pci/controller/cadence/pcie-cadence-ep.c | 2 -- drivers/pci/controller/dwc/pci-dra7xx.c | 1 - drivers/pci/controller/dwc/pci-imx6.c | 4 ---- drivers/pci/controller/dwc/pci-keystone.c | 1 - drivers/pci/controller/dwc/pcie-artpec6.c | 2 -- drivers/pci/controller/dwc/pcie-designware-plat.c | 1 - drivers/pci/controller/dwc/pcie-dw-rockchip.c | 2 -- drivers/pci/controller/dwc/pcie-keembay.c | 1 - drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 - drivers/pci/controller/dwc/pcie-rcar-gen4.c | 2 -- drivers/pci/controller/dwc/pcie-tegra194.c | 2 -- drivers/pci/controller/pcie-rcar-ep.c | 2 -- drivers/pci/controller/pcie-rockchip-ep.c | 1 - 13 files changed, 22 deletions(-)
Squashed into one, added "remove explicit zero initialization for features that are *not* supported so we don't have to touch existing drivers as new features are added" to commit log, and applied to pci/endpoint for v6.18, thanks, Niklas!