Skip to contentSkip to conversation

cpupower: fix mangled powercap comment

PATCH New Cryolitia PukNgae 1 participant 1 message Aug 15, 2025 CPU power monitoring

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 cpupower: fix mangled powercap comment

Remove leading dashes from current comments and clarify its semantics

---
The current comment exhibits a clear failed patch application artifact:
1. A stray '-' prefix indicating failed line removal
2. Broken sentence structure from improper context patching

For those interested in archaeology:

What appears to be version control residue has persisted since its initial introduction and through the 2022 kernel submission[1]. While my archaeological efforts only trace back to the 2017 openSUSE patch[2], the corrupted syntax suggests even older origins that remain elusive - perhaps maintainers with longer institutional memory could shed light on its provenance.

1. https://lore.kernel.org/all/[email protected]/
2. https://build.opensuse.org/request/show/535512
---
Changes in v2:
- Simplify expression
- Link to v1: https://lore.kernel.org/r/[email protected]

---
 tools/power/cpupower/lib/powercap.c | 2 --
 1 file changed, 2 deletions(-)
tools/power/cpupower/lib/powercap.c +0 -2
index 94a0c69e55ef5e4291b13a4218e706fa8d14e6a7..609943c829efce8045d97097b5f5e9ec86d0f519 100644
@@ -87,8 +87,6 @@ int powercap_set_enabled(int mode)
 
 /*
  * Hardcoded, because rapl is the only powercap implementation
-- * this needs to get more generic if more powercap implementations
- * should show up
  */
 int powercap_get_driver(char *driver, int buflen)
 {

---
base-commit: 6bcdbd62bd56e6d7383f9e06d9d148935b3c9b73
change-id: 20250806-mangled_cpupower-5186789f8b2b

Best regards,

Signature · 1 line
Cryolitia PukNgae <[email protected]>