Skip to contentSkip to conversation

tests/intel/xe_exec_compute_mode: Remove non-block section

PATCH In review Matthew Brost 2 participants 7 messages Aug 15, 2025 – Oct 14, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/intel/xe_exec_compute_mode: Remove non-block section

The non-block will become invalid and hang until the test exhausts all memory when LR jobs are tracked in the DRM scheduler.

---
 tests/intel/xe_exec_compute_mode.c | 113 -----------------------------
 1 file changed, 113 deletions(-)
tests/intel/xe_exec_compute_mode.c +0 -113
index b904dc76b4..316f7322c1 100644
@@ -320,116 +320,6 @@ test_exec(int fd, struct drm_xe_engine_class_instance *eci,
 		close(map_fd);
 }
 
-/**
- * SUBTEST: non-blocking
- * Description: Fill the ring and check we get expected errors.
- * Test category: functionality test
- */
-#define VM_DATA		0
-#define SPIN_DATA	1
-#define EXEC_DATA	2
-#define DATA_COUNT	3
-static void non_block(int fd, int expect)
-{
-	uint64_t addr = 0x1a0000;
-	struct drm_xe_sync sync[1] = {
-		{ .type = DRM_XE_SYNC_TYPE_USER_FENCE,
-		  .flags = DRM_XE_SYNC_FLAG_SIGNAL,
-		  .timeline_value = USER_FENCE_VALUE},
-	};
-	struct drm_xe_exec exec = {
-		.num_batch_buffer = 1,
-		.num_syncs = 1,
-		.syncs = to_user_pointer(&sync),
-	};
-	struct {
-		struct xe_spin spin;
-		uint32_t batch[16];
-		uint64_t vm_sync;
-		uint32_t data;
-		uint64_t exec_sync;
-	} *data = NULL;
-	struct xe_spin_opts spin_opts = { .preempt = false };
-	struct drm_xe_engine *engine;
-	uint64_t batch_offset = (char *)&data[EXEC_DATA].batch - (char *)data;
-	uint64_t batch_addr = addr + batch_offset;
-	uint64_t sdi_offset = (char *)&data[EXEC_DATA].data - (char *)data;
-	uint64_t sdi_addr = addr + sdi_offset;
-	size_t bo_size;
-	uint32_t vm;
-	uint32_t exec_queue;
-	int value = 0x123456;
-	uint32_t bo = 0;
-	int b, err;
-
-	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_LR_MODE, 0);
-	bo_size = sizeof(*data) * DATA_COUNT;
-	bo_size = xe_bb_size(fd, bo_size);
-
-	engine = xe_engine(fd, 1);
-	bo = xe_bo_create(fd, vm, bo_size, vram_if_possible(fd, engine->instance.gt_id),
-			  DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
-
-	data = xe_bo_map(fd, bo, bo_size);
-	memset(data, 0, bo_size);
-	exec_queue = xe_exec_queue_create(fd, vm, &engine->instance, 0);
-
-	sync[0].addr = to_user_pointer(&data[VM_DATA].vm_sync);
-	xe_vm_bind_async(fd, vm, engine->instance.gt_id, bo, 0,
-			       addr, bo_size, sync, 1);
-	xe_wait_ufence(fd, &data[VM_DATA].vm_sync, USER_FENCE_VALUE, 0, NSEC_PER_SEC);
-	data[VM_DATA].vm_sync = 0;
-
-	spin_opts.addr = addr + (char *)&data[SPIN_DATA].spin - (char *)data;
-	xe_spin_init(&data[SPIN_DATA].spin, &spin_opts);
-	sync[0].addr = addr + (char *)&data[SPIN_DATA].exec_sync - (char *)data;
-	exec.exec_queue_id = exec_queue;
-	exec.address = spin_opts.addr;
-	xe_exec(fd, &exec);
-	xe_spin_wait_started(&data[SPIN_DATA].spin);
-
-	b = 0;
-	data[EXEC_DATA].batch[b++] = MI_STORE_DWORD_IMM_GEN4;
-	data[EXEC_DATA].batch[b++] = sdi_addr;
-	data[EXEC_DATA].batch[b++] = sdi_addr >> 32;
-	data[EXEC_DATA].batch[b++] = value;
-	data[EXEC_DATA].batch[b++] = MI_BATCH_BUFFER_END;
-	igt_assert(b <= ARRAY_SIZE(data[EXEC_DATA].batch));
-
-	sync[0].addr = addr + (char *)&data[EXEC_DATA].exec_sync - (char *)data;
-	exec.num_syncs = 0;
-	exec.exec_queue_id = exec_queue;
-	exec.address = batch_addr;
-
-	while (1) {
-
-		err = ioctl(fd, DRM_IOCTL_XE_EXEC, &exec);
-
-		if (err == -1 && errno == EWOULDBLOCK)
-			break;
-
-		igt_assert_eq(err, 0);
-	}
-	igt_assert_eq(errno, expect);
-
-	xe_spin_end(&data[SPIN_DATA].spin);
-	xe_wait_ufence(fd, &data[SPIN_DATA].exec_sync, USER_FENCE_VALUE, 0, NSEC_PER_SEC);
-	usleep(50000);
-
-	exec.num_syncs = 1;
-	xe_exec(fd, &exec);
-	xe_wait_ufence(fd, &data[EXEC_DATA].exec_sync, USER_FENCE_VALUE, 0, NSEC_PER_SEC);
-
-	sync[0].addr = to_user_pointer(&data[VM_DATA].vm_sync);
-	xe_vm_unbind_async(fd, vm, 0, 0, addr, bo_size, sync, 1);
-	xe_wait_ufence(fd, &data[VM_DATA].vm_sync, USER_FENCE_VALUE, 0, NSEC_PER_SEC);
-	munmap(data, bo_size);
-	gem_close(fd, bo);
-
-	xe_exec_queue_destroy(fd, exec_queue);
-	xe_vm_destroy(fd, vm);
-}
-
 #define LR_SPINNER_TIME 30
 /**
  * SUBTEST: lr-mode-workload
@@ -570,9 +460,6 @@ igt_main
 					  s->flags);
 	}
 
-	igt_subtest("non-blocking")
-		non_block(fd, EWOULDBLOCK);
-
 	igt_subtest("lr-mode-workload")
 		lr_mode_workload(fd);
 
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 152 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Matthew Brost
Sent: 15 August 2025 08:40 AM
To: [email protected]
Cc: Wajdeczko, Michal <[email protected]>; Lis, Tomasz <[email protected]>; Summers, Stuart <[email protected]>
Subject: [PATCH] tests/intel/xe_exec_compute_mode: Remove non-block section

The non-block will become invalid and hang until the test exhausts all memory when LR jobs are tracked in the DRM scheduler.

---
 tests/intel/xe_exec_compute_mode.c | 113 -----------------------------
 1 file changed, 113 deletions(-)
tests/intel/xe_exec_compute_mode.c +0 -48
index b904dc76b4..316f7322c1 100644
@@ -320,116 +320,6 @@ test_exec(int fd, struct
 drm_xe_engine_class_instance *eci,
 		close(map_fd);
 }
 
-/**
- * SUBTEST: non-blocking
- * Description: Fill the ring and check we get expected errors.
- * Test category: functionality test
- */
-#define VM_DATA		0
-#define SPIN_DATA	1
-#define EXEC_DATA	2
-#define DATA_COUNT	3
-static void non_block(int fd, int expect) -{
-	uint64_t addr = 0x1a0000;
-	struct drm_xe_sync sync[1] = {
-		{ .type = DRM_XE_SYNC_TYPE_USER_FENCE,
-		  .flags = DRM_XE_SYNC_FLAG_SIGNAL,
-		  .timeline_value = USER_FENCE_VALUE},
-	};
-	struct drm_xe_exec exec = {
-		.num_batch_buffer = 1,
-		.num_syncs = 1,
-		.syncs = to_user_pointer(&sync),
-	};
-	struct {
-		struct xe_spin spin;
-		uint32_t batch[16];
-		uint64_t vm_sync;
-		uint32_t data;
-		uint64_t exec_sync;
-	} *data = NULL;
-	struct xe_spin_opts spin_opts = { .preempt = false };
-	struct drm_xe_engine *engine;
-	uint64_t batch_offset = (char *)&data[EXEC_DATA].batch - (char
 *)data;
-	uint64_t batch_addr = addr + batch_offset;
-	uint64_t sdi_offset = (char *)&data[EXEC_DATA].data - (char *)data;
-	uint64_t sdi_addr = addr + sdi_offset;
-	size_t bo_size;
-	uint32_t vm;
-	uint32_t exec_queue;
-	int value = 0x123456;
-	uint32_t bo = 0;
-	int b, err;
-
-	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_LR_MODE, 0);
-	bo_size = sizeof(*data) * DATA_COUNT;
-	bo_size = xe_bb_size(fd, bo_size);
-
-	engine = xe_engine(fd, 1);
-	bo = xe_bo_create(fd, vm, bo_size, vram_if_possible(fd, engine-
 >instance.gt_id),
-

DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);

tests/intel/xe_exec_compute_mode.c +0 -9
-
-	data = xe_bo_map(fd, bo, bo_size);
-	memset(data, 0, bo_size);
-	exec_queue = xe_exec_queue_create(fd, vm, &engine->instance, 0);
-
-	sync[0].addr = to_user_pointer(&data[VM_DATA].vm_sync);
-	xe_vm_bind_async(fd, vm, engine->instance.gt_id, bo, 0,
-			       addr, bo_size, sync, 1);
-	xe_wait_ufence(fd, &data[VM_DATA].vm_sync, USER_FENCE_VALUE,

0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -5
-	data[VM_DATA].vm_sync = 0;
-
-	spin_opts.addr = addr + (char *)&data[SPIN_DATA].spin - (char *)data;
-	xe_spin_init(&data[SPIN_DATA].spin, &spin_opts);
-	sync[0].addr = addr + (char *)&data[SPIN_DATA].exec_sync - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -14
-	exec.exec_queue_id = exec_queue;
-	exec.address = spin_opts.addr;
-	xe_exec(fd, &exec);
-	xe_spin_wait_started(&data[SPIN_DATA].spin);
-
-	b = 0;
-	data[EXEC_DATA].batch[b++] = MI_STORE_DWORD_IMM_GEN4;
-	data[EXEC_DATA].batch[b++] = sdi_addr;
-	data[EXEC_DATA].batch[b++] = sdi_addr >> 32;
-	data[EXEC_DATA].batch[b++] = value;
-	data[EXEC_DATA].batch[b++] = MI_BATCH_BUFFER_END;
-	igt_assert(b <= ARRAY_SIZE(data[EXEC_DATA].batch));
-
-	sync[0].addr = addr + (char *)&data[EXEC_DATA].exec_sync - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -17
-	exec.num_syncs = 0;
-	exec.exec_queue_id = exec_queue;
-	exec.address = batch_addr;
-
-	while (1) {
-
-		err = ioctl(fd, DRM_IOCTL_XE_EXEC, &exec);
-
-		if (err == -1 && errno == EWOULDBLOCK)
-			break;
-
-		igt_assert_eq(err, 0);
-	}
-	igt_assert_eq(errno, expect);
-
-	xe_spin_end(&data[SPIN_DATA].spin);
-	xe_wait_ufence(fd, &data[SPIN_DATA].exec_sync,

USER_FENCE_VALUE, 0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -5
-	usleep(50000);
-
-	exec.num_syncs = 1;
-	xe_exec(fd, &exec);
-	xe_wait_ufence(fd, &data[EXEC_DATA].exec_sync,

USER_FENCE_VALUE, 0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -4
-
-	sync[0].addr = to_user_pointer(&data[VM_DATA].vm_sync);
-	xe_vm_unbind_async(fd, vm, 0, 0, addr, bo_size, sync, 1);
-	xe_wait_ufence(fd, &data[VM_DATA].vm_sync, USER_FENCE_VALUE,

0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -7
-	munmap(data, bo_size);
-	gem_close(fd, bo);
-
-	xe_exec_queue_destroy(fd, exec_queue);
-	xe_vm_destroy(fd, vm);
-}
-
 #define LR_SPINNER_TIME 30
 /**
  * SUBTEST: lr-mode-workload

tests/intel/xe_exec_compute_mode.c igt_main · line 465

Quoted 9 lines
tests/intel/xe_exec_compute_mode.c +0 -3
@@ -570,9 +460,6 @@ igt_main
 					  s->flags);
 	}
 
-	igt_subtest("non-blocking")
-		non_block(fd, EWOULDBLOCK);
-
 	igt_subtest("lr-mode-workload")
 		lr_mode_workload(fd);
 

I see this test will be not required due to changes in DRM scheduler. LGTM,

Quoted 2 lines

--
2.34.1

#2 lore raw
Quoted 179 lines

-----Original Message-----
From: Dandamudi, Priyanka
Sent: 09 October 2025 10:59 AM
To: 'Matthew Brost' <[email protected]>; intel- [email protected]
Cc: Wajdeczko, Michal <[email protected]>; Lis, Tomasz <[email protected]>; Summers, Stuart <[email protected]>
Subject: RE: [PATCH] tests/intel/xe_exec_compute_mode: Remove non-block section

Quoted 151 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Matthew Brost
Sent: 15 August 2025 08:40 AM
To: [email protected]
Cc: Wajdeczko, Michal <[email protected]>; Lis, Tomasz <[email protected]>; Summers, Stuart <[email protected]>
Subject: [PATCH] tests/intel/xe_exec_compute_mode: Remove non-block section

The non-block will become invalid and hang until the test exhausts all memory when LR jobs are tracked in the DRM scheduler.

---
 tests/intel/xe_exec_compute_mode.c | 113
-----------------------------
 1 file changed, 113 deletions(-)
tests/intel/xe_exec_compute_mode.c +0 -48
index b904dc76b4..316f7322c1 100644
@@ -320,116 +320,6 @@ test_exec(int fd, struct
 drm_xe_engine_class_instance *eci,
 		close(map_fd);
 }
 
-/**
- * SUBTEST: non-blocking
- * Description: Fill the ring and check we get expected errors.
- * Test category: functionality test
- */
-#define VM_DATA		0
-#define SPIN_DATA	1
-#define EXEC_DATA	2
-#define DATA_COUNT	3
-static void non_block(int fd, int expect) -{
-	uint64_t addr = 0x1a0000;
-	struct drm_xe_sync sync[1] = {
-		{ .type = DRM_XE_SYNC_TYPE_USER_FENCE,
-		  .flags = DRM_XE_SYNC_FLAG_SIGNAL,
-		  .timeline_value = USER_FENCE_VALUE},
-	};
-	struct drm_xe_exec exec = {
-		.num_batch_buffer = 1,
-		.num_syncs = 1,
-		.syncs = to_user_pointer(&sync),
-	};
-	struct {
-		struct xe_spin spin;
-		uint32_t batch[16];
-		uint64_t vm_sync;
-		uint32_t data;
-		uint64_t exec_sync;
-	} *data = NULL;
-	struct xe_spin_opts spin_opts = { .preempt = false };
-	struct drm_xe_engine *engine;
-	uint64_t batch_offset = (char *)&data[EXEC_DATA].batch - (char
 *)data;
-	uint64_t batch_addr = addr + batch_offset;
-	uint64_t sdi_offset = (char *)&data[EXEC_DATA].data - (char *)data;
-	uint64_t sdi_addr = addr + sdi_offset;
-	size_t bo_size;
-	uint32_t vm;
-	uint32_t exec_queue;
-	int value = 0x123456;
-	uint32_t bo = 0;
-	int b, err;
-
-	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_LR_MODE, 0);
-	bo_size = sizeof(*data) * DATA_COUNT;
-	bo_size = xe_bb_size(fd, bo_size);
-
-	engine = xe_engine(fd, 1);
-	bo = xe_bo_create(fd, vm, bo_size, vram_if_possible(fd, engine-
 >instance.gt_id),
-

DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);

tests/intel/xe_exec_compute_mode.c +0 -9
-
-	data = xe_bo_map(fd, bo, bo_size);
-	memset(data, 0, bo_size);
-	exec_queue = xe_exec_queue_create(fd, vm, &engine->instance, 0);
-
-	sync[0].addr = to_user_pointer(&data[VM_DATA].vm_sync);
-	xe_vm_bind_async(fd, vm, engine->instance.gt_id, bo, 0,
-			       addr, bo_size, sync, 1);
-	xe_wait_ufence(fd, &data[VM_DATA].vm_sync, USER_FENCE_VALUE,

0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -5
-	data[VM_DATA].vm_sync = 0;
-
-	spin_opts.addr = addr + (char *)&data[SPIN_DATA].spin - (char *)data;
-	xe_spin_init(&data[SPIN_DATA].spin, &spin_opts);
-	sync[0].addr = addr + (char *)&data[SPIN_DATA].exec_sync - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -14
-	exec.exec_queue_id = exec_queue;
-	exec.address = spin_opts.addr;
-	xe_exec(fd, &exec);
-	xe_spin_wait_started(&data[SPIN_DATA].spin);
-
-	b = 0;
-	data[EXEC_DATA].batch[b++] = MI_STORE_DWORD_IMM_GEN4;
-	data[EXEC_DATA].batch[b++] = sdi_addr;
-	data[EXEC_DATA].batch[b++] = sdi_addr >> 32;
-	data[EXEC_DATA].batch[b++] = value;
-	data[EXEC_DATA].batch[b++] = MI_BATCH_BUFFER_END;
-	igt_assert(b <= ARRAY_SIZE(data[EXEC_DATA].batch));
-
-	sync[0].addr = addr + (char *)&data[EXEC_DATA].exec_sync - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -17
-	exec.num_syncs = 0;
-	exec.exec_queue_id = exec_queue;
-	exec.address = batch_addr;
-
-	while (1) {
-
-		err = ioctl(fd, DRM_IOCTL_XE_EXEC, &exec);
-
-		if (err == -1 && errno == EWOULDBLOCK)
-			break;
-
-		igt_assert_eq(err, 0);
-	}
-	igt_assert_eq(errno, expect);
-
-	xe_spin_end(&data[SPIN_DATA].spin);
-	xe_wait_ufence(fd, &data[SPIN_DATA].exec_sync,

USER_FENCE_VALUE, 0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -5
-	usleep(50000);
-
-	exec.num_syncs = 1;
-	xe_exec(fd, &exec);
-	xe_wait_ufence(fd, &data[EXEC_DATA].exec_sync,

USER_FENCE_VALUE, 0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -4
-
-	sync[0].addr = to_user_pointer(&data[VM_DATA].vm_sync);
-	xe_vm_unbind_async(fd, vm, 0, 0, addr, bo_size, sync, 1);
-	xe_wait_ufence(fd, &data[VM_DATA].vm_sync, USER_FENCE_VALUE,

0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -7
-	munmap(data, bo_size);
-	gem_close(fd, bo);
-
-	xe_exec_queue_destroy(fd, exec_queue);
-	xe_vm_destroy(fd, vm);
-}
-
 #define LR_SPINNER_TIME 30
 /**
  * SUBTEST: lr-mode-workload

tests/intel/xe_exec_compute_mode.c igt_main · line 465

Quoted 9 lines
tests/intel/xe_exec_compute_mode.c +0 -3
@@ -570,9 +460,6 @@ igt_main
 					  s->flags);
 	}
 
-	igt_subtest("non-blocking")
-		non_block(fd, EWOULDBLOCK);
-
 	igt_subtest("lr-mode-workload")
 		lr_mode_workload(fd);
 

I see this test will be not required due to changes in DRM scheduler. LGTM,

Quoted 2 lines

--
2.34.1

#3 lore raw
In reply to Matthew Brost
Quoted 152 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Matthew Brost
Sent: 15 August 2025 08:40 AM
To: [email protected]
Cc: Wajdeczko, Michal <[email protected]>; Lis, Tomasz <[email protected]>; Summers, Stuart <[email protected]>
Subject: [PATCH] tests/intel/xe_exec_compute_mode: Remove non-block section

The non-block will become invalid and hang until the test exhausts all memory when LR jobs are tracked in the DRM scheduler.

---
 tests/intel/xe_exec_compute_mode.c | 113 -----------------------------
 1 file changed, 113 deletions(-)
tests/intel/xe_exec_compute_mode.c +0 -48
index b904dc76b4..316f7322c1 100644
@@ -320,116 +320,6 @@ test_exec(int fd, struct
 drm_xe_engine_class_instance *eci,
 		close(map_fd);
 }
 
-/**
- * SUBTEST: non-blocking
- * Description: Fill the ring and check we get expected errors.
- * Test category: functionality test
- */
-#define VM_DATA		0
-#define SPIN_DATA	1
-#define EXEC_DATA	2
-#define DATA_COUNT	3
-static void non_block(int fd, int expect) -{
-	uint64_t addr = 0x1a0000;
-	struct drm_xe_sync sync[1] = {
-		{ .type = DRM_XE_SYNC_TYPE_USER_FENCE,
-		  .flags = DRM_XE_SYNC_FLAG_SIGNAL,
-		  .timeline_value = USER_FENCE_VALUE},
-	};
-	struct drm_xe_exec exec = {
-		.num_batch_buffer = 1,
-		.num_syncs = 1,
-		.syncs = to_user_pointer(&sync),
-	};
-	struct {
-		struct xe_spin spin;
-		uint32_t batch[16];
-		uint64_t vm_sync;
-		uint32_t data;
-		uint64_t exec_sync;
-	} *data = NULL;
-	struct xe_spin_opts spin_opts = { .preempt = false };
-	struct drm_xe_engine *engine;
-	uint64_t batch_offset = (char *)&data[EXEC_DATA].batch - (char
 *)data;
-	uint64_t batch_addr = addr + batch_offset;
-	uint64_t sdi_offset = (char *)&data[EXEC_DATA].data - (char *)data;
-	uint64_t sdi_addr = addr + sdi_offset;
-	size_t bo_size;
-	uint32_t vm;
-	uint32_t exec_queue;
-	int value = 0x123456;
-	uint32_t bo = 0;
-	int b, err;
-
-	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_LR_MODE, 0);
-	bo_size = sizeof(*data) * DATA_COUNT;
-	bo_size = xe_bb_size(fd, bo_size);
-
-	engine = xe_engine(fd, 1);
-	bo = xe_bo_create(fd, vm, bo_size, vram_if_possible(fd, engine-
 >instance.gt_id),
-

DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);

tests/intel/xe_exec_compute_mode.c +0 -9
-
-	data = xe_bo_map(fd, bo, bo_size);
-	memset(data, 0, bo_size);
-	exec_queue = xe_exec_queue_create(fd, vm, &engine->instance, 0);
-
-	sync[0].addr = to_user_pointer(&data[VM_DATA].vm_sync);
-	xe_vm_bind_async(fd, vm, engine->instance.gt_id, bo, 0,
-			       addr, bo_size, sync, 1);
-	xe_wait_ufence(fd, &data[VM_DATA].vm_sync, USER_FENCE_VALUE,

0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -5
-	data[VM_DATA].vm_sync = 0;
-
-	spin_opts.addr = addr + (char *)&data[SPIN_DATA].spin - (char *)data;
-	xe_spin_init(&data[SPIN_DATA].spin, &spin_opts);
-	sync[0].addr = addr + (char *)&data[SPIN_DATA].exec_sync - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -14
-	exec.exec_queue_id = exec_queue;
-	exec.address = spin_opts.addr;
-	xe_exec(fd, &exec);
-	xe_spin_wait_started(&data[SPIN_DATA].spin);
-
-	b = 0;
-	data[EXEC_DATA].batch[b++] = MI_STORE_DWORD_IMM_GEN4;
-	data[EXEC_DATA].batch[b++] = sdi_addr;
-	data[EXEC_DATA].batch[b++] = sdi_addr >> 32;
-	data[EXEC_DATA].batch[b++] = value;
-	data[EXEC_DATA].batch[b++] = MI_BATCH_BUFFER_END;
-	igt_assert(b <= ARRAY_SIZE(data[EXEC_DATA].batch));
-
-	sync[0].addr = addr + (char *)&data[EXEC_DATA].exec_sync - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -17
-	exec.num_syncs = 0;
-	exec.exec_queue_id = exec_queue;
-	exec.address = batch_addr;
-
-	while (1) {
-
-		err = ioctl(fd, DRM_IOCTL_XE_EXEC, &exec);
-
-		if (err == -1 && errno == EWOULDBLOCK)
-			break;
-
-		igt_assert_eq(err, 0);
-	}
-	igt_assert_eq(errno, expect);
-
-	xe_spin_end(&data[SPIN_DATA].spin);
-	xe_wait_ufence(fd, &data[SPIN_DATA].exec_sync,

USER_FENCE_VALUE, 0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -5
-	usleep(50000);
-
-	exec.num_syncs = 1;
-	xe_exec(fd, &exec);
-	xe_wait_ufence(fd, &data[EXEC_DATA].exec_sync,

USER_FENCE_VALUE, 0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -4
-
-	sync[0].addr = to_user_pointer(&data[VM_DATA].vm_sync);
-	xe_vm_unbind_async(fd, vm, 0, 0, addr, bo_size, sync, 1);
-	xe_wait_ufence(fd, &data[VM_DATA].vm_sync, USER_FENCE_VALUE,

0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -7
-	munmap(data, bo_size);
-	gem_close(fd, bo);
-
-	xe_exec_queue_destroy(fd, exec_queue);
-	xe_vm_destroy(fd, vm);
-}
-
 #define LR_SPINNER_TIME 30
 /**
  * SUBTEST: lr-mode-workload

tests/intel/xe_exec_compute_mode.c igt_main · line 462

Quoted 3 lines
tests/intel/xe_exec_compute_mode.c +0 -0
@@ -570,9 +460,6 @@ igt_main
 					  s->flags);
 	}
 

LGTM

Quoted 8 lines
tests/intel/xe_exec_compute_mode.c +0 -4
-	igt_subtest("non-blocking")
-		non_block(fd, EWOULDBLOCK);
-
 	igt_subtest("lr-mode-workload")
 		lr_mode_workload(fd);
 
--

2.34.1

Reviewed-by on v1 1/1
#4 lore raw
In reply to Matthew Brost
Quoted 153 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Matthew Brost
Sent: 15 August 2025 08:40 AM
To: [email protected]
Cc: Wajdeczko, Michal <[email protected]>; Lis, Tomasz <[email protected]>; Summers, Stuart <[email protected]>
Subject: [PATCH] tests/intel/xe_exec_compute_mode: Remove non-block section

The non-block will become invalid and hang until the test exhausts all memory when LR jobs are tracked in the DRM scheduler.

---
 tests/intel/xe_exec_compute_mode.c | 113 -----------------------------
 1 file changed, 113 deletions(-)
tests/intel/xe_exec_compute_mode.c +0 -48
index b904dc76b4..316f7322c1 100644
@@ -320,116 +320,6 @@ test_exec(int fd, struct
 drm_xe_engine_class_instance *eci,
 		close(map_fd);
 }
 
-/**
- * SUBTEST: non-blocking
- * Description: Fill the ring and check we get expected errors.
- * Test category: functionality test
- */
-#define VM_DATA		0
-#define SPIN_DATA	1
-#define EXEC_DATA	2
-#define DATA_COUNT	3
-static void non_block(int fd, int expect) -{
-	uint64_t addr = 0x1a0000;
-	struct drm_xe_sync sync[1] = {
-		{ .type = DRM_XE_SYNC_TYPE_USER_FENCE,
-		  .flags = DRM_XE_SYNC_FLAG_SIGNAL,
-		  .timeline_value = USER_FENCE_VALUE},
-	};
-	struct drm_xe_exec exec = {
-		.num_batch_buffer = 1,
-		.num_syncs = 1,
-		.syncs = to_user_pointer(&sync),
-	};
-	struct {
-		struct xe_spin spin;
-		uint32_t batch[16];
-		uint64_t vm_sync;
-		uint32_t data;
-		uint64_t exec_sync;
-	} *data = NULL;
-	struct xe_spin_opts spin_opts = { .preempt = false };
-	struct drm_xe_engine *engine;
-	uint64_t batch_offset = (char *)&data[EXEC_DATA].batch - (char
 *)data;
-	uint64_t batch_addr = addr + batch_offset;
-	uint64_t sdi_offset = (char *)&data[EXEC_DATA].data - (char *)data;
-	uint64_t sdi_addr = addr + sdi_offset;
-	size_t bo_size;
-	uint32_t vm;
-	uint32_t exec_queue;
-	int value = 0x123456;
-	uint32_t bo = 0;
-	int b, err;
-
-	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_LR_MODE, 0);
-	bo_size = sizeof(*data) * DATA_COUNT;
-	bo_size = xe_bb_size(fd, bo_size);
-
-	engine = xe_engine(fd, 1);
-	bo = xe_bo_create(fd, vm, bo_size, vram_if_possible(fd, engine-
 >instance.gt_id),
-

DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);

tests/intel/xe_exec_compute_mode.c +0 -9
-
-	data = xe_bo_map(fd, bo, bo_size);
-	memset(data, 0, bo_size);
-	exec_queue = xe_exec_queue_create(fd, vm, &engine->instance, 0);
-
-	sync[0].addr = to_user_pointer(&data[VM_DATA].vm_sync);
-	xe_vm_bind_async(fd, vm, engine->instance.gt_id, bo, 0,
-			       addr, bo_size, sync, 1);
-	xe_wait_ufence(fd, &data[VM_DATA].vm_sync, USER_FENCE_VALUE,

0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -3
-	data[VM_DATA].vm_sync = 0;
-
-	spin_opts.addr = addr + (char *)&data[SPIN_DATA].spin - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -2
-	xe_spin_init(&data[SPIN_DATA].spin, &spin_opts);
-	sync[0].addr = addr + (char *)&data[SPIN_DATA].exec_sync - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -14
-	exec.exec_queue_id = exec_queue;
-	exec.address = spin_opts.addr;
-	xe_exec(fd, &exec);
-	xe_spin_wait_started(&data[SPIN_DATA].spin);
-
-	b = 0;
-	data[EXEC_DATA].batch[b++] = MI_STORE_DWORD_IMM_GEN4;
-	data[EXEC_DATA].batch[b++] = sdi_addr;
-	data[EXEC_DATA].batch[b++] = sdi_addr >> 32;
-	data[EXEC_DATA].batch[b++] = value;
-	data[EXEC_DATA].batch[b++] = MI_BATCH_BUFFER_END;
-	igt_assert(b <= ARRAY_SIZE(data[EXEC_DATA].batch));
-
-	sync[0].addr = addr + (char *)&data[EXEC_DATA].exec_sync - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -17
-	exec.num_syncs = 0;
-	exec.exec_queue_id = exec_queue;
-	exec.address = batch_addr;
-
-	while (1) {
-
-		err = ioctl(fd, DRM_IOCTL_XE_EXEC, &exec);
-
-		if (err == -1 && errno == EWOULDBLOCK)
-			break;
-
-		igt_assert_eq(err, 0);
-	}
-	igt_assert_eq(errno, expect);
-
-	xe_spin_end(&data[SPIN_DATA].spin);
-	xe_wait_ufence(fd, &data[SPIN_DATA].exec_sync,

USER_FENCE_VALUE, 0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -5
-	usleep(50000);
-
-	exec.num_syncs = 1;
-	xe_exec(fd, &exec);
-	xe_wait_ufence(fd, &data[EXEC_DATA].exec_sync,

USER_FENCE_VALUE, 0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -4
-
-	sync[0].addr = to_user_pointer(&data[VM_DATA].vm_sync);
-	xe_vm_unbind_async(fd, vm, 0, 0, addr, bo_size, sync, 1);
-	xe_wait_ufence(fd, &data[VM_DATA].vm_sync, USER_FENCE_VALUE,

0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -7
-	munmap(data, bo_size);
-	gem_close(fd, bo);
-
-	xe_exec_queue_destroy(fd, exec_queue);
-	xe_vm_destroy(fd, vm);
-}
-
 #define LR_SPINNER_TIME 30
 /**
  * SUBTEST: lr-mode-workload

tests/intel/xe_exec_compute_mode.c igt_main · line 465

Quoted 9 lines
tests/intel/xe_exec_compute_mode.c +0 -3
@@ -570,9 +460,6 @@ igt_main
 					  s->flags);
 	}
 
-	igt_subtest("non-blocking")
-		non_block(fd, EWOULDBLOCK);
-
 	igt_subtest("lr-mode-workload")
 		lr_mode_workload(fd);
 

LGTM,

Quoted 2 lines

--
2.34.1

#5 lore raw
Quoted 179 lines

-----Original Message-----
From: Dandamudi, Priyanka
Sent: 14 October 2025 07:32 PM
To: 'Matthew Brost' <[email protected]>; intel- [email protected]
Cc: Wajdeczko, Michal <[email protected]>; Lis, Tomasz <[email protected]>; Summers, Stuart <[email protected]>
Subject: RE: [PATCH] tests/intel/xe_exec_compute_mode: Remove non-block section

Quoted 152 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Matthew Brost
Sent: 15 August 2025 08:40 AM
To: [email protected]
Cc: Wajdeczko, Michal <[email protected]>; Lis, Tomasz <[email protected]>; Summers, Stuart <[email protected]>
Subject: [PATCH] tests/intel/xe_exec_compute_mode: Remove non-block section

The non-block will become invalid and hang until the test exhausts all memory when LR jobs are tracked in the DRM scheduler.

---
 tests/intel/xe_exec_compute_mode.c | 113
-----------------------------
 1 file changed, 113 deletions(-)
tests/intel/xe_exec_compute_mode.c +0 -48
index b904dc76b4..316f7322c1 100644
@@ -320,116 +320,6 @@ test_exec(int fd, struct
 drm_xe_engine_class_instance *eci,
 		close(map_fd);
 }
 
-/**
- * SUBTEST: non-blocking
- * Description: Fill the ring and check we get expected errors.
- * Test category: functionality test
- */
-#define VM_DATA		0
-#define SPIN_DATA	1
-#define EXEC_DATA	2
-#define DATA_COUNT	3
-static void non_block(int fd, int expect) -{
-	uint64_t addr = 0x1a0000;
-	struct drm_xe_sync sync[1] = {
-		{ .type = DRM_XE_SYNC_TYPE_USER_FENCE,
-		  .flags = DRM_XE_SYNC_FLAG_SIGNAL,
-		  .timeline_value = USER_FENCE_VALUE},
-	};
-	struct drm_xe_exec exec = {
-		.num_batch_buffer = 1,
-		.num_syncs = 1,
-		.syncs = to_user_pointer(&sync),
-	};
-	struct {
-		struct xe_spin spin;
-		uint32_t batch[16];
-		uint64_t vm_sync;
-		uint32_t data;
-		uint64_t exec_sync;
-	} *data = NULL;
-	struct xe_spin_opts spin_opts = { .preempt = false };
-	struct drm_xe_engine *engine;
-	uint64_t batch_offset = (char *)&data[EXEC_DATA].batch - (char
 *)data;
-	uint64_t batch_addr = addr + batch_offset;
-	uint64_t sdi_offset = (char *)&data[EXEC_DATA].data - (char *)data;
-	uint64_t sdi_addr = addr + sdi_offset;
-	size_t bo_size;
-	uint32_t vm;
-	uint32_t exec_queue;
-	int value = 0x123456;
-	uint32_t bo = 0;
-	int b, err;
-
-	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_LR_MODE, 0);
-	bo_size = sizeof(*data) * DATA_COUNT;
-	bo_size = xe_bb_size(fd, bo_size);
-
-	engine = xe_engine(fd, 1);
-	bo = xe_bo_create(fd, vm, bo_size, vram_if_possible(fd, engine-
 >instance.gt_id),
-

DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);

tests/intel/xe_exec_compute_mode.c +0 -9
-
-	data = xe_bo_map(fd, bo, bo_size);
-	memset(data, 0, bo_size);
-	exec_queue = xe_exec_queue_create(fd, vm, &engine->instance, 0);
-
-	sync[0].addr = to_user_pointer(&data[VM_DATA].vm_sync);
-	xe_vm_bind_async(fd, vm, engine->instance.gt_id, bo, 0,
-			       addr, bo_size, sync, 1);
-	xe_wait_ufence(fd, &data[VM_DATA].vm_sync, USER_FENCE_VALUE,

0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -3
-	data[VM_DATA].vm_sync = 0;
-
-	spin_opts.addr = addr + (char *)&data[SPIN_DATA].spin - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -2
-	xe_spin_init(&data[SPIN_DATA].spin, &spin_opts);
-	sync[0].addr = addr + (char *)&data[SPIN_DATA].exec_sync - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -14
-	exec.exec_queue_id = exec_queue;
-	exec.address = spin_opts.addr;
-	xe_exec(fd, &exec);
-	xe_spin_wait_started(&data[SPIN_DATA].spin);
-
-	b = 0;
-	data[EXEC_DATA].batch[b++] = MI_STORE_DWORD_IMM_GEN4;
-	data[EXEC_DATA].batch[b++] = sdi_addr;
-	data[EXEC_DATA].batch[b++] = sdi_addr >> 32;
-	data[EXEC_DATA].batch[b++] = value;
-	data[EXEC_DATA].batch[b++] = MI_BATCH_BUFFER_END;
-	igt_assert(b <= ARRAY_SIZE(data[EXEC_DATA].batch));
-
-	sync[0].addr = addr + (char *)&data[EXEC_DATA].exec_sync - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -17
-	exec.num_syncs = 0;
-	exec.exec_queue_id = exec_queue;
-	exec.address = batch_addr;
-
-	while (1) {
-
-		err = ioctl(fd, DRM_IOCTL_XE_EXEC, &exec);
-
-		if (err == -1 && errno == EWOULDBLOCK)
-			break;
-
-		igt_assert_eq(err, 0);
-	}
-	igt_assert_eq(errno, expect);
-
-	xe_spin_end(&data[SPIN_DATA].spin);
-	xe_wait_ufence(fd, &data[SPIN_DATA].exec_sync,

USER_FENCE_VALUE, 0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -5
-	usleep(50000);
-
-	exec.num_syncs = 1;
-	xe_exec(fd, &exec);
-	xe_wait_ufence(fd, &data[EXEC_DATA].exec_sync,

USER_FENCE_VALUE, 0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -4
-
-	sync[0].addr = to_user_pointer(&data[VM_DATA].vm_sync);
-	xe_vm_unbind_async(fd, vm, 0, 0, addr, bo_size, sync, 1);
-	xe_wait_ufence(fd, &data[VM_DATA].vm_sync, USER_FENCE_VALUE,

0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -7
-	munmap(data, bo_size);
-	gem_close(fd, bo);
-
-	xe_exec_queue_destroy(fd, exec_queue);
-	xe_vm_destroy(fd, vm);
-}
-
 #define LR_SPINNER_TIME 30
 /**
  * SUBTEST: lr-mode-workload

tests/intel/xe_exec_compute_mode.c igt_main · line 465

Quoted 9 lines
tests/intel/xe_exec_compute_mode.c +0 -3
@@ -570,9 +460,6 @@ igt_main
 					  s->flags);
 	}
 
-	igt_subtest("non-blocking")
-		non_block(fd, EWOULDBLOCK);
-
 	igt_subtest("lr-mode-workload")
 		lr_mode_workload(fd);
 

LGTM,

Quoted 2 lines

--
2.34.1

#6 lore raw
Quoted 189 lines

-----Original Message-----
From: Dandamudi, Priyanka
Sent: 14 October 2025 07:33 PM
To: 'Matthew Brost' <[email protected]>; 'intel- [email protected]' <[email protected]>; igt- [email protected]
Cc: Wajdeczko, Michal <[email protected]>; Lis, Tomasz <[email protected]>; Summers, Stuart <[email protected]>
Subject: RE: [PATCH] tests/intel/xe_exec_compute_mode: Remove non-block section

Quoted 174 lines

-----Original Message-----
From: Dandamudi, Priyanka
Sent: 14 October 2025 07:32 PM
To: 'Matthew Brost' <[email protected]>; intel- [email protected]
Cc: Wajdeczko, Michal <[email protected]>; Lis, Tomasz <[email protected]>; Summers, Stuart <[email protected]>
Subject: RE: [PATCH] tests/intel/xe_exec_compute_mode: Remove non-block section

Quoted 161 lines

-----Original Message-----
From: Intel-xe <[email protected]> On Behalf Of Matthew Brost
Sent: 15 August 2025 08:40 AM
To: [email protected]
Cc: Wajdeczko, Michal <[email protected]>; Lis, Tomasz <[email protected]>; Summers, Stuart <[email protected]>
Subject: [PATCH] tests/intel/xe_exec_compute_mode: Remove non-block section

The non-block will become invalid and hang until the test exhausts all memory when LR jobs are tracked in the DRM scheduler.

---
 tests/intel/xe_exec_compute_mode.c | 113
-----------------------------
 1 file changed, 113 deletions(-)
tests/intel/xe_exec_compute_mode.c +0 -48
index b904dc76b4..316f7322c1 100644
@@ -320,116 +320,6 @@ test_exec(int fd, struct
 drm_xe_engine_class_instance *eci,
 		close(map_fd);
 }
 
-/**
- * SUBTEST: non-blocking
- * Description: Fill the ring and check we get expected errors.
- * Test category: functionality test
- */
-#define VM_DATA		0
-#define SPIN_DATA	1
-#define EXEC_DATA	2
-#define DATA_COUNT	3
-static void non_block(int fd, int expect) -{
-	uint64_t addr = 0x1a0000;
-	struct drm_xe_sync sync[1] = {
-		{ .type = DRM_XE_SYNC_TYPE_USER_FENCE,
-		  .flags = DRM_XE_SYNC_FLAG_SIGNAL,
-		  .timeline_value = USER_FENCE_VALUE},
-	};
-	struct drm_xe_exec exec = {
-		.num_batch_buffer = 1,
-		.num_syncs = 1,
-		.syncs = to_user_pointer(&sync),
-	};
-	struct {
-		struct xe_spin spin;
-		uint32_t batch[16];
-		uint64_t vm_sync;
-		uint32_t data;
-		uint64_t exec_sync;
-	} *data = NULL;
-	struct xe_spin_opts spin_opts = { .preempt = false };
-	struct drm_xe_engine *engine;
-	uint64_t batch_offset = (char *)&data[EXEC_DATA].batch - (char
 *)data;
-	uint64_t batch_addr = addr + batch_offset;
-	uint64_t sdi_offset = (char *)&data[EXEC_DATA].data - (char *)data;
-	uint64_t sdi_addr = addr + sdi_offset;
-	size_t bo_size;
-	uint32_t vm;
-	uint32_t exec_queue;
-	int value = 0x123456;
-	uint32_t bo = 0;
-	int b, err;
-
-	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_LR_MODE, 0);
-	bo_size = sizeof(*data) * DATA_COUNT;
-	bo_size = xe_bb_size(fd, bo_size);
-
-	engine = xe_engine(fd, 1);
-	bo = xe_bo_create(fd, vm, bo_size, vram_if_possible(fd, engine-
 >instance.gt_id),
-

DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);

tests/intel/xe_exec_compute_mode.c +0 -9
-
-	data = xe_bo_map(fd, bo, bo_size);
-	memset(data, 0, bo_size);
-	exec_queue = xe_exec_queue_create(fd, vm, &engine->instance, 0);
-
-	sync[0].addr = to_user_pointer(&data[VM_DATA].vm_sync);
-	xe_vm_bind_async(fd, vm, engine->instance.gt_id, bo, 0,
-			       addr, bo_size, sync, 1);
-	xe_wait_ufence(fd, &data[VM_DATA].vm_sync, USER_FENCE_VALUE,

0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -3
-	data[VM_DATA].vm_sync = 0;
-
-	spin_opts.addr = addr + (char *)&data[SPIN_DATA].spin - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -2
-	xe_spin_init(&data[SPIN_DATA].spin, &spin_opts);
-	sync[0].addr = addr + (char *)&data[SPIN_DATA].exec_sync - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -14
-	exec.exec_queue_id = exec_queue;
-	exec.address = spin_opts.addr;
-	xe_exec(fd, &exec);
-	xe_spin_wait_started(&data[SPIN_DATA].spin);
-
-	b = 0;
-	data[EXEC_DATA].batch[b++] = MI_STORE_DWORD_IMM_GEN4;
-	data[EXEC_DATA].batch[b++] = sdi_addr;
-	data[EXEC_DATA].batch[b++] = sdi_addr >> 32;
-	data[EXEC_DATA].batch[b++] = value;
-	data[EXEC_DATA].batch[b++] = MI_BATCH_BUFFER_END;
-	igt_assert(b <= ARRAY_SIZE(data[EXEC_DATA].batch));
-
-	sync[0].addr = addr + (char *)&data[EXEC_DATA].exec_sync - (char

*)data;

tests/intel/xe_exec_compute_mode.c +0 -17
-	exec.num_syncs = 0;
-	exec.exec_queue_id = exec_queue;
-	exec.address = batch_addr;
-
-	while (1) {
-
-		err = ioctl(fd, DRM_IOCTL_XE_EXEC, &exec);
-
-		if (err == -1 && errno == EWOULDBLOCK)
-			break;
-
-		igt_assert_eq(err, 0);
-	}
-	igt_assert_eq(errno, expect);
-
-	xe_spin_end(&data[SPIN_DATA].spin);
-	xe_wait_ufence(fd, &data[SPIN_DATA].exec_sync,

USER_FENCE_VALUE, 0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -5
-	usleep(50000);
-
-	exec.num_syncs = 1;
-	xe_exec(fd, &exec);
-	xe_wait_ufence(fd, &data[EXEC_DATA].exec_sync,

USER_FENCE_VALUE, 0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -4
-
-	sync[0].addr = to_user_pointer(&data[VM_DATA].vm_sync);
-	xe_vm_unbind_async(fd, vm, 0, 0, addr, bo_size, sync, 1);
-	xe_wait_ufence(fd, &data[VM_DATA].vm_sync, USER_FENCE_VALUE,

0, NSEC_PER_SEC);

tests/intel/xe_exec_compute_mode.c +0 -10
-	munmap(data, bo_size);
-	gem_close(fd, bo);
-
-	xe_exec_queue_destroy(fd, exec_queue);
-	xe_vm_destroy(fd, vm);
-}
-
 #define LR_SPINNER_TIME 30
 /**
  * SUBTEST: lr-mode-workload
@@ -570,9 +460,6 @@ igt_main
 					  s->flags);
 	}
 
-	igt_subtest("non-blocking")
-		non_block(fd, EWOULDBLOCK);
-
 	igt_subtest("lr-mode-workload")
 		lr_mode_workload(fd);
 

LGTM,

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

--
2.34.1