f2fs/018: check data eof after partial truncation on compressed cluster
PATCH v3 1/3 f2fs/018: check data eof after partial truncation on compressed cluster
This is a regression testcase, it is added to check below case and its variants:
- write 16k data into compressed file (data will be compressed)
- truncate file to 12k (truncate partial data in compressed cluster)
- truncate file to 20k
- verify data in range of [12k, 16k] to see whether data is all zero or not
---
v3:
- introduce build_fio_config() for cleanup
- use run_check() to check return value of check_data_eof()
- add _cleanup
- use $XFS_IO_PROG instead of xfs_io
tests/f2fs/018 | 89 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/018.out | 2 ++ 2 files changed, 91 insertions(+) create mode 100755 tests/f2fs/018 create mode 100644 tests/f2fs/018.out
tests/f2fs/018 new file +89 -0
@@ -0,0 +1,89 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/018 +# +# This is a regression test to check whether page eof will be +# zero or not after we truncate partial data in compressed +# cluster. +# +. ./common/preamble +_begin_fstest auto quick rw compress + +_fixed_by_kernel_commit ba8dac350faf \ + "f2fs: fix to zero post-eof page" +_fixed_by_kernel_commit xxxxxxxxxxxx \ + "f2fs: fix to zero data after EOF for compressed file correctly" + +_require_xfs_io_command "truncate" +_require_scratch + +testfile=$SCRATCH_MNT/testfile +fio_config=$tmp.fio + +build_fio_config() +{ + local offset=$1 + local size=$2 + + cat >$fio_config <<EOF +[verify-data] +filename=$testfile +rw=read +verify=pattern +verify_pattern=0x00 +do_verify=1 +verify_only +offset=$offset +size=$size +numjobs=1 +EOF + cat $fio_config >> $seqres.full +} + +build_fio_config 0 4k +_require_fio $fio_config + +_cleanup() +{ + rm -f $testfile +} + +_scratch_mkfs "-O extra_attr,compression" >> $seqres.full || _fail "mkfs failed" +_scratch_mount "-o compress_extension=*" >> $seqres.full + +check_data_eof() +{ + local eof_start=$1 + local eof_size=$2 + local filesize=$3 + local offset1=$4 + local offset2=$5 + local offset3=$6 + + rm -f $testfile + + $XFS_IO_PROG -f -c "pwrite 0 $filesize" -c "fsync" $testfile >> $seqres.full + $XFS_IO_PROG -c "truncate $offset1" $testfile + $XFS_IO_PROG -c "truncate $offset2" $testfile + + if [ "$offset3" ]; then + $XFS_IO_PROG -c "truncate $offset3" $testfile + fi + + build_fio_config $eof_start $eof_size + $FIO_PROG $fio_config >> $seqres.full 2>&1 + + return $? +} + +run_check check_data_eof 12k 4k 16k 12k 20k +run_check check_data_eof 10k 6k 16k 10k 20k +run_check check_data_eof 12k 4k 16k 8k 12k 20k +run_check check_data_eof 10k 6k 16k 8k 10k 20k + +echo "Silence is golden" + +status=0 +exit
tests/f2fs/018.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 018 +Silence is golden
Signature · 1 line
2.49.0
PATCH v3 2/3 f2fs/019: do sanity check on mapping table
This is a regression test:
1. create a file
2. write file to create a direct node at special offset
3. use inject.f2fs to inject nid of direct node w/ ino of the inode
4. check whether f2fs kernel module will detect and report such corruption in the fil
---
v2:
- add RVB tag from Zorro
tests/f2fs/019 | 42 ++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/019.out | 2 ++ 2 files changed, 44 insertions(+) create mode 100755 tests/f2fs/019 create mode 100644 tests/f2fs/019.out
tests/f2fs/019 new file +42 -0
@@ -0,0 +1,42 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/019 +# +# This is a regression test: +# 1. create a file +# 2. write file to create a direct node at special offset +# 3. use inject.f2fs to inject nid of direct node w/ ino of the inode +# 4. check whether f2fs kernel module will detect and report such +# corruption in the file +# +. ./common/preamble +_begin_fstest auto quick rw + +_fixed_by_kernel_commit 77de19b6867f \ + "f2fs: fix to avoid out-of-boundary access in dnode page" + +_require_scratch_nocheck +_require_command "$F2FS_INJECT_PROG" inject.f2fs + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +testfile=$SCRATCH_MNT/testfile + +_scratch_mkfs >> $seqres.full +_scratch_mount + +$XFS_IO_PROG -f -c "pwrite 3738M 1M" -c "fsync" $testfile >> $seqres.full + +_scratch_unmount + +$F2FS_INJECT_PROG --node --mb addr --nid 5 --idx 937 --val 4 $SCRATCH_DEV >> $seqres.full + +_scratch_mount +$XFS_IO_PROG -c "pread 3700M 40M" $testfile +_scratch_unmount + +status=0 +exit
tests/f2fs/019.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 019 +pread: Structure needs cleaning
Signature · 1 line
2.49.0
PATCH v3 3/3 f2fs/020: do sanity check on i_xattr_nid
In reply to Chao YuThis is a regression test:
1. create directory
2. add a new xattr entry to create xattr node
3. use inject.f2fs to inject nid of xattr node w/ ino in a file
4. check whether f2fs kernel module will detect and report such corruption in the file
---
v3:
- fix mount option
- check return value of inject.f2fs
tests/f2fs/020 | 51 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/020.out | 2 ++ 2 files changed, 53 insertions(+) create mode 100755 tests/f2fs/020 create mode 100644 tests/f2fs/020.out
tests/f2fs/020 new file +51 -0
@@ -0,0 +1,51 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/020 +# +# This is a regression test: +# 1. create directory +# 2. add a new xattr entry to create xattr node +# 3. use inject.f2fs to inject nid of xattr node w/ ino in a file +# 4. check whether f2fs kernel module will detect and report such +# corruption in the file +# +. ./common/preamble +_begin_fstest auto quick rw + +. ./common/attr + +_fixed_by_kernel_commit 061cf3a84bde \ + "f2fs: fix to do sanity check on ino and xnid" + +_require_scratch_nocheck +_require_command "$F2FS_INJECT_PROG" inject.f2fs +_require_attrs user + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +testdir=$SCRATCH_MNT/testdir + +_scratch_mkfs >> $seqres.full +_scratch_mount "-o user_xattr,noinline_xattr" + +mkdir $testdir +# add a new xattr entry to create xattr node +$SETFATTR_PROG -n user.abc -v 123 $testdir + +_scratch_unmount + +# inject i_xattr_nid w/ nid of inode node +$F2FS_INJECT_PROG --node --mb i_xattr_nid --nid 4 --val 4 $SCRATCH_DEV >> $seqres.full || _fail "failed to inject" + +_scratch_mount "-o acl,user_xattr" +# may potentially trigger a deadlock w/ double inode_lock on parent's inode +mkdir $testdir/dir >> $seqres.full 2>&1 +_scratch_unmount + +echo "Silence is golden" + +status=0 +exit
tests/f2fs/020.out new file +2 -0
@@ -0,0 +1,2 @@ +QA output created by 020 +Silence is golden
Signature · 1 line
2.49.0
Re: [PATCH v3 3/3] f2fs/020: do sanity check on i_xattr_nid
Quoted 56 lines · Chao Yu
This is a regression test:
1. create directory
2. add a new xattr entry to create xattr node
3. use inject.f2fs to inject nid of xattr node w/ ino in a file
4. check whether f2fs kernel module will detect and report such corruption in the fileCc Jaegeuk Kim <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v3:
- fix mount option
- check return value of inject.f2fstests/f2fs/020 | 51 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/020.out | 2 ++ 2 files changed, 53 insertions(+) create mode 100755 tests/f2fs/020 create mode 100644 tests/f2fs/020.outtests/f2fs/020 new file +31
-0@@ -0,0 +1,51 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/020 +# +# This is a regression test: +# 1. create directory +# 2. add a new xattr entry to create xattr node +# 3. use inject.f2fs to inject nid of xattr node w/ ino in a file +# 4. check whether f2fs kernel module will detect and report such +# corruption in the file +# +. ./common/preamble +_begin_fstest auto quick rw + +. ./common/attr + +_fixed_by_kernel_commit 061cf3a84bde \ + "f2fs: fix to do sanity check on ino and xnid" + +_require_scratch_nocheck +_require_command "$F2FS_INJECT_PROG" inject.f2fs +_require_attrs user + +# remove all mkfs options to avoid layout change of on-disk inode +export MKFS_OPTIONS="" + +testdir=$SCRATCH_MNT/testdir + +_scratch_mkfs >> $seqres.full
tests/f2fs/020 line 41
Quoted 10 lines
tests/f2fs/020 new file +10
-0+_scratch_mount "-o user_xattr,noinline_xattr" + +mkdir $testdir +# add a new xattr entry to create xattr node +$SETFATTR_PROG -n user.abc -v 123 $testdir + +_scratch_unmount + +# inject i_xattr_nid w/ nid of inode node +$F2FS_INJECT_PROG --node --mb i_xattr_nid --nid 4 --val 4 $SCRATCH_DEV >> $seqres.full || _fail "failed to inject"
If you'd like to deal with that _require_inject_f2fs_command (what ever name) things in another separated patchset, this patch is good to me.
Quoted 21 lines
tests/f2fs/020 new file +10
-0+ +_scratch_mount "-o acl,user_xattr" +# may potentially trigger a deadlock w/ double inode_lock on parent's inode +mkdir $testdir/dir >> $seqres.full 2>&1 +_scratch_unmount + +echo "Silence is golden" + +status=0 +exittests/f2fs/020.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 020 +Silence is goldenSignature · 1 line
2.49.0
Quoted 69 lines · Chao Yu
This is a regression testcase, it is added to check below case and its variants:
- write 16k data into compressed file (data will be compressed)
- truncate file to 12k (truncate partial data in compressed cluster)
- truncate file to 20k
- verify data in range of [12k, 16k] to see whether data is all zero or notCc Jaegeuk Kim <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v3:
- introducebuild_fio_config()for cleanup
- userun_check()to check return value ofcheck_data_eof()
- add_cleanup
- use $XFS_IO_PROG instead ofxfs_iotests/f2fs/018 | 89 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/018.out | 2 ++ 2 files changed, 91 insertions(+) create mode 100755 tests/f2fs/018 create mode 100644 tests/f2fs/018.outtests/f2fs/018 new file +41
-0@@ -0,0 +1,89 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/018 +# +# This is a regression test to check whether page eof will be +# zero or not after we truncate partial data in compressed +# cluster. +# +. ./common/preamble +_begin_fstest auto quick rw compress + +_fixed_by_kernel_commit ba8dac350faf \ + "f2fs: fix to zero post-eof page" +_fixed_by_kernel_commit xxxxxxxxxxxx \ + "f2fs: fix to zero data after EOF for compressed file correctly" + +_require_xfs_io_command "truncate" +_require_scratch + +testfile=$SCRATCH_MNT/testfile +fio_config=$tmp.fio + +build_fio_config() +{ + local offset=$1 + local size=$2 + + cat >$fio_config <<EOF +[verify-data] +filename=$testfile +rw=read +verify=pattern +verify_pattern=0x00 +do_verify=1 +verify_only +offset=$offset +size=$size +numjobs=1 +EOF
tests/f2fs/018 line 51
Quoted 10 lines
tests/f2fs/018 new file +10
-0+ cat $fio_config >> $seqres.full +} + +build_fio_config 0 4k +_require_fio $fio_config + +_cleanup() +{ + rm -f $testfile +}
This _cleanup isn't necessary, the $testfile is on SCRATCH_DEV, we don't need to cleanup SCRATCH_DEV manually.
Others look good to me, I can help to remove above _cleanup function when I merge this patchset, if other 2 patches are good to merge too :)
Thanks,
Zorro
Quoted 49 lines
tests/f2fs/018 new file +38
-0+ +_scratch_mkfs "-O extra_attr,compression" >> $seqres.full || _fail "mkfs failed" +_scratch_mount "-o compress_extension=*" >> $seqres.full + +check_data_eof() +{ + local eof_start=$1 + local eof_size=$2 + local filesize=$3 + local offset1=$4 + local offset2=$5 + local offset3=$6 + + rm -f $testfile + + $XFS_IO_PROG -f -c "pwrite 0 $filesize" -c "fsync" $testfile >> $seqres.full + $XFS_IO_PROG -c "truncate $offset1" $testfile + $XFS_IO_PROG -c "truncate $offset2" $testfile + + if [ "$offset3" ]; then + $XFS_IO_PROG -c "truncate $offset3" $testfile + fi + + build_fio_config $eof_start $eof_size + $FIO_PROG $fio_config >> $seqres.full 2>&1 + + return $? +} + +run_check check_data_eof 12k 4k 16k 12k 20k +run_check check_data_eof 10k 6k 16k 10k 20k +run_check check_data_eof 12k 4k 16k 8k 12k 20k +run_check check_data_eof 10k 6k 16k 8k 10k 20k + +echo "Silence is golden" + +status=0 +exittests/f2fs/018.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 018 +Silence is goldenSignature · 1 line
2.49.0
Quoted 84 lines · Zorro Lang
Quoted 69 lines · Chao Yu
This is a regression testcase, it is added to check below case and its variants:
- write 16k data into compressed file (data will be compressed)
- truncate file to 12k (truncate partial data in compressed cluster)
- truncate file to 20k
- verify data in range of [12k, 16k] to see whether data is all zero or notCc Jaegeuk Kim <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v3:
- introducebuild_fio_config()for cleanup
- userun_check()to check return value ofcheck_data_eof()
- add_cleanup
- use $XFS_IO_PROG instead ofxfs_iotests/f2fs/018 | 89 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/018.out | 2 ++ 2 files changed, 91 insertions(+)create mode 100755 tests/f2fs/018
create mode 100644 tests/f2fs/018.outtests/f2fs/018 new file +41
-0@@ -0,0 +1,89 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Chao Yu. All Rights Reserved. +# +# FS QA Test No. f2fs/018 +# +# This is a regression test to check whether page eof will be +# zero or not after we truncate partial data in compressed +# cluster. +# +. ./common/preamble +_begin_fstest auto quick rw compress + +_fixed_by_kernel_commit ba8dac350faf \ + "f2fs: fix to zero post-eof page" +_fixed_by_kernel_commit xxxxxxxxxxxx \ + "f2fs: fix to zero data after EOF for compressed file correctly" + +_require_xfs_io_command "truncate" +_require_scratch + +testfile=$SCRATCH_MNT/testfile +fio_config=$tmp.fio + +build_fio_config() +{ + local offset=$1 + local size=$2 + + cat >$fio_config <<EOF +[verify-data] +filename=$testfile +rw=read +verify=pattern +verify_pattern=0x00 +do_verify=1 +verify_only +offset=$offset +size=$size +numjobs=1 +EOFtests/f2fs/018 line 51
Quoted 10 lines
tests/f2fs/018 new file +10
-0+ cat $fio_config >> $seqres.full +} + +build_fio_config 0 4k +_require_fio $fio_config + +_cleanup() +{ + rm -f $testfile +}This
_cleanupisn't necessary, the $testfile is onSCRATCH_DEV, we don't need to cleanupSCRATCH_DEVmanually.
Quoted 2 lines
Others look good to me, I can help to remove above
_cleanupfunction when I merge this patchset, if other 2 patches are good to merge too :)
Fine to me. :)
Quoted 2 lines
Reviewed-by Zorro Lang <[email protected]>
Thanks a lot for all your review and suggestion.
Thanks,
Quoted 54 lines
Thanks,
ZorroQuoted 49 lines
tests/f2fs/018 new file +38
-0+ +_scratch_mkfs "-O extra_attr,compression" >> $seqres.full || _fail "mkfs failed" +_scratch_mount "-o compress_extension=*" >> $seqres.full + +check_data_eof() +{ + local eof_start=$1 + local eof_size=$2 + local filesize=$3 + local offset1=$4 + local offset2=$5 + local offset3=$6 + + rm -f $testfile + + $XFS_IO_PROG -f -c "pwrite 0 $filesize" -c "fsync" $testfile >> $seqres.full + $XFS_IO_PROG -c "truncate $offset1" $testfile + $XFS_IO_PROG -c "truncate $offset2" $testfile + + if [ "$offset3" ]; then + $XFS_IO_PROG -c "truncate $offset3" $testfile + fi + + build_fio_config $eof_start $eof_size + $FIO_PROG $fio_config >> $seqres.full 2>&1 + + return $? +} + +run_check check_data_eof 12k 4k 16k 12k 20k +run_check check_data_eof 10k 6k 16k 10k 20k +run_check check_data_eof 12k 4k 16k 8k 12k 20k +run_check check_data_eof 10k 6k 16k 8k 10k 20k + +echo "Silence is golden" + +status=0 +exittests/f2fs/018.out new file +2
-0@@ -0,0 +1,2 @@ +QA output created by 018 +Silence is goldenSignature · 1 line
2.49.0