dt-bindings: mips: lantiq: Document Lantiq Xway GPTU
Subsystems (2)
v2 cover dt-bindings: mips: lantiq: Document Lantiq Xway GPTU
The Lantiq SoC has six built-in 16-bit general purpose timers (GPTU).
---
Changes in v2:
- added device-specific compatible
- added node name pattern
- added interrupt names
- added third patch
---
Aleksander Jan Bajkowski (3):
dt-bindings: mips: lantiq: Document Lantiq Xway GPTU
mips: lantiq: danube: add missing timer interrupts
mips: lantiq: danube: add device-specified compatible in GPTU node
.../mips/lantiq/lantiq,gptu-xway.yaml | 67 +++++++++++++++++++ arch/mips/boot/dts/lantiq/danube.dtsi | 6 +- 2 files changed, 72 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml
Signature · 1 line
2.47.2
PATCH v2 1/3 dt-bindings: mips: lantiq: Document Lantiq Xway GPTU
The Lantiq SoC has six built-in 16-bit general purpose timers (GPTU).
--- .../mips/lantiq/lantiq,gptu-xway.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml
Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml new file +67 -0
@@ -0,0 +1,67 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mips/lantiq/lantiq,gptu-xway.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Lantiq Xway SoC series General Purpose Timer Unit (GPTU) + +maintainers: + - Aleksander Jan Bajkowski <[email protected]> + +description: + The Lantiq SoC has six built-in 16-bit general purpose timers. The voice + firmware needs these timers as a reference. + +properties: + $nodename: + pattern: "^gptu@[0-9a-f]+$" + + compatible: + items: + - enum: + - lantiq,ase-gptu + - lantiq,danube-gptu + - lantiq,xrx100-gptu + - lantiq,xrx200-gptu + - const: lantiq,gptu-xway + + reg: + maxItems: 1 + + interrupts: + items: + - description: timer1a interrupt + - description: timer1b interrupt + - description: timer2a interrupt + - description: timer2b interrupt + - description: timer3a interrupt + - description: timer3b interrupt + + interrupt-names: + items: + - const: timer1a + - const: timer1b + - const: timer2a + - const: timer2b + - const: timer3a + - const: timer3b + +required: + - compatible + - reg + - interrupts + - interrupt-names + +additionalProperties: false + +examples: + - | + gptu@e100a00 { + compatible = "lantiq,ase-gptu", "lantiq,gptu-xway"; + reg = <0xe100a00 0x100>; + interrupt-parent = <&icu0>; + interrupts = <126>, <127>, <128>, <129> ,<130>, <131>; + interrupt-names = "timer1a", "timer1b", "timer2a", "timer2b", + "timer3a", "timer3b"; + };
Signature · 1 line
2.47.2
Quoted 22 lines · Aleksander Jan Bajkowski
The Lantiq SoC has six built-in 16-bit general purpose timers (GPTU).
Signed-off-by Aleksander Jan Bajkowski <[email protected]>--- .../mips/lantiq/lantiq,gptu-xway.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yamlDocumentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml new file +8
-0@@ -0,0 +1,67 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mips/lantiq/lantiq,gptu-xway.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Lantiq Xway SoC series General Purpose Timer Unit (GPTU) +
Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml line 18
Quoted 10 lines
Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml new file +10
-0+maintainers: + - Aleksander Jan Bajkowski <[email protected]> + +description: + The Lantiq SoC has six built-in 16-bit general purpose timers. The voice + firmware needs these timers as a reference. + +properties: + $nodename: + pattern: "^gptu@[0-9a-f]+$"
This is a timer, why are you not using "timer" as the prefix? Otherwise, this looks okay to me other than...
Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml line 27
Quoted 9 lines
Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml new file +9
-0+ + compatible: + items: + - enum: + - lantiq,ase-gptu + - lantiq,danube-gptu + - lantiq,xrx100-gptu + - lantiq,xrx200-gptu + - const: lantiq,gptu-xway
..the fact that my OCD hates how the fallback inverts the position of gptu in the compatible!
Quoted 47 lines · Conor Dooley
Quoted 22 lines · Aleksander Jan Bajkowski
The Lantiq SoC has six built-in 16-bit general purpose timers (GPTU).
Signed-off-by Aleksander Jan Bajkowski <[email protected]>--- .../mips/lantiq/lantiq,gptu-xway.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yamlDocumentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml new file +8
-0@@ -0,0 +1,67 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mips/lantiq/lantiq,gptu-xway.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Lantiq Xway SoC series General Purpose Timer Unit (GPTU) +Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml line 18
Quoted 10 lines
Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml new file +10
-0+maintainers: + - Aleksander Jan Bajkowski <[email protected]> + +description: + The Lantiq SoC has six built-in 16-bit general purpose timers. The voice + firmware needs these timers as a reference. + +properties: + $nodename: + pattern: "^gptu@[0-9a-f]+$"This is a timer, why are you not using "timer" as the prefix? Otherwise, this looks okay to me other than...
Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml line 27
Quoted 9 lines
Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml new file +9
-0+ + compatible: + items: + - enum: + - lantiq,ase-gptu + - lantiq,danube-gptu + - lantiq,xrx100-gptu + - lantiq,xrx200-gptu + - const: lantiq,gptu-xway
Quoted 2 lines
..the fact that my OCD hates how the fallback inverts the position of gptu in the compatible!
Recommended naming is soc-subblock, so xway-gptu, but even more recommended (and documented...) is to use only soc compatibles.
If xway is the soc, where is separate entry for that (maybe missing in email context?).
Best regards,
Krzysztof
PATCH v2 2/3 mips: lantiq: danube: add missing timer interrupts
In reply to Aleksander Jan BajkowskiThe driver expects six interrupt lines to be specified.
--- arch/mips/boot/dts/lantiq/danube.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/mips/boot/dts/lantiq/danube.dtsi +4 -0
@@ -71,6 +71,10 @@ fpi@10000000 { gptu@e100a00 { compatible = "lantiq,gptu-xway"; reg = <0xe100a00 0x100>; + interrupt-parent = <&icu0>; + interrupts = <126 127 128 129 130 131>; + interrupt-names = "timer1a", "timer1b", "timer2a", + "timer2b", "timer3a", "timer3b"; }; serial@e100c00 {
Signature · 1 line
2.47.2
PATCH v2 3/3 mips: lantiq: danube: add device-specified compatible in GPTU node
In reply to Aleksander Jan BajkowskiThis patch adds device-specific compatibility in the GPTU node.
--- arch/mips/boot/dts/lantiq/danube.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/boot/dts/lantiq/danube.dtsi +1 -1
@@ -69,7 +69,7 @@ fpi@10000000 { reg = <0x10000000 0xef00000>; gptu@e100a00 { - compatible = "lantiq,gptu-xway"; + compatible = "lantiq,danube-gptu", "lantiq,gptu-xway"; reg = <0xe100a00 0x100>; interrupt-parent = <&icu0>; interrupts = <126 127 128 129 130 131>;
Signature · 1 line
2.47.2