Skip to contentSkip to conversation

iio: pressure: bmp280: GPIO error handling and cleanups

PATCH Applied Salah Triki 4 participants 11 messages Aug 18, 2025 – Sep 13, 2025 IIO

lore
Share & tools
lore
#0 lore raw

v4 cover iio: pressure: bmp280: GPIO error handling and cleanups

Hi all,

This patch series improves the GPIO error handling and addresses small cleanups in the bmp280 driver.

Changes in v4:
- Split patch 2/2 into two separate patches, as suggested by Markus Elfring.

Changes in v3:
- Split into two separate patches, as suggested by Andy Shevchenko.
- Improve the error message to "failed to get reset GPIO", as suggested by David Lechner.
- Add Fixes and Cc tags where appropriate, as suggested by Markus Elfring.

Changes in v2:
- Use IS_ERR() instead of IS_ERR_OR_NULL()
- Drop dev_info()
- Use gpiod_set_value_cansleep()
- Improve commit title and message

Salah Triki (3):
iio: pressure: bmp280: Use IS_ERR() in bmp280_common_probe()
iio: pressure: bmp280: Remove noisy dev_info()
iio: pressure: bmp280: Use gpiod_set_value_cansleep()

 drivers/iio/pressure/bmp280-core.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.43.0
#1 lore raw

PATCH v4 1/3 iio: pressure: bmp280: Use IS_ERR() in bmp280_common_probe()

devm_gpiod_get_optional() may return non-NULL error pointer on failure. Check its return value using IS_ERR() and propagate the error if necessary.

Fixes df6e71256c84 ("iio: pressure: bmp280: Explicitly mark GPIO optional")
Cc David Lechner <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Nuno Sá <[email protected]>
Cc Markus Elfring <[email protected]>
---
 drivers/iio/pressure/bmp280-core.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/iio/pressure/bmp280-core.c +5 -4
index 74505c9ec1a0..6cdc8ed53520 100644
@@ -3213,11 +3213,12 @@ int bmp280_common_probe(struct device *dev,
 
 	/* Bring chip out of reset if there is an assigned GPIO line */
 	gpiod = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
+	if (IS_ERR(gpiod))
+		return dev_err_probe(dev, PTR_ERR(gpiod), "failed to get reset GPIO\n");
+
 	/* Deassert the signal */
-	if (gpiod) {
-		dev_info(dev, "release reset\n");
-		gpiod_set_value(gpiod, 0);
-	}
+	dev_info(dev, "release reset\n");
+	gpiod_set_value(gpiod, 0);
 
 	data->regmap = regmap;
 
Signature · 1 line
2.43.0
maintainer Applied
#2 lore raw

Re: [PATCH v4 1/3] iio: pressure: bmp280: Use IS_ERR() in bmp280_common_probe()

Quoted 4 lines · On Mon, 18 Aug 2025 10:27:30 +0100 Salah Triki <[email protected]> wrote:

devm_gpiod_get_optional() may return non-NULL error pointer on failure. Check its return value using IS_ERR() and propagate the error if necessary.

Quoted 8 lines
Fixes df6e71256c84 ("iio: pressure: bmp280: Explicitly mark GPIO optional")
Cc David Lechner <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Nuno Sá <[email protected]>
Cc Markus Elfring <[email protected]>

Applied to the fixes-togreg branch of iio.git and marked for stable.

The rest of the series will have to wait for that to work it's way back via upstream.

Thanks

Jonathan

Quoted 25 lines
---
 drivers/iio/pressure/bmp280-core.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/iio/pressure/bmp280-core.c +5 -4
index 74505c9ec1a0..6cdc8ed53520 100644
@@ -3213,11 +3213,12 @@ int bmp280_common_probe(struct device *dev,
 
 	/* Bring chip out of reset if there is an assigned GPIO line */
 	gpiod = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
+	if (IS_ERR(gpiod))
+		return dev_err_probe(dev, PTR_ERR(gpiod), "failed to get reset GPIO\n");
+
 	/* Deassert the signal */
-	if (gpiod) {
-		dev_info(dev, "release reset\n");
-		gpiod_set_value(gpiod, 0);
-	}
+	dev_info(dev, "release reset\n");
+	gpiod_set_value(gpiod, 0);
 
 	data->regmap = regmap;
 
#3 lore raw

Re: [PATCH v4 1/3] iio: pressure: bmp280: Use IS_ERR() in bmp280_common_probe()

In reply to Salah Triki
Quoted 11 lines · Salah Triki

devm_gpiod_get_optional() may return non-NULL error pointer on failure. Check its return value using IS_ERR() and propagate the error if necessary.

Fixes df6e71256c84 ("iio: pressure: bmp280: Explicitly mark GPIO optional")
Cc David Lechner <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Nuno Sá <[email protected]>
Cc Markus Elfring <[email protected]>

Please, next time move the Cc:s to be the after '---' line...

Quoted 3 lines

---

...somewhere here.

It will reduce a lot the noise in the commit message. The all people will be Cc'ed anyway (assuming you use git send-email).

Quoted 2 lines
 drivers/iio/pressure/bmp280-core.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Jonathan, would it be possible to drop them from the commit you pushed?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#4 lore raw

Re: [PATCH v4 1/3] iio: pressure: bmp280: Use IS_ERR() in bmp280_common_probe()

Quoted 21 lines · On Wed, 20 Aug 2025 17:48:56 +0300 Andy Shevchenko…
Quoted 11 lines · Salah Triki

devm_gpiod_get_optional() may return non-NULL error pointer on failure. Check its return value using IS_ERR() and propagate the error if necessary.

Fixes df6e71256c84 ("iio: pressure: bmp280: Explicitly mark GPIO optional")
Cc David Lechner <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Nuno Sá <[email protected]>
Cc Markus Elfring <[email protected]>

Please, next time move the Cc:s to be the after '---' line...

Quoted 3 lines

---

...somewhere here.

Quoted 8 lines

It will reduce a lot the noise in the commit message. The all people will be Cc'ed anyway (assuming you use git send-email).

Quoted 2 lines
 drivers/iio/pressure/bmp280-core.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)  

Jonathan, would it be possible to drop them from the commit you pushed?

I did so, just didn't mention it.

J

#5 lore raw

PATCH v4 2/3 iio: pressure: bmp280: Remove noisy dev_info()

In reply to Salah Triki

Remove dev_info() call as it was considered noisy and is not necessary for normal driver operation.

---
 drivers/iio/pressure/bmp280-core.c | 1 -
 1 file changed, 1 deletion(-)
drivers/iio/pressure/bmp280-core.c +0 -1
index 6cdc8ed53520..1f0852fc3414 100644
@@ -3217,7 +3217,6 @@ int bmp280_common_probe(struct device *dev,
 		return dev_err_probe(dev, PTR_ERR(gpiod), "failed to get reset GPIO\n");
 
 	/* Deassert the signal */
-	dev_info(dev, "release reset\n");
 	gpiod_set_value(gpiod, 0);
 
 	data->regmap = regmap;
Signature · 1 line
2.43.0
Reviewed-by on v4 2/3
#6 lore raw

Re: [PATCH v4 2/3] iio: pressure: bmp280: Remove noisy dev_info()

Quoted 2 lines · Salah Triki

Remove dev_info() call as it was considered noisy and is not necessary for normal driver operation.

I agree with this.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Applied
#7 lore raw

Re: [PATCH v4 2/3] iio: pressure: bmp280: Remove noisy dev_info()

Quoted 7 lines · On Wed, 20 Aug 2025 17:49:43 +0300 Andy Shevchenko…
Quoted 2 lines · Salah Triki

Remove dev_info() call as it was considered noisy and is not necessary for normal driver operation.

I agree with this.

Applied. Thanks

#8 lore raw

PATCH v4 3/3 iio: pressure: bmp280: Use gpiod_set_value_cansleep()

In reply to Salah Triki

Switch to gpiod_set_value_cansleep(), which is safe to use in sleepable contexts like the driver probe function.

---
 drivers/iio/pressure/bmp280-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/pressure/bmp280-core.c +1 -1
index 1f0852fc3414..656f6189c84c 100644
@@ -3217,7 +3217,7 @@ int bmp280_common_probe(struct device *dev,
 		return dev_err_probe(dev, PTR_ERR(gpiod), "failed to get reset GPIO\n");
 
 	/* Deassert the signal */
-	gpiod_set_value(gpiod, 0);
+	gpiod_set_value_cansleep(gpiod, 0);
 
 	data->regmap = regmap;
 
Signature · 1 line
2.43.0
Reviewed-by on v4 3/3
#9 lore raw

Re: [PATCH v4 3/3] iio: pressure: bmp280: Use gpiod_set_value_cansleep()

Quoted 2 lines · Salah Triki

Switch to gpiod_set_value_cansleep(), which is safe to use in sleepable contexts like the driver probe function.

The commit message is unclear on why? aspect. You need to elaborate that some GPIO chips may be located behind slow (and hence sleepable) busses, such as I²C).

Code wise I agree with the change.
With amended commit message

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#10 lore raw

Re: [PATCH v4 3/3] iio: pressure: bmp280: Use gpiod_set_value_cansleep()

Quoted 4 lines · On Wed, 20 Aug 2025 17:51:22 +0300 Andy Shevchenko…
Quoted 2 lines · Salah Triki

Switch to gpiod_set_value_cansleep(), which is safe to use in sleepable contexts like the driver probe function.

Quoted 8 lines

The commit message is unclear on why? aspect. You need to elaborate that some GPIO chips may be located behind slow (and hence sleepable) busses, such as I²C).

Code wise I agree with the change.
With amended commit message

I added a brief not on slow buses and applied.

Thanks,

Jonathan