Skip to contentSkip to conversation

ultipath-tools: standardize NVME vendor_id in hwtable

PATCH New Xose Vazquez Perez 1 participant 1 message Aug 19, 2025 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ultipath-tools: standardize NVME vendor_id in hwtable

There is no vendor_id/product_id for NVMe devices. Just "model". and typically it's a combination of both.

"NVME" is a static tag, added in:
https://github.com/opensvc/multipath-tools/blob/de16cf82c5263fc148118be56ebf44c8f0ee60b8/libmultipath/discovery.c#L1635

Cc Martin Wilck <[email protected]>
Cc Benjamin Marzinski <[email protected]>
Cc Christophe Varoqui <[email protected]>
Cc DM_DEVEL-ML <[email protected]>
---
 libmultipath/hwtable.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
libmultipath/hwtable.c +4 -4
index aedf4b88..de0af8a4 100644
@@ -88,7 +88,7 @@ static struct hwentry default_hw[] = {
 	 */
 	{
 		/* Generic NVMe */
-		.vendor        = "NVM[eE]",
+		.vendor        = "^NVME",
 		.product       = ".*",
 		.uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE,
 		.checker_name  = NONE,
@@ -396,7 +396,7 @@ static struct hwentry default_hw[] = {
 	},
 	{
 		/* PowerStore NVMe */
-		.vendor        = ".*",
+		.vendor        = "NVME",
 		.product       = "dellemc-powerstore",
 		.no_path_retry = 3,
 	},
@@ -738,7 +738,7 @@ static struct hwentry default_hw[] = {
 	},
 	{
 		/* FlashSystem(RamSan) NVMe */
-		.vendor        = "NVMe",
+		.vendor        = "NVME",
 		.product       = "FlashSystem",
 		.no_path_retry = NO_PATH_RETRY_FAIL,
 	},
@@ -1112,7 +1112,7 @@ static struct hwentry default_hw[] = {
 	},
 	{
 		/* OceanStor NVMe */
-		.vendor        = "NVM[eE]",
+		.vendor        = "NVME",
 		.product       = "Huawei-XSG1",
 		.checker_name  = DIRECTIO,
 		.no_path_retry = 12,
Signature · 1 line
2.50.1