Skip to contentSkip to conversation

mips: lantiq: fix ethernet support

PATCH In review Aleksander Jan Bajkowski 3 participants 7 messages Aug 17, 2025 – Aug 22, 2025

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

v2 cover mips: lantiq: fix ethernet support

This series fixes broken Ethernet in the upstream danube dts. The driver doesn't attach due to missing burst length property. OpenWRT has its own dts, which is correct, so the problem has only been spotted now. Other dts inconsistencies with bindings have been fixed as well.

---
Changes in v2:
- renaming clocks in sysctrl
---
Aleksander Jan Bajkowski (2):
mips: dts: lantiq: danube: add missing burst length property
mips: lantiq: xway: sysctrl: rename the etop node

 arch/mips/boot/dts/lantiq/danube_easy50712.dts |  5 ++++-
 arch/mips/lantiq/xway/sysctrl.c                | 10 +++++-----
 2 files changed, 9 insertions(+), 6 deletions(-)
Signature · 1 line
2.47.2
#1 lore raw

PATCH v2 1/2 mips: dts: lantiq: danube: add missing burst length property

The upstream dts lacks the lantiq,{rx/tx}-burst-length property. Other
issues were also fixed:
arch/mips/boot/dts/lantiq/danube_easy50712.dtb: etop@e180000 (lantiq,etop-xway): 'interrupt-names' is a required property
from schema $id: http://devicetree.org/schemas/net/lantiq,etop-xway.yaml#
arch/mips/boot/dts/lantiq/danube_easy50712.dtb: etop@e180000 (lantiq,etop-xway): 'lantiq,tx-burst-length' is a required property
from schema $id: http://devicetree.org/schemas/net/lantiq,etop-xway.yaml#
arch/mips/boot/dts/lantiq/danube_easy50712.dtb: etop@e180000 (lantiq,etop-xway): 'lantiq,rx-burst-length' is a required property
from schema $id: http://devicetree.org/schemas/net/lantiq,etop-xway.yaml#

Fixes 14d4e308e0aa ("net: lantiq: configure the burst length in ethernet drivers")
---
 arch/mips/boot/dts/lantiq/danube_easy50712.dts | 3 +++
 1 file changed, 3 insertions(+)
arch/mips/boot/dts/lantiq/danube_easy50712.dts +3 -0
index 1ce20b7d05cb..d8b3cd69eda3 100644
@@ -87,8 +87,11 @@ etop@e180000 {
 			reg = <0xe180000 0x40000>;
 			interrupt-parent = <&icu0>;
 			interrupts = <73 78>;
+			interrupt-names = "tx", "rx";
 			phy-mode = "rmii";
 			mac-address = [ 00 11 22 33 44 55 ];
+			lantiq,rx-burst-length = <4>;
+			lantiq,tx-burst-length = <4>;
 		};
 
 		stp0: stp@e100bb0 {
Signature · 1 line
2.47.2
#2 lore raw

PATCH v2 2/2 mips: lantiq: xway: sysctrl: rename the etop node

In reply to Aleksander Jan Bajkowski

Bindig requires a node name matching ‘^ethernet@[0-9a-f]+$’. This patch changes the clock name from “etop” to “ethernet”.

This fixes the following warning:
arch/mips/boot/dts/lantiq/danube_easy50712.dtb: etop@e180000 (lantiq,etop-xway): $nodename:0: 'etop@e180000' does not match '^ethernet@[0-9a-f]+$'
from schema $id: http://devicetree.org/schemas/net/lantiq,etop-xway.yaml#

Fixes dac0bad93741 ("dt-bindings: net: lantiq,etop-xway: Document Lantiq Xway ETOP bindings")
---
 arch/mips/boot/dts/lantiq/danube_easy50712.dts |  2 +-
 arch/mips/lantiq/xway/sysctrl.c                | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)
arch/mips/boot/dts/lantiq/danube_easy50712.dts +1 -1
index d8b3cd69eda3..c4d7aa5753b0 100644
@@ -82,7 +82,7 @@ conf_out {
 			};
 		};
 
-		etop@e180000 {
+		ethernet@e180000 {
 			compatible = "lantiq,etop-xway";
 			reg = <0xe180000 0x40000>;
 			interrupt-parent = <&icu0>;
arch/mips/lantiq/xway/sysctrl.c +5 -5
index 5a75283d17f1..6031a0272d87 100644
@@ -497,7 +497,7 @@ void __init ltq_soc_init(void)
 		ifccr = CGU_IFCCR_VR9;
 		pcicr = CGU_PCICR_VR9;
 	} else {
-		clkdev_add_pmu("1e180000.etop", NULL, 1, 0, PMU_PPE);
+		clkdev_add_pmu("1e180000.ethernet", NULL, 1, 0, PMU_PPE);
 	}
 
 	if (!of_machine_is_compatible("lantiq,ase"))
@@ -531,9 +531,9 @@ void __init ltq_soc_init(void)
 						CLOCK_133M, CLOCK_133M);
 		clkdev_add_pmu("1e101000.usb", "otg", 1, 0, PMU_USB0);
 		clkdev_add_pmu("1f203018.usb2-phy", "phy", 1, 0, PMU_USB0_P);
-		clkdev_add_pmu("1e180000.etop", "ppe", 1, 0, PMU_PPE);
-		clkdev_add_cgu("1e180000.etop", "ephycgu", CGU_EPHY);
-		clkdev_add_pmu("1e180000.etop", "ephy", 1, 0, PMU_EPHY);
+		clkdev_add_pmu("1e180000.ethernet", "ppe", 1, 0, PMU_PPE);
+		clkdev_add_cgu("1e180000.ethernet", "ephycgu", CGU_EPHY);
+		clkdev_add_pmu("1e180000.ethernet", "ephy", 1, 0, PMU_EPHY);
 		clkdev_add_pmu("1e103000.sdio", NULL, 1, 0, PMU_ASE_SDIO);
 		clkdev_add_pmu("1e116000.mei", "dfe", 1, 0, PMU_DFE);
 	} else if (of_machine_is_compatible("lantiq,grx390")) {
@@ -592,7 +592,7 @@ void __init ltq_soc_init(void)
 		clkdev_add_pmu("1e101000.usb", "otg", 1, 0, PMU_USB0 | PMU_AHBM);
 		clkdev_add_pmu("1f203034.usb2-phy", "phy", 1, 0, PMU_USB1_P);
 		clkdev_add_pmu("1e106000.usb", "otg", 1, 0, PMU_USB1 | PMU_AHBM);
-		clkdev_add_pmu("1e180000.etop", "switch", 1, 0, PMU_SWITCH);
+		clkdev_add_pmu("1e180000.ethernet", "switch", 1, 0, PMU_SWITCH);
 		clkdev_add_pmu("1e103000.sdio", NULL, 1, 0, PMU_SDIO);
 		clkdev_add_pmu("1e103100.deu", NULL, 1, 0, PMU_DEU);
 		clkdev_add_pmu("1e116000.mei", "dfe", 1, 0, PMU_DFE);
Signature · 1 line
2.47.2
maintainer
#3 lore raw
In reply to Aleksander Jan Bajkowski
Quoted 5 lines · On Sun, 17 Aug 2025 14:49:05 +0200 Aleksander Jan Bajkowski wrote:

This series fixes broken Ethernet in the upstream danube dts. The driver doesn't attach due to missing burst length property. OpenWRT has its own dts, which is correct, so the problem has only been spotted now. Other dts inconsistencies with bindings have been fixed as well.

Hi Thomas, Aleksander tagged these for net, are you okay with us taking them via the networking tree? Looks like these are half DTS changes.

#4 lore raw
Quoted 9 lines · Jakub Kicinski
Quoted 5 lines · On Sun, 17 Aug 2025 14:49:05 +0200 Aleksander Jan Bajkowski wrote:

This series fixes broken Ethernet in the upstream danube dts. The driver doesn't attach due to missing burst length property. OpenWRT has its own dts, which is correct, so the problem has only been spotted now. Other dts inconsistencies with bindings have been fixed as well.

Hi Thomas, Aleksander tagged these for net, are you okay with us taking them via the networking tree? Looks like these are half DTS changes.

Aleksander is further changing the Lantiq DTs, so I'd prefer to take this patches through the MIPS tree.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
maintainer Acked-by
#5 lore raw
Quoted 8 lines · On Wed, 20 Aug 2025 12:24:25 +0200 Thomas Bogendoerfer wrote:
Quoted 7 lines · Jakub Kicinski
Quoted 5 lines · On Sun, 17 Aug 2025 14:49:05 +0200 Aleksander Jan Bajkowski wrote:

This series fixes broken Ethernet in the upstream danube dts. The driver doesn't attach due to missing burst length property. OpenWRT has its own dts, which is correct, so the problem has only been spotted now. Other dts inconsistencies with bindings have been fixed as well.

Quoted 5 lines
Quoted 2 lines

Hi Thomas, Aleksander tagged these for net, are you okay with us taking them via the networking tree? Looks like these are half DTS changes.

Aleksander is further changing the Lantiq DTs, so I'd prefer to take this patches through the MIPS tree.

SG! Feel free to add:

Signature · 1 line
pw-bot: not-applicable
#6 lore raw
In reply to Aleksander Jan Bajkowski
Quoted 14 lines · Aleksander Jan Bajkowski

This series fixes broken Ethernet in the upstream danube dts. The driver doesn't attach due to missing burst length property. OpenWRT has its own dts, which is correct, so the problem has only been spotted now. Other dts inconsistencies with bindings have been fixed as well.

---
Changes in v2:
- renaming clocks in sysctrl
---
Aleksander Jan Bajkowski (2):
mips: dts: lantiq: danube: add missing burst length property
mips: lantiq: xway: sysctrl: rename the etop node

Quoted 3 lines
 arch/mips/boot/dts/lantiq/danube_easy50712.dts |  5 ++++-
 arch/mips/lantiq/xway/sysctrl.c                | 10 +++++-----
 2 files changed, 9 insertions(+), 6 deletions(-)

series applied to mips-fixes.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]